Wrapper for Google_Service_Calendar as a Symfony service

up vote
0
down vote

favorite

My app interacts with Google Calendar. This Service wraps Google_Service_Calendar:

<?php

declare(strict_types=1);



namespace AppService;



use SymfonyComponentHttpFoundationSessionSessionInterface;



class GoogleCalendarService extends Google_Service_Calendar

{

    public const CALENDAR_ID = '123example@group.calendar.google.com';



    public function __construct(SessionInterface $session) {

        $client = new Google_Client();

        $client->setAccessToken($session->get('google_access_token'));

        parent::__construct($client);

    }

}

I have the feeling that having the session as a dependency is not good practice. For a user of that service, it is absolutely not clear that the access token needs to be set in the session.

I could probably add some Exceptions for the case that it is not set, but I wonder whether there is a better way?

edited 8 mins ago

200_success

127k15149412

asked 7 hours ago

Chrisissorry

1011

New contributor

add a comment |

up vote
0
down vote

favorite

My app interacts with Google Calendar. This Service wraps Google_Service_Calendar:

<?php

declare(strict_types=1);



namespace AppService;



use SymfonyComponentHttpFoundationSessionSessionInterface;



class GoogleCalendarService extends Google_Service_Calendar

{

    public const CALENDAR_ID = '123example@group.calendar.google.com';



    public function __construct(SessionInterface $session) {

        $client = new Google_Client();

        $client->setAccessToken($session->get('google_access_token'));

        parent::__construct($client);

    }

}

I have the feeling that having the session as a dependency is not good practice. For a user of that service, it is absolutely not clear that the access token needs to be set in the session.

I could probably add some Exceptions for the case that it is not set, but I wonder whether there is a better way?

edited 8 mins ago

200_success

127k15149412

asked 7 hours ago

Chrisissorry

1011

New contributor

add a comment |

up vote
0
down vote

favorite

My app interacts with Google Calendar. This Service wraps Google_Service_Calendar:

<?php

declare(strict_types=1);



namespace AppService;



use SymfonyComponentHttpFoundationSessionSessionInterface;



class GoogleCalendarService extends Google_Service_Calendar

{

    public const CALENDAR_ID = '123example@group.calendar.google.com';



    public function __construct(SessionInterface $session) {

        $client = new Google_Client();

        $client->setAccessToken($session->get('google_access_token'));

        parent::__construct($client);

    }

}

I have the feeling that having the session as a dependency is not good practice. For a user of that service, it is absolutely not clear that the access token needs to be set in the session.

I could probably add some Exceptions for the case that it is not set, but I wonder whether there is a better way?

edited 8 mins ago

200_success

127k15149412

asked 7 hours ago

Chrisissorry

1011

New contributor

My app interacts with Google Calendar. This Service wraps Google_Service_Calendar:

<?php

declare(strict_types=1);



namespace AppService;



use SymfonyComponentHttpFoundationSessionSessionInterface;



class GoogleCalendarService extends Google_Service_Calendar

{

    public const CALENDAR_ID = '123example@group.calendar.google.com';



    public function __construct(SessionInterface $session) {

        $client = new Google_Client();

        $client->setAccessToken($session->get('google_access_token'));

        parent::__construct($client);

    }

}

I have the feeling that having the session as a dependency is not good practice. For a user of that service, it is absolutely not clear that the access token needs to be set in the session.

I could probably add some Exceptions for the case that it is not set, but I wonder whether there is a better way?

php session wrapper symfony3

edited 8 mins ago

200_success

127k15149412

asked 7 hours ago

Chrisissorry

1011

New contributor

edited 8 mins ago

200_success

127k15149412

asked 7 hours ago

Chrisissorry

1011

New contributor

edited 8 mins ago

200_success

127k15149412

edited 8 mins ago

200_success

127k15149412

edited 8 mins ago

200_success

127k15149412

asked 7 hours ago

Chrisissorry

1011

New contributor

asked 7 hours ago

Chrisissorry

1011

asked 7 hours ago

Chrisissorry

1011

New contributor

Chrisissorry is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

add a comment |

active

oldest

votes

Your Answer

StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});

}
});

Chrisissorry is a new contributor. Be nice, and check out our Code of Conduct.

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209292%2fwrapper-for-google-service-calendar-as-a-symfony-service%23new-answer', 'question_page');
}
);

Post as a guest

Name

Required, but never shown

active

oldest

votes

Chrisissorry is a new contributor. Be nice, and check out our Code of Conduct.

draft saved

draft discarded

Chrisissorry is a new contributor. Be nice, and check out our Code of Conduct.

Thanks for contributing an answer to Code Review Stack Exchange!

Please be sure to answer the question. Provide details and share your research!

But avoid …

Asking for help, clarification, or responding to other answers.

Making statements based on opinion; back them up with references or personal experience.

Use MathJax to format equations. MathJax reference.

To learn more, see our tips on writing great answers.

Some of your past answers have not been well-received, and you're in danger of being blocked from answering.

Please pay close attention to the following guidance:

Please be sure to answer the question. Provide details and share your research!

But avoid …

Asking for help, clarification, or responding to other answers.

Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Name

Required, but never shown

Name

Required, but never shown

This page is only for reference, If you need detailed information, please check here

搜尋此網誌

Tukukkk