Wrapper for Google_Service_Calendar as a Symfony service
up vote
0
down vote
favorite
My app interacts with Google Calendar. This Service wraps Google_Service_Calendar:
<?php
declare(strict_types=1);
namespace AppService;
use SymfonyComponentHttpFoundationSessionSessionInterface;
class GoogleCalendarService extends Google_Service_Calendar
{
public const CALENDAR_ID = '123example@group.calendar.google.com';
public function __construct(SessionInterface $session) {
$client = new Google_Client();
$client->setAccessToken($session->get('google_access_token'));
parent::__construct($client);
}
}
I have the feeling that having the session as a dependency is not good practice. For a user of that service, it is absolutely not clear that the access token needs to be set in the session.
I could probably add some Exceptions for the case that it is not set, but I wonder whether there is a better way?
php session wrapper symfony3
edited 8 mins ago
200_success
127k15149412
asked 7 hours ago
Chrisissorry
1011
New contributor
Chrisissorry is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
up vote
0
down vote
favorite
My app interacts with Google Calendar. This Service wraps Google_Service_Calendar:
<?php
declare(strict_types=1);
namespace AppService;
use SymfonyComponentHttpFoundationSessionSessionInterface;
class GoogleCalendarService extends Google_Service_Calendar
{
public const CALENDAR_ID = '123example@group.calendar.google.com';
public function __construct(SessionInterface $session) {
$client = new Google_Client();
$client->setAccessToken($session->get('google_access_token'));
parent::__construct($client);
}
}
I have the feeling that having the session as a dependency is not good practice. For a user of that service, it is absolutely not clear that the access token needs to be set in the session.
I could probably add some Exceptions for the case that it is not set, but I wonder whether there is a better way?
php session wrapper symfony3
edited 8 mins ago
200_success
127k15149412
asked 7 hours ago
Chrisissorry
1011
New contributor
Chrisissorry is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
up vote
0
down vote
favorite
up vote
0
down vote
favorite
My app interacts with Google Calendar. This Service wraps Google_Service_Calendar:
<?php
declare(strict_types=1);
namespace AppService;
use SymfonyComponentHttpFoundationSessionSessionInterface;
class GoogleCalendarService extends Google_Service_Calendar
{
public const CALENDAR_ID = '123example@group.calendar.google.com';
public function __construct(SessionInterface $session) {
$client = new Google_Client();
$client->setAccessToken($session->get('google_access_token'));
parent::__construct($client);
}
}
I have the feeling that having the session as a dependency is not good practice. For a user of that service, it is absolutely not clear that the access token needs to be set in the session.
I could probably add some Exceptions for the case that it is not set, but I wonder whether there is a better way?
php session wrapper symfony3
edited 8 mins ago
200_success
127k15149412
asked 7 hours ago
Chrisissorry
1011
New contributor
Chrisissorry is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
My app interacts with Google Calendar. This Service wraps Google_Service_Calendar:
<?php
declare(strict_types=1);
namespace AppService;
use SymfonyComponentHttpFoundationSessionSessionInterface;
class GoogleCalendarService extends Google_Service_Calendar
{
public const CALENDAR_ID = '123example@group.calendar.google.com';
public function __construct(SessionInterface $session) {
$client = new Google_Client();
$client->setAccessToken($session->get('google_access_token'));
parent::__construct($client);
}
}
I have the feeling that having the session as a dependency is not good practice. For a user of that service, it is absolutely not clear that the access token needs to be set in the session.
I could probably add some Exceptions for the case that it is not set, but I wonder whether there is a better way?
php session wrapper symfony3
php session wrapper symfony3
edited 8 mins ago
200_success
127k15149412
asked 7 hours ago
Chrisissorry
1011
New contributor
Chrisissorry is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 8 mins ago
200_success
127k15149412
asked 7 hours ago
Chrisissorry
1011
New contributor
Chrisissorry is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 8 mins ago
200_success
127k15149412
edited 8 mins ago
200_success
127k15149412
edited 8 mins ago
200_success
127k15149412
127k15149412
asked 7 hours ago
Chrisissorry
1011
New contributor
Chrisissorry is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 hours ago
Chrisissorry
1011
asked 7 hours ago
Chrisissorry
1011
1011
New contributor
Chrisissorry is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Chrisissorry is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Chrisissorry is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Chrisissorry is a new contributor. Be nice, and check out our Code of Conduct.
Chrisissorry is a new contributor. Be nice, and check out our Code of Conduct.
Chrisissorry is a new contributor. Be nice, and check out our Code of Conduct.
Chrisissorry is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209292%2fwrapper-for-google-service-calendar-as-a-symfony-service%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
