Reduce a grid array [][] into a string












0












$begingroup$


I have a class with a property of grid and each value is either true or false. I need to convert this to a string with letters o and b in place of the boolean.



First way, simple for loops over the array and return the string:



 get rle() {
let result = "";
for(let y = 0; y < this.grid.length; y++) {
for(let x =0; x < this.grid[y].length; x++) {
result += ( (this.grid[y][x]) ? "o" : "b" );
}
}
return result;
}


Or a more JS style solution?



get rle() {
return this.grid.reduce( (total, currentValue, currentIndex, arr) => {
return total + arr[currentIndex].reduce( (total, currentValue, currentIndex, arr) => {
return total + ( (arr[currentIndex]) ? "o" : "b" );
}, "");
}, "");
}


Is this a good JS style solution, and what in your opinion is better? I prefer the first because anyone can instantly understand it. The JS solution makes me frown with 3 nested returns, looks odd.










share|improve this question











$endgroup$

















    0












    $begingroup$


    I have a class with a property of grid and each value is either true or false. I need to convert this to a string with letters o and b in place of the boolean.



    First way, simple for loops over the array and return the string:



     get rle() {
    let result = "";
    for(let y = 0; y < this.grid.length; y++) {
    for(let x =0; x < this.grid[y].length; x++) {
    result += ( (this.grid[y][x]) ? "o" : "b" );
    }
    }
    return result;
    }


    Or a more JS style solution?



    get rle() {
    return this.grid.reduce( (total, currentValue, currentIndex, arr) => {
    return total + arr[currentIndex].reduce( (total, currentValue, currentIndex, arr) => {
    return total + ( (arr[currentIndex]) ? "o" : "b" );
    }, "");
    }, "");
    }


    Is this a good JS style solution, and what in your opinion is better? I prefer the first because anyone can instantly understand it. The JS solution makes me frown with 3 nested returns, looks odd.










    share|improve this question











    $endgroup$















      0












      0








      0





      $begingroup$


      I have a class with a property of grid and each value is either true or false. I need to convert this to a string with letters o and b in place of the boolean.



      First way, simple for loops over the array and return the string:



       get rle() {
      let result = "";
      for(let y = 0; y < this.grid.length; y++) {
      for(let x =0; x < this.grid[y].length; x++) {
      result += ( (this.grid[y][x]) ? "o" : "b" );
      }
      }
      return result;
      }


      Or a more JS style solution?



      get rle() {
      return this.grid.reduce( (total, currentValue, currentIndex, arr) => {
      return total + arr[currentIndex].reduce( (total, currentValue, currentIndex, arr) => {
      return total + ( (arr[currentIndex]) ? "o" : "b" );
      }, "");
      }, "");
      }


      Is this a good JS style solution, and what in your opinion is better? I prefer the first because anyone can instantly understand it. The JS solution makes me frown with 3 nested returns, looks odd.










      share|improve this question











      $endgroup$




      I have a class with a property of grid and each value is either true or false. I need to convert this to a string with letters o and b in place of the boolean.



      First way, simple for loops over the array and return the string:



       get rle() {
      let result = "";
      for(let y = 0; y < this.grid.length; y++) {
      for(let x =0; x < this.grid[y].length; x++) {
      result += ( (this.grid[y][x]) ? "o" : "b" );
      }
      }
      return result;
      }


      Or a more JS style solution?



      get rle() {
      return this.grid.reduce( (total, currentValue, currentIndex, arr) => {
      return total + arr[currentIndex].reduce( (total, currentValue, currentIndex, arr) => {
      return total + ( (arr[currentIndex]) ? "o" : "b" );
      }, "");
      }, "");
      }


      Is this a good JS style solution, and what in your opinion is better? I prefer the first because anyone can instantly understand it. The JS solution makes me frown with 3 nested returns, looks odd.







      javascript array






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 16 mins ago









      Jamal

      30.3k11117227




      30.3k11117227










      asked 7 hours ago









      Matthew PageMatthew Page

      1014




      1014






















          1 Answer
          1






          active

          oldest

          votes


















          0












          $begingroup$

          First, a few points of the code you wrote. If you have an array of values, you can join the values together to efficiently create a string. This would eliminate the need for at least one of the reduce calls. Second, in a reduce call, the value of the second callback parameter (currentValue in your code) is the value of the array parameter at the index parameter (arr[currentIndex] in your code). Combining that with Javascript's capability to ignore excess function parameters, your reduce calls should take only two parameters, and use the currentValue in place of the arr[currentIndex].



          You should also avoid using the same variable names in the same scope. Having two sets of total, currentValue, currentIndex, andarr` could get confusing quickly, and lead to strange bugs.



          Now, for the one-liner:



          return this.grid.flat().map((el) => el ? "o" : "b").join("");


          See Array#flat, Array#map, and the aforementioned Array#join. Of these, Array#flat is the newest and possibly unsupported method. It can be easily polyfilled or replaced. The MDN page shows some clever replacements like arr.reduce((all, row) => all.concat(row), ) and .concat(...arr).






          share|improve this answer









          $endgroup$













            Your Answer





            StackExchange.ifUsing("editor", function () {
            return StackExchange.using("mathjaxEditing", function () {
            StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
            StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
            });
            });
            }, "mathjax-editing");

            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "196"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213218%2freduce-a-grid-array-into-a-string%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            0












            $begingroup$

            First, a few points of the code you wrote. If you have an array of values, you can join the values together to efficiently create a string. This would eliminate the need for at least one of the reduce calls. Second, in a reduce call, the value of the second callback parameter (currentValue in your code) is the value of the array parameter at the index parameter (arr[currentIndex] in your code). Combining that with Javascript's capability to ignore excess function parameters, your reduce calls should take only two parameters, and use the currentValue in place of the arr[currentIndex].



            You should also avoid using the same variable names in the same scope. Having two sets of total, currentValue, currentIndex, andarr` could get confusing quickly, and lead to strange bugs.



            Now, for the one-liner:



            return this.grid.flat().map((el) => el ? "o" : "b").join("");


            See Array#flat, Array#map, and the aforementioned Array#join. Of these, Array#flat is the newest and possibly unsupported method. It can be easily polyfilled or replaced. The MDN page shows some clever replacements like arr.reduce((all, row) => all.concat(row), ) and .concat(...arr).






            share|improve this answer









            $endgroup$


















              0












              $begingroup$

              First, a few points of the code you wrote. If you have an array of values, you can join the values together to efficiently create a string. This would eliminate the need for at least one of the reduce calls. Second, in a reduce call, the value of the second callback parameter (currentValue in your code) is the value of the array parameter at the index parameter (arr[currentIndex] in your code). Combining that with Javascript's capability to ignore excess function parameters, your reduce calls should take only two parameters, and use the currentValue in place of the arr[currentIndex].



              You should also avoid using the same variable names in the same scope. Having two sets of total, currentValue, currentIndex, andarr` could get confusing quickly, and lead to strange bugs.



              Now, for the one-liner:



              return this.grid.flat().map((el) => el ? "o" : "b").join("");


              See Array#flat, Array#map, and the aforementioned Array#join. Of these, Array#flat is the newest and possibly unsupported method. It can be easily polyfilled or replaced. The MDN page shows some clever replacements like arr.reduce((all, row) => all.concat(row), ) and .concat(...arr).






              share|improve this answer









              $endgroup$
















                0












                0








                0





                $begingroup$

                First, a few points of the code you wrote. If you have an array of values, you can join the values together to efficiently create a string. This would eliminate the need for at least one of the reduce calls. Second, in a reduce call, the value of the second callback parameter (currentValue in your code) is the value of the array parameter at the index parameter (arr[currentIndex] in your code). Combining that with Javascript's capability to ignore excess function parameters, your reduce calls should take only two parameters, and use the currentValue in place of the arr[currentIndex].



                You should also avoid using the same variable names in the same scope. Having two sets of total, currentValue, currentIndex, andarr` could get confusing quickly, and lead to strange bugs.



                Now, for the one-liner:



                return this.grid.flat().map((el) => el ? "o" : "b").join("");


                See Array#flat, Array#map, and the aforementioned Array#join. Of these, Array#flat is the newest and possibly unsupported method. It can be easily polyfilled or replaced. The MDN page shows some clever replacements like arr.reduce((all, row) => all.concat(row), ) and .concat(...arr).






                share|improve this answer









                $endgroup$



                First, a few points of the code you wrote. If you have an array of values, you can join the values together to efficiently create a string. This would eliminate the need for at least one of the reduce calls. Second, in a reduce call, the value of the second callback parameter (currentValue in your code) is the value of the array parameter at the index parameter (arr[currentIndex] in your code). Combining that with Javascript's capability to ignore excess function parameters, your reduce calls should take only two parameters, and use the currentValue in place of the arr[currentIndex].



                You should also avoid using the same variable names in the same scope. Having two sets of total, currentValue, currentIndex, andarr` could get confusing quickly, and lead to strange bugs.



                Now, for the one-liner:



                return this.grid.flat().map((el) => el ? "o" : "b").join("");


                See Array#flat, Array#map, and the aforementioned Array#join. Of these, Array#flat is the newest and possibly unsupported method. It can be easily polyfilled or replaced. The MDN page shows some clever replacements like arr.reduce((all, row) => all.concat(row), ) and .concat(...arr).







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered 2 hours ago









                cbojarcbojar

                2,3672818




                2,3672818






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Code Review Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    Use MathJax to format equations. MathJax reference.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213218%2freduce-a-grid-array-into-a-string%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    404 Error Contact Form 7 ajax form submitting

                    How to know if a Active Directory user can login interactively

                    TypeError: fit_transform() missing 1 required positional argument: 'X'