jquery onclick change image not working, Correct Code i think











up vote
0
down vote

favorite












I have a really simple onclick event to change the image of an image in a div, but for whatever reason i keep getting an undefined back instead of the image source.



iv tried every which way around and still had no luck.



can anyone see from the code below where i am going wrong please.



thank you.



$messageid=$row['id'];

<div class='Mimage3'>

<input type='file' class='INimage' id='input3{$messageid}' onClick='showFiles(this , "image3{$messageid}" , "input3{$messageid}" , {$messageid});' accept='image/*' >

<label for='input3' class='LMimage'>
<img id='image3{$messageid}' class='vimage' src='{$image3}'></img>
</label>

</div>


<script>
function showFiles(thisID, imageID , inputID , messageID ) {


var imageid=imageID; //passed imageID --onclick "image3"+{$messageid}
var messageid=messageID; //passed messageID --onclick {$messageid}
var ebm=document.getElementById('editSeller'+messageid+''); //passed messageID --onclick {$messageid}
var inputID=inputID; //passed inputID --onclick "input3"+{$messageid}
var input=thisID; //passed thisID --onclick this

console.log('imageid='+imageid); // shows the id correctly


// attempt 1 var imagesrc = $(imageid 'img').attr('src');

// attempt 2 var imagesrc = $('#'+imageid 'img').attr('src');

// attempt 3 var imagesrc = ($imageid).find('img').attr('src'));

// attempt 4 var imagesrc = $(imageid).attr('src');

// attempt 5 var imagesrc = $(imageid).find('img').attr('src');

// attempt 6 var imagesrc = $('#'+imageid).find('img').attr('src');


console.log(imagesrc); // but this returns undefined???



</script>









share|improve this question


























    up vote
    0
    down vote

    favorite












    I have a really simple onclick event to change the image of an image in a div, but for whatever reason i keep getting an undefined back instead of the image source.



    iv tried every which way around and still had no luck.



    can anyone see from the code below where i am going wrong please.



    thank you.



    $messageid=$row['id'];

    <div class='Mimage3'>

    <input type='file' class='INimage' id='input3{$messageid}' onClick='showFiles(this , "image3{$messageid}" , "input3{$messageid}" , {$messageid});' accept='image/*' >

    <label for='input3' class='LMimage'>
    <img id='image3{$messageid}' class='vimage' src='{$image3}'></img>
    </label>

    </div>


    <script>
    function showFiles(thisID, imageID , inputID , messageID ) {


    var imageid=imageID; //passed imageID --onclick "image3"+{$messageid}
    var messageid=messageID; //passed messageID --onclick {$messageid}
    var ebm=document.getElementById('editSeller'+messageid+''); //passed messageID --onclick {$messageid}
    var inputID=inputID; //passed inputID --onclick "input3"+{$messageid}
    var input=thisID; //passed thisID --onclick this

    console.log('imageid='+imageid); // shows the id correctly


    // attempt 1 var imagesrc = $(imageid 'img').attr('src');

    // attempt 2 var imagesrc = $('#'+imageid 'img').attr('src');

    // attempt 3 var imagesrc = ($imageid).find('img').attr('src'));

    // attempt 4 var imagesrc = $(imageid).attr('src');

    // attempt 5 var imagesrc = $(imageid).find('img').attr('src');

    // attempt 6 var imagesrc = $('#'+imageid).find('img').attr('src');


    console.log(imagesrc); // but this returns undefined???



    </script>









    share|improve this question
























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I have a really simple onclick event to change the image of an image in a div, but for whatever reason i keep getting an undefined back instead of the image source.



      iv tried every which way around and still had no luck.



      can anyone see from the code below where i am going wrong please.



      thank you.



      $messageid=$row['id'];

      <div class='Mimage3'>

      <input type='file' class='INimage' id='input3{$messageid}' onClick='showFiles(this , "image3{$messageid}" , "input3{$messageid}" , {$messageid});' accept='image/*' >

      <label for='input3' class='LMimage'>
      <img id='image3{$messageid}' class='vimage' src='{$image3}'></img>
      </label>

      </div>


      <script>
      function showFiles(thisID, imageID , inputID , messageID ) {


      var imageid=imageID; //passed imageID --onclick "image3"+{$messageid}
      var messageid=messageID; //passed messageID --onclick {$messageid}
      var ebm=document.getElementById('editSeller'+messageid+''); //passed messageID --onclick {$messageid}
      var inputID=inputID; //passed inputID --onclick "input3"+{$messageid}
      var input=thisID; //passed thisID --onclick this

      console.log('imageid='+imageid); // shows the id correctly


      // attempt 1 var imagesrc = $(imageid 'img').attr('src');

      // attempt 2 var imagesrc = $('#'+imageid 'img').attr('src');

      // attempt 3 var imagesrc = ($imageid).find('img').attr('src'));

      // attempt 4 var imagesrc = $(imageid).attr('src');

      // attempt 5 var imagesrc = $(imageid).find('img').attr('src');

      // attempt 6 var imagesrc = $('#'+imageid).find('img').attr('src');


      console.log(imagesrc); // but this returns undefined???



      </script>









      share|improve this question













      I have a really simple onclick event to change the image of an image in a div, but for whatever reason i keep getting an undefined back instead of the image source.



      iv tried every which way around and still had no luck.



      can anyone see from the code below where i am going wrong please.



      thank you.



      $messageid=$row['id'];

      <div class='Mimage3'>

      <input type='file' class='INimage' id='input3{$messageid}' onClick='showFiles(this , "image3{$messageid}" , "input3{$messageid}" , {$messageid});' accept='image/*' >

      <label for='input3' class='LMimage'>
      <img id='image3{$messageid}' class='vimage' src='{$image3}'></img>
      </label>

      </div>


      <script>
      function showFiles(thisID, imageID , inputID , messageID ) {


      var imageid=imageID; //passed imageID --onclick "image3"+{$messageid}
      var messageid=messageID; //passed messageID --onclick {$messageid}
      var ebm=document.getElementById('editSeller'+messageid+''); //passed messageID --onclick {$messageid}
      var inputID=inputID; //passed inputID --onclick "input3"+{$messageid}
      var input=thisID; //passed thisID --onclick this

      console.log('imageid='+imageid); // shows the id correctly


      // attempt 1 var imagesrc = $(imageid 'img').attr('src');

      // attempt 2 var imagesrc = $('#'+imageid 'img').attr('src');

      // attempt 3 var imagesrc = ($imageid).find('img').attr('src'));

      // attempt 4 var imagesrc = $(imageid).attr('src');

      // attempt 5 var imagesrc = $(imageid).find('img').attr('src');

      // attempt 6 var imagesrc = $('#'+imageid).find('img').attr('src');


      console.log(imagesrc); // but this returns undefined???



      </script>






      onclick jscript






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 19 at 23:29









      lezz

      206




      206
























          1 Answer
          1






          active

          oldest

          votes

















          up vote
          0
          down vote













          var imagesrc = $('#' + imageid).attr('src');



          oops...
          forget to try that 1..






          share|improve this answer





















            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53384133%2fjquery-onclick-change-image-not-working-correct-code-i-think%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes








            up vote
            0
            down vote













            var imagesrc = $('#' + imageid).attr('src');



            oops...
            forget to try that 1..






            share|improve this answer

























              up vote
              0
              down vote













              var imagesrc = $('#' + imageid).attr('src');



              oops...
              forget to try that 1..






              share|improve this answer























                up vote
                0
                down vote










                up vote
                0
                down vote









                var imagesrc = $('#' + imageid).attr('src');



                oops...
                forget to try that 1..






                share|improve this answer












                var imagesrc = $('#' + imageid).attr('src');



                oops...
                forget to try that 1..







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 19 at 23:34









                lezz

                206




                206






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.





                    Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                    Please pay close attention to the following guidance:


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53384133%2fjquery-onclick-change-image-not-working-correct-code-i-think%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    404 Error Contact Form 7 ajax form submitting

                    How to know if a Active Directory user can login interactively

                    TypeError: fit_transform() missing 1 required positional argument: 'X'