HTML5 canvas video with React












0












$begingroup$


I'm trying to work HTML5 canvas video into a React application while making the code as clean as possible. What kind of improvements should be made to improve the performance utilizing the React to its fullest potential?



import React, { Component } from 'react';
import './App.css';
import video from './video.mp4';
import watermark from './watermark.png';

class App extends Component {
constructor() {
super();
this.state = {};
}

componentDidMount() {

const canvas = document.createElement('canvas');
canvas.width = 1280;
canvas.height = 720;
const context = canvas.getContext('2d');
context.drawImage(document.querySelector('video'), 0, 0, 720, 1280);
context.drawImage(
document.querySelector('.watermark'),
parseInt(document.querySelector('select').value),
parseInt(document.querySelector('select').value)
);
if (document.querySelector('input[name=live]').checked) {
this.setState({ image: canvas.toDataURL() });
}

}


render() {
const range = ;
for (let i = 0; i < 1280; i++) {
range.push(i);
}

return (
<div className="app">

<video src={video} controls />

<div>
<div className="watermarkButton" style={{}}>

<span className="watermarkButtonX">Watermark X
<select className="positionX">
{range.map(i => (
<option key={i}>{i}</option>
))} </select></span>

<span className="watermarkButtonY">Watermark Y
<select className="positionY">
{range.map(i => (
<option key={i}>{i}</option>
))} </select></span>



<span>Live</span>
<input type="checkbox" name="live" />
</div>


<button className = "watermarkButton watermarkSubmit"
onClick={() => {
const canvas = document.createElement('canvas');
canvas.width = 1280;
canvas.height = 720;
const context = canvas.getContext('2d');
context.drawImage(document.querySelector('video'), 0, 0, 1280, 720);
context.drawImage(
document.querySelector('.watermark'),
parseInt(document.querySelector('.positionX').value),
parseInt(document.querySelector('.positionY').value)
);
this.setState({ image: canvas.toDataURL() });
}}> Watermark! </button>


<img alt="watermarks" className="watermark" src={watermark} style={{ visibility: 'visible' }} />
<img alt="watermarks" className="imageDisplay" height="405px" width="560px" src={this.state.image} />
</div>
</div>
);
}

}

export default App;









share|improve this question









New contributor




Romane Green is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    I'm trying to work HTML5 canvas video into a React application while making the code as clean as possible. What kind of improvements should be made to improve the performance utilizing the React to its fullest potential?



    import React, { Component } from 'react';
    import './App.css';
    import video from './video.mp4';
    import watermark from './watermark.png';

    class App extends Component {
    constructor() {
    super();
    this.state = {};
    }

    componentDidMount() {

    const canvas = document.createElement('canvas');
    canvas.width = 1280;
    canvas.height = 720;
    const context = canvas.getContext('2d');
    context.drawImage(document.querySelector('video'), 0, 0, 720, 1280);
    context.drawImage(
    document.querySelector('.watermark'),
    parseInt(document.querySelector('select').value),
    parseInt(document.querySelector('select').value)
    );
    if (document.querySelector('input[name=live]').checked) {
    this.setState({ image: canvas.toDataURL() });
    }

    }


    render() {
    const range = ;
    for (let i = 0; i < 1280; i++) {
    range.push(i);
    }

    return (
    <div className="app">

    <video src={video} controls />

    <div>
    <div className="watermarkButton" style={{}}>

    <span className="watermarkButtonX">Watermark X
    <select className="positionX">
    {range.map(i => (
    <option key={i}>{i}</option>
    ))} </select></span>

    <span className="watermarkButtonY">Watermark Y
    <select className="positionY">
    {range.map(i => (
    <option key={i}>{i}</option>
    ))} </select></span>



    <span>Live</span>
    <input type="checkbox" name="live" />
    </div>


    <button className = "watermarkButton watermarkSubmit"
    onClick={() => {
    const canvas = document.createElement('canvas');
    canvas.width = 1280;
    canvas.height = 720;
    const context = canvas.getContext('2d');
    context.drawImage(document.querySelector('video'), 0, 0, 1280, 720);
    context.drawImage(
    document.querySelector('.watermark'),
    parseInt(document.querySelector('.positionX').value),
    parseInt(document.querySelector('.positionY').value)
    );
    this.setState({ image: canvas.toDataURL() });
    }}> Watermark! </button>


    <img alt="watermarks" className="watermark" src={watermark} style={{ visibility: 'visible' }} />
    <img alt="watermarks" className="imageDisplay" height="405px" width="560px" src={this.state.image} />
    </div>
    </div>
    );
    }

    }

    export default App;









    share|improve this question









    New contributor




    Romane Green is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      I'm trying to work HTML5 canvas video into a React application while making the code as clean as possible. What kind of improvements should be made to improve the performance utilizing the React to its fullest potential?



      import React, { Component } from 'react';
      import './App.css';
      import video from './video.mp4';
      import watermark from './watermark.png';

      class App extends Component {
      constructor() {
      super();
      this.state = {};
      }

      componentDidMount() {

      const canvas = document.createElement('canvas');
      canvas.width = 1280;
      canvas.height = 720;
      const context = canvas.getContext('2d');
      context.drawImage(document.querySelector('video'), 0, 0, 720, 1280);
      context.drawImage(
      document.querySelector('.watermark'),
      parseInt(document.querySelector('select').value),
      parseInt(document.querySelector('select').value)
      );
      if (document.querySelector('input[name=live]').checked) {
      this.setState({ image: canvas.toDataURL() });
      }

      }


      render() {
      const range = ;
      for (let i = 0; i < 1280; i++) {
      range.push(i);
      }

      return (
      <div className="app">

      <video src={video} controls />

      <div>
      <div className="watermarkButton" style={{}}>

      <span className="watermarkButtonX">Watermark X
      <select className="positionX">
      {range.map(i => (
      <option key={i}>{i}</option>
      ))} </select></span>

      <span className="watermarkButtonY">Watermark Y
      <select className="positionY">
      {range.map(i => (
      <option key={i}>{i}</option>
      ))} </select></span>



      <span>Live</span>
      <input type="checkbox" name="live" />
      </div>


      <button className = "watermarkButton watermarkSubmit"
      onClick={() => {
      const canvas = document.createElement('canvas');
      canvas.width = 1280;
      canvas.height = 720;
      const context = canvas.getContext('2d');
      context.drawImage(document.querySelector('video'), 0, 0, 1280, 720);
      context.drawImage(
      document.querySelector('.watermark'),
      parseInt(document.querySelector('.positionX').value),
      parseInt(document.querySelector('.positionY').value)
      );
      this.setState({ image: canvas.toDataURL() });
      }}> Watermark! </button>


      <img alt="watermarks" className="watermark" src={watermark} style={{ visibility: 'visible' }} />
      <img alt="watermarks" className="imageDisplay" height="405px" width="560px" src={this.state.image} />
      </div>
      </div>
      );
      }

      }

      export default App;









      share|improve this question









      New contributor




      Romane Green is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I'm trying to work HTML5 canvas video into a React application while making the code as clean as possible. What kind of improvements should be made to improve the performance utilizing the React to its fullest potential?



      import React, { Component } from 'react';
      import './App.css';
      import video from './video.mp4';
      import watermark from './watermark.png';

      class App extends Component {
      constructor() {
      super();
      this.state = {};
      }

      componentDidMount() {

      const canvas = document.createElement('canvas');
      canvas.width = 1280;
      canvas.height = 720;
      const context = canvas.getContext('2d');
      context.drawImage(document.querySelector('video'), 0, 0, 720, 1280);
      context.drawImage(
      document.querySelector('.watermark'),
      parseInt(document.querySelector('select').value),
      parseInt(document.querySelector('select').value)
      );
      if (document.querySelector('input[name=live]').checked) {
      this.setState({ image: canvas.toDataURL() });
      }

      }


      render() {
      const range = ;
      for (let i = 0; i < 1280; i++) {
      range.push(i);
      }

      return (
      <div className="app">

      <video src={video} controls />

      <div>
      <div className="watermarkButton" style={{}}>

      <span className="watermarkButtonX">Watermark X
      <select className="positionX">
      {range.map(i => (
      <option key={i}>{i}</option>
      ))} </select></span>

      <span className="watermarkButtonY">Watermark Y
      <select className="positionY">
      {range.map(i => (
      <option key={i}>{i}</option>
      ))} </select></span>



      <span>Live</span>
      <input type="checkbox" name="live" />
      </div>


      <button className = "watermarkButton watermarkSubmit"
      onClick={() => {
      const canvas = document.createElement('canvas');
      canvas.width = 1280;
      canvas.height = 720;
      const context = canvas.getContext('2d');
      context.drawImage(document.querySelector('video'), 0, 0, 1280, 720);
      context.drawImage(
      document.querySelector('.watermark'),
      parseInt(document.querySelector('.positionX').value),
      parseInt(document.querySelector('.positionY').value)
      );
      this.setState({ image: canvas.toDataURL() });
      }}> Watermark! </button>


      <img alt="watermarks" className="watermark" src={watermark} style={{ visibility: 'visible' }} />
      <img alt="watermarks" className="imageDisplay" height="405px" width="560px" src={this.state.image} />
      </div>
      </div>
      );
      }

      }

      export default App;






      javascript html5 react.js






      share|improve this question









      New contributor




      Romane Green is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Romane Green is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 11 mins ago









      Jamal

      30.3k11119227




      30.3k11119227






      New contributor




      Romane Green is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 13 mins ago









      Romane GreenRomane Green

      1




      1




      New contributor




      Romane Green is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Romane Green is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Romane Green is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Romane Green is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214087%2fhtml5-canvas-video-with-react%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Romane Green is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Romane Green is a new contributor. Be nice, and check out our Code of Conduct.













          Romane Green is a new contributor. Be nice, and check out our Code of Conduct.












          Romane Green is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214087%2fhtml5-canvas-video-with-react%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'