Loan Calculator in C
0
$begingroup$
I wanted to create a loan calculator, but the code I could think of was using 3 functions, and calling them and getting result. But I felt it was easy but bad code because I thought this can be written in fewer lines and with more quality. I wanted to ask what are some things to keep in my mind while trying to write better code instead of going in flow and creating many functions.
#include<stdio.h>
#include<stdlib.h>
#include<math.h>
float loanAmount,interestRate,Discount,i,loanPayment; //global variables
int years;
void loanDetails(void); //input from user regarding the loan
float annualRate(void);// interest rate
float discount(void); //discount to be added
int main() //main
{
loanDetails(); //called three functions
annualRate();
discount();
loanPayment = (loanAmount)/(Discount); //formula for monthly payments
printf("nthe monthly loan payment is %f",loanPayment);
return EXIT_SUCCESS;
}
void loanDetails(void) //taking input from user
{
printf("please enter Total Loan Amount: ");
scanf("%f",&loanAmount);
printf("please enter the number of years: ");
scanf("%d",&years);
printf("please enter the annualrate to be applied: ");
scanf("%f",&interestRate);
}
float annualRate(void) //calculated annual rate
{
float *ann;
ann = &interestRate;
i = ((*ann)/(100))/12;
printf("the value for %d years is %f",years,i);
return i;
}
float discount(void) //calculated dicount
{
float *x,y;
x = &i;
y = 1 + *x;
int n = years*12;
//Discount = pow((1+(*x)),12)-1/(*x)(pow((1+(*x)),12));
//Discount = (pow(y,(12))-1)/(y-1)*(pow(y,(12)));
float topD = (pow((y),n)-1);
float botD = (y-1)*pow((y),n);
Discount = topD/botD;
printf("nthe value of discount is : %f",Discount);
return Discount;
}
c
edited 4 secs ago
Jamal♦
30.3k11119227
asked 1 min ago
heeatheeat
11
New contributor
heeat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
I wanted to create a loan calculator, but the code I could think of was using 3 functions, and calling them and getting result. But I felt it was easy but bad code because I thought this can be written in fewer lines and with more quality. I wanted to ask what are some things to keep in my mind while trying to write better code instead of going in flow and creating many functions.
#include<stdio.h>
#include<stdlib.h>
#include<math.h>
float loanAmount,interestRate,Discount,i,loanPayment; //global variables
int years;
void loanDetails(void); //input from user regarding the loan
float annualRate(void);// interest rate
float discount(void); //discount to be added
int main() //main
{
loanDetails(); //called three functions
annualRate();
discount();
loanPayment = (loanAmount)/(Discount); //formula for monthly payments
printf("nthe monthly loan payment is %f",loanPayment);
return EXIT_SUCCESS;
}
void loanDetails(void) //taking input from user
{
printf("please enter Total Loan Amount: ");
scanf("%f",&loanAmount);
printf("please enter the number of years: ");
scanf("%d",&years);
printf("please enter the annualrate to be applied: ");
scanf("%f",&interestRate);
}
float annualRate(void) //calculated annual rate
{
float *ann;
ann = &interestRate;
i = ((*ann)/(100))/12;
printf("the value for %d years is %f",years,i);
return i;
}
float discount(void) //calculated dicount
{
float *x,y;
x = &i;
y = 1 + *x;
int n = years*12;
//Discount = pow((1+(*x)),12)-1/(*x)(pow((1+(*x)),12));
//Discount = (pow(y,(12))-1)/(y-1)*(pow(y,(12)));
float topD = (pow((y),n)-1);
float botD = (y-1)*pow((y),n);
Discount = topD/botD;
printf("nthe value of discount is : %f",Discount);
return Discount;
}
c
edited 4 secs ago
Jamal♦
30.3k11119227
asked 1 min ago
heeatheeat
11
New contributor
heeat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
I wanted to create a loan calculator, but the code I could think of was using 3 functions, and calling them and getting result. But I felt it was easy but bad code because I thought this can be written in fewer lines and with more quality. I wanted to ask what are some things to keep in my mind while trying to write better code instead of going in flow and creating many functions.
#include<stdio.h>
#include<stdlib.h>
#include<math.h>
float loanAmount,interestRate,Discount,i,loanPayment; //global variables
int years;
void loanDetails(void); //input from user regarding the loan
float annualRate(void);// interest rate
float discount(void); //discount to be added
int main() //main
{
loanDetails(); //called three functions
annualRate();
discount();
loanPayment = (loanAmount)/(Discount); //formula for monthly payments
printf("nthe monthly loan payment is %f",loanPayment);
return EXIT_SUCCESS;
}
void loanDetails(void) //taking input from user
{
printf("please enter Total Loan Amount: ");
scanf("%f",&loanAmount);
printf("please enter the number of years: ");
scanf("%d",&years);
printf("please enter the annualrate to be applied: ");
scanf("%f",&interestRate);
}
float annualRate(void) //calculated annual rate
{
float *ann;
ann = &interestRate;
i = ((*ann)/(100))/12;
printf("the value for %d years is %f",years,i);
return i;
}
float discount(void) //calculated dicount
{
float *x,y;
x = &i;
y = 1 + *x;
int n = years*12;
//Discount = pow((1+(*x)),12)-1/(*x)(pow((1+(*x)),12));
//Discount = (pow(y,(12))-1)/(y-1)*(pow(y,(12)));
float topD = (pow((y),n)-1);
float botD = (y-1)*pow((y),n);
Discount = topD/botD;
printf("nthe value of discount is : %f",Discount);
return Discount;
}
c
edited 4 secs ago
Jamal♦
30.3k11119227
asked 1 min ago
heeatheeat
11
New contributor
heeat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I wanted to create a loan calculator, but the code I could think of was using 3 functions, and calling them and getting result. But I felt it was easy but bad code because I thought this can be written in fewer lines and with more quality. I wanted to ask what are some things to keep in my mind while trying to write better code instead of going in flow and creating many functions.
#include<stdio.h>
#include<stdlib.h>
#include<math.h>
float loanAmount,interestRate,Discount,i,loanPayment; //global variables
int years;
void loanDetails(void); //input from user regarding the loan
float annualRate(void);// interest rate
float discount(void); //discount to be added
int main() //main
{
loanDetails(); //called three functions
annualRate();
discount();
loanPayment = (loanAmount)/(Discount); //formula for monthly payments
printf("nthe monthly loan payment is %f",loanPayment);
return EXIT_SUCCESS;
}
void loanDetails(void) //taking input from user
{
printf("please enter Total Loan Amount: ");
scanf("%f",&loanAmount);
printf("please enter the number of years: ");
scanf("%d",&years);
printf("please enter the annualrate to be applied: ");
scanf("%f",&interestRate);
}
float annualRate(void) //calculated annual rate
{
float *ann;
ann = &interestRate;
i = ((*ann)/(100))/12;
printf("the value for %d years is %f",years,i);
return i;
}
float discount(void) //calculated dicount
{
float *x,y;
x = &i;
y = 1 + *x;
int n = years*12;
//Discount = pow((1+(*x)),12)-1/(*x)(pow((1+(*x)),12));
//Discount = (pow(y,(12))-1)/(y-1)*(pow(y,(12)));
float topD = (pow((y),n)-1);
float botD = (y-1)*pow((y),n);
Discount = topD/botD;
printf("nthe value of discount is : %f",Discount);
return Discount;
}
c
c
edited 4 secs ago
Jamal♦
30.3k11119227
asked 1 min ago
heeatheeat
11
New contributor
heeat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 4 secs ago
Jamal♦
30.3k11119227
asked 1 min ago
heeatheeat
11
New contributor
heeat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 4 secs ago
Jamal♦
30.3k11119227
edited 4 secs ago
Jamal♦
30.3k11119227
edited 4 secs ago
Jamal♦
30.3k11119227
30.3k11119227
asked 1 min ago
heeatheeat
11
New contributor
heeat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 min ago
heeatheeat
11
asked 1 min ago
heeatheeat
11
11
New contributor
heeat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
heeat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
heeat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
heeat is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214091%2floan-calculator-in-c%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
heeat is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
heeat is a new contributor. Be nice, and check out our Code of Conduct.
heeat is a new contributor. Be nice, and check out our Code of Conduct.
heeat is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214091%2floan-calculator-in-c%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
