Retrieving a parser












0












$begingroup$


In the main method, I have to call a factory to retrieve the Parser and cast it to a child parser to read the different file.



How should I improve the code for it to make more sense?



public interface Parser<T>{
public Parser read(T t){};
}

public class ParserFromJson implements Parser<JSON>{
@Override
public Data read(JSON json){...};
}

public class ParserFromXml implements Parser<XML>{
@Override
public Data read(XML xml){...};
}

public class ParserFactory{
public Parser create(Type type){
switch(type){
case JSON:
return new ParserFromJson();
case XML:
return new ParserFromXml();
}
}

public enum Type{
JSON, XML
}

public static void main(String args){
((ParserFromJson)ParserFactory.create(JSON)).read(jsonfile);
((ParserFromXml )ParserFactory.create(XML)).read(xmlfile);
}









share|improve this question









New contributor




Zingoer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    In the main method, I have to call a factory to retrieve the Parser and cast it to a child parser to read the different file.



    How should I improve the code for it to make more sense?



    public interface Parser<T>{
    public Parser read(T t){};
    }

    public class ParserFromJson implements Parser<JSON>{
    @Override
    public Data read(JSON json){...};
    }

    public class ParserFromXml implements Parser<XML>{
    @Override
    public Data read(XML xml){...};
    }

    public class ParserFactory{
    public Parser create(Type type){
    switch(type){
    case JSON:
    return new ParserFromJson();
    case XML:
    return new ParserFromXml();
    }
    }

    public enum Type{
    JSON, XML
    }

    public static void main(String args){
    ((ParserFromJson)ParserFactory.create(JSON)).read(jsonfile);
    ((ParserFromXml )ParserFactory.create(XML)).read(xmlfile);
    }









    share|improve this question









    New contributor




    Zingoer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      In the main method, I have to call a factory to retrieve the Parser and cast it to a child parser to read the different file.



      How should I improve the code for it to make more sense?



      public interface Parser<T>{
      public Parser read(T t){};
      }

      public class ParserFromJson implements Parser<JSON>{
      @Override
      public Data read(JSON json){...};
      }

      public class ParserFromXml implements Parser<XML>{
      @Override
      public Data read(XML xml){...};
      }

      public class ParserFactory{
      public Parser create(Type type){
      switch(type){
      case JSON:
      return new ParserFromJson();
      case XML:
      return new ParserFromXml();
      }
      }

      public enum Type{
      JSON, XML
      }

      public static void main(String args){
      ((ParserFromJson)ParserFactory.create(JSON)).read(jsonfile);
      ((ParserFromXml )ParserFactory.create(XML)).read(xmlfile);
      }









      share|improve this question









      New contributor




      Zingoer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      In the main method, I have to call a factory to retrieve the Parser and cast it to a child parser to read the different file.



      How should I improve the code for it to make more sense?



      public interface Parser<T>{
      public Parser read(T t){};
      }

      public class ParserFromJson implements Parser<JSON>{
      @Override
      public Data read(JSON json){...};
      }

      public class ParserFromXml implements Parser<XML>{
      @Override
      public Data read(XML xml){...};
      }

      public class ParserFactory{
      public Parser create(Type type){
      switch(type){
      case JSON:
      return new ParserFromJson();
      case XML:
      return new ParserFromXml();
      }
      }

      public enum Type{
      JSON, XML
      }

      public static void main(String args){
      ((ParserFromJson)ParserFactory.create(JSON)).read(jsonfile);
      ((ParserFromXml )ParserFactory.create(XML)).read(xmlfile);
      }






      java






      share|improve this question









      New contributor




      Zingoer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Zingoer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 6 mins ago









      Jamal

      30.3k11116227




      30.3k11116227






      New contributor




      Zingoer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 42 mins ago









      ZingoerZingoer

      1




      1




      New contributor




      Zingoer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Zingoer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Zingoer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Zingoer is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212438%2fretrieving-a-parser%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Zingoer is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Zingoer is a new contributor. Be nice, and check out our Code of Conduct.













          Zingoer is a new contributor. Be nice, and check out our Code of Conduct.












          Zingoer is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212438%2fretrieving-a-parser%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'