Porting bitfields from c++ to C#












0












$begingroup$


I am porting a C++ library, which uses bitfields extensively into C# code.



Here is a an example of a bitfield class



struct Header{
uint32_t A;
uint16_t B: 1;
uint16_t C: 1;
uint16_t D: 1;
uint16_t : 13;
uint16_t E;
};


When turning this class into a C# class should I keep bitfield information or just neglect the bitfield information.



classNoBitFieldHeader{
uint A;
bool B;
bool C;
bool D;
ushort E;
};


or somewhere along the lines of



public class Header
{

private readonly BitArray _bitArray = new BitArray(16);

public uint A;

public bool B
{
get => _bitArray.Get(0);
set => _bitArray.Set(0,value);
}

public bool C
{
get => _bitArray.Get(1);
set => _bitArray.Set(1, value);
}

public bool D{
get => _bitArray.Get(0);
set => _bitArray.Set(0,value);
}

public ushort E;
}


In the latter I am happy that I kept all the information available but I am not sure if it should be kept at all










share|improve this question







New contributor




Hasan Emrah Süngü is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    I am porting a C++ library, which uses bitfields extensively into C# code.



    Here is a an example of a bitfield class



    struct Header{
    uint32_t A;
    uint16_t B: 1;
    uint16_t C: 1;
    uint16_t D: 1;
    uint16_t : 13;
    uint16_t E;
    };


    When turning this class into a C# class should I keep bitfield information or just neglect the bitfield information.



    classNoBitFieldHeader{
    uint A;
    bool B;
    bool C;
    bool D;
    ushort E;
    };


    or somewhere along the lines of



    public class Header
    {

    private readonly BitArray _bitArray = new BitArray(16);

    public uint A;

    public bool B
    {
    get => _bitArray.Get(0);
    set => _bitArray.Set(0,value);
    }

    public bool C
    {
    get => _bitArray.Get(1);
    set => _bitArray.Set(1, value);
    }

    public bool D{
    get => _bitArray.Get(0);
    set => _bitArray.Set(0,value);
    }

    public ushort E;
    }


    In the latter I am happy that I kept all the information available but I am not sure if it should be kept at all










    share|improve this question







    New contributor




    Hasan Emrah Süngü is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      I am porting a C++ library, which uses bitfields extensively into C# code.



      Here is a an example of a bitfield class



      struct Header{
      uint32_t A;
      uint16_t B: 1;
      uint16_t C: 1;
      uint16_t D: 1;
      uint16_t : 13;
      uint16_t E;
      };


      When turning this class into a C# class should I keep bitfield information or just neglect the bitfield information.



      classNoBitFieldHeader{
      uint A;
      bool B;
      bool C;
      bool D;
      ushort E;
      };


      or somewhere along the lines of



      public class Header
      {

      private readonly BitArray _bitArray = new BitArray(16);

      public uint A;

      public bool B
      {
      get => _bitArray.Get(0);
      set => _bitArray.Set(0,value);
      }

      public bool C
      {
      get => _bitArray.Get(1);
      set => _bitArray.Set(1, value);
      }

      public bool D{
      get => _bitArray.Get(0);
      set => _bitArray.Set(0,value);
      }

      public ushort E;
      }


      In the latter I am happy that I kept all the information available but I am not sure if it should be kept at all










      share|improve this question







      New contributor




      Hasan Emrah Süngü is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I am porting a C++ library, which uses bitfields extensively into C# code.



      Here is a an example of a bitfield class



      struct Header{
      uint32_t A;
      uint16_t B: 1;
      uint16_t C: 1;
      uint16_t D: 1;
      uint16_t : 13;
      uint16_t E;
      };


      When turning this class into a C# class should I keep bitfield information or just neglect the bitfield information.



      classNoBitFieldHeader{
      uint A;
      bool B;
      bool C;
      bool D;
      ushort E;
      };


      or somewhere along the lines of



      public class Header
      {

      private readonly BitArray _bitArray = new BitArray(16);

      public uint A;

      public bool B
      {
      get => _bitArray.Get(0);
      set => _bitArray.Set(0,value);
      }

      public bool C
      {
      get => _bitArray.Get(1);
      set => _bitArray.Set(1, value);
      }

      public bool D{
      get => _bitArray.Get(0);
      set => _bitArray.Set(0,value);
      }

      public ushort E;
      }


      In the latter I am happy that I kept all the information available but I am not sure if it should be kept at all







      c# c++ .net






      share|improve this question







      New contributor




      Hasan Emrah Süngü is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      Hasan Emrah Süngü is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      Hasan Emrah Süngü is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 13 mins ago









      Hasan Emrah SüngüHasan Emrah Süngü

      1011




      1011




      New contributor




      Hasan Emrah Süngü is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Hasan Emrah Süngü is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Hasan Emrah Süngü is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Hasan Emrah Süngü is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214444%2fporting-bitfields-from-c-to-c%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Hasan Emrah Süngü is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Hasan Emrah Süngü is a new contributor. Be nice, and check out our Code of Conduct.













          Hasan Emrah Süngü is a new contributor. Be nice, and check out our Code of Conduct.












          Hasan Emrah Süngü is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214444%2fporting-bitfields-from-c-to-c%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'