Checking values for victory condition in TicTacToe
-1
$begingroup$
Winning condition is not executing properly. When I run the code, most of the time, the victory condition is either not recognized or ends the game prematurely.
NOTE: I know my code is not very efficient/ easy to understand and I would really appreciate it if someone would help me get "my logic" to work for the code before I try and learn new things and optimize it because I am a beginner and it is my first project that I'm just trying to get to work.
Tuple where X and O are stored
def resetboard(self):
global posvalues
posvalues = [
['1','2','3'],
['','',''],
['4','5','6'],
['','',''],
['7','8','9'],
]
Checking the Winning Condition
def isthereawinner(self):
global winner
##Check rows for winning condition; exclude odd nubered rows in posvalues that are blank
for num in range(0,5):
if posvalues[num][0] == posvalues[num][1] == posvalues[num][2] == character1 != "":
winner = player1
break
elif posvalues[num][0] == posvalues[num][1] == posvalues[num][2] == character2 != "":
winner = player2
break
if num:
break
##Check columns for winning condition
for num in range(0,3):
for row in range(0,5,2):
if posvalues[row][num] == posvalues[row][num] == posvalues[row][num] == character1 != "":
winner = player1
break
elif posvalues[row][num] == posvalues[row][num] == posvalues[row][num] == character2 != "":
winner = player2
break
if row:
break
##Check diagonal for the winning condition
if posvalues[0][0] == posvalues[2][1] == posvalues[4][2] == character1:
winner = player1
elif posvalues[0][0] == posvalues[2][1] == posvalues[4][2] == character2:
winner = player2
elif posvalues[0][2] == posvalues[2][1] == posvalues[4][0] == character1:
winner = player1
elif posvalues[0][2] == posvalues[2][1] == posvalues[4][0] == character2:
winner = player2
return winner
At the end of each Turn
displaywinner = print(self.isthereawinner())
if displaywinner == player1 or displaywinner == player2:
print(displaywinner + " WINS!")
return
else:
pass
python tic-tac-toe
asked 12 mins ago
Aviral GuptaAviral Gupta
1
New contributor
Aviral Gupta is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
-1
$begingroup$
Winning condition is not executing properly. When I run the code, most of the time, the victory condition is either not recognized or ends the game prematurely.
NOTE: I know my code is not very efficient/ easy to understand and I would really appreciate it if someone would help me get "my logic" to work for the code before I try and learn new things and optimize it because I am a beginner and it is my first project that I'm just trying to get to work.
Tuple where X and O are stored
def resetboard(self):
global posvalues
posvalues = [
['1','2','3'],
['','',''],
['4','5','6'],
['','',''],
['7','8','9'],
]
Checking the Winning Condition
def isthereawinner(self):
global winner
##Check rows for winning condition; exclude odd nubered rows in posvalues that are blank
for num in range(0,5):
if posvalues[num][0] == posvalues[num][1] == posvalues[num][2] == character1 != "":
winner = player1
break
elif posvalues[num][0] == posvalues[num][1] == posvalues[num][2] == character2 != "":
winner = player2
break
if num:
break
##Check columns for winning condition
for num in range(0,3):
for row in range(0,5,2):
if posvalues[row][num] == posvalues[row][num] == posvalues[row][num] == character1 != "":
winner = player1
break
elif posvalues[row][num] == posvalues[row][num] == posvalues[row][num] == character2 != "":
winner = player2
break
if row:
break
##Check diagonal for the winning condition
if posvalues[0][0] == posvalues[2][1] == posvalues[4][2] == character1:
winner = player1
elif posvalues[0][0] == posvalues[2][1] == posvalues[4][2] == character2:
winner = player2
elif posvalues[0][2] == posvalues[2][1] == posvalues[4][0] == character1:
winner = player1
elif posvalues[0][2] == posvalues[2][1] == posvalues[4][0] == character2:
winner = player2
return winner
At the end of each Turn
displaywinner = print(self.isthereawinner())
if displaywinner == player1 or displaywinner == player2:
print(displaywinner + " WINS!")
return
else:
pass
python tic-tac-toe
asked 12 mins ago
Aviral GuptaAviral Gupta
1
New contributor
Aviral Gupta is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
$begingroup$
Welcome to Code Review. Your code must work correct before we can review it. Since you say that your code does not work reliably, it is off-topic.
$endgroup$
– 200_success
8 mins ago
add a comment |
-1
-1
-1
0
$begingroup$
Winning condition is not executing properly. When I run the code, most of the time, the victory condition is either not recognized or ends the game prematurely.
NOTE: I know my code is not very efficient/ easy to understand and I would really appreciate it if someone would help me get "my logic" to work for the code before I try and learn new things and optimize it because I am a beginner and it is my first project that I'm just trying to get to work.
Tuple where X and O are stored
def resetboard(self):
global posvalues
posvalues = [
['1','2','3'],
['','',''],
['4','5','6'],
['','',''],
['7','8','9'],
]
Checking the Winning Condition
def isthereawinner(self):
global winner
##Check rows for winning condition; exclude odd nubered rows in posvalues that are blank
for num in range(0,5):
if posvalues[num][0] == posvalues[num][1] == posvalues[num][2] == character1 != "":
winner = player1
break
elif posvalues[num][0] == posvalues[num][1] == posvalues[num][2] == character2 != "":
winner = player2
break
if num:
break
##Check columns for winning condition
for num in range(0,3):
for row in range(0,5,2):
if posvalues[row][num] == posvalues[row][num] == posvalues[row][num] == character1 != "":
winner = player1
break
elif posvalues[row][num] == posvalues[row][num] == posvalues[row][num] == character2 != "":
winner = player2
break
if row:
break
##Check diagonal for the winning condition
if posvalues[0][0] == posvalues[2][1] == posvalues[4][2] == character1:
winner = player1
elif posvalues[0][0] == posvalues[2][1] == posvalues[4][2] == character2:
winner = player2
elif posvalues[0][2] == posvalues[2][1] == posvalues[4][0] == character1:
winner = player1
elif posvalues[0][2] == posvalues[2][1] == posvalues[4][0] == character2:
winner = player2
return winner
At the end of each Turn
displaywinner = print(self.isthereawinner())
if displaywinner == player1 or displaywinner == player2:
print(displaywinner + " WINS!")
return
else:
pass
python tic-tac-toe
asked 12 mins ago
Aviral GuptaAviral Gupta
1
New contributor
Aviral Gupta is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
Winning condition is not executing properly. When I run the code, most of the time, the victory condition is either not recognized or ends the game prematurely.
NOTE: I know my code is not very efficient/ easy to understand and I would really appreciate it if someone would help me get "my logic" to work for the code before I try and learn new things and optimize it because I am a beginner and it is my first project that I'm just trying to get to work.
Tuple where X and O are stored
def resetboard(self):
global posvalues
posvalues = [
['1','2','3'],
['','',''],
['4','5','6'],
['','',''],
['7','8','9'],
]
Checking the Winning Condition
def isthereawinner(self):
global winner
##Check rows for winning condition; exclude odd nubered rows in posvalues that are blank
for num in range(0,5):
if posvalues[num][0] == posvalues[num][1] == posvalues[num][2] == character1 != "":
winner = player1
break
elif posvalues[num][0] == posvalues[num][1] == posvalues[num][2] == character2 != "":
winner = player2
break
if num:
break
##Check columns for winning condition
for num in range(0,3):
for row in range(0,5,2):
if posvalues[row][num] == posvalues[row][num] == posvalues[row][num] == character1 != "":
winner = player1
break
elif posvalues[row][num] == posvalues[row][num] == posvalues[row][num] == character2 != "":
winner = player2
break
if row:
break
##Check diagonal for the winning condition
if posvalues[0][0] == posvalues[2][1] == posvalues[4][2] == character1:
winner = player1
elif posvalues[0][0] == posvalues[2][1] == posvalues[4][2] == character2:
winner = player2
elif posvalues[0][2] == posvalues[2][1] == posvalues[4][0] == character1:
winner = player1
elif posvalues[0][2] == posvalues[2][1] == posvalues[4][0] == character2:
winner = player2
return winner
At the end of each Turn
displaywinner = print(self.isthereawinner())
if displaywinner == player1 or displaywinner == player2:
print(displaywinner + " WINS!")
return
else:
pass
python tic-tac-toe
python tic-tac-toe
asked 12 mins ago
Aviral GuptaAviral Gupta
1
New contributor
Aviral Gupta is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 12 mins ago
Aviral GuptaAviral Gupta
1
New contributor
Aviral Gupta is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 12 mins ago
Aviral GuptaAviral Gupta
1
New contributor
Aviral Gupta is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 12 mins ago
Aviral GuptaAviral Gupta
1
asked 12 mins ago
Aviral GuptaAviral Gupta
1
1
New contributor
Aviral Gupta is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Aviral Gupta is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Aviral Gupta is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$begingroup$
Welcome to Code Review. Your code must work correct before we can review it. Since you say that your code does not work reliably, it is off-topic.
$endgroup$
– 200_success
8 mins ago
add a comment |
$begingroup$
Welcome to Code Review. Your code must work correct before we can review it. Since you say that your code does not work reliably, it is off-topic.
$endgroup$
– 200_success
8 mins ago
$begingroup$
Welcome to Code Review. Your code must work correct before we can review it. Since you say that your code does not work reliably, it is off-topic.
$endgroup$
– 200_success
8 mins ago
$begingroup$
Welcome to Code Review. Your code must work correct before we can review it. Since you say that your code does not work reliably, it is off-topic.
$endgroup$
– 200_success
8 mins ago
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Aviral Gupta is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212889%2fchecking-values-for-victory-condition-in-tictactoe%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Aviral Gupta is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Aviral Gupta is a new contributor. Be nice, and check out our Code of Conduct.
Aviral Gupta is a new contributor. Be nice, and check out our Code of Conduct.
Aviral Gupta is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212889%2fchecking-values-for-victory-condition-in-tictactoe%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
$begingroup$
Welcome to Code Review. Your code must work correct before we can review it. Since you say that your code does not work reliably, it is off-topic.
$endgroup$
– 200_success
8 mins ago