ObjectUnsubscribedError after using takeUntil

up vote
0
down vote

favorite

So I have a bunch of http requests happening while I load different items to the screen. this is the basic layout

ngUnsubscribe: any = new Subject();



constructor(private service: Service){}



ngOnInit() {}



BuildView(data) {this.submitLayerservice.submitLayer(onLoadSubmitLayerFormat)

        .pipe(takeUntil(this.ngUnsubscribe))

        .subscribe( //logic happens here 

)

}



ngOnDestroy() {

this.ngUnsubscribe.next();

this.ngUnsubscribe.unsubscribe();

}

Everything works fine and I see all of the requests get canceled when the component is destroyed. But when I go to load the project again I get this error and nothing shows up. I'm guessing it's because the ngUnsubscribe already happened? Not really sure. Most of the questions for this have to deal with Map.

EDIT:
If i dont add this.ngUnsubscribe.unsubscribe(); The problem seems to be fixed. Should I not unsubscribe from this subject?

edited Nov 19 at 21:19

asked Nov 19 at 21:10

Petey

197

When do you call BuildView?
– Explosion Pills
Nov 19 at 21:13

I call build view when a user clicks to load a project.
– Petey
Nov 19 at 21:18

Can you please provide a stackblitz so we can reproduce your error
– Batajus
Nov 19 at 21:36

1

You almost never want to call unsubscribe on a Subject instance: blog.angularindepth.com/rxjs-closed-subjects-1b6f76c1b63c
– cartant
Nov 19 at 23:24

maybe call this.ngUnsubscribe.next(); then this.ngUnsubscribe.complete(); before unsubscribe, according to the article
– Fan Cheung
Nov 20 at 5:43

add a comment |

up vote
0
down vote

favorite

So I have a bunch of http requests happening while I load different items to the screen. this is the basic layout

ngUnsubscribe: any = new Subject();



constructor(private service: Service){}



ngOnInit() {}



BuildView(data) {this.submitLayerservice.submitLayer(onLoadSubmitLayerFormat)

        .pipe(takeUntil(this.ngUnsubscribe))

        .subscribe( //logic happens here 

)

}



ngOnDestroy() {

this.ngUnsubscribe.next();

this.ngUnsubscribe.unsubscribe();

}

EDIT:
If i dont add this.ngUnsubscribe.unsubscribe(); The problem seems to be fixed. Should I not unsubscribe from this subject?

edited Nov 19 at 21:19

asked Nov 19 at 21:10

Petey

197

When do you call BuildView?
– Explosion Pills
Nov 19 at 21:13

I call build view when a user clicks to load a project.
– Petey
Nov 19 at 21:18

Can you please provide a stackblitz so we can reproduce your error
– Batajus
Nov 19 at 21:36

1

You almost never want to call unsubscribe on a Subject instance: blog.angularindepth.com/rxjs-closed-subjects-1b6f76c1b63c
– cartant
Nov 19 at 23:24

maybe call this.ngUnsubscribe.next(); then this.ngUnsubscribe.complete(); before unsubscribe, according to the article
– Fan Cheung
Nov 20 at 5:43

add a comment |

up vote
0
down vote

favorite

So I have a bunch of http requests happening while I load different items to the screen. this is the basic layout

ngUnsubscribe: any = new Subject();



constructor(private service: Service){}



ngOnInit() {}



BuildView(data) {this.submitLayerservice.submitLayer(onLoadSubmitLayerFormat)

        .pipe(takeUntil(this.ngUnsubscribe))

        .subscribe( //logic happens here 

)

}



ngOnDestroy() {

this.ngUnsubscribe.next();

this.ngUnsubscribe.unsubscribe();

}

EDIT:
If i dont add this.ngUnsubscribe.unsubscribe(); The problem seems to be fixed. Should I not unsubscribe from this subject?

edited Nov 19 at 21:19

asked Nov 19 at 21:10

Petey

197

So I have a bunch of http requests happening while I load different items to the screen. this is the basic layout

ngUnsubscribe: any = new Subject();



constructor(private service: Service){}



ngOnInit() {}



BuildView(data) {this.submitLayerservice.submitLayer(onLoadSubmitLayerFormat)

        .pipe(takeUntil(this.ngUnsubscribe))

        .subscribe( //logic happens here 

)

}



ngOnDestroy() {

this.ngUnsubscribe.next();

this.ngUnsubscribe.unsubscribe();

}

EDIT:
If i dont add this.ngUnsubscribe.unsubscribe(); The problem seems to be fixed. Should I not unsubscribe from this subject?

angular rxjs

edited Nov 19 at 21:19

asked Nov 19 at 21:10

Petey

197

edited Nov 19 at 21:19

asked Nov 19 at 21:10

Petey

197

edited Nov 19 at 21:19

asked Nov 19 at 21:10

Petey

197

asked Nov 19 at 21:10

Petey

197

asked Nov 19 at 21:10

Petey

197

When do you call BuildView?
– Explosion Pills
Nov 19 at 21:13

I call build view when a user clicks to load a project.
– Petey
Nov 19 at 21:18

Can you please provide a stackblitz so we can reproduce your error
– Batajus
Nov 19 at 21:36

1

You almost never want to call unsubscribe on a Subject instance: blog.angularindepth.com/rxjs-closed-subjects-1b6f76c1b63c
– cartant
Nov 19 at 23:24

maybe call this.ngUnsubscribe.next(); then this.ngUnsubscribe.complete(); before unsubscribe, according to the article
– Fan Cheung
Nov 20 at 5:43

add a comment |

When do you call BuildView?
– Explosion Pills
Nov 19 at 21:13

I call build view when a user clicks to load a project.
– Petey
Nov 19 at 21:18

Can you please provide a stackblitz so we can reproduce your error
– Batajus
Nov 19 at 21:36

1

You almost never want to call unsubscribe on a Subject instance: blog.angularindepth.com/rxjs-closed-subjects-1b6f76c1b63c
– cartant
Nov 19 at 23:24

maybe call this.ngUnsubscribe.next(); then this.ngUnsubscribe.complete(); before unsubscribe, according to the article
– Fan Cheung
Nov 20 at 5:43

When do you call BuildView?
– Explosion Pills
Nov 19 at 21:13

I call build view when a user clicks to load a project.
– Petey
Nov 19 at 21:18

Can you please provide a stackblitz so we can reproduce your error
– Batajus
Nov 19 at 21:36

You almost never want to call unsubscribe on a Subject instance: blog.angularindepth.com/rxjs-closed-subjects-1b6f76c1b63c
– cartant
Nov 19 at 23:24

maybe call this.ngUnsubscribe.next(); then this.ngUnsubscribe.complete(); before unsubscribe, according to the article
– Fan Cheung
Nov 20 at 5:43

add a comment |

active

oldest

votes

Your Answer

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});

}
});

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53382688%2fobjectunsubscribederror-after-using-takeuntil%23new-answer', 'question_page');
}
);

Post as a guest

Name

Required, but never shown

active

oldest

votes

draft saved

draft discarded

Thanks for contributing an answer to Stack Overflow!

Please be sure to answer the question. Provide details and share your research!

But avoid …

Asking for help, clarification, or responding to other answers.

Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.

Some of your past answers have not been well-received, and you're in danger of being blocked from answering.

Please pay close attention to the following guidance:

Please be sure to answer the question. Provide details and share your research!

But avoid …

Asking for help, clarification, or responding to other answers.

Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Name

Required, but never shown

Name

Required, but never shown

This page is only for reference, If you need detailed information, please check here

搜尋此網誌

Tukukkk