Find kth smallest element in binary search tree











up vote
2
down vote

favorite
1












I was faced with below interview question today and I came up with below solution but somehow interviewer was not happy. I am not sure why..




Given a binary search tree, find the kth smallest element in it.




Is there any better or more efficient way to do this problem?



  /*****************************************************
*
* Kth Smallest Iterative
*
******************************************************/

public int kthSmallestIterative(TreeNode root, int k) {
Stack<TreeNode> st = new Stack<>();

while (root != null) {
st.push(root);
root = root.left;
}

while (k != 0) {
TreeNode n = st.pop();
k--;
if (k == 0)
return n.data;
TreeNode right = n.right;
while (right != null) {
st.push(right);
right = right.left;
}
}

return -1;
}


I mentioned time and space complexity as O(n). My iterative version takes extra space. Is there any way to do it without any extra space?










share|improve this question
























  • Is the tree mutable? Is O(k) memory acceptable?
    – vnp
    1 hour ago










  • I didn't asked this question to the interviewer but let's say if it is not mutable then can we optimize anything? And let's say if it is mutable then how efficiently we can do it?
    – user5447339
    1 hour ago










  • Do you have control over the TreeNode class?
    – tinstaafl
    22 mins ago















up vote
2
down vote

favorite
1












I was faced with below interview question today and I came up with below solution but somehow interviewer was not happy. I am not sure why..




Given a binary search tree, find the kth smallest element in it.




Is there any better or more efficient way to do this problem?



  /*****************************************************
*
* Kth Smallest Iterative
*
******************************************************/

public int kthSmallestIterative(TreeNode root, int k) {
Stack<TreeNode> st = new Stack<>();

while (root != null) {
st.push(root);
root = root.left;
}

while (k != 0) {
TreeNode n = st.pop();
k--;
if (k == 0)
return n.data;
TreeNode right = n.right;
while (right != null) {
st.push(right);
right = right.left;
}
}

return -1;
}


I mentioned time and space complexity as O(n). My iterative version takes extra space. Is there any way to do it without any extra space?










share|improve this question
























  • Is the tree mutable? Is O(k) memory acceptable?
    – vnp
    1 hour ago










  • I didn't asked this question to the interviewer but let's say if it is not mutable then can we optimize anything? And let's say if it is mutable then how efficiently we can do it?
    – user5447339
    1 hour ago










  • Do you have control over the TreeNode class?
    – tinstaafl
    22 mins ago













up vote
2
down vote

favorite
1









up vote
2
down vote

favorite
1






1





I was faced with below interview question today and I came up with below solution but somehow interviewer was not happy. I am not sure why..




Given a binary search tree, find the kth smallest element in it.




Is there any better or more efficient way to do this problem?



  /*****************************************************
*
* Kth Smallest Iterative
*
******************************************************/

public int kthSmallestIterative(TreeNode root, int k) {
Stack<TreeNode> st = new Stack<>();

while (root != null) {
st.push(root);
root = root.left;
}

while (k != 0) {
TreeNode n = st.pop();
k--;
if (k == 0)
return n.data;
TreeNode right = n.right;
while (right != null) {
st.push(right);
right = right.left;
}
}

return -1;
}


I mentioned time and space complexity as O(n). My iterative version takes extra space. Is there any way to do it without any extra space?










share|improve this question















I was faced with below interview question today and I came up with below solution but somehow interviewer was not happy. I am not sure why..




Given a binary search tree, find the kth smallest element in it.




Is there any better or more efficient way to do this problem?



  /*****************************************************
*
* Kth Smallest Iterative
*
******************************************************/

public int kthSmallestIterative(TreeNode root, int k) {
Stack<TreeNode> st = new Stack<>();

while (root != null) {
st.push(root);
root = root.left;
}

while (k != 0) {
TreeNode n = st.pop();
k--;
if (k == 0)
return n.data;
TreeNode right = n.right;
while (right != null) {
st.push(right);
right = right.left;
}
}

return -1;
}


I mentioned time and space complexity as O(n). My iterative version takes extra space. Is there any way to do it without any extra space?







java algorithm interview-questions tree






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited 3 mins ago









200_success

127k15148412




127k15148412










asked 1 hour ago









user5447339

15318




15318












  • Is the tree mutable? Is O(k) memory acceptable?
    – vnp
    1 hour ago










  • I didn't asked this question to the interviewer but let's say if it is not mutable then can we optimize anything? And let's say if it is mutable then how efficiently we can do it?
    – user5447339
    1 hour ago










  • Do you have control over the TreeNode class?
    – tinstaafl
    22 mins ago


















  • Is the tree mutable? Is O(k) memory acceptable?
    – vnp
    1 hour ago










  • I didn't asked this question to the interviewer but let's say if it is not mutable then can we optimize anything? And let's say if it is mutable then how efficiently we can do it?
    – user5447339
    1 hour ago










  • Do you have control over the TreeNode class?
    – tinstaafl
    22 mins ago
















Is the tree mutable? Is O(k) memory acceptable?
– vnp
1 hour ago




Is the tree mutable? Is O(k) memory acceptable?
– vnp
1 hour ago












I didn't asked this question to the interviewer but let's say if it is not mutable then can we optimize anything? And let's say if it is mutable then how efficiently we can do it?
– user5447339
1 hour ago




I didn't asked this question to the interviewer but let's say if it is not mutable then can we optimize anything? And let's say if it is mutable then how efficiently we can do it?
– user5447339
1 hour ago












Do you have control over the TreeNode class?
– tinstaafl
22 mins ago




Do you have control over the TreeNode class?
– tinstaafl
22 mins ago















active

oldest

votes











Your Answer





StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














 

draft saved


draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208668%2ffind-kth-smallest-element-in-binary-search-tree%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown






























active

oldest

votes













active

oldest

votes









active

oldest

votes






active

oldest

votes
















 

draft saved


draft discarded



















































 


draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208668%2ffind-kth-smallest-element-in-binary-search-tree%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

404 Error Contact Form 7 ajax form submitting

How to know if a Active Directory user can login interactively

TypeError: fit_transform() missing 1 required positional argument: 'X'