Refactoring coordinates for Minecraft Pi buildings written in Python
0
$begingroup$
I'm fairly new to coding and I wrote this script in Python for a house with a roof in Minecraft Pi. I've found different ways to write the coordinates to make the code base shorter, but I'm wondering if it is possible for me to refactor it any further so I don't have to list each coordinate line by line.
import mcpi.minecraft as minecraft
import mcpi.block as block
mc = minecraft.Minecraft.create()
p = mc.player.getTilePos()
mc.setBlocks(p.x+1, p.y, p.z+1, #Main structure starting coordinates (DO NOT ALTER)
p.x+19, p.y+4, p.z+6, #Structure size/coordinates (Alters cube size)
block.STONE_BRICK)
mc.setBlocks(p.x+2, p.y+1, p.z+2, #Hollowing out main structure interior
p.x+18, p.y+3, p.z+5,
block.AIR)
mc.setBlocks(p.x, p.y+4, p.z, #Main Structure Roof (Front Side, 1st Row)
p.x+12, p.y+4, p.z,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x+20, p.y+4, p.z,
p.x+20, p.y+4, p.z,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+5, p.z+1, #Main Structure Roof (Front Side, 2nd Row)
p.x+13, p.y+5, p.z+1,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x+19, p.y+5, p.z+1,
p.x+20, p.y+5, p.z+1,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+6, p.z+2, #Main Structure Roof (Front Side, 3rd Row)
p.x+14, p.y+6, p.z+2,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x+18, p.y+6, p.z+2,
p.x+20, p.y+6, p.z+2,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+7, p.z+3, #Main Structure Roof (Front Side, 4th Row)
p.x+20, p.y+7, p.z+3,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+4, p.z+7, #Main Structure Roof (Rear Side, 1st Row)
p.x+20, p.y+4, p.z+7,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x, p.y+5, p.z+6, #Main Structure Roof (Rear Side, 2nd Row)
p.x+20, p.y+5, p.z+6,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x, p.y+6, p.z+5, #Main Structure Roof (Rear Side, 3rd Row)
p.x+20, p.y+6, p.z+5,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x, p.y+7, p.z+4, #Main Structure Roof (Rear Side, 4th Row)
p.x+20, p.y+7, p.z+4,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x+1, p.y+5, p.z+2, #Main Structure Roof End (Right Side, 1st Row)
p.x+1, p.y+5, p.z+5,
block.STONE_BRICK)
mc.setBlocks(p.x+1, p.y+6, p.z+3, #Main Structure Roof End (Right Side, 2nd Row)
p.x+1, p.y+6, p.z+4,
block.STONE_BRICK)
mc.setBlocks(p.x+19, p.y+5, p.z+2, #Main Structure Roof End (Left Side, 1st Row)
p.x+19, p.y+5, p.z+5,
block.STONE_BRICK)
mc.setBlocks(p.x+19, p.y+6, p.z+3, #Main Structure Roof End (Left Side, 2nd Row)
p.x+19, p.y+6, p.z+4,
block.STONE_BRICK)
python raspberry-pi minecraft
asked 22 mins ago
DysFunctionDysFunction
1
New contributor
DysFunction is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
I'm fairly new to coding and I wrote this script in Python for a house with a roof in Minecraft Pi. I've found different ways to write the coordinates to make the code base shorter, but I'm wondering if it is possible for me to refactor it any further so I don't have to list each coordinate line by line.
import mcpi.minecraft as minecraft
import mcpi.block as block
mc = minecraft.Minecraft.create()
p = mc.player.getTilePos()
mc.setBlocks(p.x+1, p.y, p.z+1, #Main structure starting coordinates (DO NOT ALTER)
p.x+19, p.y+4, p.z+6, #Structure size/coordinates (Alters cube size)
block.STONE_BRICK)
mc.setBlocks(p.x+2, p.y+1, p.z+2, #Hollowing out main structure interior
p.x+18, p.y+3, p.z+5,
block.AIR)
mc.setBlocks(p.x, p.y+4, p.z, #Main Structure Roof (Front Side, 1st Row)
p.x+12, p.y+4, p.z,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x+20, p.y+4, p.z,
p.x+20, p.y+4, p.z,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+5, p.z+1, #Main Structure Roof (Front Side, 2nd Row)
p.x+13, p.y+5, p.z+1,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x+19, p.y+5, p.z+1,
p.x+20, p.y+5, p.z+1,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+6, p.z+2, #Main Structure Roof (Front Side, 3rd Row)
p.x+14, p.y+6, p.z+2,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x+18, p.y+6, p.z+2,
p.x+20, p.y+6, p.z+2,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+7, p.z+3, #Main Structure Roof (Front Side, 4th Row)
p.x+20, p.y+7, p.z+3,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+4, p.z+7, #Main Structure Roof (Rear Side, 1st Row)
p.x+20, p.y+4, p.z+7,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x, p.y+5, p.z+6, #Main Structure Roof (Rear Side, 2nd Row)
p.x+20, p.y+5, p.z+6,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x, p.y+6, p.z+5, #Main Structure Roof (Rear Side, 3rd Row)
p.x+20, p.y+6, p.z+5,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x, p.y+7, p.z+4, #Main Structure Roof (Rear Side, 4th Row)
p.x+20, p.y+7, p.z+4,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x+1, p.y+5, p.z+2, #Main Structure Roof End (Right Side, 1st Row)
p.x+1, p.y+5, p.z+5,
block.STONE_BRICK)
mc.setBlocks(p.x+1, p.y+6, p.z+3, #Main Structure Roof End (Right Side, 2nd Row)
p.x+1, p.y+6, p.z+4,
block.STONE_BRICK)
mc.setBlocks(p.x+19, p.y+5, p.z+2, #Main Structure Roof End (Left Side, 1st Row)
p.x+19, p.y+5, p.z+5,
block.STONE_BRICK)
mc.setBlocks(p.x+19, p.y+6, p.z+3, #Main Structure Roof End (Left Side, 2nd Row)
p.x+19, p.y+6, p.z+4,
block.STONE_BRICK)
python raspberry-pi minecraft
asked 22 mins ago
DysFunctionDysFunction
1
New contributor
DysFunction is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
I'm fairly new to coding and I wrote this script in Python for a house with a roof in Minecraft Pi. I've found different ways to write the coordinates to make the code base shorter, but I'm wondering if it is possible for me to refactor it any further so I don't have to list each coordinate line by line.
import mcpi.minecraft as minecraft
import mcpi.block as block
mc = minecraft.Minecraft.create()
p = mc.player.getTilePos()
mc.setBlocks(p.x+1, p.y, p.z+1, #Main structure starting coordinates (DO NOT ALTER)
p.x+19, p.y+4, p.z+6, #Structure size/coordinates (Alters cube size)
block.STONE_BRICK)
mc.setBlocks(p.x+2, p.y+1, p.z+2, #Hollowing out main structure interior
p.x+18, p.y+3, p.z+5,
block.AIR)
mc.setBlocks(p.x, p.y+4, p.z, #Main Structure Roof (Front Side, 1st Row)
p.x+12, p.y+4, p.z,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x+20, p.y+4, p.z,
p.x+20, p.y+4, p.z,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+5, p.z+1, #Main Structure Roof (Front Side, 2nd Row)
p.x+13, p.y+5, p.z+1,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x+19, p.y+5, p.z+1,
p.x+20, p.y+5, p.z+1,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+6, p.z+2, #Main Structure Roof (Front Side, 3rd Row)
p.x+14, p.y+6, p.z+2,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x+18, p.y+6, p.z+2,
p.x+20, p.y+6, p.z+2,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+7, p.z+3, #Main Structure Roof (Front Side, 4th Row)
p.x+20, p.y+7, p.z+3,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+4, p.z+7, #Main Structure Roof (Rear Side, 1st Row)
p.x+20, p.y+4, p.z+7,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x, p.y+5, p.z+6, #Main Structure Roof (Rear Side, 2nd Row)
p.x+20, p.y+5, p.z+6,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x, p.y+6, p.z+5, #Main Structure Roof (Rear Side, 3rd Row)
p.x+20, p.y+6, p.z+5,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x, p.y+7, p.z+4, #Main Structure Roof (Rear Side, 4th Row)
p.x+20, p.y+7, p.z+4,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x+1, p.y+5, p.z+2, #Main Structure Roof End (Right Side, 1st Row)
p.x+1, p.y+5, p.z+5,
block.STONE_BRICK)
mc.setBlocks(p.x+1, p.y+6, p.z+3, #Main Structure Roof End (Right Side, 2nd Row)
p.x+1, p.y+6, p.z+4,
block.STONE_BRICK)
mc.setBlocks(p.x+19, p.y+5, p.z+2, #Main Structure Roof End (Left Side, 1st Row)
p.x+19, p.y+5, p.z+5,
block.STONE_BRICK)
mc.setBlocks(p.x+19, p.y+6, p.z+3, #Main Structure Roof End (Left Side, 2nd Row)
p.x+19, p.y+6, p.z+4,
block.STONE_BRICK)
python raspberry-pi minecraft
asked 22 mins ago
DysFunctionDysFunction
1
New contributor
DysFunction is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I'm fairly new to coding and I wrote this script in Python for a house with a roof in Minecraft Pi. I've found different ways to write the coordinates to make the code base shorter, but I'm wondering if it is possible for me to refactor it any further so I don't have to list each coordinate line by line.
import mcpi.minecraft as minecraft
import mcpi.block as block
mc = minecraft.Minecraft.create()
p = mc.player.getTilePos()
mc.setBlocks(p.x+1, p.y, p.z+1, #Main structure starting coordinates (DO NOT ALTER)
p.x+19, p.y+4, p.z+6, #Structure size/coordinates (Alters cube size)
block.STONE_BRICK)
mc.setBlocks(p.x+2, p.y+1, p.z+2, #Hollowing out main structure interior
p.x+18, p.y+3, p.z+5,
block.AIR)
mc.setBlocks(p.x, p.y+4, p.z, #Main Structure Roof (Front Side, 1st Row)
p.x+12, p.y+4, p.z,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x+20, p.y+4, p.z,
p.x+20, p.y+4, p.z,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+5, p.z+1, #Main Structure Roof (Front Side, 2nd Row)
p.x+13, p.y+5, p.z+1,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x+19, p.y+5, p.z+1,
p.x+20, p.y+5, p.z+1,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+6, p.z+2, #Main Structure Roof (Front Side, 3rd Row)
p.x+14, p.y+6, p.z+2,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x+18, p.y+6, p.z+2,
p.x+20, p.y+6, p.z+2,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+7, p.z+3, #Main Structure Roof (Front Side, 4th Row)
p.x+20, p.y+7, p.z+3,
block.STAIRS_WOOD.id, 2)
mc.setBlocks(p.x, p.y+4, p.z+7, #Main Structure Roof (Rear Side, 1st Row)
p.x+20, p.y+4, p.z+7,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x, p.y+5, p.z+6, #Main Structure Roof (Rear Side, 2nd Row)
p.x+20, p.y+5, p.z+6,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x, p.y+6, p.z+5, #Main Structure Roof (Rear Side, 3rd Row)
p.x+20, p.y+6, p.z+5,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x, p.y+7, p.z+4, #Main Structure Roof (Rear Side, 4th Row)
p.x+20, p.y+7, p.z+4,
block.STAIRS_WOOD.id, 3)
mc.setBlocks(p.x+1, p.y+5, p.z+2, #Main Structure Roof End (Right Side, 1st Row)
p.x+1, p.y+5, p.z+5,
block.STONE_BRICK)
mc.setBlocks(p.x+1, p.y+6, p.z+3, #Main Structure Roof End (Right Side, 2nd Row)
p.x+1, p.y+6, p.z+4,
block.STONE_BRICK)
mc.setBlocks(p.x+19, p.y+5, p.z+2, #Main Structure Roof End (Left Side, 1st Row)
p.x+19, p.y+5, p.z+5,
block.STONE_BRICK)
mc.setBlocks(p.x+19, p.y+6, p.z+3, #Main Structure Roof End (Left Side, 2nd Row)
p.x+19, p.y+6, p.z+4,
block.STONE_BRICK)
python raspberry-pi minecraft
python raspberry-pi minecraft
asked 22 mins ago
DysFunctionDysFunction
1
New contributor
DysFunction is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 22 mins ago
DysFunctionDysFunction
1
New contributor
DysFunction is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 22 mins ago
DysFunctionDysFunction
1
New contributor
DysFunction is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 22 mins ago
DysFunctionDysFunction
1
asked 22 mins ago
DysFunctionDysFunction
1
1
New contributor
DysFunction is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
DysFunction is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
DysFunction is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
DysFunction is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213253%2frefactoring-coordinates-for-minecraft-pi-buildings-written-in-python%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
DysFunction is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
DysFunction is a new contributor. Be nice, and check out our Code of Conduct.
DysFunction is a new contributor. Be nice, and check out our Code of Conduct.
DysFunction is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213253%2frefactoring-coordinates-for-minecraft-pi-buildings-written-in-python%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
