Saving allowed positions from a 3x3 matrix












1















I wrote the next code chunk to save all the allowed positions from a 3x3 matrix, it's working but I think it could be better. Besides something similar happens in my Randomizer class, although I admit it's messy.



public class MatrixRegistry : MonoBehaviour
{
private int matrixVolume;
private int matrixCount;

private GameObject matrix;

private List<GameObject> dynamicCubes = new List<GameObject>();
private List<Vector3> staticCubes = new List<Vector3>();
private List<Vector3> allowedPositions = new List<Vector3>();

public Func<List<GameObject>> GetDynamicCubes { get; private set; }
public Func<List<Vector3>> GetAllowedPositions { get; private set; }

private void Awake()
{
#region Getting all Matrix Cubes

matrixCount = gameObject.transform.childCount;

if (matrixCount != 0)
{
matrix = new GameObject[matrixCount];

for (int i = 0; i < matrixCount; i++)
{
matrix[i] = gameObject.transform.GetChild(i).gameObject;

if (matrix[i].GetComponent<CubeInfo>().cubeType == CubeSort.Dynamic)
{
dynamicCubes.Add(matrix[i]);
}

if (matrix[i].GetComponent<CubeInfo>().cubeType == CubeSort.Static)
{
staticCubes.Add(matrix[i].transform.position);
}
}
}

GetDynamicCubes = () => dynamicCubes;
#endregion

#region Setting Allowed Positions

matrixVolume = 3; // Hard Coding

for (int x = 0; x < matrixVolume; x++)
{
for (int y = 0; y < matrixVolume; y++)
{
for (int z = 0; z < matrixVolume; z++)
{
Vector3 position = new Vector3
{
x = x,
y = y,
z = z
};

allowedPositions.Add(position);
}
}
}

for (int f = 0; f < staticCubes.Count; f++)
{
for (int a = 0; a < allowedPositions.Count; a++)
{
if (allowedPositions[a] == staticCubes[f])
{
allowedPositions.Remove(allowedPositions[a]);
}
}
}

GetAllowedPositions = () => allowedPositions;
#endregion
}
}




public class Randomizer
{
private MatrixRegistry matrixRegistry;
private EventManager eventManager;

public Randomizer(MatrixRegistry matrixRegistry, EventManager eventManager)
{
this.matrixRegistry = matrixRegistry;
this.eventManager = eventManager;

eventManager.OnStartGame += Randomize;
}

private void Randomize()
{
for (int i = 0; i < matrixRegistry.GetDynamicCubes().Count; i++)
{
Vector3 randomPosition = new Vector3
{
x = Random.Range(0, 3),
y = Random.Range(0, 3),
z = Random.Range(0, 3)
};

for (int j = 0; j < matrixRegistry.GetAllowedPositions().Count; j++)
{
for (int k = 0; k < matrixRegistry.GetDynamicCubes().Count; k++)
{
if (randomPosition == matrixRegistry.GetAllowedPositions()[j])
{
if (randomPosition != matrixRegistry.GetDynamicCubes()[k].transform.position)
{
matrixRegistry.GetDynamicCubes()[i].transform.position = randomPosition;
}
}
}
}
}
}
}


The randomizer class should check all the allowed positions to get in place all the cubes and avoid overlapping issues.
I know it's not the best, and this is why I'm here.










share|improve this question









New contributor




Lobsang White is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.





















  • Why don't you post the complete class? I'd be much easier to review it having all the code rather then some random snippets.

    – t3chb0t
    21 mins ago






  • 1





    @t3chb0t I didn't think it was necessary, it's just a for loop, but already I did it.

    – Lobsang White
    6 mins ago











  • It looks much better now and it's much easier to understand. Thanks for updating ;-]

    – t3chb0t
    4 mins ago
















1















I wrote the next code chunk to save all the allowed positions from a 3x3 matrix, it's working but I think it could be better. Besides something similar happens in my Randomizer class, although I admit it's messy.



public class MatrixRegistry : MonoBehaviour
{
private int matrixVolume;
private int matrixCount;

private GameObject matrix;

private List<GameObject> dynamicCubes = new List<GameObject>();
private List<Vector3> staticCubes = new List<Vector3>();
private List<Vector3> allowedPositions = new List<Vector3>();

public Func<List<GameObject>> GetDynamicCubes { get; private set; }
public Func<List<Vector3>> GetAllowedPositions { get; private set; }

private void Awake()
{
#region Getting all Matrix Cubes

matrixCount = gameObject.transform.childCount;

if (matrixCount != 0)
{
matrix = new GameObject[matrixCount];

for (int i = 0; i < matrixCount; i++)
{
matrix[i] = gameObject.transform.GetChild(i).gameObject;

if (matrix[i].GetComponent<CubeInfo>().cubeType == CubeSort.Dynamic)
{
dynamicCubes.Add(matrix[i]);
}

if (matrix[i].GetComponent<CubeInfo>().cubeType == CubeSort.Static)
{
staticCubes.Add(matrix[i].transform.position);
}
}
}

GetDynamicCubes = () => dynamicCubes;
#endregion

#region Setting Allowed Positions

matrixVolume = 3; // Hard Coding

for (int x = 0; x < matrixVolume; x++)
{
for (int y = 0; y < matrixVolume; y++)
{
for (int z = 0; z < matrixVolume; z++)
{
Vector3 position = new Vector3
{
x = x,
y = y,
z = z
};

allowedPositions.Add(position);
}
}
}

for (int f = 0; f < staticCubes.Count; f++)
{
for (int a = 0; a < allowedPositions.Count; a++)
{
if (allowedPositions[a] == staticCubes[f])
{
allowedPositions.Remove(allowedPositions[a]);
}
}
}

GetAllowedPositions = () => allowedPositions;
#endregion
}
}




public class Randomizer
{
private MatrixRegistry matrixRegistry;
private EventManager eventManager;

public Randomizer(MatrixRegistry matrixRegistry, EventManager eventManager)
{
this.matrixRegistry = matrixRegistry;
this.eventManager = eventManager;

eventManager.OnStartGame += Randomize;
}

private void Randomize()
{
for (int i = 0; i < matrixRegistry.GetDynamicCubes().Count; i++)
{
Vector3 randomPosition = new Vector3
{
x = Random.Range(0, 3),
y = Random.Range(0, 3),
z = Random.Range(0, 3)
};

for (int j = 0; j < matrixRegistry.GetAllowedPositions().Count; j++)
{
for (int k = 0; k < matrixRegistry.GetDynamicCubes().Count; k++)
{
if (randomPosition == matrixRegistry.GetAllowedPositions()[j])
{
if (randomPosition != matrixRegistry.GetDynamicCubes()[k].transform.position)
{
matrixRegistry.GetDynamicCubes()[i].transform.position = randomPosition;
}
}
}
}
}
}
}


The randomizer class should check all the allowed positions to get in place all the cubes and avoid overlapping issues.
I know it's not the best, and this is why I'm here.










share|improve this question









New contributor




Lobsang White is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.





















  • Why don't you post the complete class? I'd be much easier to review it having all the code rather then some random snippets.

    – t3chb0t
    21 mins ago






  • 1





    @t3chb0t I didn't think it was necessary, it's just a for loop, but already I did it.

    – Lobsang White
    6 mins ago











  • It looks much better now and it's much easier to understand. Thanks for updating ;-]

    – t3chb0t
    4 mins ago














1












1








1








I wrote the next code chunk to save all the allowed positions from a 3x3 matrix, it's working but I think it could be better. Besides something similar happens in my Randomizer class, although I admit it's messy.



public class MatrixRegistry : MonoBehaviour
{
private int matrixVolume;
private int matrixCount;

private GameObject matrix;

private List<GameObject> dynamicCubes = new List<GameObject>();
private List<Vector3> staticCubes = new List<Vector3>();
private List<Vector3> allowedPositions = new List<Vector3>();

public Func<List<GameObject>> GetDynamicCubes { get; private set; }
public Func<List<Vector3>> GetAllowedPositions { get; private set; }

private void Awake()
{
#region Getting all Matrix Cubes

matrixCount = gameObject.transform.childCount;

if (matrixCount != 0)
{
matrix = new GameObject[matrixCount];

for (int i = 0; i < matrixCount; i++)
{
matrix[i] = gameObject.transform.GetChild(i).gameObject;

if (matrix[i].GetComponent<CubeInfo>().cubeType == CubeSort.Dynamic)
{
dynamicCubes.Add(matrix[i]);
}

if (matrix[i].GetComponent<CubeInfo>().cubeType == CubeSort.Static)
{
staticCubes.Add(matrix[i].transform.position);
}
}
}

GetDynamicCubes = () => dynamicCubes;
#endregion

#region Setting Allowed Positions

matrixVolume = 3; // Hard Coding

for (int x = 0; x < matrixVolume; x++)
{
for (int y = 0; y < matrixVolume; y++)
{
for (int z = 0; z < matrixVolume; z++)
{
Vector3 position = new Vector3
{
x = x,
y = y,
z = z
};

allowedPositions.Add(position);
}
}
}

for (int f = 0; f < staticCubes.Count; f++)
{
for (int a = 0; a < allowedPositions.Count; a++)
{
if (allowedPositions[a] == staticCubes[f])
{
allowedPositions.Remove(allowedPositions[a]);
}
}
}

GetAllowedPositions = () => allowedPositions;
#endregion
}
}




public class Randomizer
{
private MatrixRegistry matrixRegistry;
private EventManager eventManager;

public Randomizer(MatrixRegistry matrixRegistry, EventManager eventManager)
{
this.matrixRegistry = matrixRegistry;
this.eventManager = eventManager;

eventManager.OnStartGame += Randomize;
}

private void Randomize()
{
for (int i = 0; i < matrixRegistry.GetDynamicCubes().Count; i++)
{
Vector3 randomPosition = new Vector3
{
x = Random.Range(0, 3),
y = Random.Range(0, 3),
z = Random.Range(0, 3)
};

for (int j = 0; j < matrixRegistry.GetAllowedPositions().Count; j++)
{
for (int k = 0; k < matrixRegistry.GetDynamicCubes().Count; k++)
{
if (randomPosition == matrixRegistry.GetAllowedPositions()[j])
{
if (randomPosition != matrixRegistry.GetDynamicCubes()[k].transform.position)
{
matrixRegistry.GetDynamicCubes()[i].transform.position = randomPosition;
}
}
}
}
}
}
}


The randomizer class should check all the allowed positions to get in place all the cubes and avoid overlapping issues.
I know it's not the best, and this is why I'm here.










share|improve this question









New contributor




Lobsang White is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.












I wrote the next code chunk to save all the allowed positions from a 3x3 matrix, it's working but I think it could be better. Besides something similar happens in my Randomizer class, although I admit it's messy.



public class MatrixRegistry : MonoBehaviour
{
private int matrixVolume;
private int matrixCount;

private GameObject matrix;

private List<GameObject> dynamicCubes = new List<GameObject>();
private List<Vector3> staticCubes = new List<Vector3>();
private List<Vector3> allowedPositions = new List<Vector3>();

public Func<List<GameObject>> GetDynamicCubes { get; private set; }
public Func<List<Vector3>> GetAllowedPositions { get; private set; }

private void Awake()
{
#region Getting all Matrix Cubes

matrixCount = gameObject.transform.childCount;

if (matrixCount != 0)
{
matrix = new GameObject[matrixCount];

for (int i = 0; i < matrixCount; i++)
{
matrix[i] = gameObject.transform.GetChild(i).gameObject;

if (matrix[i].GetComponent<CubeInfo>().cubeType == CubeSort.Dynamic)
{
dynamicCubes.Add(matrix[i]);
}

if (matrix[i].GetComponent<CubeInfo>().cubeType == CubeSort.Static)
{
staticCubes.Add(matrix[i].transform.position);
}
}
}

GetDynamicCubes = () => dynamicCubes;
#endregion

#region Setting Allowed Positions

matrixVolume = 3; // Hard Coding

for (int x = 0; x < matrixVolume; x++)
{
for (int y = 0; y < matrixVolume; y++)
{
for (int z = 0; z < matrixVolume; z++)
{
Vector3 position = new Vector3
{
x = x,
y = y,
z = z
};

allowedPositions.Add(position);
}
}
}

for (int f = 0; f < staticCubes.Count; f++)
{
for (int a = 0; a < allowedPositions.Count; a++)
{
if (allowedPositions[a] == staticCubes[f])
{
allowedPositions.Remove(allowedPositions[a]);
}
}
}

GetAllowedPositions = () => allowedPositions;
#endregion
}
}




public class Randomizer
{
private MatrixRegistry matrixRegistry;
private EventManager eventManager;

public Randomizer(MatrixRegistry matrixRegistry, EventManager eventManager)
{
this.matrixRegistry = matrixRegistry;
this.eventManager = eventManager;

eventManager.OnStartGame += Randomize;
}

private void Randomize()
{
for (int i = 0; i < matrixRegistry.GetDynamicCubes().Count; i++)
{
Vector3 randomPosition = new Vector3
{
x = Random.Range(0, 3),
y = Random.Range(0, 3),
z = Random.Range(0, 3)
};

for (int j = 0; j < matrixRegistry.GetAllowedPositions().Count; j++)
{
for (int k = 0; k < matrixRegistry.GetDynamicCubes().Count; k++)
{
if (randomPosition == matrixRegistry.GetAllowedPositions()[j])
{
if (randomPosition != matrixRegistry.GetDynamicCubes()[k].transform.position)
{
matrixRegistry.GetDynamicCubes()[i].transform.position = randomPosition;
}
}
}
}
}
}
}


The randomizer class should check all the allowed positions to get in place all the cubes and avoid overlapping issues.
I know it's not the best, and this is why I'm here.







c# unity3d






share|improve this question









New contributor




Lobsang White is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.











share|improve this question









New contributor




Lobsang White is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









share|improve this question




share|improve this question








edited 5 mins ago







Lobsang White













New contributor




Lobsang White is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









asked 36 mins ago









Lobsang WhiteLobsang White

62




62




New contributor




Lobsang White is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.





New contributor





Lobsang White is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.






Lobsang White is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.













  • Why don't you post the complete class? I'd be much easier to review it having all the code rather then some random snippets.

    – t3chb0t
    21 mins ago






  • 1





    @t3chb0t I didn't think it was necessary, it's just a for loop, but already I did it.

    – Lobsang White
    6 mins ago











  • It looks much better now and it's much easier to understand. Thanks for updating ;-]

    – t3chb0t
    4 mins ago



















  • Why don't you post the complete class? I'd be much easier to review it having all the code rather then some random snippets.

    – t3chb0t
    21 mins ago






  • 1





    @t3chb0t I didn't think it was necessary, it's just a for loop, but already I did it.

    – Lobsang White
    6 mins ago











  • It looks much better now and it's much easier to understand. Thanks for updating ;-]

    – t3chb0t
    4 mins ago

















Why don't you post the complete class? I'd be much easier to review it having all the code rather then some random snippets.

– t3chb0t
21 mins ago





Why don't you post the complete class? I'd be much easier to review it having all the code rather then some random snippets.

– t3chb0t
21 mins ago




1




1





@t3chb0t I didn't think it was necessary, it's just a for loop, but already I did it.

– Lobsang White
6 mins ago





@t3chb0t I didn't think it was necessary, it's just a for loop, but already I did it.

– Lobsang White
6 mins ago













It looks much better now and it's much easier to understand. Thanks for updating ;-]

– t3chb0t
4 mins ago





It looks much better now and it's much easier to understand. Thanks for updating ;-]

– t3chb0t
4 mins ago










0






active

oldest

votes











Your Answer





StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});






Lobsang White is a new contributor. Be nice, and check out our Code of Conduct.










draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211457%2fsaving-allowed-positions-from-a-3x3-matrix%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























0






active

oldest

votes








0






active

oldest

votes









active

oldest

votes






active

oldest

votes








Lobsang White is a new contributor. Be nice, and check out our Code of Conduct.










draft saved

draft discarded


















Lobsang White is a new contributor. Be nice, and check out our Code of Conduct.













Lobsang White is a new contributor. Be nice, and check out our Code of Conduct.












Lobsang White is a new contributor. Be nice, and check out our Code of Conduct.
















Thanks for contributing an answer to Code Review Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


Use MathJax to format equations. MathJax reference.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211457%2fsaving-allowed-positions-from-a-3x3-matrix%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

404 Error Contact Form 7 ajax form submitting

How to know if a Active Directory user can login interactively

TypeError: fit_transform() missing 1 required positional argument: 'X'