Is really Files.createDirectory() non-blocking?
I've created such method:
Flux<GetObjectResponse> download(String bucket, List<String> s3FileNames) {
String tmpDirName = UUID.randomUUID().toString();
Path dir = Paths.get(tmpDirName);
if (!Files.exists(dir)) {
try {
Files.createDirectory(dir);
} catch (IOException e) {
e.printStackTrace();
}
}
return Flux.fromIterable(s3FileNames)
.flatMap(filename -> Mono.just(GetObjectRequest.builder().bucket(bucket).key(filename).build()))
.flatMap(getObjectRequest -> Mono.fromFuture(s3AsyncClient.getObject(getObjectRequest, Paths.get(tmpDirName, getObjectRequest.key()))));
}
Later I process this reactive stream, but IntelliJ gives me a hint when I call Files.createDirectory(dir):
Inappropriate blocking method call less... (Ctrl+1)
Inspection info: Reports thread-blocking method calls found in a code fragment where a thread should not be blocked
Is IntelliJ right? Is NIO blocking when interoperates with files?
java intellij-idea nio project-reactor aws-sdk-java-2.0
asked Nov 22 '18 at 18:33
qwalerqwaler
104
add a comment |
I've created such method:
Flux<GetObjectResponse> download(String bucket, List<String> s3FileNames) {
String tmpDirName = UUID.randomUUID().toString();
Path dir = Paths.get(tmpDirName);
if (!Files.exists(dir)) {
try {
Files.createDirectory(dir);
} catch (IOException e) {
e.printStackTrace();
}
}
return Flux.fromIterable(s3FileNames)
.flatMap(filename -> Mono.just(GetObjectRequest.builder().bucket(bucket).key(filename).build()))
.flatMap(getObjectRequest -> Mono.fromFuture(s3AsyncClient.getObject(getObjectRequest, Paths.get(tmpDirName, getObjectRequest.key()))));
}
Later I process this reactive stream, but IntelliJ gives me a hint when I call Files.createDirectory(dir):
Inappropriate blocking method call less... (Ctrl+1)
Inspection info: Reports thread-blocking method calls found in a code fragment where a thread should not be blocked
Is IntelliJ right? Is NIO blocking when interoperates with files?
java intellij-idea nio project-reactor aws-sdk-java-2.0
asked Nov 22 '18 at 18:33
qwalerqwaler
104
I wouldn't expect such a call to be asynchronous. Why would it be? The usual expectation when you're creating a folder is that the folder is going to be immediately available for adding files to it.
– Robert Harvey♦
Nov 22 '18 at 19:09
add a comment |
I've created such method:
Flux<GetObjectResponse> download(String bucket, List<String> s3FileNames) {
String tmpDirName = UUID.randomUUID().toString();
Path dir = Paths.get(tmpDirName);
if (!Files.exists(dir)) {
try {
Files.createDirectory(dir);
} catch (IOException e) {
e.printStackTrace();
}
}
return Flux.fromIterable(s3FileNames)
.flatMap(filename -> Mono.just(GetObjectRequest.builder().bucket(bucket).key(filename).build()))
.flatMap(getObjectRequest -> Mono.fromFuture(s3AsyncClient.getObject(getObjectRequest, Paths.get(tmpDirName, getObjectRequest.key()))));
}
Later I process this reactive stream, but IntelliJ gives me a hint when I call Files.createDirectory(dir):
Inappropriate blocking method call less... (Ctrl+1)
Inspection info: Reports thread-blocking method calls found in a code fragment where a thread should not be blocked
Is IntelliJ right? Is NIO blocking when interoperates with files?
java intellij-idea nio project-reactor aws-sdk-java-2.0
asked Nov 22 '18 at 18:33
qwalerqwaler
104
I've created such method:
Flux<GetObjectResponse> download(String bucket, List<String> s3FileNames) {
String tmpDirName = UUID.randomUUID().toString();
Path dir = Paths.get(tmpDirName);
if (!Files.exists(dir)) {
try {
Files.createDirectory(dir);
} catch (IOException e) {
e.printStackTrace();
}
}
return Flux.fromIterable(s3FileNames)
.flatMap(filename -> Mono.just(GetObjectRequest.builder().bucket(bucket).key(filename).build()))
.flatMap(getObjectRequest -> Mono.fromFuture(s3AsyncClient.getObject(getObjectRequest, Paths.get(tmpDirName, getObjectRequest.key()))));
}
Later I process this reactive stream, but IntelliJ gives me a hint when I call Files.createDirectory(dir):
Inappropriate blocking method call less... (Ctrl+1)
Inspection info: Reports thread-blocking method calls found in a code fragment where a thread should not be blocked
Is IntelliJ right? Is NIO blocking when interoperates with files?
java intellij-idea nio project-reactor aws-sdk-java-2.0
java intellij-idea nio project-reactor aws-sdk-java-2.0
asked Nov 22 '18 at 18:33
qwalerqwaler
104
asked Nov 22 '18 at 18:33
qwalerqwaler
104
asked Nov 22 '18 at 18:33
qwalerqwaler
104
asked Nov 22 '18 at 18:33
qwalerqwaler
104
asked Nov 22 '18 at 18:33
qwalerqwaler
104
104
I wouldn't expect such a call to be asynchronous. Why would it be? The usual expectation when you're creating a folder is that the folder is going to be immediately available for adding files to it.
– Robert Harvey♦
Nov 22 '18 at 19:09
add a comment |
I wouldn't expect such a call to be asynchronous. Why would it be? The usual expectation when you're creating a folder is that the folder is going to be immediately available for adding files to it.
– Robert Harvey♦
Nov 22 '18 at 19:09
I wouldn't expect such a call to be asynchronous. Why would it be? The usual expectation when you're creating a folder is that the folder is going to be immediately available for adding files to it.
– Robert Harvey♦
Nov 22 '18 at 19:09
I wouldn't expect such a call to be asynchronous. Why would it be? The usual expectation when you're creating a folder is that the folder is going to be immediately available for adding files to it.
– Robert Harvey♦
Nov 22 '18 at 19:09
add a comment |
1 Answer
1
active
oldest
votes
All file operations before NIO2 are synchronous and you can assume the operation has completed by the time the method returns.
Only TCP sockets and the file watcher had asynchronous operations.
NIO2 added AsynchronousFileChannel however it doesn't apply to directories.
answered Nov 22 '18 at 19:23
Peter LawreyPeter Lawrey
443k56564966
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53436520%2fis-really-files-createdirectory-non-blocking%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
All file operations before NIO2 are synchronous and you can assume the operation has completed by the time the method returns.
Only TCP sockets and the file watcher had asynchronous operations.
NIO2 added AsynchronousFileChannel however it doesn't apply to directories.
answered Nov 22 '18 at 19:23
Peter LawreyPeter Lawrey
443k56564966
add a comment |
All file operations before NIO2 are synchronous and you can assume the operation has completed by the time the method returns.
Only TCP sockets and the file watcher had asynchronous operations.
NIO2 added AsynchronousFileChannel however it doesn't apply to directories.
answered Nov 22 '18 at 19:23
Peter LawreyPeter Lawrey
443k56564966
add a comment |
All file operations before NIO2 are synchronous and you can assume the operation has completed by the time the method returns.
Only TCP sockets and the file watcher had asynchronous operations.
NIO2 added AsynchronousFileChannel however it doesn't apply to directories.
answered Nov 22 '18 at 19:23
Peter LawreyPeter Lawrey
443k56564966
All file operations before NIO2 are synchronous and you can assume the operation has completed by the time the method returns.
Only TCP sockets and the file watcher had asynchronous operations.
NIO2 added AsynchronousFileChannel however it doesn't apply to directories.
answered Nov 22 '18 at 19:23
Peter LawreyPeter Lawrey
443k56564966
answered Nov 22 '18 at 19:23
Peter LawreyPeter Lawrey
443k56564966
answered Nov 22 '18 at 19:23
Peter LawreyPeter Lawrey
443k56564966
answered Nov 22 '18 at 19:23
Peter LawreyPeter Lawrey
443k56564966
443k56564966
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53436520%2fis-really-files-createdirectory-non-blocking%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
I wouldn't expect such a call to be asynchronous. Why would it be? The usual expectation when you're creating a folder is that the folder is going to be immediately available for adding files to it.
– Robert Harvey♦
Nov 22 '18 at 19:09