N Queens in Python using backtracking












0














I write this solution to the popular N Queens problem using backtracking algorithm. I am relatively new to Python. I would like to know what are the ways to refactor this code and also code style of Python in general.



def isSafe (board, row, col):
# check left row
for y in range(col):
if board[row][y] == 1:
return False
# check diagonal left top
for x, y in zip(range(row, -1, -1), range(col, -1, -1)):
if board[x][y] == 1:
return False
# check diagonal left bottom
for x, y in zip(range(row, N, 1), range(col, -1, -1)):
if board[x][y] == 1:
return False

return True

def generateSolution(board, col):
# terminating condition
# all columns covered
global N
if col >= N:
return True
# loop over all the rows
for i in range(N):
if isSafe(board, i, col) == True:
board[i][col] = 1
# recursively place other queens
if generateSolution(board, col + 1) == True:
return True
# unmark queen spot
board[i][col] = 0
# backtrack
return False


N = int(input())
startCol = 0
board = [[0 for i in range(N)] for j in range(N)]
# print(board)

if generateSolution(board, startCol) == False:
print("No Solution Exists")
else:
print("Solution exists")
print(board)









share|improve this question









New contributor




Abrar is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

























    0














    I write this solution to the popular N Queens problem using backtracking algorithm. I am relatively new to Python. I would like to know what are the ways to refactor this code and also code style of Python in general.



    def isSafe (board, row, col):
    # check left row
    for y in range(col):
    if board[row][y] == 1:
    return False
    # check diagonal left top
    for x, y in zip(range(row, -1, -1), range(col, -1, -1)):
    if board[x][y] == 1:
    return False
    # check diagonal left bottom
    for x, y in zip(range(row, N, 1), range(col, -1, -1)):
    if board[x][y] == 1:
    return False

    return True

    def generateSolution(board, col):
    # terminating condition
    # all columns covered
    global N
    if col >= N:
    return True
    # loop over all the rows
    for i in range(N):
    if isSafe(board, i, col) == True:
    board[i][col] = 1
    # recursively place other queens
    if generateSolution(board, col + 1) == True:
    return True
    # unmark queen spot
    board[i][col] = 0
    # backtrack
    return False


    N = int(input())
    startCol = 0
    board = [[0 for i in range(N)] for j in range(N)]
    # print(board)

    if generateSolution(board, startCol) == False:
    print("No Solution Exists")
    else:
    print("Solution exists")
    print(board)









    share|improve this question









    New contributor




    Abrar is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.























      0












      0








      0







      I write this solution to the popular N Queens problem using backtracking algorithm. I am relatively new to Python. I would like to know what are the ways to refactor this code and also code style of Python in general.



      def isSafe (board, row, col):
      # check left row
      for y in range(col):
      if board[row][y] == 1:
      return False
      # check diagonal left top
      for x, y in zip(range(row, -1, -1), range(col, -1, -1)):
      if board[x][y] == 1:
      return False
      # check diagonal left bottom
      for x, y in zip(range(row, N, 1), range(col, -1, -1)):
      if board[x][y] == 1:
      return False

      return True

      def generateSolution(board, col):
      # terminating condition
      # all columns covered
      global N
      if col >= N:
      return True
      # loop over all the rows
      for i in range(N):
      if isSafe(board, i, col) == True:
      board[i][col] = 1
      # recursively place other queens
      if generateSolution(board, col + 1) == True:
      return True
      # unmark queen spot
      board[i][col] = 0
      # backtrack
      return False


      N = int(input())
      startCol = 0
      board = [[0 for i in range(N)] for j in range(N)]
      # print(board)

      if generateSolution(board, startCol) == False:
      print("No Solution Exists")
      else:
      print("Solution exists")
      print(board)









      share|improve this question









      New contributor




      Abrar is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      I write this solution to the popular N Queens problem using backtracking algorithm. I am relatively new to Python. I would like to know what are the ways to refactor this code and also code style of Python in general.



      def isSafe (board, row, col):
      # check left row
      for y in range(col):
      if board[row][y] == 1:
      return False
      # check diagonal left top
      for x, y in zip(range(row, -1, -1), range(col, -1, -1)):
      if board[x][y] == 1:
      return False
      # check diagonal left bottom
      for x, y in zip(range(row, N, 1), range(col, -1, -1)):
      if board[x][y] == 1:
      return False

      return True

      def generateSolution(board, col):
      # terminating condition
      # all columns covered
      global N
      if col >= N:
      return True
      # loop over all the rows
      for i in range(N):
      if isSafe(board, i, col) == True:
      board[i][col] = 1
      # recursively place other queens
      if generateSolution(board, col + 1) == True:
      return True
      # unmark queen spot
      board[i][col] = 0
      # backtrack
      return False


      N = int(input())
      startCol = 0
      board = [[0 for i in range(N)] for j in range(N)]
      # print(board)

      if generateSolution(board, startCol) == False:
      print("No Solution Exists")
      else:
      print("Solution exists")
      print(board)






      python algorithm python-3.x backtracking n-queens






      share|improve this question









      New contributor




      Abrar is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Abrar is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 8 mins ago









      Jamal

      30.2k11116226




      30.2k11116226






      New contributor




      Abrar is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 14 mins ago









      Abrar

      1205




      1205




      New contributor




      Abrar is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Abrar is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Abrar is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Abrar is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210202%2fn-queens-in-python-using-backtracking%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Abrar is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Abrar is a new contributor. Be nice, and check out our Code of Conduct.













          Abrar is a new contributor. Be nice, and check out our Code of Conduct.












          Abrar is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210202%2fn-queens-in-python-using-backtracking%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'