Moving through set of values
$begingroup$
I started with advent of code 2015 and just stuck with day 3, part two. This part is also described in my repository. I tried to follow TDD rules. Till now it was OK.
But with day 3 I am not able to find correct solution. As you can see, I already created test cases for known scenarios (which is in Task.txt in repository or on AoC 2015 web.
class RoboSantaDelivering {
private final int startingHouseForRoboSanta = 1;
private Delivering delivering;
private String santasWay;
private String roboSantasWay;
int deliver(String way) {
splitInput(way);
initDelivering();
var servedBySanta = delivering.countLuckyHouses(santasWay);
initDelivering();
var servedByRoboSanta = delivering.countLuckyHouses(roboSantasWay);
return servedBySanta + servedByRoboSanta - startingHouseForRoboSanta;
}
private void splitInput(String way) {
var santasWayStepByStep = new StringBuilder();
var roboSantaWayStepByStep = new StringBuilder();
for (int i=0; i<way.length(); i++) {
var currentChar = way.charAt(i);
if (i % 2 == 0)
santasWayStepByStep.append(currentChar);
else roboSantaWayStepByStep.append(currentChar);
}
santasWay = santasWayStepByStep.toString();
roboSantasWay = roboSantaWayStepByStep.toString();
}
private void initDelivering() {
delivering = new Delivering();
}
}
Problem is "testInput" test in RoboSantaDeliveringTest class. Implementation many times debuged is in RoboSantaDelivering class. My result from test is 2498, but the AoC does not accepting this number.
Can someone see mistake?
java unit-testing
asked 3 mins ago
Old EngineerOld Engineer
11
New contributor
Old Engineer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I started with advent of code 2015 and just stuck with day 3, part two. This part is also described in my repository. I tried to follow TDD rules. Till now it was OK.
But with day 3 I am not able to find correct solution. As you can see, I already created test cases for known scenarios (which is in Task.txt in repository or on AoC 2015 web.
class RoboSantaDelivering {
private final int startingHouseForRoboSanta = 1;
private Delivering delivering;
private String santasWay;
private String roboSantasWay;
int deliver(String way) {
splitInput(way);
initDelivering();
var servedBySanta = delivering.countLuckyHouses(santasWay);
initDelivering();
var servedByRoboSanta = delivering.countLuckyHouses(roboSantasWay);
return servedBySanta + servedByRoboSanta - startingHouseForRoboSanta;
}
private void splitInput(String way) {
var santasWayStepByStep = new StringBuilder();
var roboSantaWayStepByStep = new StringBuilder();
for (int i=0; i<way.length(); i++) {
var currentChar = way.charAt(i);
if (i % 2 == 0)
santasWayStepByStep.append(currentChar);
else roboSantaWayStepByStep.append(currentChar);
}
santasWay = santasWayStepByStep.toString();
roboSantasWay = roboSantaWayStepByStep.toString();
}
private void initDelivering() {
delivering = new Delivering();
}
}
Problem is "testInput" test in RoboSantaDeliveringTest class. Implementation many times debuged is in RoboSantaDelivering class. My result from test is 2498, but the AoC does not accepting this number.
Can someone see mistake?
java unit-testing
asked 3 mins ago
Old EngineerOld Engineer
11
New contributor
Old Engineer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I started with advent of code 2015 and just stuck with day 3, part two. This part is also described in my repository. I tried to follow TDD rules. Till now it was OK.
But with day 3 I am not able to find correct solution. As you can see, I already created test cases for known scenarios (which is in Task.txt in repository or on AoC 2015 web.
class RoboSantaDelivering {
private final int startingHouseForRoboSanta = 1;
private Delivering delivering;
private String santasWay;
private String roboSantasWay;
int deliver(String way) {
splitInput(way);
initDelivering();
var servedBySanta = delivering.countLuckyHouses(santasWay);
initDelivering();
var servedByRoboSanta = delivering.countLuckyHouses(roboSantasWay);
return servedBySanta + servedByRoboSanta - startingHouseForRoboSanta;
}
private void splitInput(String way) {
var santasWayStepByStep = new StringBuilder();
var roboSantaWayStepByStep = new StringBuilder();
for (int i=0; i<way.length(); i++) {
var currentChar = way.charAt(i);
if (i % 2 == 0)
santasWayStepByStep.append(currentChar);
else roboSantaWayStepByStep.append(currentChar);
}
santasWay = santasWayStepByStep.toString();
roboSantasWay = roboSantaWayStepByStep.toString();
}
private void initDelivering() {
delivering = new Delivering();
}
}
Problem is "testInput" test in RoboSantaDeliveringTest class. Implementation many times debuged is in RoboSantaDelivering class. My result from test is 2498, but the AoC does not accepting this number.
Can someone see mistake?
java unit-testing
asked 3 mins ago
Old EngineerOld Engineer
11
New contributor
Old Engineer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I started with advent of code 2015 and just stuck with day 3, part two. This part is also described in my repository. I tried to follow TDD rules. Till now it was OK.
But with day 3 I am not able to find correct solution. As you can see, I already created test cases for known scenarios (which is in Task.txt in repository or on AoC 2015 web.
class RoboSantaDelivering {
private final int startingHouseForRoboSanta = 1;
private Delivering delivering;
private String santasWay;
private String roboSantasWay;
int deliver(String way) {
splitInput(way);
initDelivering();
var servedBySanta = delivering.countLuckyHouses(santasWay);
initDelivering();
var servedByRoboSanta = delivering.countLuckyHouses(roboSantasWay);
return servedBySanta + servedByRoboSanta - startingHouseForRoboSanta;
}
private void splitInput(String way) {
var santasWayStepByStep = new StringBuilder();
var roboSantaWayStepByStep = new StringBuilder();
for (int i=0; i<way.length(); i++) {
var currentChar = way.charAt(i);
if (i % 2 == 0)
santasWayStepByStep.append(currentChar);
else roboSantaWayStepByStep.append(currentChar);
}
santasWay = santasWayStepByStep.toString();
roboSantasWay = roboSantaWayStepByStep.toString();
}
private void initDelivering() {
delivering = new Delivering();
}
}
Problem is "testInput" test in RoboSantaDeliveringTest class. Implementation many times debuged is in RoboSantaDelivering class. My result from test is 2498, but the AoC does not accepting this number.
Can someone see mistake?
java unit-testing
java unit-testing
asked 3 mins ago
Old EngineerOld Engineer
11
New contributor
Old Engineer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 3 mins ago
Old EngineerOld Engineer
11
New contributor
Old Engineer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 3 mins ago
Old EngineerOld Engineer
11
New contributor
Old Engineer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 3 mins ago
Old EngineerOld Engineer
11
asked 3 mins ago
Old EngineerOld Engineer
11
11
New contributor
Old Engineer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Old Engineer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Old Engineer is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Old Engineer is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211866%2fmoving-through-set-of-values%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Old Engineer is a new contributor. Be nice, and check out our Code of Conduct.
Old Engineer is a new contributor. Be nice, and check out our Code of Conduct.
Old Engineer is a new contributor. Be nice, and check out our Code of Conduct.
Old Engineer is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211866%2fmoving-through-set-of-values%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
