Leetcode Three Sum in Python












0












$begingroup$


Here's my solution for the Leet Code's Two Sum problem -- would love feedback on (1) code efficiency and (2) style/formatting.



Problem:




Given an array nums of n integers, are there elements a, b, c in nums
such that a + b + c = 0? Find all unique triplets in the array which
gives the sum of zero.



Note:



The solution set must not contain duplicate triplets.



Example:



Given array nums = [-1, 0, 1, 2, -1, -4],



A solution set is: [ [-1, 0, 1], [-1, -1, 2] ]




My solution:



def threeSum(nums):
"""
:type nums: List[int]
:rtype: List[List[int]]
"""

def _twoSum(nums_small, target):
'''
INPUT: List of numeric values, int target
OUTPUT: list: pair(s) from nums_small that add up to target and -1*target
'''
nums_dict = {}
return_lst =

for indx, val in enumerate(nums_small, target):
if target - val in nums_dict:
return_lst.append([val, target - val, -1*target])
nums_dict[val] = indx
return return_lst

return_dict = {}

for indx, val in enumerate(nums):
for solution in _twoSum(nums[:indx] + nums[indx+1:], -1*val):
if sorted(solution) not in return_dict.values():
return_dict[str(indx)+str(solution)] = sorted(solution) # ... hacky way of storing multiple solutions to one index ...

return list(return_dict.values())









share|improve this question









$endgroup$

















    0












    $begingroup$


    Here's my solution for the Leet Code's Two Sum problem -- would love feedback on (1) code efficiency and (2) style/formatting.



    Problem:




    Given an array nums of n integers, are there elements a, b, c in nums
    such that a + b + c = 0? Find all unique triplets in the array which
    gives the sum of zero.



    Note:



    The solution set must not contain duplicate triplets.



    Example:



    Given array nums = [-1, 0, 1, 2, -1, -4],



    A solution set is: [ [-1, 0, 1], [-1, -1, 2] ]




    My solution:



    def threeSum(nums):
    """
    :type nums: List[int]
    :rtype: List[List[int]]
    """

    def _twoSum(nums_small, target):
    '''
    INPUT: List of numeric values, int target
    OUTPUT: list: pair(s) from nums_small that add up to target and -1*target
    '''
    nums_dict = {}
    return_lst =

    for indx, val in enumerate(nums_small, target):
    if target - val in nums_dict:
    return_lst.append([val, target - val, -1*target])
    nums_dict[val] = indx
    return return_lst

    return_dict = {}

    for indx, val in enumerate(nums):
    for solution in _twoSum(nums[:indx] + nums[indx+1:], -1*val):
    if sorted(solution) not in return_dict.values():
    return_dict[str(indx)+str(solution)] = sorted(solution) # ... hacky way of storing multiple solutions to one index ...

    return list(return_dict.values())









    share|improve this question









    $endgroup$















      0












      0








      0





      $begingroup$


      Here's my solution for the Leet Code's Two Sum problem -- would love feedback on (1) code efficiency and (2) style/formatting.



      Problem:




      Given an array nums of n integers, are there elements a, b, c in nums
      such that a + b + c = 0? Find all unique triplets in the array which
      gives the sum of zero.



      Note:



      The solution set must not contain duplicate triplets.



      Example:



      Given array nums = [-1, 0, 1, 2, -1, -4],



      A solution set is: [ [-1, 0, 1], [-1, -1, 2] ]




      My solution:



      def threeSum(nums):
      """
      :type nums: List[int]
      :rtype: List[List[int]]
      """

      def _twoSum(nums_small, target):
      '''
      INPUT: List of numeric values, int target
      OUTPUT: list: pair(s) from nums_small that add up to target and -1*target
      '''
      nums_dict = {}
      return_lst =

      for indx, val in enumerate(nums_small, target):
      if target - val in nums_dict:
      return_lst.append([val, target - val, -1*target])
      nums_dict[val] = indx
      return return_lst

      return_dict = {}

      for indx, val in enumerate(nums):
      for solution in _twoSum(nums[:indx] + nums[indx+1:], -1*val):
      if sorted(solution) not in return_dict.values():
      return_dict[str(indx)+str(solution)] = sorted(solution) # ... hacky way of storing multiple solutions to one index ...

      return list(return_dict.values())









      share|improve this question









      $endgroup$




      Here's my solution for the Leet Code's Two Sum problem -- would love feedback on (1) code efficiency and (2) style/formatting.



      Problem:




      Given an array nums of n integers, are there elements a, b, c in nums
      such that a + b + c = 0? Find all unique triplets in the array which
      gives the sum of zero.



      Note:



      The solution set must not contain duplicate triplets.



      Example:



      Given array nums = [-1, 0, 1, 2, -1, -4],



      A solution set is: [ [-1, 0, 1], [-1, -1, 2] ]




      My solution:



      def threeSum(nums):
      """
      :type nums: List[int]
      :rtype: List[List[int]]
      """

      def _twoSum(nums_small, target):
      '''
      INPUT: List of numeric values, int target
      OUTPUT: list: pair(s) from nums_small that add up to target and -1*target
      '''
      nums_dict = {}
      return_lst =

      for indx, val in enumerate(nums_small, target):
      if target - val in nums_dict:
      return_lst.append([val, target - val, -1*target])
      nums_dict[val] = indx
      return return_lst

      return_dict = {}

      for indx, val in enumerate(nums):
      for solution in _twoSum(nums[:indx] + nums[indx+1:], -1*val):
      if sorted(solution) not in return_dict.values():
      return_dict[str(indx)+str(solution)] = sorted(solution) # ... hacky way of storing multiple solutions to one index ...

      return list(return_dict.values())






      python






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 18 mins ago









      zthomas.nczthomas.nc

      263311




      263311






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212337%2fleetcode-three-sum-in-python%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212337%2fleetcode-three-sum-in-python%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          Refactoring coordinates for Minecraft Pi buildings written in Python