Reducing the amount of List in a WebScraper












0














At the moment, I'm learning and experimenting on the use of web scraping content from different varieties of web pages. But I've come across a common smelly code among several of my applications. I have many repetitive List that has data being append to them.



from requests import get
import requests
import json
from time import sleep
import pandas as pd

url = 'https://shopee.com.my/api/v2/flash_sale/get_items?offset=0&limit=16&filter_soldout=true'
list_name =
list_price =
list_discount =
list_stock =

response = get(url)
json_data = response.json()


def getShockingSales():
index = 0
if response.status_code is 200:
print('Api Satus: ' + 'OK')
else:
print('API unable to access')
total_flashsale = 15
for i in range(index, total_flashsale):
print('Getting data from requested API... please wait a few seconds')
while i <= total_flashsale:
flash_name = json_data['data']['items'][i]['name']
flash_price = json_data['data']['items'][i]['price']
flash_discount = json_data['data']['items'][i]['discount']
flash_stock = json_data['data']['items'][i]['stock']
list_name.append(flash_name)
list_price.append(flash_price)
list_discount.append(flash_discount)
list_stock.append(flash_stock)
sleep(0.5)
i += 1
if i > total_flashsale:
print('No more avaialble items')
return

getShockingSales()
new_panda = pd.DataFrame({'Name': list_name, 'Price': list_price,
'Discount': list_discount, 'Stock Available': list_stock})

print('Converting to Panda Frame....')
sleep(5)
print(new_panda)


Would one list be more than sufficient? Am I approaching this wrongly.










share|improve this question







New contributor




Minial is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

























    0














    At the moment, I'm learning and experimenting on the use of web scraping content from different varieties of web pages. But I've come across a common smelly code among several of my applications. I have many repetitive List that has data being append to them.



    from requests import get
    import requests
    import json
    from time import sleep
    import pandas as pd

    url = 'https://shopee.com.my/api/v2/flash_sale/get_items?offset=0&limit=16&filter_soldout=true'
    list_name =
    list_price =
    list_discount =
    list_stock =

    response = get(url)
    json_data = response.json()


    def getShockingSales():
    index = 0
    if response.status_code is 200:
    print('Api Satus: ' + 'OK')
    else:
    print('API unable to access')
    total_flashsale = 15
    for i in range(index, total_flashsale):
    print('Getting data from requested API... please wait a few seconds')
    while i <= total_flashsale:
    flash_name = json_data['data']['items'][i]['name']
    flash_price = json_data['data']['items'][i]['price']
    flash_discount = json_data['data']['items'][i]['discount']
    flash_stock = json_data['data']['items'][i]['stock']
    list_name.append(flash_name)
    list_price.append(flash_price)
    list_discount.append(flash_discount)
    list_stock.append(flash_stock)
    sleep(0.5)
    i += 1
    if i > total_flashsale:
    print('No more avaialble items')
    return

    getShockingSales()
    new_panda = pd.DataFrame({'Name': list_name, 'Price': list_price,
    'Discount': list_discount, 'Stock Available': list_stock})

    print('Converting to Panda Frame....')
    sleep(5)
    print(new_panda)


    Would one list be more than sufficient? Am I approaching this wrongly.










    share|improve this question







    New contributor




    Minial is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.























      0












      0








      0







      At the moment, I'm learning and experimenting on the use of web scraping content from different varieties of web pages. But I've come across a common smelly code among several of my applications. I have many repetitive List that has data being append to them.



      from requests import get
      import requests
      import json
      from time import sleep
      import pandas as pd

      url = 'https://shopee.com.my/api/v2/flash_sale/get_items?offset=0&limit=16&filter_soldout=true'
      list_name =
      list_price =
      list_discount =
      list_stock =

      response = get(url)
      json_data = response.json()


      def getShockingSales():
      index = 0
      if response.status_code is 200:
      print('Api Satus: ' + 'OK')
      else:
      print('API unable to access')
      total_flashsale = 15
      for i in range(index, total_flashsale):
      print('Getting data from requested API... please wait a few seconds')
      while i <= total_flashsale:
      flash_name = json_data['data']['items'][i]['name']
      flash_price = json_data['data']['items'][i]['price']
      flash_discount = json_data['data']['items'][i]['discount']
      flash_stock = json_data['data']['items'][i]['stock']
      list_name.append(flash_name)
      list_price.append(flash_price)
      list_discount.append(flash_discount)
      list_stock.append(flash_stock)
      sleep(0.5)
      i += 1
      if i > total_flashsale:
      print('No more avaialble items')
      return

      getShockingSales()
      new_panda = pd.DataFrame({'Name': list_name, 'Price': list_price,
      'Discount': list_discount, 'Stock Available': list_stock})

      print('Converting to Panda Frame....')
      sleep(5)
      print(new_panda)


      Would one list be more than sufficient? Am I approaching this wrongly.










      share|improve this question







      New contributor




      Minial is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      At the moment, I'm learning and experimenting on the use of web scraping content from different varieties of web pages. But I've come across a common smelly code among several of my applications. I have many repetitive List that has data being append to them.



      from requests import get
      import requests
      import json
      from time import sleep
      import pandas as pd

      url = 'https://shopee.com.my/api/v2/flash_sale/get_items?offset=0&limit=16&filter_soldout=true'
      list_name =
      list_price =
      list_discount =
      list_stock =

      response = get(url)
      json_data = response.json()


      def getShockingSales():
      index = 0
      if response.status_code is 200:
      print('Api Satus: ' + 'OK')
      else:
      print('API unable to access')
      total_flashsale = 15
      for i in range(index, total_flashsale):
      print('Getting data from requested API... please wait a few seconds')
      while i <= total_flashsale:
      flash_name = json_data['data']['items'][i]['name']
      flash_price = json_data['data']['items'][i]['price']
      flash_discount = json_data['data']['items'][i]['discount']
      flash_stock = json_data['data']['items'][i]['stock']
      list_name.append(flash_name)
      list_price.append(flash_price)
      list_discount.append(flash_discount)
      list_stock.append(flash_stock)
      sleep(0.5)
      i += 1
      if i > total_flashsale:
      print('No more avaialble items')
      return

      getShockingSales()
      new_panda = pd.DataFrame({'Name': list_name, 'Price': list_price,
      'Discount': list_discount, 'Stock Available': list_stock})

      print('Converting to Panda Frame....')
      sleep(5)
      print(new_panda)


      Would one list be more than sufficient? Am I approaching this wrongly.







      python-3.x json






      share|improve this question







      New contributor




      Minial is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      Minial is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      Minial is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 14 mins ago









      MinialMinial

      11




      11




      New contributor




      Minial is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Minial is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Minial is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Minial is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211164%2freducing-the-amount-of-list-in-a-webscraper%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Minial is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Minial is a new contributor. Be nice, and check out our Code of Conduct.













          Minial is a new contributor. Be nice, and check out our Code of Conduct.












          Minial is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211164%2freducing-the-amount-of-list-in-a-webscraper%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'