Qsort in C++ using vector











up vote
0
down vote

favorite












I tried to make a simple qsort() function in a functional way, it takes a vector and a bool pred()



Suggestions as to make it more functional, optimize it, and/or remove extra steps and intermediate variables are appreciated



template <typename T>
void operator+=(std::vector<T> &v1, const std::vector<T> &v2) {
v1.insert(v1.end(), v2.begin(), v2.end());
}

template <typename T, typename Func>
std::vector<T> qsort(const std::vector<T>& in, const Func& pred) {
std::vector<T> out;
std::vector<T> less;
std::vector<T> more;

if (in.size() < 2)
return in;
auto p = in[0];
for (auto i = 1; i < in.size(); i++) {
if (pred(p, in[i]))
less.push_back(in[i]);
else
more.push_back(in[i]);
}
out = qsort(less, pred);
out.push_back(p);
out += qsort(more, pred);

return out;
}









share|improve this question


























    up vote
    0
    down vote

    favorite












    I tried to make a simple qsort() function in a functional way, it takes a vector and a bool pred()



    Suggestions as to make it more functional, optimize it, and/or remove extra steps and intermediate variables are appreciated



    template <typename T>
    void operator+=(std::vector<T> &v1, const std::vector<T> &v2) {
    v1.insert(v1.end(), v2.begin(), v2.end());
    }

    template <typename T, typename Func>
    std::vector<T> qsort(const std::vector<T>& in, const Func& pred) {
    std::vector<T> out;
    std::vector<T> less;
    std::vector<T> more;

    if (in.size() < 2)
    return in;
    auto p = in[0];
    for (auto i = 1; i < in.size(); i++) {
    if (pred(p, in[i]))
    less.push_back(in[i]);
    else
    more.push_back(in[i]);
    }
    out = qsort(less, pred);
    out.push_back(p);
    out += qsort(more, pred);

    return out;
    }









    share|improve this question
























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I tried to make a simple qsort() function in a functional way, it takes a vector and a bool pred()



      Suggestions as to make it more functional, optimize it, and/or remove extra steps and intermediate variables are appreciated



      template <typename T>
      void operator+=(std::vector<T> &v1, const std::vector<T> &v2) {
      v1.insert(v1.end(), v2.begin(), v2.end());
      }

      template <typename T, typename Func>
      std::vector<T> qsort(const std::vector<T>& in, const Func& pred) {
      std::vector<T> out;
      std::vector<T> less;
      std::vector<T> more;

      if (in.size() < 2)
      return in;
      auto p = in[0];
      for (auto i = 1; i < in.size(); i++) {
      if (pred(p, in[i]))
      less.push_back(in[i]);
      else
      more.push_back(in[i]);
      }
      out = qsort(less, pred);
      out.push_back(p);
      out += qsort(more, pred);

      return out;
      }









      share|improve this question













      I tried to make a simple qsort() function in a functional way, it takes a vector and a bool pred()



      Suggestions as to make it more functional, optimize it, and/or remove extra steps and intermediate variables are appreciated



      template <typename T>
      void operator+=(std::vector<T> &v1, const std::vector<T> &v2) {
      v1.insert(v1.end(), v2.begin(), v2.end());
      }

      template <typename T, typename Func>
      std::vector<T> qsort(const std::vector<T>& in, const Func& pred) {
      std::vector<T> out;
      std::vector<T> less;
      std::vector<T> more;

      if (in.size() < 2)
      return in;
      auto p = in[0];
      for (auto i = 1; i < in.size(); i++) {
      if (pred(p, in[i]))
      less.push_back(in[i]);
      else
      more.push_back(in[i]);
      }
      out = qsort(less, pred);
      out.push_back(p);
      out += qsort(more, pred);

      return out;
      }






      c++ algorithm vectors c++17 quick-sort






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 11 hours ago









      Meme myself and a very creepy

      564




      564



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














           

          draft saved


          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f207943%2fqsort-in-c-using-vector%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















           

          draft saved


          draft discarded



















































           


          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f207943%2fqsort-in-c-using-vector%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'