Multi threading with CachedThreadPool











up vote
0
down vote

favorite












I have server-client communication architecture where there is one server and 150 clients
The server-client communication happens via java NIO where all the clients send some or the other data every 10 seconds.
Previously we used to queue all the process messages and process all those in a single thread, as the number of clients are more so as the messages, server is not able to process all the messages instantly and there is a delay in processing in turn data loss.
So i have thought of implementing CachecThreadPool to process the tasks simultaneously as soon as they come, i have picked CachedThreadPool over FixedThreadPool because the tasks are short lived and many in number, below is the code for that.
The thread which receives messages from client calls ProcessorClass.processData(message) as soon as it receives the message.



public class ProcessorClass{

private static final Logger LOGGER = Logger.getLogger(ProcessorClass.class);
static ThreadPoolExecutor executor = (ThreadPoolExecutor) Executors.newCachedThreadPool();

public static void processData(StringBuffer message) {
Runnable task = new Runnable() {
@Override
public void run() {
try {
LOGGER.info("Queue size:"+executor.getQueue().size());
if (message != null){
processMessage(message);
}
}
catch(Exception e) {
LOGGER.error("Error happened in run() method" + e.getMessage());
}

}
};
executor.execute(task);
}
public static void processMessage(StringBuffer message){
// all the processing of message such as DB operations goes here.
}


}
Doubts:




  1. How CachedThreadPool stores the message in the queue because i haven't defined any explicitly.

  2. Should i chose FixedThreadPool over this?

  3. Should i make my processMessage() method synchronized?


All the suggestions and review comments are welcome.









share







New contributor




raviraja is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
























    up vote
    0
    down vote

    favorite












    I have server-client communication architecture where there is one server and 150 clients
    The server-client communication happens via java NIO where all the clients send some or the other data every 10 seconds.
    Previously we used to queue all the process messages and process all those in a single thread, as the number of clients are more so as the messages, server is not able to process all the messages instantly and there is a delay in processing in turn data loss.
    So i have thought of implementing CachecThreadPool to process the tasks simultaneously as soon as they come, i have picked CachedThreadPool over FixedThreadPool because the tasks are short lived and many in number, below is the code for that.
    The thread which receives messages from client calls ProcessorClass.processData(message) as soon as it receives the message.



    public class ProcessorClass{

    private static final Logger LOGGER = Logger.getLogger(ProcessorClass.class);
    static ThreadPoolExecutor executor = (ThreadPoolExecutor) Executors.newCachedThreadPool();

    public static void processData(StringBuffer message) {
    Runnable task = new Runnable() {
    @Override
    public void run() {
    try {
    LOGGER.info("Queue size:"+executor.getQueue().size());
    if (message != null){
    processMessage(message);
    }
    }
    catch(Exception e) {
    LOGGER.error("Error happened in run() method" + e.getMessage());
    }

    }
    };
    executor.execute(task);
    }
    public static void processMessage(StringBuffer message){
    // all the processing of message such as DB operations goes here.
    }


    }
    Doubts:




    1. How CachedThreadPool stores the message in the queue because i haven't defined any explicitly.

    2. Should i chose FixedThreadPool over this?

    3. Should i make my processMessage() method synchronized?


    All the suggestions and review comments are welcome.









    share







    New contributor




    raviraja is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.






















      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I have server-client communication architecture where there is one server and 150 clients
      The server-client communication happens via java NIO where all the clients send some or the other data every 10 seconds.
      Previously we used to queue all the process messages and process all those in a single thread, as the number of clients are more so as the messages, server is not able to process all the messages instantly and there is a delay in processing in turn data loss.
      So i have thought of implementing CachecThreadPool to process the tasks simultaneously as soon as they come, i have picked CachedThreadPool over FixedThreadPool because the tasks are short lived and many in number, below is the code for that.
      The thread which receives messages from client calls ProcessorClass.processData(message) as soon as it receives the message.



      public class ProcessorClass{

      private static final Logger LOGGER = Logger.getLogger(ProcessorClass.class);
      static ThreadPoolExecutor executor = (ThreadPoolExecutor) Executors.newCachedThreadPool();

      public static void processData(StringBuffer message) {
      Runnable task = new Runnable() {
      @Override
      public void run() {
      try {
      LOGGER.info("Queue size:"+executor.getQueue().size());
      if (message != null){
      processMessage(message);
      }
      }
      catch(Exception e) {
      LOGGER.error("Error happened in run() method" + e.getMessage());
      }

      }
      };
      executor.execute(task);
      }
      public static void processMessage(StringBuffer message){
      // all the processing of message such as DB operations goes here.
      }


      }
      Doubts:




      1. How CachedThreadPool stores the message in the queue because i haven't defined any explicitly.

      2. Should i chose FixedThreadPool over this?

      3. Should i make my processMessage() method synchronized?


      All the suggestions and review comments are welcome.









      share







      New contributor




      raviraja is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      I have server-client communication architecture where there is one server and 150 clients
      The server-client communication happens via java NIO where all the clients send some or the other data every 10 seconds.
      Previously we used to queue all the process messages and process all those in a single thread, as the number of clients are more so as the messages, server is not able to process all the messages instantly and there is a delay in processing in turn data loss.
      So i have thought of implementing CachecThreadPool to process the tasks simultaneously as soon as they come, i have picked CachedThreadPool over FixedThreadPool because the tasks are short lived and many in number, below is the code for that.
      The thread which receives messages from client calls ProcessorClass.processData(message) as soon as it receives the message.



      public class ProcessorClass{

      private static final Logger LOGGER = Logger.getLogger(ProcessorClass.class);
      static ThreadPoolExecutor executor = (ThreadPoolExecutor) Executors.newCachedThreadPool();

      public static void processData(StringBuffer message) {
      Runnable task = new Runnable() {
      @Override
      public void run() {
      try {
      LOGGER.info("Queue size:"+executor.getQueue().size());
      if (message != null){
      processMessage(message);
      }
      }
      catch(Exception e) {
      LOGGER.error("Error happened in run() method" + e.getMessage());
      }

      }
      };
      executor.execute(task);
      }
      public static void processMessage(StringBuffer message){
      // all the processing of message such as DB operations goes here.
      }


      }
      Doubts:




      1. How CachedThreadPool stores the message in the queue because i haven't defined any explicitly.

      2. Should i chose FixedThreadPool over this?

      3. Should i make my processMessage() method synchronized?


      All the suggestions and review comments are welcome.







      java multithreading





      share







      New contributor




      raviraja is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      raviraja is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      raviraja is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 8 mins ago









      raviraja

      101




      101




      New contributor




      raviraja is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      raviraja is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      raviraja is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          raviraja is a new contributor. Be nice, and check out our Code of Conduct.










           

          draft saved


          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208210%2fmulti-threading-with-cachedthreadpool%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          raviraja is a new contributor. Be nice, and check out our Code of Conduct.










           

          draft saved


          draft discarded


















          raviraja is a new contributor. Be nice, and check out our Code of Conduct.













          raviraja is a new contributor. Be nice, and check out our Code of Conduct.












          raviraja is a new contributor. Be nice, and check out our Code of Conduct.















           


          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208210%2fmulti-threading-with-cachedthreadpool%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          Refactoring coordinates for Minecraft Pi buildings written in Python