JavaScript Adding Items Dynamically












0












$begingroup$


For a homework assignment, I have to create a "TO-DO" list, which will add a list item to the unordered list dynamically using JavaScript. I'm looking for answers that will improve the efficiency of the code. Any and all suggestions are welcome and considered. Thank you!



index.html



<!DOCTYPE html>
<html lang="en-US">
<head>
<meta charset="UTF-8">
<title>TO-DO</title>
<script src="script.js"></script>
<link rel="stylesheet" type="text/css" href="style.css">
</head>
<body>
<center>
<form action="">
<fieldset>
<input type="text" id="user_input"><br>
<button type="button" onclick="execute(1)">Add To List</button>
<button type="button" onclick="execute(2)">Remove From List</button>
</fieldset>
</form>
</center>
<center>
<h1>TO-DO</h1>
</center>
<ul id="list">
<!-- items will below -->
</ul>
</body>
</html>


script.js



/*
- get user input
- create <li> element
- append that to <ul> list
*/

function Form_Processes() {

this.count = 0;

this.addToList = function() {
var itemToAdd = document.getElementById('user_input').value;
if(!(itemToAdd === "")) {
this.count += 1;
var list_tag = document.getElementById('list');
var li_tag = document.createElement('li');
li_tag.id = "li_" + this.count;
var li_text = document.createTextNode(itemToAdd);
li_tag.appendChild(li_text);
list_tag.appendChild(li_tag);

//clear textbox for next input
document.getElementById('user_input').value = "";
}
}

this.removeFromList = function() {
var numsOfElements = document.getElementById('list').childElementCount;
if(numsOfElements > 0) {
var itemToRemove = document.getElementById('li_' + this.count);
itemToRemove.outerHTML = "";
this.count -= 1;
} else {
console.log('ERROR: Not Enough Child Elements to remove (script.js:25)');
}
}
}

var f = new Form_Processes();

function execute(x) {
if(x == 1) {
f.addToList()
} else if(x == 2) {
f.removeFromList();
}
}


style.css



* {
font-family: "Times New Roman", Times, serif;
}

body {
background-color: pink;
}

fieldset {
border: none;
}

input[type=text] {
padding: 12px 20px;
font-size: 16px;
margin: 2px;
}

button {
background-color: green;
border: none;
border-radius: 6px; /* rounded corner look */
color: white; /* button text color */
text-align: center;
font-size: 16px;
}

ul {
list-style-type: none;
margin: 0;
padding: 0;
}

li {
background-color: grey;
margin: 3px;
font-size: 50px;
border-radius: 5px;
color: white;
padding-left: 15px;
}








share









$endgroup$

















    0












    $begingroup$


    For a homework assignment, I have to create a "TO-DO" list, which will add a list item to the unordered list dynamically using JavaScript. I'm looking for answers that will improve the efficiency of the code. Any and all suggestions are welcome and considered. Thank you!



    index.html



    <!DOCTYPE html>
    <html lang="en-US">
    <head>
    <meta charset="UTF-8">
    <title>TO-DO</title>
    <script src="script.js"></script>
    <link rel="stylesheet" type="text/css" href="style.css">
    </head>
    <body>
    <center>
    <form action="">
    <fieldset>
    <input type="text" id="user_input"><br>
    <button type="button" onclick="execute(1)">Add To List</button>
    <button type="button" onclick="execute(2)">Remove From List</button>
    </fieldset>
    </form>
    </center>
    <center>
    <h1>TO-DO</h1>
    </center>
    <ul id="list">
    <!-- items will below -->
    </ul>
    </body>
    </html>


    script.js



    /*
    - get user input
    - create <li> element
    - append that to <ul> list
    */

    function Form_Processes() {

    this.count = 0;

    this.addToList = function() {
    var itemToAdd = document.getElementById('user_input').value;
    if(!(itemToAdd === "")) {
    this.count += 1;
    var list_tag = document.getElementById('list');
    var li_tag = document.createElement('li');
    li_tag.id = "li_" + this.count;
    var li_text = document.createTextNode(itemToAdd);
    li_tag.appendChild(li_text);
    list_tag.appendChild(li_tag);

    //clear textbox for next input
    document.getElementById('user_input').value = "";
    }
    }

    this.removeFromList = function() {
    var numsOfElements = document.getElementById('list').childElementCount;
    if(numsOfElements > 0) {
    var itemToRemove = document.getElementById('li_' + this.count);
    itemToRemove.outerHTML = "";
    this.count -= 1;
    } else {
    console.log('ERROR: Not Enough Child Elements to remove (script.js:25)');
    }
    }
    }

    var f = new Form_Processes();

    function execute(x) {
    if(x == 1) {
    f.addToList()
    } else if(x == 2) {
    f.removeFromList();
    }
    }


    style.css



    * {
    font-family: "Times New Roman", Times, serif;
    }

    body {
    background-color: pink;
    }

    fieldset {
    border: none;
    }

    input[type=text] {
    padding: 12px 20px;
    font-size: 16px;
    margin: 2px;
    }

    button {
    background-color: green;
    border: none;
    border-radius: 6px; /* rounded corner look */
    color: white; /* button text color */
    text-align: center;
    font-size: 16px;
    }

    ul {
    list-style-type: none;
    margin: 0;
    padding: 0;
    }

    li {
    background-color: grey;
    margin: 3px;
    font-size: 50px;
    border-radius: 5px;
    color: white;
    padding-left: 15px;
    }








    share









    $endgroup$















      0












      0








      0





      $begingroup$


      For a homework assignment, I have to create a "TO-DO" list, which will add a list item to the unordered list dynamically using JavaScript. I'm looking for answers that will improve the efficiency of the code. Any and all suggestions are welcome and considered. Thank you!



      index.html



      <!DOCTYPE html>
      <html lang="en-US">
      <head>
      <meta charset="UTF-8">
      <title>TO-DO</title>
      <script src="script.js"></script>
      <link rel="stylesheet" type="text/css" href="style.css">
      </head>
      <body>
      <center>
      <form action="">
      <fieldset>
      <input type="text" id="user_input"><br>
      <button type="button" onclick="execute(1)">Add To List</button>
      <button type="button" onclick="execute(2)">Remove From List</button>
      </fieldset>
      </form>
      </center>
      <center>
      <h1>TO-DO</h1>
      </center>
      <ul id="list">
      <!-- items will below -->
      </ul>
      </body>
      </html>


      script.js



      /*
      - get user input
      - create <li> element
      - append that to <ul> list
      */

      function Form_Processes() {

      this.count = 0;

      this.addToList = function() {
      var itemToAdd = document.getElementById('user_input').value;
      if(!(itemToAdd === "")) {
      this.count += 1;
      var list_tag = document.getElementById('list');
      var li_tag = document.createElement('li');
      li_tag.id = "li_" + this.count;
      var li_text = document.createTextNode(itemToAdd);
      li_tag.appendChild(li_text);
      list_tag.appendChild(li_tag);

      //clear textbox for next input
      document.getElementById('user_input').value = "";
      }
      }

      this.removeFromList = function() {
      var numsOfElements = document.getElementById('list').childElementCount;
      if(numsOfElements > 0) {
      var itemToRemove = document.getElementById('li_' + this.count);
      itemToRemove.outerHTML = "";
      this.count -= 1;
      } else {
      console.log('ERROR: Not Enough Child Elements to remove (script.js:25)');
      }
      }
      }

      var f = new Form_Processes();

      function execute(x) {
      if(x == 1) {
      f.addToList()
      } else if(x == 2) {
      f.removeFromList();
      }
      }


      style.css



      * {
      font-family: "Times New Roman", Times, serif;
      }

      body {
      background-color: pink;
      }

      fieldset {
      border: none;
      }

      input[type=text] {
      padding: 12px 20px;
      font-size: 16px;
      margin: 2px;
      }

      button {
      background-color: green;
      border: none;
      border-radius: 6px; /* rounded corner look */
      color: white; /* button text color */
      text-align: center;
      font-size: 16px;
      }

      ul {
      list-style-type: none;
      margin: 0;
      padding: 0;
      }

      li {
      background-color: grey;
      margin: 3px;
      font-size: 50px;
      border-radius: 5px;
      color: white;
      padding-left: 15px;
      }








      share









      $endgroup$




      For a homework assignment, I have to create a "TO-DO" list, which will add a list item to the unordered list dynamically using JavaScript. I'm looking for answers that will improve the efficiency of the code. Any and all suggestions are welcome and considered. Thank you!



      index.html



      <!DOCTYPE html>
      <html lang="en-US">
      <head>
      <meta charset="UTF-8">
      <title>TO-DO</title>
      <script src="script.js"></script>
      <link rel="stylesheet" type="text/css" href="style.css">
      </head>
      <body>
      <center>
      <form action="">
      <fieldset>
      <input type="text" id="user_input"><br>
      <button type="button" onclick="execute(1)">Add To List</button>
      <button type="button" onclick="execute(2)">Remove From List</button>
      </fieldset>
      </form>
      </center>
      <center>
      <h1>TO-DO</h1>
      </center>
      <ul id="list">
      <!-- items will below -->
      </ul>
      </body>
      </html>


      script.js



      /*
      - get user input
      - create <li> element
      - append that to <ul> list
      */

      function Form_Processes() {

      this.count = 0;

      this.addToList = function() {
      var itemToAdd = document.getElementById('user_input').value;
      if(!(itemToAdd === "")) {
      this.count += 1;
      var list_tag = document.getElementById('list');
      var li_tag = document.createElement('li');
      li_tag.id = "li_" + this.count;
      var li_text = document.createTextNode(itemToAdd);
      li_tag.appendChild(li_text);
      list_tag.appendChild(li_tag);

      //clear textbox for next input
      document.getElementById('user_input').value = "";
      }
      }

      this.removeFromList = function() {
      var numsOfElements = document.getElementById('list').childElementCount;
      if(numsOfElements > 0) {
      var itemToRemove = document.getElementById('li_' + this.count);
      itemToRemove.outerHTML = "";
      this.count -= 1;
      } else {
      console.log('ERROR: Not Enough Child Elements to remove (script.js:25)');
      }
      }
      }

      var f = new Form_Processes();

      function execute(x) {
      if(x == 1) {
      f.addToList()
      } else if(x == 2) {
      f.removeFromList();
      }
      }


      style.css



      * {
      font-family: "Times New Roman", Times, serif;
      }

      body {
      background-color: pink;
      }

      fieldset {
      border: none;
      }

      input[type=text] {
      padding: 12px 20px;
      font-size: 16px;
      margin: 2px;
      }

      button {
      background-color: green;
      border: none;
      border-radius: 6px; /* rounded corner look */
      color: white; /* button text color */
      text-align: center;
      font-size: 16px;
      }

      ul {
      list-style-type: none;
      margin: 0;
      padding: 0;
      }

      li {
      background-color: grey;
      margin: 3px;
      font-size: 50px;
      border-radius: 5px;
      color: white;
      padding-left: 15px;
      }






      javascript homework





      share












      share










      share



      share










      asked 6 mins ago









      David WhiteDavid White

      258313




      258313






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213431%2fjavascript-adding-li-items-dynamically%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213431%2fjavascript-adding-li-items-dynamically%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'