Best practices for CSS and Javascript for a basic navigation drawer?












0












$begingroup$


all I am trying to optimize my navigation drawer code. I have tried and followed the BEM naming convention for my CSS although I would like it reviewed with respect to the best practices being followed.
Also, I have used javascript arrow functions for my list in order to avoid repetition of the list item which also needs to be reviewed since I have a nested list where I have used a workaround.



Please find below my code for the navigation drawer list:-



import React from 'react';
import PropTypes from 'prop-types';
import { withStyles, Button } from '@material-ui/core';
import ListSubheader from '@material-ui/core/ListSubheader';
import List from '@material-ui/core/List';
import ListItem from '@material-ui/core/ListItem';
import Collapse from '@material-ui/core/Collapse';
import ExpandLess from '@material-ui/icons/ExpandLess';
import ExpandMore from '@material-ui/icons/ExpandMore';
import MenuIcon from '@material-ui/icons/ArrowForward';
import IconButton from '@material-ui/core/IconButton';
import Divider from '@material-ui/core/Divider';
import Typography from '@material-ui/core/Typography';
import Link from 'next/link';

const fbIcon = '../static/facebook-icon.png';
const twitterIcon = '../static/twitter-icon.png';
const linkedinIcon = '../static/linkedin-icon.png';
const androidIcon = '../static/androidIcon.png';
const iosIcon = '../static/iosIcon.png';

const styles = theme => ({
'list-container': {
width: '100%',
maxWidth: 360,
backgroundColor: '#2ec3d2',
[theme.breakpoints.down('sm')]: {
maxWidth: '15rem',
}
},
'list-container__subheader': {
display: 'flex',
flexDirection: 'column',
backgroundColor: '#2ec3d2'
},
'list-container__nested': {
paddingLeft: theme.spacing.unit * 4
},
'list-container__button': {
color: theme.palette.getContrastText('#fff'),
backgroundColor: '#fff',
marginBottom: 20,
},
'list-container__arrowicon': {
width: 50,
height: 50,
color: '#fff'
},
'list-container__arrow-container': {
display: 'flex',
justifyContent: 'flex-end',
marginTop: 31,
marginBottom: 22,
[theme.breakpoints.down('sm')]: {
marginTop: 11,
marginBottom: 11
}
},
'list-container__row': {
display: 'flex',
flexDirection: 'row',
alignItems: 'flex-end'
},
'list-container__expicon': {
marginLeft: 20,
color: '#fff'
},
'list-container__headertxt': {
fontSize: '14px',
fontFamily: 'Montserrat,sans-serif',
lineHeight: 1,
textAlign: 'left',
color: '#fff',
textTransform: 'uppercase'
},
'social-container': {
display: 'flex',
flexDirection: 'row',
justifyContent: 'space-around',
paddingLeft: 10,
marginTop: 10
},
'social-container__icon': {
width: 30,
height: 30
},
'social-container__psicon': {
width: '145px',
height: '45px',
display: 'flex',
alignItems: 'left',
marginBottom: '5%',
marginTop: '8%',
[theme.breakpoints.down('sm')]: {
marginTop: '10%',
width: '104px',
height: '32px'
},
[theme.breakpoints.down('xs')]: {
marginTop: '10%',
width: '94px',
height: '30px'
}

}
});

const getNavigationLinks = (navigationObj, classes) => Object.keys(navigationObj)
.map(linkName => (
<Link key={linkName} href={navigationObj[linkName]}>
{/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
<ListItem button>
<Typography className={classes['list-container__headertxt']} variant="subtitle2" gutterBottom>
{linkName}
</Typography>
</ListItem>

</Link>
));

const getNestedLinks = (navigationObj, classes) => Object.keys(navigationObj)
.map(linkName => (
<Link key={linkName} href={navigationObj[linkName]}>
{/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
<ListItem button className={classes['list-container__nested']}>
<Typography className={classes['list-container__headertxt']} variant="subtitle2" gutterBottom>
{linkName}
</Typography>
</ListItem>

</Link>
));

class NavigationList extends React.Component {
state = {
open: false
};

handleClick = () => {
this.setState(state => ({ open: !state.open }));
};

render() {
const { classes } = this.props;
const { open } = this.state;
return (
<div className={classes['list-container']}>
<List
component="nav"
subheader={(
<ListSubheader
className={classes['list-container__subheader']}
component="div"
>
<div className={classes['list-container__arrow-container']}>
<IconButton className={classes['list-container__arrowicon']} aria-label="arrow">
<MenuIcon />
</IconButton>
</div>
<Button
className={classes['list-container__button']}
variant="contained"
size="large"
style={{
color: '#2ec3d2'
}}
>
Download
</Button>
</ListSubheader>
)}
>
{getNavigationLinks(
{
HOME: '/',
'EXISTING CUSTOMER LOGIN': 'https://somelink/',
'ABOUT Us': '/aboutus',
CAREERS: '/careers',
},
classes
)}
<ListItem button onClick={this.handleClick}>
<div className={classes['list-container__row']}>
<Typography className={classes['list-container__headertxt']} variant="subtitle2" gutterBottom>
PRODUCTS
</Typography>
{open ? <ExpandLess className={classes['list-container__expicon']} />
: <ExpandMore className={classes['list-container__expicon']} />}
</div>
</ListItem>
<Collapse in={open} timeout="auto" unmountOnExit>
<List component="div" disablePadding>
{getNestedLinks(
{
'INSTANT CASH': '/',
'SHOP ON AMAZON': 'https://somelink/',
'SHOP AT BIG BAZAAR': '/bigbazaar',
'SCHOOL FEES ': 'https://somelink/'
},
classes
)}
</List>
</Collapse>
{getNavigationLinks(
{
BLOGS: 'https://somelink/',
NEWS: 'https://somelink',
FAQS: '/faqs',
'START YOUR APPLICATION': 'https://somelink/'
},
classes
)}
</List>
<Divider />
<div className={classes['social-container']}>
<img className={classes['social-container__icon']} src={fbIcon} alt="facebook" />
<img className={classes['social-container__icon']} src={twitterIcon} alt="twitter" />
<img className={classes['social-container__icon']} src={linkedinIcon} alt="linkedin" />
</div>
<div className={classes['social-container']}>
<img className={classes['social-container__psicon']} src={androidIcon} alt="android" />
<img className={classes['social-container__psicon']} src={iosIcon} alt="ios" />
</div>
</div>
);
}
}
NavigationList.propTypes = {
classes: PropTypes.object.isRequired
};
export default withStyles(styles)(NavigationList);


Any help or suggestion is appreciated. Thank you!









share









$endgroup$

















    0












    $begingroup$


    all I am trying to optimize my navigation drawer code. I have tried and followed the BEM naming convention for my CSS although I would like it reviewed with respect to the best practices being followed.
    Also, I have used javascript arrow functions for my list in order to avoid repetition of the list item which also needs to be reviewed since I have a nested list where I have used a workaround.



    Please find below my code for the navigation drawer list:-



    import React from 'react';
    import PropTypes from 'prop-types';
    import { withStyles, Button } from '@material-ui/core';
    import ListSubheader from '@material-ui/core/ListSubheader';
    import List from '@material-ui/core/List';
    import ListItem from '@material-ui/core/ListItem';
    import Collapse from '@material-ui/core/Collapse';
    import ExpandLess from '@material-ui/icons/ExpandLess';
    import ExpandMore from '@material-ui/icons/ExpandMore';
    import MenuIcon from '@material-ui/icons/ArrowForward';
    import IconButton from '@material-ui/core/IconButton';
    import Divider from '@material-ui/core/Divider';
    import Typography from '@material-ui/core/Typography';
    import Link from 'next/link';

    const fbIcon = '../static/facebook-icon.png';
    const twitterIcon = '../static/twitter-icon.png';
    const linkedinIcon = '../static/linkedin-icon.png';
    const androidIcon = '../static/androidIcon.png';
    const iosIcon = '../static/iosIcon.png';

    const styles = theme => ({
    'list-container': {
    width: '100%',
    maxWidth: 360,
    backgroundColor: '#2ec3d2',
    [theme.breakpoints.down('sm')]: {
    maxWidth: '15rem',
    }
    },
    'list-container__subheader': {
    display: 'flex',
    flexDirection: 'column',
    backgroundColor: '#2ec3d2'
    },
    'list-container__nested': {
    paddingLeft: theme.spacing.unit * 4
    },
    'list-container__button': {
    color: theme.palette.getContrastText('#fff'),
    backgroundColor: '#fff',
    marginBottom: 20,
    },
    'list-container__arrowicon': {
    width: 50,
    height: 50,
    color: '#fff'
    },
    'list-container__arrow-container': {
    display: 'flex',
    justifyContent: 'flex-end',
    marginTop: 31,
    marginBottom: 22,
    [theme.breakpoints.down('sm')]: {
    marginTop: 11,
    marginBottom: 11
    }
    },
    'list-container__row': {
    display: 'flex',
    flexDirection: 'row',
    alignItems: 'flex-end'
    },
    'list-container__expicon': {
    marginLeft: 20,
    color: '#fff'
    },
    'list-container__headertxt': {
    fontSize: '14px',
    fontFamily: 'Montserrat,sans-serif',
    lineHeight: 1,
    textAlign: 'left',
    color: '#fff',
    textTransform: 'uppercase'
    },
    'social-container': {
    display: 'flex',
    flexDirection: 'row',
    justifyContent: 'space-around',
    paddingLeft: 10,
    marginTop: 10
    },
    'social-container__icon': {
    width: 30,
    height: 30
    },
    'social-container__psicon': {
    width: '145px',
    height: '45px',
    display: 'flex',
    alignItems: 'left',
    marginBottom: '5%',
    marginTop: '8%',
    [theme.breakpoints.down('sm')]: {
    marginTop: '10%',
    width: '104px',
    height: '32px'
    },
    [theme.breakpoints.down('xs')]: {
    marginTop: '10%',
    width: '94px',
    height: '30px'
    }

    }
    });

    const getNavigationLinks = (navigationObj, classes) => Object.keys(navigationObj)
    .map(linkName => (
    <Link key={linkName} href={navigationObj[linkName]}>
    {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
    <ListItem button>
    <Typography className={classes['list-container__headertxt']} variant="subtitle2" gutterBottom>
    {linkName}
    </Typography>
    </ListItem>

    </Link>
    ));

    const getNestedLinks = (navigationObj, classes) => Object.keys(navigationObj)
    .map(linkName => (
    <Link key={linkName} href={navigationObj[linkName]}>
    {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
    <ListItem button className={classes['list-container__nested']}>
    <Typography className={classes['list-container__headertxt']} variant="subtitle2" gutterBottom>
    {linkName}
    </Typography>
    </ListItem>

    </Link>
    ));

    class NavigationList extends React.Component {
    state = {
    open: false
    };

    handleClick = () => {
    this.setState(state => ({ open: !state.open }));
    };

    render() {
    const { classes } = this.props;
    const { open } = this.state;
    return (
    <div className={classes['list-container']}>
    <List
    component="nav"
    subheader={(
    <ListSubheader
    className={classes['list-container__subheader']}
    component="div"
    >
    <div className={classes['list-container__arrow-container']}>
    <IconButton className={classes['list-container__arrowicon']} aria-label="arrow">
    <MenuIcon />
    </IconButton>
    </div>
    <Button
    className={classes['list-container__button']}
    variant="contained"
    size="large"
    style={{
    color: '#2ec3d2'
    }}
    >
    Download
    </Button>
    </ListSubheader>
    )}
    >
    {getNavigationLinks(
    {
    HOME: '/',
    'EXISTING CUSTOMER LOGIN': 'https://somelink/',
    'ABOUT Us': '/aboutus',
    CAREERS: '/careers',
    },
    classes
    )}
    <ListItem button onClick={this.handleClick}>
    <div className={classes['list-container__row']}>
    <Typography className={classes['list-container__headertxt']} variant="subtitle2" gutterBottom>
    PRODUCTS
    </Typography>
    {open ? <ExpandLess className={classes['list-container__expicon']} />
    : <ExpandMore className={classes['list-container__expicon']} />}
    </div>
    </ListItem>
    <Collapse in={open} timeout="auto" unmountOnExit>
    <List component="div" disablePadding>
    {getNestedLinks(
    {
    'INSTANT CASH': '/',
    'SHOP ON AMAZON': 'https://somelink/',
    'SHOP AT BIG BAZAAR': '/bigbazaar',
    'SCHOOL FEES ': 'https://somelink/'
    },
    classes
    )}
    </List>
    </Collapse>
    {getNavigationLinks(
    {
    BLOGS: 'https://somelink/',
    NEWS: 'https://somelink',
    FAQS: '/faqs',
    'START YOUR APPLICATION': 'https://somelink/'
    },
    classes
    )}
    </List>
    <Divider />
    <div className={classes['social-container']}>
    <img className={classes['social-container__icon']} src={fbIcon} alt="facebook" />
    <img className={classes['social-container__icon']} src={twitterIcon} alt="twitter" />
    <img className={classes['social-container__icon']} src={linkedinIcon} alt="linkedin" />
    </div>
    <div className={classes['social-container']}>
    <img className={classes['social-container__psicon']} src={androidIcon} alt="android" />
    <img className={classes['social-container__psicon']} src={iosIcon} alt="ios" />
    </div>
    </div>
    );
    }
    }
    NavigationList.propTypes = {
    classes: PropTypes.object.isRequired
    };
    export default withStyles(styles)(NavigationList);


    Any help or suggestion is appreciated. Thank you!









    share









    $endgroup$















      0












      0








      0





      $begingroup$


      all I am trying to optimize my navigation drawer code. I have tried and followed the BEM naming convention for my CSS although I would like it reviewed with respect to the best practices being followed.
      Also, I have used javascript arrow functions for my list in order to avoid repetition of the list item which also needs to be reviewed since I have a nested list where I have used a workaround.



      Please find below my code for the navigation drawer list:-



      import React from 'react';
      import PropTypes from 'prop-types';
      import { withStyles, Button } from '@material-ui/core';
      import ListSubheader from '@material-ui/core/ListSubheader';
      import List from '@material-ui/core/List';
      import ListItem from '@material-ui/core/ListItem';
      import Collapse from '@material-ui/core/Collapse';
      import ExpandLess from '@material-ui/icons/ExpandLess';
      import ExpandMore from '@material-ui/icons/ExpandMore';
      import MenuIcon from '@material-ui/icons/ArrowForward';
      import IconButton from '@material-ui/core/IconButton';
      import Divider from '@material-ui/core/Divider';
      import Typography from '@material-ui/core/Typography';
      import Link from 'next/link';

      const fbIcon = '../static/facebook-icon.png';
      const twitterIcon = '../static/twitter-icon.png';
      const linkedinIcon = '../static/linkedin-icon.png';
      const androidIcon = '../static/androidIcon.png';
      const iosIcon = '../static/iosIcon.png';

      const styles = theme => ({
      'list-container': {
      width: '100%',
      maxWidth: 360,
      backgroundColor: '#2ec3d2',
      [theme.breakpoints.down('sm')]: {
      maxWidth: '15rem',
      }
      },
      'list-container__subheader': {
      display: 'flex',
      flexDirection: 'column',
      backgroundColor: '#2ec3d2'
      },
      'list-container__nested': {
      paddingLeft: theme.spacing.unit * 4
      },
      'list-container__button': {
      color: theme.palette.getContrastText('#fff'),
      backgroundColor: '#fff',
      marginBottom: 20,
      },
      'list-container__arrowicon': {
      width: 50,
      height: 50,
      color: '#fff'
      },
      'list-container__arrow-container': {
      display: 'flex',
      justifyContent: 'flex-end',
      marginTop: 31,
      marginBottom: 22,
      [theme.breakpoints.down('sm')]: {
      marginTop: 11,
      marginBottom: 11
      }
      },
      'list-container__row': {
      display: 'flex',
      flexDirection: 'row',
      alignItems: 'flex-end'
      },
      'list-container__expicon': {
      marginLeft: 20,
      color: '#fff'
      },
      'list-container__headertxt': {
      fontSize: '14px',
      fontFamily: 'Montserrat,sans-serif',
      lineHeight: 1,
      textAlign: 'left',
      color: '#fff',
      textTransform: 'uppercase'
      },
      'social-container': {
      display: 'flex',
      flexDirection: 'row',
      justifyContent: 'space-around',
      paddingLeft: 10,
      marginTop: 10
      },
      'social-container__icon': {
      width: 30,
      height: 30
      },
      'social-container__psicon': {
      width: '145px',
      height: '45px',
      display: 'flex',
      alignItems: 'left',
      marginBottom: '5%',
      marginTop: '8%',
      [theme.breakpoints.down('sm')]: {
      marginTop: '10%',
      width: '104px',
      height: '32px'
      },
      [theme.breakpoints.down('xs')]: {
      marginTop: '10%',
      width: '94px',
      height: '30px'
      }

      }
      });

      const getNavigationLinks = (navigationObj, classes) => Object.keys(navigationObj)
      .map(linkName => (
      <Link key={linkName} href={navigationObj[linkName]}>
      {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
      <ListItem button>
      <Typography className={classes['list-container__headertxt']} variant="subtitle2" gutterBottom>
      {linkName}
      </Typography>
      </ListItem>

      </Link>
      ));

      const getNestedLinks = (navigationObj, classes) => Object.keys(navigationObj)
      .map(linkName => (
      <Link key={linkName} href={navigationObj[linkName]}>
      {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
      <ListItem button className={classes['list-container__nested']}>
      <Typography className={classes['list-container__headertxt']} variant="subtitle2" gutterBottom>
      {linkName}
      </Typography>
      </ListItem>

      </Link>
      ));

      class NavigationList extends React.Component {
      state = {
      open: false
      };

      handleClick = () => {
      this.setState(state => ({ open: !state.open }));
      };

      render() {
      const { classes } = this.props;
      const { open } = this.state;
      return (
      <div className={classes['list-container']}>
      <List
      component="nav"
      subheader={(
      <ListSubheader
      className={classes['list-container__subheader']}
      component="div"
      >
      <div className={classes['list-container__arrow-container']}>
      <IconButton className={classes['list-container__arrowicon']} aria-label="arrow">
      <MenuIcon />
      </IconButton>
      </div>
      <Button
      className={classes['list-container__button']}
      variant="contained"
      size="large"
      style={{
      color: '#2ec3d2'
      }}
      >
      Download
      </Button>
      </ListSubheader>
      )}
      >
      {getNavigationLinks(
      {
      HOME: '/',
      'EXISTING CUSTOMER LOGIN': 'https://somelink/',
      'ABOUT Us': '/aboutus',
      CAREERS: '/careers',
      },
      classes
      )}
      <ListItem button onClick={this.handleClick}>
      <div className={classes['list-container__row']}>
      <Typography className={classes['list-container__headertxt']} variant="subtitle2" gutterBottom>
      PRODUCTS
      </Typography>
      {open ? <ExpandLess className={classes['list-container__expicon']} />
      : <ExpandMore className={classes['list-container__expicon']} />}
      </div>
      </ListItem>
      <Collapse in={open} timeout="auto" unmountOnExit>
      <List component="div" disablePadding>
      {getNestedLinks(
      {
      'INSTANT CASH': '/',
      'SHOP ON AMAZON': 'https://somelink/',
      'SHOP AT BIG BAZAAR': '/bigbazaar',
      'SCHOOL FEES ': 'https://somelink/'
      },
      classes
      )}
      </List>
      </Collapse>
      {getNavigationLinks(
      {
      BLOGS: 'https://somelink/',
      NEWS: 'https://somelink',
      FAQS: '/faqs',
      'START YOUR APPLICATION': 'https://somelink/'
      },
      classes
      )}
      </List>
      <Divider />
      <div className={classes['social-container']}>
      <img className={classes['social-container__icon']} src={fbIcon} alt="facebook" />
      <img className={classes['social-container__icon']} src={twitterIcon} alt="twitter" />
      <img className={classes['social-container__icon']} src={linkedinIcon} alt="linkedin" />
      </div>
      <div className={classes['social-container']}>
      <img className={classes['social-container__psicon']} src={androidIcon} alt="android" />
      <img className={classes['social-container__psicon']} src={iosIcon} alt="ios" />
      </div>
      </div>
      );
      }
      }
      NavigationList.propTypes = {
      classes: PropTypes.object.isRequired
      };
      export default withStyles(styles)(NavigationList);


      Any help or suggestion is appreciated. Thank you!









      share









      $endgroup$




      all I am trying to optimize my navigation drawer code. I have tried and followed the BEM naming convention for my CSS although I would like it reviewed with respect to the best practices being followed.
      Also, I have used javascript arrow functions for my list in order to avoid repetition of the list item which also needs to be reviewed since I have a nested list where I have used a workaround.



      Please find below my code for the navigation drawer list:-



      import React from 'react';
      import PropTypes from 'prop-types';
      import { withStyles, Button } from '@material-ui/core';
      import ListSubheader from '@material-ui/core/ListSubheader';
      import List from '@material-ui/core/List';
      import ListItem from '@material-ui/core/ListItem';
      import Collapse from '@material-ui/core/Collapse';
      import ExpandLess from '@material-ui/icons/ExpandLess';
      import ExpandMore from '@material-ui/icons/ExpandMore';
      import MenuIcon from '@material-ui/icons/ArrowForward';
      import IconButton from '@material-ui/core/IconButton';
      import Divider from '@material-ui/core/Divider';
      import Typography from '@material-ui/core/Typography';
      import Link from 'next/link';

      const fbIcon = '../static/facebook-icon.png';
      const twitterIcon = '../static/twitter-icon.png';
      const linkedinIcon = '../static/linkedin-icon.png';
      const androidIcon = '../static/androidIcon.png';
      const iosIcon = '../static/iosIcon.png';

      const styles = theme => ({
      'list-container': {
      width: '100%',
      maxWidth: 360,
      backgroundColor: '#2ec3d2',
      [theme.breakpoints.down('sm')]: {
      maxWidth: '15rem',
      }
      },
      'list-container__subheader': {
      display: 'flex',
      flexDirection: 'column',
      backgroundColor: '#2ec3d2'
      },
      'list-container__nested': {
      paddingLeft: theme.spacing.unit * 4
      },
      'list-container__button': {
      color: theme.palette.getContrastText('#fff'),
      backgroundColor: '#fff',
      marginBottom: 20,
      },
      'list-container__arrowicon': {
      width: 50,
      height: 50,
      color: '#fff'
      },
      'list-container__arrow-container': {
      display: 'flex',
      justifyContent: 'flex-end',
      marginTop: 31,
      marginBottom: 22,
      [theme.breakpoints.down('sm')]: {
      marginTop: 11,
      marginBottom: 11
      }
      },
      'list-container__row': {
      display: 'flex',
      flexDirection: 'row',
      alignItems: 'flex-end'
      },
      'list-container__expicon': {
      marginLeft: 20,
      color: '#fff'
      },
      'list-container__headertxt': {
      fontSize: '14px',
      fontFamily: 'Montserrat,sans-serif',
      lineHeight: 1,
      textAlign: 'left',
      color: '#fff',
      textTransform: 'uppercase'
      },
      'social-container': {
      display: 'flex',
      flexDirection: 'row',
      justifyContent: 'space-around',
      paddingLeft: 10,
      marginTop: 10
      },
      'social-container__icon': {
      width: 30,
      height: 30
      },
      'social-container__psicon': {
      width: '145px',
      height: '45px',
      display: 'flex',
      alignItems: 'left',
      marginBottom: '5%',
      marginTop: '8%',
      [theme.breakpoints.down('sm')]: {
      marginTop: '10%',
      width: '104px',
      height: '32px'
      },
      [theme.breakpoints.down('xs')]: {
      marginTop: '10%',
      width: '94px',
      height: '30px'
      }

      }
      });

      const getNavigationLinks = (navigationObj, classes) => Object.keys(navigationObj)
      .map(linkName => (
      <Link key={linkName} href={navigationObj[linkName]}>
      {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
      <ListItem button>
      <Typography className={classes['list-container__headertxt']} variant="subtitle2" gutterBottom>
      {linkName}
      </Typography>
      </ListItem>

      </Link>
      ));

      const getNestedLinks = (navigationObj, classes) => Object.keys(navigationObj)
      .map(linkName => (
      <Link key={linkName} href={navigationObj[linkName]}>
      {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
      <ListItem button className={classes['list-container__nested']}>
      <Typography className={classes['list-container__headertxt']} variant="subtitle2" gutterBottom>
      {linkName}
      </Typography>
      </ListItem>

      </Link>
      ));

      class NavigationList extends React.Component {
      state = {
      open: false
      };

      handleClick = () => {
      this.setState(state => ({ open: !state.open }));
      };

      render() {
      const { classes } = this.props;
      const { open } = this.state;
      return (
      <div className={classes['list-container']}>
      <List
      component="nav"
      subheader={(
      <ListSubheader
      className={classes['list-container__subheader']}
      component="div"
      >
      <div className={classes['list-container__arrow-container']}>
      <IconButton className={classes['list-container__arrowicon']} aria-label="arrow">
      <MenuIcon />
      </IconButton>
      </div>
      <Button
      className={classes['list-container__button']}
      variant="contained"
      size="large"
      style={{
      color: '#2ec3d2'
      }}
      >
      Download
      </Button>
      </ListSubheader>
      )}
      >
      {getNavigationLinks(
      {
      HOME: '/',
      'EXISTING CUSTOMER LOGIN': 'https://somelink/',
      'ABOUT Us': '/aboutus',
      CAREERS: '/careers',
      },
      classes
      )}
      <ListItem button onClick={this.handleClick}>
      <div className={classes['list-container__row']}>
      <Typography className={classes['list-container__headertxt']} variant="subtitle2" gutterBottom>
      PRODUCTS
      </Typography>
      {open ? <ExpandLess className={classes['list-container__expicon']} />
      : <ExpandMore className={classes['list-container__expicon']} />}
      </div>
      </ListItem>
      <Collapse in={open} timeout="auto" unmountOnExit>
      <List component="div" disablePadding>
      {getNestedLinks(
      {
      'INSTANT CASH': '/',
      'SHOP ON AMAZON': 'https://somelink/',
      'SHOP AT BIG BAZAAR': '/bigbazaar',
      'SCHOOL FEES ': 'https://somelink/'
      },
      classes
      )}
      </List>
      </Collapse>
      {getNavigationLinks(
      {
      BLOGS: 'https://somelink/',
      NEWS: 'https://somelink',
      FAQS: '/faqs',
      'START YOUR APPLICATION': 'https://somelink/'
      },
      classes
      )}
      </List>
      <Divider />
      <div className={classes['social-container']}>
      <img className={classes['social-container__icon']} src={fbIcon} alt="facebook" />
      <img className={classes['social-container__icon']} src={twitterIcon} alt="twitter" />
      <img className={classes['social-container__icon']} src={linkedinIcon} alt="linkedin" />
      </div>
      <div className={classes['social-container']}>
      <img className={classes['social-container__psicon']} src={androidIcon} alt="android" />
      <img className={classes['social-container__psicon']} src={iosIcon} alt="ios" />
      </div>
      </div>
      );
      }
      }
      NavigationList.propTypes = {
      classes: PropTypes.object.isRequired
      };
      export default withStyles(styles)(NavigationList);


      Any help or suggestion is appreciated. Thank you!







      javascript beginner css react.js bem





      share












      share










      share



      share










      asked 5 mins ago









      anupanup

      1042




      1042






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213436%2fbest-practices-for-css-and-javascript-for-a-basic-navigation-drawer%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213436%2fbest-practices-for-css-and-javascript-for-a-basic-navigation-drawer%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'