tinyxml2 to support wchar，rewrite funtion Print
0
$begingroup$
My colleague modify the tinyxml2 source code to deal with wchar(tinyxml2.2.0 version),Here is the code bellow,actually the code will only run in liunx,so the windows part should not concern.
The code bellow whichi my colleague write,the comment between /**/ is the right way I think.
void XMLPrinter::Print( const wchar_t* format, ... )
{
va_list va;
va_start( va, format );
wchar_t buf[MAX_PATH*30] ={0};
vswprintf( buf,MAX_PATH*30,format,va);
char * pText = NULL;
int iTextLen = wcstombs(NULL, buf , 0);
pText = new char[iTextLen + 1];
if (pText == NULL)
{
return ;
}
memset( ( void* )pText, 0, sizeof( char ) * ( iTextLen + 1 ) );
/*for a safe way ,should be sizeof(pText) instead of sizeof(buf)*/
wcstombs(pText, buf, sizeof(buf));
if ( _fp ) {
/*Here I think should be fwrite( pText , iTextLen , 1 , _fp ); */
fwrite( pText , iTextLen-1 , 1 , _fp );
}
else {
#if defined(_MSC_VER) && (_MSC_VER >= 1400 )
#if defined(WINCE)
int len = 512;
do {
len = len*2;
wchar_t* str = new wchar_t[len]();
len = _vsnprintf(str, len, format, va);
delete str;
}while (len < 0);
#else
int len = _vscwprintf( format, va );
#endif
#else
int len = vswprintf( 0, 0, format, va );
#endif
// Close out and re-start the va-args
va_end( va );
va_start( va, format );
TIXMLASSERT( _buffer.Size() > 0 && _buffer[_buffer.Size() - 1] == 0 );
/*Here should be _buffer.PushArr( len ) - sizeof(wchar_t);*/
wchar_t* p = _buffer.PushArr( len ) - 1; // back up over the null terminator.
#if defined(_MSC_VER) && (_MSC_VER >= 1400 )
#if defined(WINCE)
_vsnprintf( p, len+1, format, va );
#else
_vsnwprintf_s( p, len+1, _TRUNCATE, format, va );
#endif
#else
vswprintf( p, len+1, format, va );
#endif
}
delete pText;
va_end( va );
}
Review the code and told my colleague,he said it run well.How can I prove it,and the code above has other problem?
c++ c
asked 11 mins ago
J.DoeJ.Doe
1
New contributor
J.Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
My colleague modify the tinyxml2 source code to deal with wchar(tinyxml2.2.0 version),Here is the code bellow,actually the code will only run in liunx,so the windows part should not concern.
The code bellow whichi my colleague write,the comment between /**/ is the right way I think.
void XMLPrinter::Print( const wchar_t* format, ... )
{
va_list va;
va_start( va, format );
wchar_t buf[MAX_PATH*30] ={0};
vswprintf( buf,MAX_PATH*30,format,va);
char * pText = NULL;
int iTextLen = wcstombs(NULL, buf , 0);
pText = new char[iTextLen + 1];
if (pText == NULL)
{
return ;
}
memset( ( void* )pText, 0, sizeof( char ) * ( iTextLen + 1 ) );
/*for a safe way ,should be sizeof(pText) instead of sizeof(buf)*/
wcstombs(pText, buf, sizeof(buf));
if ( _fp ) {
/*Here I think should be fwrite( pText , iTextLen , 1 , _fp ); */
fwrite( pText , iTextLen-1 , 1 , _fp );
}
else {
#if defined(_MSC_VER) && (_MSC_VER >= 1400 )
#if defined(WINCE)
int len = 512;
do {
len = len*2;
wchar_t* str = new wchar_t[len]();
len = _vsnprintf(str, len, format, va);
delete str;
}while (len < 0);
#else
int len = _vscwprintf( format, va );
#endif
#else
int len = vswprintf( 0, 0, format, va );
#endif
// Close out and re-start the va-args
va_end( va );
va_start( va, format );
TIXMLASSERT( _buffer.Size() > 0 && _buffer[_buffer.Size() - 1] == 0 );
/*Here should be _buffer.PushArr( len ) - sizeof(wchar_t);*/
wchar_t* p = _buffer.PushArr( len ) - 1; // back up over the null terminator.
#if defined(_MSC_VER) && (_MSC_VER >= 1400 )
#if defined(WINCE)
_vsnprintf( p, len+1, format, va );
#else
_vsnwprintf_s( p, len+1, _TRUNCATE, format, va );
#endif
#else
vswprintf( p, len+1, format, va );
#endif
}
delete pText;
va_end( va );
}
Review the code and told my colleague,he said it run well.How can I prove it,and the code above has other problem?
c++ c
asked 11 mins ago
J.DoeJ.Doe
1
New contributor
J.Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
My colleague modify the tinyxml2 source code to deal with wchar(tinyxml2.2.0 version),Here is the code bellow,actually the code will only run in liunx,so the windows part should not concern.
The code bellow whichi my colleague write,the comment between /**/ is the right way I think.
void XMLPrinter::Print( const wchar_t* format, ... )
{
va_list va;
va_start( va, format );
wchar_t buf[MAX_PATH*30] ={0};
vswprintf( buf,MAX_PATH*30,format,va);
char * pText = NULL;
int iTextLen = wcstombs(NULL, buf , 0);
pText = new char[iTextLen + 1];
if (pText == NULL)
{
return ;
}
memset( ( void* )pText, 0, sizeof( char ) * ( iTextLen + 1 ) );
/*for a safe way ,should be sizeof(pText) instead of sizeof(buf)*/
wcstombs(pText, buf, sizeof(buf));
if ( _fp ) {
/*Here I think should be fwrite( pText , iTextLen , 1 , _fp ); */
fwrite( pText , iTextLen-1 , 1 , _fp );
}
else {
#if defined(_MSC_VER) && (_MSC_VER >= 1400 )
#if defined(WINCE)
int len = 512;
do {
len = len*2;
wchar_t* str = new wchar_t[len]();
len = _vsnprintf(str, len, format, va);
delete str;
}while (len < 0);
#else
int len = _vscwprintf( format, va );
#endif
#else
int len = vswprintf( 0, 0, format, va );
#endif
// Close out and re-start the va-args
va_end( va );
va_start( va, format );
TIXMLASSERT( _buffer.Size() > 0 && _buffer[_buffer.Size() - 1] == 0 );
/*Here should be _buffer.PushArr( len ) - sizeof(wchar_t);*/
wchar_t* p = _buffer.PushArr( len ) - 1; // back up over the null terminator.
#if defined(_MSC_VER) && (_MSC_VER >= 1400 )
#if defined(WINCE)
_vsnprintf( p, len+1, format, va );
#else
_vsnwprintf_s( p, len+1, _TRUNCATE, format, va );
#endif
#else
vswprintf( p, len+1, format, va );
#endif
}
delete pText;
va_end( va );
}
Review the code and told my colleague,he said it run well.How can I prove it,and the code above has other problem?
c++ c
asked 11 mins ago
J.DoeJ.Doe
1
New contributor
J.Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
My colleague modify the tinyxml2 source code to deal with wchar(tinyxml2.2.0 version),Here is the code bellow,actually the code will only run in liunx,so the windows part should not concern.
The code bellow whichi my colleague write,the comment between /**/ is the right way I think.
void XMLPrinter::Print( const wchar_t* format, ... )
{
va_list va;
va_start( va, format );
wchar_t buf[MAX_PATH*30] ={0};
vswprintf( buf,MAX_PATH*30,format,va);
char * pText = NULL;
int iTextLen = wcstombs(NULL, buf , 0);
pText = new char[iTextLen + 1];
if (pText == NULL)
{
return ;
}
memset( ( void* )pText, 0, sizeof( char ) * ( iTextLen + 1 ) );
/*for a safe way ,should be sizeof(pText) instead of sizeof(buf)*/
wcstombs(pText, buf, sizeof(buf));
if ( _fp ) {
/*Here I think should be fwrite( pText , iTextLen , 1 , _fp ); */
fwrite( pText , iTextLen-1 , 1 , _fp );
}
else {
#if defined(_MSC_VER) && (_MSC_VER >= 1400 )
#if defined(WINCE)
int len = 512;
do {
len = len*2;
wchar_t* str = new wchar_t[len]();
len = _vsnprintf(str, len, format, va);
delete str;
}while (len < 0);
#else
int len = _vscwprintf( format, va );
#endif
#else
int len = vswprintf( 0, 0, format, va );
#endif
// Close out and re-start the va-args
va_end( va );
va_start( va, format );
TIXMLASSERT( _buffer.Size() > 0 && _buffer[_buffer.Size() - 1] == 0 );
/*Here should be _buffer.PushArr( len ) - sizeof(wchar_t);*/
wchar_t* p = _buffer.PushArr( len ) - 1; // back up over the null terminator.
#if defined(_MSC_VER) && (_MSC_VER >= 1400 )
#if defined(WINCE)
_vsnprintf( p, len+1, format, va );
#else
_vsnwprintf_s( p, len+1, _TRUNCATE, format, va );
#endif
#else
vswprintf( p, len+1, format, va );
#endif
}
delete pText;
va_end( va );
}
Review the code and told my colleague,he said it run well.How can I prove it,and the code above has other problem?
c++ c
c++ c
asked 11 mins ago
J.DoeJ.Doe
1
New contributor
J.Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 11 mins ago
J.DoeJ.Doe
1
New contributor
J.Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 11 mins ago
J.DoeJ.Doe
1
New contributor
J.Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 11 mins ago
J.DoeJ.Doe
1
asked 11 mins ago
J.DoeJ.Doe
1
1
New contributor
J.Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
J.Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
J.Doe is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
J.Doe is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211974%2ftinyxml2-to-support-wchar-rewrite-funtion-print%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
J.Doe is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
J.Doe is a new contributor. Be nice, and check out our Code of Conduct.
J.Doe is a new contributor. Be nice, and check out our Code of Conduct.
J.Doe is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211974%2ftinyxml2-to-support-wchar-rewrite-funtion-print%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
