Tukukkk

I am trying to reduce the boiler plate code from getting data from my cache repository. I was basically copying and pasting the same code over and over, so I put all of that logic into a new class, CacheReadCommand. I am trying to do this using async/await as my database repository has already implemented async/await. What has ended up happening is that I got this stack of await keywords when I am trying to execute CacheReadCommand.Read. This is not actually returning anything and leaving the application hung up. Where did I go wrong here?

CacheReadCommand

public class CacheReadCommand : ICacheReadCommand {

    private readonly ICacheRepository _repo;



    public CacheReadCommand(ICacheRepository repo) {

        _repo = repo;

    }



    public async Task<T> Read<T>(string cacheKey, Func<T> query) {

        T retVal = await _repo.GetValue<T>(cacheKey);



        if(retVal == null) {

            retVal = query.Invoke();



            if(retVal != null) {

                await _repo.SetValue<T>(cacheKey, retVal);

            }

        }



        return retVal;

    }

}

** Settings Repository **

    public async Task<Setting> GetSetting(Guid guid, string key) {

        string cacheKey = $"GetSetting_{guid}_{key}";



        return await await _readCommand.Read(cacheKey, async () => await ReadOne<Setting>("GetSetting", guid));

    }



    protected async Task<T> ReadOne<T>(string sql, Guid siteGuid) {

        DynamicParameters parms = new DynamicParameters();

        parms.Add(PARMNAME_GUID, siteGuid.ToFormattedString());



        return await ReadOne<T>(GetCommandDefinition(sql, parms));

    }

If you want to give an async query to your Read function, you need to ask explicitly for a Func<Task<T>> and await it. Right now you're calling Invoke() on the delegate, which returns a Task<Setting>.

So instead you should do something like:

public async Task<T> Read<T>(string cacheKey, Func<Task<T>> query) {

    T retVal = await _repo.GetValue<T>(cacheKey);



    if(retVal == null) {

        retVal = await query();



        if(retVal != null) {

            await _repo.SetValue<T>(cacheKey, retVal);

        }

    }



    return retVal;

}