Get pixel data from image UWP











up vote
0
down vote

favorite












I'm writing a simple tool, the user can select an image and it should list all the colors found in the picture.



Now, I'm facing 2 main issues, one is that it's slow because I'm looping through all the pixels in an image.
Second, I'm getting unexpected results.



First thing's first, the code:



    public static async Task<List<ImageColor>> GetImageColorsAsync(StorageFile image)
{
List<ImageColor> colors = new List<ImageColor>();

var imagestream = await image.OpenStreamForReadAsync(); // Convert image to stream
var imageDecoder = await BitmapDecoder.CreateAsync(imagestream.AsRandomAccessStream()); // decode stream
var imagePixelData = await imageDecoder.GetPixelDataAsync(); // get information about pixels
var bytes = imagePixelData.DetachPixelData(); // get pixel data

for (int x = 0; x < imageDecoder.PixelWidth; x++)
{
for (int y = 0; y < imageDecoder.PixelHeight; y++)
{
var location = (y * (int)imageDecoder.PixelWidth + x) * 3; // Navigate to corresponding coordinates
var color = Color.FromArgb(0, bytes[location + 0], bytes[location + 1], bytes[location + 2]); // Filter Red Green Blue and convert this to Argb

// find if color already exsists from its hex code
string hex = color.ToString();
var prevColor = colors.FirstOrDefault(a => a.ColorCodeHex == hex);

if (colors.Count == 0 || prevColor == null)
{
// new color
ImageColor imgColor = new ImageColor()
{
R = color.R,
G = color.G,
B = color.B,
ColorCodeHex = hex,
Occurence = 1
};

colors.Add(imgColor);
}
else
{
// exsisting color
prevColor.Occurence++;
}
}
}


return colors;
}


Now, do I really need to go through every single pixel?



And, what I did was test this function using a black image (completely black) and what I got was that there are 4 colors in that picture: black, red, green and blue.



Now the lines where I find the location and color are not mine, I found them online and I can't really verify that this is how you should do it.



Any help guys?









share


























    up vote
    0
    down vote

    favorite












    I'm writing a simple tool, the user can select an image and it should list all the colors found in the picture.



    Now, I'm facing 2 main issues, one is that it's slow because I'm looping through all the pixels in an image.
    Second, I'm getting unexpected results.



    First thing's first, the code:



        public static async Task<List<ImageColor>> GetImageColorsAsync(StorageFile image)
    {
    List<ImageColor> colors = new List<ImageColor>();

    var imagestream = await image.OpenStreamForReadAsync(); // Convert image to stream
    var imageDecoder = await BitmapDecoder.CreateAsync(imagestream.AsRandomAccessStream()); // decode stream
    var imagePixelData = await imageDecoder.GetPixelDataAsync(); // get information about pixels
    var bytes = imagePixelData.DetachPixelData(); // get pixel data

    for (int x = 0; x < imageDecoder.PixelWidth; x++)
    {
    for (int y = 0; y < imageDecoder.PixelHeight; y++)
    {
    var location = (y * (int)imageDecoder.PixelWidth + x) * 3; // Navigate to corresponding coordinates
    var color = Color.FromArgb(0, bytes[location + 0], bytes[location + 1], bytes[location + 2]); // Filter Red Green Blue and convert this to Argb

    // find if color already exsists from its hex code
    string hex = color.ToString();
    var prevColor = colors.FirstOrDefault(a => a.ColorCodeHex == hex);

    if (colors.Count == 0 || prevColor == null)
    {
    // new color
    ImageColor imgColor = new ImageColor()
    {
    R = color.R,
    G = color.G,
    B = color.B,
    ColorCodeHex = hex,
    Occurence = 1
    };

    colors.Add(imgColor);
    }
    else
    {
    // exsisting color
    prevColor.Occurence++;
    }
    }
    }


    return colors;
    }


    Now, do I really need to go through every single pixel?



    And, what I did was test this function using a black image (completely black) and what I got was that there are 4 colors in that picture: black, red, green and blue.



    Now the lines where I find the location and color are not mine, I found them online and I can't really verify that this is how you should do it.



    Any help guys?









    share
























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I'm writing a simple tool, the user can select an image and it should list all the colors found in the picture.



      Now, I'm facing 2 main issues, one is that it's slow because I'm looping through all the pixels in an image.
      Second, I'm getting unexpected results.



      First thing's first, the code:



          public static async Task<List<ImageColor>> GetImageColorsAsync(StorageFile image)
      {
      List<ImageColor> colors = new List<ImageColor>();

      var imagestream = await image.OpenStreamForReadAsync(); // Convert image to stream
      var imageDecoder = await BitmapDecoder.CreateAsync(imagestream.AsRandomAccessStream()); // decode stream
      var imagePixelData = await imageDecoder.GetPixelDataAsync(); // get information about pixels
      var bytes = imagePixelData.DetachPixelData(); // get pixel data

      for (int x = 0; x < imageDecoder.PixelWidth; x++)
      {
      for (int y = 0; y < imageDecoder.PixelHeight; y++)
      {
      var location = (y * (int)imageDecoder.PixelWidth + x) * 3; // Navigate to corresponding coordinates
      var color = Color.FromArgb(0, bytes[location + 0], bytes[location + 1], bytes[location + 2]); // Filter Red Green Blue and convert this to Argb

      // find if color already exsists from its hex code
      string hex = color.ToString();
      var prevColor = colors.FirstOrDefault(a => a.ColorCodeHex == hex);

      if (colors.Count == 0 || prevColor == null)
      {
      // new color
      ImageColor imgColor = new ImageColor()
      {
      R = color.R,
      G = color.G,
      B = color.B,
      ColorCodeHex = hex,
      Occurence = 1
      };

      colors.Add(imgColor);
      }
      else
      {
      // exsisting color
      prevColor.Occurence++;
      }
      }
      }


      return colors;
      }


      Now, do I really need to go through every single pixel?



      And, what I did was test this function using a black image (completely black) and what I got was that there are 4 colors in that picture: black, red, green and blue.



      Now the lines where I find the location and color are not mine, I found them online and I can't really verify that this is how you should do it.



      Any help guys?









      share













      I'm writing a simple tool, the user can select an image and it should list all the colors found in the picture.



      Now, I'm facing 2 main issues, one is that it's slow because I'm looping through all the pixels in an image.
      Second, I'm getting unexpected results.



      First thing's first, the code:



          public static async Task<List<ImageColor>> GetImageColorsAsync(StorageFile image)
      {
      List<ImageColor> colors = new List<ImageColor>();

      var imagestream = await image.OpenStreamForReadAsync(); // Convert image to stream
      var imageDecoder = await BitmapDecoder.CreateAsync(imagestream.AsRandomAccessStream()); // decode stream
      var imagePixelData = await imageDecoder.GetPixelDataAsync(); // get information about pixels
      var bytes = imagePixelData.DetachPixelData(); // get pixel data

      for (int x = 0; x < imageDecoder.PixelWidth; x++)
      {
      for (int y = 0; y < imageDecoder.PixelHeight; y++)
      {
      var location = (y * (int)imageDecoder.PixelWidth + x) * 3; // Navigate to corresponding coordinates
      var color = Color.FromArgb(0, bytes[location + 0], bytes[location + 1], bytes[location + 2]); // Filter Red Green Blue and convert this to Argb

      // find if color already exsists from its hex code
      string hex = color.ToString();
      var prevColor = colors.FirstOrDefault(a => a.ColorCodeHex == hex);

      if (colors.Count == 0 || prevColor == null)
      {
      // new color
      ImageColor imgColor = new ImageColor()
      {
      R = color.R,
      G = color.G,
      B = color.B,
      ColorCodeHex = hex,
      Occurence = 1
      };

      colors.Add(imgColor);
      }
      else
      {
      // exsisting color
      prevColor.Occurence++;
      }
      }
      }


      return colors;
      }


      Now, do I really need to go through every single pixel?



      And, what I did was test this function using a black image (completely black) and what I got was that there are 4 colors in that picture: black, red, green and blue.



      Now the lines where I find the location and color are not mine, I found them online and I can't really verify that this is how you should do it.



      Any help guys?







      c# uwp





      share












      share










      share



      share










      asked 2 mins ago









      user3159792

      383




      383



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209332%2fget-pixel-data-from-image-uwp%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209332%2fget-pixel-data-from-image-uwp%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Feedback on college project

          Futebolista

          Albești (Vaslui)