Tukukkk

I recently worked on module, in which i implemented the functionality of downloading the CSV files, I need to know the best practices which will improve this to the next level.

@RequestMapping(value = "/export_data")

public void downloadDataInCsv(

        @RequestParam("type") String type,

        @RequestParam("tID") String tableId,

        HttpServletRequest request,

        HttpServletResponse response) throws IOException {

    if (type.equals("csv")) {

        List<UserInfo> list = userInfoDao.findById(tableId);

        ExportCsvUtil.downloadCsv(request, response, list);

    }

}

private void downloadCsv(HttpServletRequest request, HttpServletResponse response, List<UserInfo> list) throws IOException {

    String headerKey = "Content-Disposition";

    String headerValue = String.format("attachment; filename=Table_Data.csv");

    response.setContentType("text/csv");

    response.setHeader(headerKey, headerValue);



    try (final CSVWriter writer = new CSVWriter(response.getWriter(), ",")) {



        writer.writeNext(new String{"User Id", "First Name", "Last Name", "Roll No", "Email ID", "Gender"});



        for (UserInfo entry: list) {

            // cast/convert to String where needed

            writer.writeNext(new String{entry.getUserId()+"", entry.getFirstName(), entry.getLastName(),entry.getRollNo(),entry.getEmail(),entry.getGender()});

        }

        writer.close();

    }

}

I am using OpenCSV library for reading and writing the CSV files, in addition, one thing should be note down here is, the function writeAll() and write() accepts String .

I initialized the String inside writeNext() , I want to know the better way to do the same, so the readability enhanced.

Please review my code and suggest me the best practice.