List implementation in C
0
I tried to implement a Python-esque list in C. Having not really used C in anger, I'd like some pointers on style and error handling in particular.
Header
#ifndef __TYPE_LIST_H__
#define __TYPE_LIST_H__
/* Generic list implementation for holding a set of pointers to a type
(has to be consistently handled by the element_match and element_delete
functions)
*/
typedef struct list_s list_t;
#include <stdbool.h>
#include <stdint.h>
extern const uint16_t default_capacity;
list_t* list_create(
uint16_t initial_capacity,
bool (*element_match )(const void* a, const void* b),
void (*element_delete)(void* element));
void list_delete(list_t* list);
bool list_append(list_t* list, void* element);
void* list_pop(list_t* list);
bool list_remove(list_t* list, void* element);
int16_t list_index(list_t* list, void* element);
bool list_contains(list_t* list, void* element);
bool list_empty(list_t* list);
#endif
Source
#include <type/list.h>
#include <stdio.h>
#include <stdlib.h>
const uint16_t default_capacity = 256;
struct list_s
{
uint16_t length;
uint16_t capacity;
void** elements;
bool (*element_match )(const void* a, const void* b);
void (*element_delete)(void* element);
};
list_t* list_create(
uint16_t initial_capacity,
bool (*element_match )(const void* a, const void* b),
void (*element_delete)(void* element))
{
list_t* list = (list_t*) malloc(sizeof(list_t));
if (!list) return NULL;
if (!initial_capacity) {
initial_capacity = default_capacity;
}
list->elements = (void**) malloc(sizeof(void*) * initial_capacity);
if (!list->elements) return NULL;
list->length = 0;
list->capacity = initial_capacity;
list->element_match = element_match;
list->element_delete = element_delete;
return list;
}
void list_delete(list_t* list)
{
if (!list) return;
if (list->element_delete) {
unsigned i;
for (i = 0; i< list->length; i++) {
list->element_delete(list->elements[i]);
}
}
else {
fprintf(stderr, "WARNING: no element_delete specified");
}
free(list);
}
bool list_append(list_t* list, void* element)
{
if (!list || !element)
return false;
if (list->length >= list->capacity) {
// expand the elements array
list->capacity *= 2;
list->elements = realloc(list->elements, sizeof(void*) * list->capacity);
if (!list->elements) {
return false;
}
}
list->length += 1;
list->elements[list->length] = element;
return true;
}
void* list_pop(list_t* list)
{
if (!list || list_empty(list)) {
return NULL;
}
void* element = list->elements[list->length];
list->elements[list->length] = NULL;
list->length -= 1;
return element;
}
bool list_remove(list_t* list, void* element)
{
if (!list || !list->element_match) {
return false;
}
unsigned i;
bool found = false;
for (i = 0; i < list->length; i++) {
if (!found && list->element_match(list->elements[i], element)) {
found = true;
list->length -= 1;
}
if (found) {
// shift all subsequent elements back one
list->elements[i] = list->elements[i + 1];
}
}
return found;
}
int16_t list_index(list_t* list, void* element)
{
int16_t i;
for (i = 0; i < list->length; i++) {
if (list->element_match(list->elements[i], element)) {
return i;
}
}
return -1;
}
bool list_contains(list_t* list, void* element) {
return (list_index(list, element) != -1);
}
bool list_empty(list_t* list)
{
return (list->length == 0);
}
beginner c
asked 3 mins ago
Aidenhjj
1,3612516
add a comment |
0
I tried to implement a Python-esque list in C. Having not really used C in anger, I'd like some pointers on style and error handling in particular.
Header
#ifndef __TYPE_LIST_H__
#define __TYPE_LIST_H__
/* Generic list implementation for holding a set of pointers to a type
(has to be consistently handled by the element_match and element_delete
functions)
*/
typedef struct list_s list_t;
#include <stdbool.h>
#include <stdint.h>
extern const uint16_t default_capacity;
list_t* list_create(
uint16_t initial_capacity,
bool (*element_match )(const void* a, const void* b),
void (*element_delete)(void* element));
void list_delete(list_t* list);
bool list_append(list_t* list, void* element);
void* list_pop(list_t* list);
bool list_remove(list_t* list, void* element);
int16_t list_index(list_t* list, void* element);
bool list_contains(list_t* list, void* element);
bool list_empty(list_t* list);
#endif
Source
#include <type/list.h>
#include <stdio.h>
#include <stdlib.h>
const uint16_t default_capacity = 256;
struct list_s
{
uint16_t length;
uint16_t capacity;
void** elements;
bool (*element_match )(const void* a, const void* b);
void (*element_delete)(void* element);
};
list_t* list_create(
uint16_t initial_capacity,
bool (*element_match )(const void* a, const void* b),
void (*element_delete)(void* element))
{
list_t* list = (list_t*) malloc(sizeof(list_t));
if (!list) return NULL;
if (!initial_capacity) {
initial_capacity = default_capacity;
}
list->elements = (void**) malloc(sizeof(void*) * initial_capacity);
if (!list->elements) return NULL;
list->length = 0;
list->capacity = initial_capacity;
list->element_match = element_match;
list->element_delete = element_delete;
return list;
}
void list_delete(list_t* list)
{
if (!list) return;
if (list->element_delete) {
unsigned i;
for (i = 0; i< list->length; i++) {
list->element_delete(list->elements[i]);
}
}
else {
fprintf(stderr, "WARNING: no element_delete specified");
}
free(list);
}
bool list_append(list_t* list, void* element)
{
if (!list || !element)
return false;
if (list->length >= list->capacity) {
// expand the elements array
list->capacity *= 2;
list->elements = realloc(list->elements, sizeof(void*) * list->capacity);
if (!list->elements) {
return false;
}
}
list->length += 1;
list->elements[list->length] = element;
return true;
}
void* list_pop(list_t* list)
{
if (!list || list_empty(list)) {
return NULL;
}
void* element = list->elements[list->length];
list->elements[list->length] = NULL;
list->length -= 1;
return element;
}
bool list_remove(list_t* list, void* element)
{
if (!list || !list->element_match) {
return false;
}
unsigned i;
bool found = false;
for (i = 0; i < list->length; i++) {
if (!found && list->element_match(list->elements[i], element)) {
found = true;
list->length -= 1;
}
if (found) {
// shift all subsequent elements back one
list->elements[i] = list->elements[i + 1];
}
}
return found;
}
int16_t list_index(list_t* list, void* element)
{
int16_t i;
for (i = 0; i < list->length; i++) {
if (list->element_match(list->elements[i], element)) {
return i;
}
}
return -1;
}
bool list_contains(list_t* list, void* element) {
return (list_index(list, element) != -1);
}
bool list_empty(list_t* list)
{
return (list->length == 0);
}
beginner c
asked 3 mins ago
Aidenhjj
1,3612516
add a comment |
0
0
0
I tried to implement a Python-esque list in C. Having not really used C in anger, I'd like some pointers on style and error handling in particular.
Header
#ifndef __TYPE_LIST_H__
#define __TYPE_LIST_H__
/* Generic list implementation for holding a set of pointers to a type
(has to be consistently handled by the element_match and element_delete
functions)
*/
typedef struct list_s list_t;
#include <stdbool.h>
#include <stdint.h>
extern const uint16_t default_capacity;
list_t* list_create(
uint16_t initial_capacity,
bool (*element_match )(const void* a, const void* b),
void (*element_delete)(void* element));
void list_delete(list_t* list);
bool list_append(list_t* list, void* element);
void* list_pop(list_t* list);
bool list_remove(list_t* list, void* element);
int16_t list_index(list_t* list, void* element);
bool list_contains(list_t* list, void* element);
bool list_empty(list_t* list);
#endif
Source
#include <type/list.h>
#include <stdio.h>
#include <stdlib.h>
const uint16_t default_capacity = 256;
struct list_s
{
uint16_t length;
uint16_t capacity;
void** elements;
bool (*element_match )(const void* a, const void* b);
void (*element_delete)(void* element);
};
list_t* list_create(
uint16_t initial_capacity,
bool (*element_match )(const void* a, const void* b),
void (*element_delete)(void* element))
{
list_t* list = (list_t*) malloc(sizeof(list_t));
if (!list) return NULL;
if (!initial_capacity) {
initial_capacity = default_capacity;
}
list->elements = (void**) malloc(sizeof(void*) * initial_capacity);
if (!list->elements) return NULL;
list->length = 0;
list->capacity = initial_capacity;
list->element_match = element_match;
list->element_delete = element_delete;
return list;
}
void list_delete(list_t* list)
{
if (!list) return;
if (list->element_delete) {
unsigned i;
for (i = 0; i< list->length; i++) {
list->element_delete(list->elements[i]);
}
}
else {
fprintf(stderr, "WARNING: no element_delete specified");
}
free(list);
}
bool list_append(list_t* list, void* element)
{
if (!list || !element)
return false;
if (list->length >= list->capacity) {
// expand the elements array
list->capacity *= 2;
list->elements = realloc(list->elements, sizeof(void*) * list->capacity);
if (!list->elements) {
return false;
}
}
list->length += 1;
list->elements[list->length] = element;
return true;
}
void* list_pop(list_t* list)
{
if (!list || list_empty(list)) {
return NULL;
}
void* element = list->elements[list->length];
list->elements[list->length] = NULL;
list->length -= 1;
return element;
}
bool list_remove(list_t* list, void* element)
{
if (!list || !list->element_match) {
return false;
}
unsigned i;
bool found = false;
for (i = 0; i < list->length; i++) {
if (!found && list->element_match(list->elements[i], element)) {
found = true;
list->length -= 1;
}
if (found) {
// shift all subsequent elements back one
list->elements[i] = list->elements[i + 1];
}
}
return found;
}
int16_t list_index(list_t* list, void* element)
{
int16_t i;
for (i = 0; i < list->length; i++) {
if (list->element_match(list->elements[i], element)) {
return i;
}
}
return -1;
}
bool list_contains(list_t* list, void* element) {
return (list_index(list, element) != -1);
}
bool list_empty(list_t* list)
{
return (list->length == 0);
}
beginner c
asked 3 mins ago
Aidenhjj
1,3612516
I tried to implement a Python-esque list in C. Having not really used C in anger, I'd like some pointers on style and error handling in particular.
Header
#ifndef __TYPE_LIST_H__
#define __TYPE_LIST_H__
/* Generic list implementation for holding a set of pointers to a type
(has to be consistently handled by the element_match and element_delete
functions)
*/
typedef struct list_s list_t;
#include <stdbool.h>
#include <stdint.h>
extern const uint16_t default_capacity;
list_t* list_create(
uint16_t initial_capacity,
bool (*element_match )(const void* a, const void* b),
void (*element_delete)(void* element));
void list_delete(list_t* list);
bool list_append(list_t* list, void* element);
void* list_pop(list_t* list);
bool list_remove(list_t* list, void* element);
int16_t list_index(list_t* list, void* element);
bool list_contains(list_t* list, void* element);
bool list_empty(list_t* list);
#endif
Source
#include <type/list.h>
#include <stdio.h>
#include <stdlib.h>
const uint16_t default_capacity = 256;
struct list_s
{
uint16_t length;
uint16_t capacity;
void** elements;
bool (*element_match )(const void* a, const void* b);
void (*element_delete)(void* element);
};
list_t* list_create(
uint16_t initial_capacity,
bool (*element_match )(const void* a, const void* b),
void (*element_delete)(void* element))
{
list_t* list = (list_t*) malloc(sizeof(list_t));
if (!list) return NULL;
if (!initial_capacity) {
initial_capacity = default_capacity;
}
list->elements = (void**) malloc(sizeof(void*) * initial_capacity);
if (!list->elements) return NULL;
list->length = 0;
list->capacity = initial_capacity;
list->element_match = element_match;
list->element_delete = element_delete;
return list;
}
void list_delete(list_t* list)
{
if (!list) return;
if (list->element_delete) {
unsigned i;
for (i = 0; i< list->length; i++) {
list->element_delete(list->elements[i]);
}
}
else {
fprintf(stderr, "WARNING: no element_delete specified");
}
free(list);
}
bool list_append(list_t* list, void* element)
{
if (!list || !element)
return false;
if (list->length >= list->capacity) {
// expand the elements array
list->capacity *= 2;
list->elements = realloc(list->elements, sizeof(void*) * list->capacity);
if (!list->elements) {
return false;
}
}
list->length += 1;
list->elements[list->length] = element;
return true;
}
void* list_pop(list_t* list)
{
if (!list || list_empty(list)) {
return NULL;
}
void* element = list->elements[list->length];
list->elements[list->length] = NULL;
list->length -= 1;
return element;
}
bool list_remove(list_t* list, void* element)
{
if (!list || !list->element_match) {
return false;
}
unsigned i;
bool found = false;
for (i = 0; i < list->length; i++) {
if (!found && list->element_match(list->elements[i], element)) {
found = true;
list->length -= 1;
}
if (found) {
// shift all subsequent elements back one
list->elements[i] = list->elements[i + 1];
}
}
return found;
}
int16_t list_index(list_t* list, void* element)
{
int16_t i;
for (i = 0; i < list->length; i++) {
if (list->element_match(list->elements[i], element)) {
return i;
}
}
return -1;
}
bool list_contains(list_t* list, void* element) {
return (list_index(list, element) != -1);
}
bool list_empty(list_t* list)
{
return (list->length == 0);
}
beginner c
beginner c
asked 3 mins ago
Aidenhjj
1,3612516
asked 3 mins ago
Aidenhjj
1,3612516
asked 3 mins ago
Aidenhjj
1,3612516
asked 3 mins ago
Aidenhjj
1,3612516
asked 3 mins ago
Aidenhjj
1,3612516
1,3612516
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210861%2flist-implementation-in-c%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210861%2flist-implementation-in-c%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
