A simple function that removes empty or tags containing just ' '
I've written a function that should get rid of empty p, span, etc tags and those with just ' ' and am looking for ways to improve it. My original solution was very 'wet', but I've managed to come up with a drier solution.
The Original HTML:
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<div id='test'>
<p>text</p>
<p> </p>
<p>text</p>
<p><span>text</span></p>
<p><span></span></p>
<p>text</p>
<p><strong>text</strong></p>
<p></p>
<p> </p>
<p>text</p>
<p><span><strong> </strong></span></p>
<p><span><strong>text</strong></span></p>
<p> </p>
<p><span>text</span></p>
<p></p>
<p><span></span></p>
<p><span> </span></p>
<p><span><strong></strong></span></p>
<p>text</p>
</div>
My Original Solution:
/*
How to make this drier?
ORIGINAL UNCLEAN SOLUTION
*/
var ps = document.getElementsByTagName('p'),
spans = document.getElementsByTagName('span'),
strongs = document.getElementsByTagName('strong');
for (let el of ps) {
if (el.innerHTML == ' ') { // can't also include if '' at this stage
el.parentNode.removeChild(el);
}
}
for (let el of spans) {
if (el.innerHTML == ' ' || el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
for (let el of strongs) {
if (el.innerHTML == ' ' || el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
for (let el of ps) {
if (el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
My 'drier' solution:
/*
MY CLEANER SOLUTION
*/
var ps = document.getElementsByTagName('p'),
spans = document.getElementsByTagName('span'),
strongs = document.getElementsByTagName('strong');
for (let el of ps) {
cleaner(el);
}
for (let el of spans) {
cleaner(el);
}
for (let el of strongs) {
cleaner(el);
}
function cleaner(el) {
if (el.innerHTML == ' ' || el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
Would someone mind quickly running over both solutions and verifying that my 2nd solution is best? Also, I wonder whether that could be improved, or whether anyone has any better ideas for a solution? Thanks for the help here - for brevity, I'm looking at writing concise but also clear code.
javascript
asked 31 mins ago
user8758206
1763
add a comment |
I've written a function that should get rid of empty p, span, etc tags and those with just ' ' and am looking for ways to improve it. My original solution was very 'wet', but I've managed to come up with a drier solution.
The Original HTML:
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<div id='test'>
<p>text</p>
<p> </p>
<p>text</p>
<p><span>text</span></p>
<p><span></span></p>
<p>text</p>
<p><strong>text</strong></p>
<p></p>
<p> </p>
<p>text</p>
<p><span><strong> </strong></span></p>
<p><span><strong>text</strong></span></p>
<p> </p>
<p><span>text</span></p>
<p></p>
<p><span></span></p>
<p><span> </span></p>
<p><span><strong></strong></span></p>
<p>text</p>
</div>
My Original Solution:
/*
How to make this drier?
ORIGINAL UNCLEAN SOLUTION
*/
var ps = document.getElementsByTagName('p'),
spans = document.getElementsByTagName('span'),
strongs = document.getElementsByTagName('strong');
for (let el of ps) {
if (el.innerHTML == ' ') { // can't also include if '' at this stage
el.parentNode.removeChild(el);
}
}
for (let el of spans) {
if (el.innerHTML == ' ' || el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
for (let el of strongs) {
if (el.innerHTML == ' ' || el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
for (let el of ps) {
if (el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
My 'drier' solution:
/*
MY CLEANER SOLUTION
*/
var ps = document.getElementsByTagName('p'),
spans = document.getElementsByTagName('span'),
strongs = document.getElementsByTagName('strong');
for (let el of ps) {
cleaner(el);
}
for (let el of spans) {
cleaner(el);
}
for (let el of strongs) {
cleaner(el);
}
function cleaner(el) {
if (el.innerHTML == ' ' || el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
Would someone mind quickly running over both solutions and verifying that my 2nd solution is best? Also, I wonder whether that could be improved, or whether anyone has any better ideas for a solution? Thanks for the help here - for brevity, I'm looking at writing concise but also clear code.
javascript
asked 31 mins ago
user8758206
1763
add a comment |
I've written a function that should get rid of empty p, span, etc tags and those with just ' ' and am looking for ways to improve it. My original solution was very 'wet', but I've managed to come up with a drier solution.
The Original HTML:
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<div id='test'>
<p>text</p>
<p> </p>
<p>text</p>
<p><span>text</span></p>
<p><span></span></p>
<p>text</p>
<p><strong>text</strong></p>
<p></p>
<p> </p>
<p>text</p>
<p><span><strong> </strong></span></p>
<p><span><strong>text</strong></span></p>
<p> </p>
<p><span>text</span></p>
<p></p>
<p><span></span></p>
<p><span> </span></p>
<p><span><strong></strong></span></p>
<p>text</p>
</div>
My Original Solution:
/*
How to make this drier?
ORIGINAL UNCLEAN SOLUTION
*/
var ps = document.getElementsByTagName('p'),
spans = document.getElementsByTagName('span'),
strongs = document.getElementsByTagName('strong');
for (let el of ps) {
if (el.innerHTML == ' ') { // can't also include if '' at this stage
el.parentNode.removeChild(el);
}
}
for (let el of spans) {
if (el.innerHTML == ' ' || el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
for (let el of strongs) {
if (el.innerHTML == ' ' || el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
for (let el of ps) {
if (el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
My 'drier' solution:
/*
MY CLEANER SOLUTION
*/
var ps = document.getElementsByTagName('p'),
spans = document.getElementsByTagName('span'),
strongs = document.getElementsByTagName('strong');
for (let el of ps) {
cleaner(el);
}
for (let el of spans) {
cleaner(el);
}
for (let el of strongs) {
cleaner(el);
}
function cleaner(el) {
if (el.innerHTML == ' ' || el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
Would someone mind quickly running over both solutions and verifying that my 2nd solution is best? Also, I wonder whether that could be improved, or whether anyone has any better ideas for a solution? Thanks for the help here - for brevity, I'm looking at writing concise but also clear code.
javascript
asked 31 mins ago
user8758206
1763
I've written a function that should get rid of empty p, span, etc tags and those with just ' ' and am looking for ways to improve it. My original solution was very 'wet', but I've managed to come up with a drier solution.
The Original HTML:
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<div id='test'>
<p>text</p>
<p> </p>
<p>text</p>
<p><span>text</span></p>
<p><span></span></p>
<p>text</p>
<p><strong>text</strong></p>
<p></p>
<p> </p>
<p>text</p>
<p><span><strong> </strong></span></p>
<p><span><strong>text</strong></span></p>
<p> </p>
<p><span>text</span></p>
<p></p>
<p><span></span></p>
<p><span> </span></p>
<p><span><strong></strong></span></p>
<p>text</p>
</div>
My Original Solution:
/*
How to make this drier?
ORIGINAL UNCLEAN SOLUTION
*/
var ps = document.getElementsByTagName('p'),
spans = document.getElementsByTagName('span'),
strongs = document.getElementsByTagName('strong');
for (let el of ps) {
if (el.innerHTML == ' ') { // can't also include if '' at this stage
el.parentNode.removeChild(el);
}
}
for (let el of spans) {
if (el.innerHTML == ' ' || el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
for (let el of strongs) {
if (el.innerHTML == ' ' || el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
for (let el of ps) {
if (el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
My 'drier' solution:
/*
MY CLEANER SOLUTION
*/
var ps = document.getElementsByTagName('p'),
spans = document.getElementsByTagName('span'),
strongs = document.getElementsByTagName('strong');
for (let el of ps) {
cleaner(el);
}
for (let el of spans) {
cleaner(el);
}
for (let el of strongs) {
cleaner(el);
}
function cleaner(el) {
if (el.innerHTML == ' ' || el.innerHTML == '') {
el.parentNode.removeChild(el);
}
}
Would someone mind quickly running over both solutions and verifying that my 2nd solution is best? Also, I wonder whether that could be improved, or whether anyone has any better ideas for a solution? Thanks for the help here - for brevity, I'm looking at writing concise but also clear code.
javascript
javascript
asked 31 mins ago
user8758206
1763
asked 31 mins ago
user8758206
1763
asked 31 mins ago
user8758206
1763
asked 31 mins ago
user8758206
1763
asked 31 mins ago
user8758206
1763
1763
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
You can use querySelectorAll to simplify your code further:
var elements = document.querySelectorAll('p, span, strong'),
for (let el of elements) {
cleaner(el);
}
answered 25 mins ago
Carra
1945
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210883%2fa-simple-function-that-removes-empty-or-tags-containing-just-nbsp%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
You can use querySelectorAll to simplify your code further:
var elements = document.querySelectorAll('p, span, strong'),
for (let el of elements) {
cleaner(el);
}
answered 25 mins ago
Carra
1945
add a comment |
You can use querySelectorAll to simplify your code further:
var elements = document.querySelectorAll('p, span, strong'),
for (let el of elements) {
cleaner(el);
}
answered 25 mins ago
Carra
1945
add a comment |
You can use querySelectorAll to simplify your code further:
var elements = document.querySelectorAll('p, span, strong'),
for (let el of elements) {
cleaner(el);
}
answered 25 mins ago
Carra
1945
You can use querySelectorAll to simplify your code further:
var elements = document.querySelectorAll('p, span, strong'),
for (let el of elements) {
cleaner(el);
}
answered 25 mins ago
Carra
1945
answered 25 mins ago
Carra
1945
answered 25 mins ago
Carra
1945
answered 25 mins ago
Carra
1945
1945
add a comment |
add a comment |
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210883%2fa-simple-function-that-removes-empty-or-tags-containing-just-nbsp%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
