Extracting many files from FTP site
I'm trying to extract all files (XMLs) from an ftp site with python and the ftplib module, but it's incredibly slow so I suspect I'm doing something wrong.
The files are in subfolders, and all at the same "depth" eg: 'startingdir/folder1/place1/file.xml', 'startingdir/folder1/place1/file2.xml', 'startingdir/folder1/place2/file.xml', 'startingdir/folder2/place1/file.xml'
I want to extract everything regardless of location.
As a side note, if this can be put into a function which iterates the process until it finds .xml files in the directory and then extracts those, that would be incredibly helpful (rather than knowing the "depth" and putting the right number of nested for loops).
Code as it stands:
from ftplib import FTP
import os
destination = r'C:Destination'
ftp = FTP('ftp.com')
ftp.login('user','pw')
Once I'm in, I get a list of all the folders in my starting directory:
ftp.cwd('startingdir')
templist =
ftp.retrlines('LIST',templist.append)
subdirlist = [i.split(None,8)[-1].lstrip() for i in templist]
Then, I iterate this process a few times:
for i in subdirlist:
ftp.cwd('startingdir/'+i)
templist =
ftp.retrlines('LIST',templist.append)
subdirlist2 = [i.split(None,8)[-1].lstrip() for i in templist]
for j in subdirlist2:
ftp.cwd('startingdir/'+i)
templist =
ftp.retrlines('LIST',templist.append)
subdirlist3 = [i.split(None,8)[-1].lstrip() for i in templist]
Finally, I extract all files from the right "depth" folder:
for k in subdirlist3:
local_filename = os.path.join(destination,k)
lf = open(local_filename, 'wb')
ftp.retbinary('RETR '+ k, lf.write, 8*1024)
lf.close
The code works, but it's incredibly slow (without counting precisely, it looks like 3-4 files/second). Is there anything obvious I'm doing wrong? Having 4-5 nested for loops doesn't look good, but I don't know how else to achieve this.
Thank you in advance for the suggestions!
python python-3.x ftp
asked 25 mins ago
Jim EisenbergJim Eisenberg
32
add a comment |
I'm trying to extract all files (XMLs) from an ftp site with python and the ftplib module, but it's incredibly slow so I suspect I'm doing something wrong.
The files are in subfolders, and all at the same "depth" eg: 'startingdir/folder1/place1/file.xml', 'startingdir/folder1/place1/file2.xml', 'startingdir/folder1/place2/file.xml', 'startingdir/folder2/place1/file.xml'
I want to extract everything regardless of location.
As a side note, if this can be put into a function which iterates the process until it finds .xml files in the directory and then extracts those, that would be incredibly helpful (rather than knowing the "depth" and putting the right number of nested for loops).
Code as it stands:
from ftplib import FTP
import os
destination = r'C:Destination'
ftp = FTP('ftp.com')
ftp.login('user','pw')
Once I'm in, I get a list of all the folders in my starting directory:
ftp.cwd('startingdir')
templist =
ftp.retrlines('LIST',templist.append)
subdirlist = [i.split(None,8)[-1].lstrip() for i in templist]
Then, I iterate this process a few times:
for i in subdirlist:
ftp.cwd('startingdir/'+i)
templist =
ftp.retrlines('LIST',templist.append)
subdirlist2 = [i.split(None,8)[-1].lstrip() for i in templist]
for j in subdirlist2:
ftp.cwd('startingdir/'+i)
templist =
ftp.retrlines('LIST',templist.append)
subdirlist3 = [i.split(None,8)[-1].lstrip() for i in templist]
Finally, I extract all files from the right "depth" folder:
for k in subdirlist3:
local_filename = os.path.join(destination,k)
lf = open(local_filename, 'wb')
ftp.retbinary('RETR '+ k, lf.write, 8*1024)
lf.close
The code works, but it's incredibly slow (without counting precisely, it looks like 3-4 files/second). Is there anything obvious I'm doing wrong? Having 4-5 nested for loops doesn't look good, but I don't know how else to achieve this.
Thank you in advance for the suggestions!
python python-3.x ftp
asked 25 mins ago
Jim EisenbergJim Eisenberg
32
add a comment |
I'm trying to extract all files (XMLs) from an ftp site with python and the ftplib module, but it's incredibly slow so I suspect I'm doing something wrong.
The files are in subfolders, and all at the same "depth" eg: 'startingdir/folder1/place1/file.xml', 'startingdir/folder1/place1/file2.xml', 'startingdir/folder1/place2/file.xml', 'startingdir/folder2/place1/file.xml'
I want to extract everything regardless of location.
As a side note, if this can be put into a function which iterates the process until it finds .xml files in the directory and then extracts those, that would be incredibly helpful (rather than knowing the "depth" and putting the right number of nested for loops).
Code as it stands:
from ftplib import FTP
import os
destination = r'C:Destination'
ftp = FTP('ftp.com')
ftp.login('user','pw')
Once I'm in, I get a list of all the folders in my starting directory:
ftp.cwd('startingdir')
templist =
ftp.retrlines('LIST',templist.append)
subdirlist = [i.split(None,8)[-1].lstrip() for i in templist]
Then, I iterate this process a few times:
for i in subdirlist:
ftp.cwd('startingdir/'+i)
templist =
ftp.retrlines('LIST',templist.append)
subdirlist2 = [i.split(None,8)[-1].lstrip() for i in templist]
for j in subdirlist2:
ftp.cwd('startingdir/'+i)
templist =
ftp.retrlines('LIST',templist.append)
subdirlist3 = [i.split(None,8)[-1].lstrip() for i in templist]
Finally, I extract all files from the right "depth" folder:
for k in subdirlist3:
local_filename = os.path.join(destination,k)
lf = open(local_filename, 'wb')
ftp.retbinary('RETR '+ k, lf.write, 8*1024)
lf.close
The code works, but it's incredibly slow (without counting precisely, it looks like 3-4 files/second). Is there anything obvious I'm doing wrong? Having 4-5 nested for loops doesn't look good, but I don't know how else to achieve this.
Thank you in advance for the suggestions!
python python-3.x ftp
asked 25 mins ago
Jim EisenbergJim Eisenberg
32
I'm trying to extract all files (XMLs) from an ftp site with python and the ftplib module, but it's incredibly slow so I suspect I'm doing something wrong.
The files are in subfolders, and all at the same "depth" eg: 'startingdir/folder1/place1/file.xml', 'startingdir/folder1/place1/file2.xml', 'startingdir/folder1/place2/file.xml', 'startingdir/folder2/place1/file.xml'
I want to extract everything regardless of location.
As a side note, if this can be put into a function which iterates the process until it finds .xml files in the directory and then extracts those, that would be incredibly helpful (rather than knowing the "depth" and putting the right number of nested for loops).
Code as it stands:
from ftplib import FTP
import os
destination = r'C:Destination'
ftp = FTP('ftp.com')
ftp.login('user','pw')
Once I'm in, I get a list of all the folders in my starting directory:
ftp.cwd('startingdir')
templist =
ftp.retrlines('LIST',templist.append)
subdirlist = [i.split(None,8)[-1].lstrip() for i in templist]
Then, I iterate this process a few times:
for i in subdirlist:
ftp.cwd('startingdir/'+i)
templist =
ftp.retrlines('LIST',templist.append)
subdirlist2 = [i.split(None,8)[-1].lstrip() for i in templist]
for j in subdirlist2:
ftp.cwd('startingdir/'+i)
templist =
ftp.retrlines('LIST',templist.append)
subdirlist3 = [i.split(None,8)[-1].lstrip() for i in templist]
Finally, I extract all files from the right "depth" folder:
for k in subdirlist3:
local_filename = os.path.join(destination,k)
lf = open(local_filename, 'wb')
ftp.retbinary('RETR '+ k, lf.write, 8*1024)
lf.close
The code works, but it's incredibly slow (without counting precisely, it looks like 3-4 files/second). Is there anything obvious I'm doing wrong? Having 4-5 nested for loops doesn't look good, but I don't know how else to achieve this.
Thank you in advance for the suggestions!
python python-3.x ftp
python python-3.x ftp
asked 25 mins ago
Jim EisenbergJim Eisenberg
32
asked 25 mins ago
Jim EisenbergJim Eisenberg
32
asked 25 mins ago
Jim EisenbergJim Eisenberg
32
asked 25 mins ago
Jim EisenbergJim Eisenberg
32
asked 25 mins ago
Jim EisenbergJim Eisenberg
32
32
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211274%2fextracting-many-files-from-ftp-site%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211274%2fextracting-many-files-from-ftp-site%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
