What is the best way to stop thread execution after run method has starting executing












0












$begingroup$


I am trying to stop an executing runnable instance post the run method has been called.



I have come up with the below approach



    public class StoppableWorkflowTask implements Runnable {
volatile Thread runner = null;

@Override
public void run() {
runner = Thread.currentThread();
try {

while (true) {
System.out.println("Stop Thread " + Thread.currentThread().getId());
}

} catch (Exception ex) {
ex.printStackTrace();
}

}

void stop() {
runner.stop();
}

}

public class StoppableWorkflowTaskTest {
public static void main(String args) {
StoppableWorkflowTask stoppableTask = new StoppableWorkflowTask();

Thread thread = new Thread(stoppableTask);

thread.start();
System.out.println(thread.currentThread().getId());

try {
stoppableTask.stop();
} catch (Exception ex) {
ex.printStackTrace();
}

}
}


As per java documention it is unsafe to call thread.stop(). I have checked few examples , but all either use thread.sleep() which can be terminated on interrupt.










share|improve this question









$endgroup$

















    0












    $begingroup$


    I am trying to stop an executing runnable instance post the run method has been called.



    I have come up with the below approach



        public class StoppableWorkflowTask implements Runnable {
    volatile Thread runner = null;

    @Override
    public void run() {
    runner = Thread.currentThread();
    try {

    while (true) {
    System.out.println("Stop Thread " + Thread.currentThread().getId());
    }

    } catch (Exception ex) {
    ex.printStackTrace();
    }

    }

    void stop() {
    runner.stop();
    }

    }

    public class StoppableWorkflowTaskTest {
    public static void main(String args) {
    StoppableWorkflowTask stoppableTask = new StoppableWorkflowTask();

    Thread thread = new Thread(stoppableTask);

    thread.start();
    System.out.println(thread.currentThread().getId());

    try {
    stoppableTask.stop();
    } catch (Exception ex) {
    ex.printStackTrace();
    }

    }
    }


    As per java documention it is unsafe to call thread.stop(). I have checked few examples , but all either use thread.sleep() which can be terminated on interrupt.










    share|improve this question









    $endgroup$















      0












      0








      0





      $begingroup$


      I am trying to stop an executing runnable instance post the run method has been called.



      I have come up with the below approach



          public class StoppableWorkflowTask implements Runnable {
      volatile Thread runner = null;

      @Override
      public void run() {
      runner = Thread.currentThread();
      try {

      while (true) {
      System.out.println("Stop Thread " + Thread.currentThread().getId());
      }

      } catch (Exception ex) {
      ex.printStackTrace();
      }

      }

      void stop() {
      runner.stop();
      }

      }

      public class StoppableWorkflowTaskTest {
      public static void main(String args) {
      StoppableWorkflowTask stoppableTask = new StoppableWorkflowTask();

      Thread thread = new Thread(stoppableTask);

      thread.start();
      System.out.println(thread.currentThread().getId());

      try {
      stoppableTask.stop();
      } catch (Exception ex) {
      ex.printStackTrace();
      }

      }
      }


      As per java documention it is unsafe to call thread.stop(). I have checked few examples , but all either use thread.sleep() which can be terminated on interrupt.










      share|improve this question









      $endgroup$




      I am trying to stop an executing runnable instance post the run method has been called.



      I have come up with the below approach



          public class StoppableWorkflowTask implements Runnable {
      volatile Thread runner = null;

      @Override
      public void run() {
      runner = Thread.currentThread();
      try {

      while (true) {
      System.out.println("Stop Thread " + Thread.currentThread().getId());
      }

      } catch (Exception ex) {
      ex.printStackTrace();
      }

      }

      void stop() {
      runner.stop();
      }

      }

      public class StoppableWorkflowTaskTest {
      public static void main(String args) {
      StoppableWorkflowTask stoppableTask = new StoppableWorkflowTask();

      Thread thread = new Thread(stoppableTask);

      thread.start();
      System.out.println(thread.currentThread().getId());

      try {
      stoppableTask.stop();
      } catch (Exception ex) {
      ex.printStackTrace();
      }

      }
      }


      As per java documention it is unsafe to call thread.stop(). I have checked few examples , but all either use thread.sleep() which can be terminated on interrupt.







      java multithreading






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 10 mins ago









      Maclean PintoMaclean Pinto

      2597




      2597






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214988%2fwhat-is-the-best-way-to-stop-thread-execution-after-run-method-has-starting-exec%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214988%2fwhat-is-the-best-way-to-stop-thread-execution-after-run-method-has-starting-exec%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'