duplicate action on stream redux observable
I got duplicate action firing when I subscribe to a socket io event.
const onStartGameActionEpic = (action$, state$) =>
action$.pipe(
ofType(ON_START_GAME),
mergeMap(() =>
fromEvent(socket, 'newGameCreated').pipe(
map(response => onStartGameFulfilled(response)),
),
),
);
socket.io redux-observable
asked Nov 25 '18 at 13:11
hunghthunght
815
add a comment |
I got duplicate action firing when I subscribe to a socket io event.
const onStartGameActionEpic = (action$, state$) =>
action$.pipe(
ofType(ON_START_GAME),
mergeMap(() =>
fromEvent(socket, 'newGameCreated').pipe(
map(response => onStartGameFulfilled(response)),
),
),
);
socket.io redux-observable
asked Nov 25 '18 at 13:11
hunghthunght
815
add a comment |
I got duplicate action firing when I subscribe to a socket io event.
const onStartGameActionEpic = (action$, state$) =>
action$.pipe(
ofType(ON_START_GAME),
mergeMap(() =>
fromEvent(socket, 'newGameCreated').pipe(
map(response => onStartGameFulfilled(response)),
),
),
);
socket.io redux-observable
asked Nov 25 '18 at 13:11
hunghthunght
815
I got duplicate action firing when I subscribe to a socket io event.
const onStartGameActionEpic = (action$, state$) =>
action$.pipe(
ofType(ON_START_GAME),
mergeMap(() =>
fromEvent(socket, 'newGameCreated').pipe(
map(response => onStartGameFulfilled(response)),
),
),
);
socket.io redux-observable
socket.io redux-observable
asked Nov 25 '18 at 13:11
hunghthunght
815
asked Nov 25 '18 at 13:11
hunghthunght
815
edited Nov 25 '18 at 13:16
hunght
asked Nov 25 '18 at 13:11
hunghthunght
815
asked Nov 25 '18 at 13:11
hunghthunght
815
asked Nov 25 '18 at 13:11
hunghthunght
815
815
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
You're creating a new listener every time ON_START_GAMEoccurs, but you're never killing off the old ones. That's the root of the issue.
Fix 1
Change mergeMap to switchMap.
Fix 2
You might want to have multiple games going at once. If so, assign a namespace prop to your ON_START_GAME action. When the game end action fires, kill off that specific observable.
const onStartGameActionEpic = (action$, state$) =>
action$.pipe(
ofType(ON_START_GAME),
mergeMap(onStartGameAction =>
fromEvent(socket, 'newGameCreated').pipe(
takeUntil(action$.pipe(
ofType(ON_END_GAME),
filter(onEndGameAction => (
endGameAction.namespace === startGameAction.namespace
)),
)),
map(response => onStartGameFulfilled(response)),
),
),
);
answered Nov 25 '18 at 16:44
SawtaytoesSawtaytoes
2,08711833
1
yeah, that's works perfectly for me. thank you!
– hunght
Nov 26 '18 at 0:54
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53467795%2fduplicate-action-on-stream-redux-observable%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
You're creating a new listener every time ON_START_GAMEoccurs, but you're never killing off the old ones. That's the root of the issue.
Fix 1
Change mergeMap to switchMap.
Fix 2
You might want to have multiple games going at once. If so, assign a namespace prop to your ON_START_GAME action. When the game end action fires, kill off that specific observable.
const onStartGameActionEpic = (action$, state$) =>
action$.pipe(
ofType(ON_START_GAME),
mergeMap(onStartGameAction =>
fromEvent(socket, 'newGameCreated').pipe(
takeUntil(action$.pipe(
ofType(ON_END_GAME),
filter(onEndGameAction => (
endGameAction.namespace === startGameAction.namespace
)),
)),
map(response => onStartGameFulfilled(response)),
),
),
);
answered Nov 25 '18 at 16:44
SawtaytoesSawtaytoes
2,08711833
1
yeah, that's works perfectly for me. thank you!
– hunght
Nov 26 '18 at 0:54
add a comment |
You're creating a new listener every time ON_START_GAMEoccurs, but you're never killing off the old ones. That's the root of the issue.
Fix 1
Change mergeMap to switchMap.
Fix 2
You might want to have multiple games going at once. If so, assign a namespace prop to your ON_START_GAME action. When the game end action fires, kill off that specific observable.
const onStartGameActionEpic = (action$, state$) =>
action$.pipe(
ofType(ON_START_GAME),
mergeMap(onStartGameAction =>
fromEvent(socket, 'newGameCreated').pipe(
takeUntil(action$.pipe(
ofType(ON_END_GAME),
filter(onEndGameAction => (
endGameAction.namespace === startGameAction.namespace
)),
)),
map(response => onStartGameFulfilled(response)),
),
),
);
answered Nov 25 '18 at 16:44
SawtaytoesSawtaytoes
2,08711833
1
yeah, that's works perfectly for me. thank you!
– hunght
Nov 26 '18 at 0:54
add a comment |
You're creating a new listener every time ON_START_GAMEoccurs, but you're never killing off the old ones. That's the root of the issue.
Fix 1
Change mergeMap to switchMap.
Fix 2
You might want to have multiple games going at once. If so, assign a namespace prop to your ON_START_GAME action. When the game end action fires, kill off that specific observable.
const onStartGameActionEpic = (action$, state$) =>
action$.pipe(
ofType(ON_START_GAME),
mergeMap(onStartGameAction =>
fromEvent(socket, 'newGameCreated').pipe(
takeUntil(action$.pipe(
ofType(ON_END_GAME),
filter(onEndGameAction => (
endGameAction.namespace === startGameAction.namespace
)),
)),
map(response => onStartGameFulfilled(response)),
),
),
);
answered Nov 25 '18 at 16:44
SawtaytoesSawtaytoes
2,08711833
You're creating a new listener every time ON_START_GAMEoccurs, but you're never killing off the old ones. That's the root of the issue.
Fix 1
Change mergeMap to switchMap.
Fix 2
You might want to have multiple games going at once. If so, assign a namespace prop to your ON_START_GAME action. When the game end action fires, kill off that specific observable.
const onStartGameActionEpic = (action$, state$) =>
action$.pipe(
ofType(ON_START_GAME),
mergeMap(onStartGameAction =>
fromEvent(socket, 'newGameCreated').pipe(
takeUntil(action$.pipe(
ofType(ON_END_GAME),
filter(onEndGameAction => (
endGameAction.namespace === startGameAction.namespace
)),
)),
map(response => onStartGameFulfilled(response)),
),
),
);
answered Nov 25 '18 at 16:44
SawtaytoesSawtaytoes
2,08711833
edited Nov 25 '18 at 17:21
answered Nov 25 '18 at 16:44
SawtaytoesSawtaytoes
2,08711833
answered Nov 25 '18 at 16:44
SawtaytoesSawtaytoes
2,08711833
answered Nov 25 '18 at 16:44
SawtaytoesSawtaytoes
2,08711833
2,08711833
1
yeah, that's works perfectly for me. thank you!
– hunght
Nov 26 '18 at 0:54
add a comment |
1
yeah, that's works perfectly for me. thank you!
– hunght
Nov 26 '18 at 0:54
1
1
yeah, that's works perfectly for me. thank you!
– hunght
Nov 26 '18 at 0:54
yeah, that's works perfectly for me. thank you!
– hunght
Nov 26 '18 at 0:54
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53467795%2fduplicate-action-on-stream-redux-observable%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
