Finding all prime numbers within a range












0












$begingroup$


I am trying to find all primes less than 2,000,000 and sum them together. My code currently takes 1'36" to run. Is there a faster way to get my solution?



The logic I am following in this code is make a list of all primes I have found. Then check that every odd number less than 2,000,000 is not divisible by any of the primes in my list. If that is the case I am calling the number prime.



package main                                          

import ("fmt"
"time"
)

func find_primes(max int) int {
// list of all primes that we find
var primes int
primes = append(primes, 2)

var is_prime = true
for i:=3; i<=max; i++ {
is_prime = false
// only odds can be prime
if i%2 != 0 {
is_prime = true
// should not be divisible by any previous
// prime numbers
for _, x := range primes {
if i%x == 0 {
is_prime = false
break
}
}
}
if is_prime {
primes = append(primes, i)
}
}
return primes
}

// just sume up all of the primes
func sum_primes(primes int) int {
var total int = 0
for _, x := range primes {
total = total + x
}
return total
}

func main() {
start := time.Now()
// find all primes less than 2,000,000
primes := find_primes(2000000)
sum := sum_primes(primes)
fmt.Println(sum)
t := time.Now()
elapsed := t.Sub(start)
fmt.Println(elapsed)
}








share









$endgroup$

















    0












    $begingroup$


    I am trying to find all primes less than 2,000,000 and sum them together. My code currently takes 1'36" to run. Is there a faster way to get my solution?



    The logic I am following in this code is make a list of all primes I have found. Then check that every odd number less than 2,000,000 is not divisible by any of the primes in my list. If that is the case I am calling the number prime.



    package main                                          

    import ("fmt"
    "time"
    )

    func find_primes(max int) int {
    // list of all primes that we find
    var primes int
    primes = append(primes, 2)

    var is_prime = true
    for i:=3; i<=max; i++ {
    is_prime = false
    // only odds can be prime
    if i%2 != 0 {
    is_prime = true
    // should not be divisible by any previous
    // prime numbers
    for _, x := range primes {
    if i%x == 0 {
    is_prime = false
    break
    }
    }
    }
    if is_prime {
    primes = append(primes, i)
    }
    }
    return primes
    }

    // just sume up all of the primes
    func sum_primes(primes int) int {
    var total int = 0
    for _, x := range primes {
    total = total + x
    }
    return total
    }

    func main() {
    start := time.Now()
    // find all primes less than 2,000,000
    primes := find_primes(2000000)
    sum := sum_primes(primes)
    fmt.Println(sum)
    t := time.Now()
    elapsed := t.Sub(start)
    fmt.Println(elapsed)
    }








    share









    $endgroup$















      0












      0








      0





      $begingroup$


      I am trying to find all primes less than 2,000,000 and sum them together. My code currently takes 1'36" to run. Is there a faster way to get my solution?



      The logic I am following in this code is make a list of all primes I have found. Then check that every odd number less than 2,000,000 is not divisible by any of the primes in my list. If that is the case I am calling the number prime.



      package main                                          

      import ("fmt"
      "time"
      )

      func find_primes(max int) int {
      // list of all primes that we find
      var primes int
      primes = append(primes, 2)

      var is_prime = true
      for i:=3; i<=max; i++ {
      is_prime = false
      // only odds can be prime
      if i%2 != 0 {
      is_prime = true
      // should not be divisible by any previous
      // prime numbers
      for _, x := range primes {
      if i%x == 0 {
      is_prime = false
      break
      }
      }
      }
      if is_prime {
      primes = append(primes, i)
      }
      }
      return primes
      }

      // just sume up all of the primes
      func sum_primes(primes int) int {
      var total int = 0
      for _, x := range primes {
      total = total + x
      }
      return total
      }

      func main() {
      start := time.Now()
      // find all primes less than 2,000,000
      primes := find_primes(2000000)
      sum := sum_primes(primes)
      fmt.Println(sum)
      t := time.Now()
      elapsed := t.Sub(start)
      fmt.Println(elapsed)
      }








      share









      $endgroup$




      I am trying to find all primes less than 2,000,000 and sum them together. My code currently takes 1'36" to run. Is there a faster way to get my solution?



      The logic I am following in this code is make a list of all primes I have found. Then check that every odd number less than 2,000,000 is not divisible by any of the primes in my list. If that is the case I am calling the number prime.



      package main                                          

      import ("fmt"
      "time"
      )

      func find_primes(max int) int {
      // list of all primes that we find
      var primes int
      primes = append(primes, 2)

      var is_prime = true
      for i:=3; i<=max; i++ {
      is_prime = false
      // only odds can be prime
      if i%2 != 0 {
      is_prime = true
      // should not be divisible by any previous
      // prime numbers
      for _, x := range primes {
      if i%x == 0 {
      is_prime = false
      break
      }
      }
      }
      if is_prime {
      primes = append(primes, i)
      }
      }
      return primes
      }

      // just sume up all of the primes
      func sum_primes(primes int) int {
      var total int = 0
      for _, x := range primes {
      total = total + x
      }
      return total
      }

      func main() {
      start := time.Now()
      // find all primes less than 2,000,000
      primes := find_primes(2000000)
      sum := sum_primes(primes)
      fmt.Println(sum)
      t := time.Now()
      elapsed := t.Sub(start)
      fmt.Println(elapsed)
      }






      go





      share












      share










      share



      share










      asked 8 mins ago









      The NightmanThe Nightman

      1707




      1707






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212039%2ffinding-all-prime-numbers-within-a-range%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212039%2ffinding-all-prime-numbers-within-a-range%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'