If valid certificate(.pem) file, upload file












0














I want to upload a certificate file only if the credential_type is linux. If it is windows, I don't want to upload the certificate.



class Credential < ApplicationRecord
enum credential_type: { windows: 1, linux: 2 }

validates :user_name, presence: { message: "User name can't be empty" }
validates :credential_type, presence: true
validate :must_be_pem, if: -> { linux? && cert_file_path.present? }

def must_be_pem
cert_error_msg = 'Certificate is not valid'
fm = FileMagic.new(FileMagic::MAGIC_MIME)
if fm.file(cert_file_path) =~ /^text// # text/plain
first_line = File.open(attachment) { |f| f.readline }
if first_line.include? '-----BEGIN RSA PRIVATE KEY-----'
upload_certificate
else
errors.add(:cert_file_path, cert_error_msg)
end
else
errors.add(:cert_file_path, cert_error_msg)
end
end

def upload_certificate
upload_dir = Rails.root.join('private', 'certificates', cert_file_path.original_filename)
File.open(cert_file_path, 'w') { |f| f.write(attachment.read) }
end
end


Do I need to get some code out of the model and put in controller like certificate upload thing or should I use .valid? in controller before saving. Here is my controller code:



def create
@credential = Credential.new(credential_params)
respond_to do |format|
if @credential.save
format.html { redirect_to credentials_url, notice: 'Credential was successfully mapped.' }
format.js
format.json { render :show, status: :created, location: @credential }
else
format.html { render :new }
format.js
format.json { render json: @credential.errors, status: :unprocessable_entity }
end
end
end









share|improve this question



























    0














    I want to upload a certificate file only if the credential_type is linux. If it is windows, I don't want to upload the certificate.



    class Credential < ApplicationRecord
    enum credential_type: { windows: 1, linux: 2 }

    validates :user_name, presence: { message: "User name can't be empty" }
    validates :credential_type, presence: true
    validate :must_be_pem, if: -> { linux? && cert_file_path.present? }

    def must_be_pem
    cert_error_msg = 'Certificate is not valid'
    fm = FileMagic.new(FileMagic::MAGIC_MIME)
    if fm.file(cert_file_path) =~ /^text// # text/plain
    first_line = File.open(attachment) { |f| f.readline }
    if first_line.include? '-----BEGIN RSA PRIVATE KEY-----'
    upload_certificate
    else
    errors.add(:cert_file_path, cert_error_msg)
    end
    else
    errors.add(:cert_file_path, cert_error_msg)
    end
    end

    def upload_certificate
    upload_dir = Rails.root.join('private', 'certificates', cert_file_path.original_filename)
    File.open(cert_file_path, 'w') { |f| f.write(attachment.read) }
    end
    end


    Do I need to get some code out of the model and put in controller like certificate upload thing or should I use .valid? in controller before saving. Here is my controller code:



    def create
    @credential = Credential.new(credential_params)
    respond_to do |format|
    if @credential.save
    format.html { redirect_to credentials_url, notice: 'Credential was successfully mapped.' }
    format.js
    format.json { render :show, status: :created, location: @credential }
    else
    format.html { render :new }
    format.js
    format.json { render json: @credential.errors, status: :unprocessable_entity }
    end
    end
    end









    share|improve this question

























      0












      0








      0







      I want to upload a certificate file only if the credential_type is linux. If it is windows, I don't want to upload the certificate.



      class Credential < ApplicationRecord
      enum credential_type: { windows: 1, linux: 2 }

      validates :user_name, presence: { message: "User name can't be empty" }
      validates :credential_type, presence: true
      validate :must_be_pem, if: -> { linux? && cert_file_path.present? }

      def must_be_pem
      cert_error_msg = 'Certificate is not valid'
      fm = FileMagic.new(FileMagic::MAGIC_MIME)
      if fm.file(cert_file_path) =~ /^text// # text/plain
      first_line = File.open(attachment) { |f| f.readline }
      if first_line.include? '-----BEGIN RSA PRIVATE KEY-----'
      upload_certificate
      else
      errors.add(:cert_file_path, cert_error_msg)
      end
      else
      errors.add(:cert_file_path, cert_error_msg)
      end
      end

      def upload_certificate
      upload_dir = Rails.root.join('private', 'certificates', cert_file_path.original_filename)
      File.open(cert_file_path, 'w') { |f| f.write(attachment.read) }
      end
      end


      Do I need to get some code out of the model and put in controller like certificate upload thing or should I use .valid? in controller before saving. Here is my controller code:



      def create
      @credential = Credential.new(credential_params)
      respond_to do |format|
      if @credential.save
      format.html { redirect_to credentials_url, notice: 'Credential was successfully mapped.' }
      format.js
      format.json { render :show, status: :created, location: @credential }
      else
      format.html { render :new }
      format.js
      format.json { render json: @credential.errors, status: :unprocessable_entity }
      end
      end
      end









      share|improve this question













      I want to upload a certificate file only if the credential_type is linux. If it is windows, I don't want to upload the certificate.



      class Credential < ApplicationRecord
      enum credential_type: { windows: 1, linux: 2 }

      validates :user_name, presence: { message: "User name can't be empty" }
      validates :credential_type, presence: true
      validate :must_be_pem, if: -> { linux? && cert_file_path.present? }

      def must_be_pem
      cert_error_msg = 'Certificate is not valid'
      fm = FileMagic.new(FileMagic::MAGIC_MIME)
      if fm.file(cert_file_path) =~ /^text// # text/plain
      first_line = File.open(attachment) { |f| f.readline }
      if first_line.include? '-----BEGIN RSA PRIVATE KEY-----'
      upload_certificate
      else
      errors.add(:cert_file_path, cert_error_msg)
      end
      else
      errors.add(:cert_file_path, cert_error_msg)
      end
      end

      def upload_certificate
      upload_dir = Rails.root.join('private', 'certificates', cert_file_path.original_filename)
      File.open(cert_file_path, 'w') { |f| f.write(attachment.read) }
      end
      end


      Do I need to get some code out of the model and put in controller like certificate upload thing or should I use .valid? in controller before saving. Here is my controller code:



      def create
      @credential = Credential.new(credential_params)
      respond_to do |format|
      if @credential.save
      format.html { redirect_to credentials_url, notice: 'Credential was successfully mapped.' }
      format.js
      format.json { render :show, status: :created, location: @credential }
      else
      format.html { render :new }
      format.js
      format.json { render json: @credential.errors, status: :unprocessable_entity }
      end
      end
      end






      ruby-on-rails






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 1 hour ago









      Rajkaran MishraRajkaran Mishra

      1242




      1242






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211112%2fif-valid-certificate-pem-file-upload-file%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211112%2fif-valid-certificate-pem-file-upload-file%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          Refactoring coordinates for Minecraft Pi buildings written in Python