Showing a message when the column is true











up vote
0
down vote

favorite












I'm making an app using Rails. I have 4 boolean columns in a table like below, and I want to show a message if that column is true.



class CreatePosts < ActiveRecord::Migration[5.2]
def change
create_table :posts do |t|
t.integer :user_id, null: false, default: 0
t.string :title, null: false, default: ''
t.text :description, null: true
t.boolean :tag_1, null: false, default: false
t.boolean :tag_2, null: false, default: false
t.boolean :tag_3, null: false, default: false
t.boolean :tag_4, null: false, default: false

t.timestamps
end
end




posts_controller.rb



def index
@posts = Post.all
end




index.html.erb



<% @posts.each do |post| %>
<ul>
<% if post.tag_1 %>
<li><%= 'tag_name_A' %></li>
<% end %>
<% if post.tag_2 %>
<li><%= 'tag_name_B' %></li>
<% end %>
<% if post.tag_3 %>
<li><%= 'tag_name_C' %></li>
<% end %>
<% if post.tag_4 %>
<li><%= 'tag_name_D' %></li>
<% end %>
<% if !post.tag_1 && !post.tag_2 && !post.tag_3 && !post.tag_4 %>
<li>none</li>
<% end %>
</ul>
<% end %>


So 'tag_name_A' will be shown if tag_1 is the only true column, and there'll be 'tag_name_B' & 'tag_name_D' shown if tag_2 and tag_4 are both true. (I hope I'm making myself clear.)

These codes are working fine and I'm already getting what I want, but I just don't like how they are written. It looks messy and obviously not smart. (You can tell that I'm a newbie.) How would you optimize them?









share







New contributor




ta539tg70 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
























    up vote
    0
    down vote

    favorite












    I'm making an app using Rails. I have 4 boolean columns in a table like below, and I want to show a message if that column is true.



    class CreatePosts < ActiveRecord::Migration[5.2]
    def change
    create_table :posts do |t|
    t.integer :user_id, null: false, default: 0
    t.string :title, null: false, default: ''
    t.text :description, null: true
    t.boolean :tag_1, null: false, default: false
    t.boolean :tag_2, null: false, default: false
    t.boolean :tag_3, null: false, default: false
    t.boolean :tag_4, null: false, default: false

    t.timestamps
    end
    end




    posts_controller.rb



    def index
    @posts = Post.all
    end




    index.html.erb



    <% @posts.each do |post| %>
    <ul>
    <% if post.tag_1 %>
    <li><%= 'tag_name_A' %></li>
    <% end %>
    <% if post.tag_2 %>
    <li><%= 'tag_name_B' %></li>
    <% end %>
    <% if post.tag_3 %>
    <li><%= 'tag_name_C' %></li>
    <% end %>
    <% if post.tag_4 %>
    <li><%= 'tag_name_D' %></li>
    <% end %>
    <% if !post.tag_1 && !post.tag_2 && !post.tag_3 && !post.tag_4 %>
    <li>none</li>
    <% end %>
    </ul>
    <% end %>


    So 'tag_name_A' will be shown if tag_1 is the only true column, and there'll be 'tag_name_B' & 'tag_name_D' shown if tag_2 and tag_4 are both true. (I hope I'm making myself clear.)

    These codes are working fine and I'm already getting what I want, but I just don't like how they are written. It looks messy and obviously not smart. (You can tell that I'm a newbie.) How would you optimize them?









    share







    New contributor




    ta539tg70 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.






















      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I'm making an app using Rails. I have 4 boolean columns in a table like below, and I want to show a message if that column is true.



      class CreatePosts < ActiveRecord::Migration[5.2]
      def change
      create_table :posts do |t|
      t.integer :user_id, null: false, default: 0
      t.string :title, null: false, default: ''
      t.text :description, null: true
      t.boolean :tag_1, null: false, default: false
      t.boolean :tag_2, null: false, default: false
      t.boolean :tag_3, null: false, default: false
      t.boolean :tag_4, null: false, default: false

      t.timestamps
      end
      end




      posts_controller.rb



      def index
      @posts = Post.all
      end




      index.html.erb



      <% @posts.each do |post| %>
      <ul>
      <% if post.tag_1 %>
      <li><%= 'tag_name_A' %></li>
      <% end %>
      <% if post.tag_2 %>
      <li><%= 'tag_name_B' %></li>
      <% end %>
      <% if post.tag_3 %>
      <li><%= 'tag_name_C' %></li>
      <% end %>
      <% if post.tag_4 %>
      <li><%= 'tag_name_D' %></li>
      <% end %>
      <% if !post.tag_1 && !post.tag_2 && !post.tag_3 && !post.tag_4 %>
      <li>none</li>
      <% end %>
      </ul>
      <% end %>


      So 'tag_name_A' will be shown if tag_1 is the only true column, and there'll be 'tag_name_B' & 'tag_name_D' shown if tag_2 and tag_4 are both true. (I hope I'm making myself clear.)

      These codes are working fine and I'm already getting what I want, but I just don't like how they are written. It looks messy and obviously not smart. (You can tell that I'm a newbie.) How would you optimize them?









      share







      New contributor




      ta539tg70 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      I'm making an app using Rails. I have 4 boolean columns in a table like below, and I want to show a message if that column is true.



      class CreatePosts < ActiveRecord::Migration[5.2]
      def change
      create_table :posts do |t|
      t.integer :user_id, null: false, default: 0
      t.string :title, null: false, default: ''
      t.text :description, null: true
      t.boolean :tag_1, null: false, default: false
      t.boolean :tag_2, null: false, default: false
      t.boolean :tag_3, null: false, default: false
      t.boolean :tag_4, null: false, default: false

      t.timestamps
      end
      end




      posts_controller.rb



      def index
      @posts = Post.all
      end




      index.html.erb



      <% @posts.each do |post| %>
      <ul>
      <% if post.tag_1 %>
      <li><%= 'tag_name_A' %></li>
      <% end %>
      <% if post.tag_2 %>
      <li><%= 'tag_name_B' %></li>
      <% end %>
      <% if post.tag_3 %>
      <li><%= 'tag_name_C' %></li>
      <% end %>
      <% if post.tag_4 %>
      <li><%= 'tag_name_D' %></li>
      <% end %>
      <% if !post.tag_1 && !post.tag_2 && !post.tag_3 && !post.tag_4 %>
      <li>none</li>
      <% end %>
      </ul>
      <% end %>


      So 'tag_name_A' will be shown if tag_1 is the only true column, and there'll be 'tag_name_B' & 'tag_name_D' shown if tag_2 and tag_4 are both true. (I hope I'm making myself clear.)

      These codes are working fine and I'm already getting what I want, but I just don't like how they are written. It looks messy and obviously not smart. (You can tell that I'm a newbie.) How would you optimize them?







      ruby-on-rails





      share







      New contributor




      ta539tg70 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      ta539tg70 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      ta539tg70 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 3 mins ago









      ta539tg70

      1




      1




      New contributor




      ta539tg70 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      ta539tg70 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      ta539tg70 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          ta539tg70 is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208853%2fshowing-a-message-when-the-column-is-true%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          ta539tg70 is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          ta539tg70 is a new contributor. Be nice, and check out our Code of Conduct.













          ta539tg70 is a new contributor. Be nice, and check out our Code of Conduct.












          ta539tg70 is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208853%2fshowing-a-message-when-the-column-is-true%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          Refactoring coordinates for Minecraft Pi buildings written in Python