Conway's Game of Life in C (3 mode)











up vote
1
down vote

favorite












This is my program for the Game of life, I created it by myself with no reference or peers review so i need some comments and reviews on it.
I created 3 mode:



A. User Mode:
The program asks the user to enter the coordinates (x,y) where live creatures are to be
placed on the board, until the user enters a negative coordinate.



B. Automatic Mode:
The program randomly populates the board with creatures, each cell having a 1 in 10
chance of containing a creature.



C. Hybrid Mode:
After having automatically populated the board, allow the user to modify it.



How can I improve this? And I'm also working on a function to detect "steady" state. If anyone have any idea please suggest. Thank you very much.



/**Conway's Game of Life**/
#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#include <conio.h>

const int WIDTH = 67;
const int HEIGHT = 47;
const int TRUE = 1;
const int FALSE = 0;

void makingboundarylines (int board[HEIGHT][WIDTH])
{
int cols, rows;
for (cols =0; cols <WIDTH; cols++)
{
board[0][cols] = '_';
board[HEIGHT -1][cols]= '_';
}
for (rows =1; rows <HEIGHT; rows++)
{
board[rows][0] = '|';
board[rows][WIDTH -1] = '|';
}
}
void fillarray(int board[HEIGHT][WIDTH])
{
int i,j;
for(i =1; i <HEIGHT-1; i++)
for(j=1; j <WIDTH-1; j++)
board[i][j] = ' ';
}
void fillarrayrandomly(int board[HEIGHT][WIDTH])
{
int i, j, num;
srand((unsigned)time(NULL));
for(i =1; i <HEIGHT -1; i++)
for(j=1; j <WIDTH -1;j++)
{
num = rand()%11;
if (num == 1)
board[i][j] = 'O';
else board[i][j] = ' ';
}
}
void display2Darray(int board[HEIGHT][WIDTH])
{
int rows;
int cols;
for (rows = 0; rows <HEIGHT; rows++)
{
for(cols =0; cols <WIDTH; cols++)
printf ("%3c", board[rows][cols]);
printf ("n");
}
}
void countneighbors (int board[HEIGHT][WIDTH])
{
int neighbors;
int rows;
int cols;
int a, b;
for (rows =1; rows <HEIGHT; rows++)
{
for (cols = 1; cols <WIDTH; cols ++)
{
neighbors = 0;
if (board[rows][cols] == 'O')
{
for (a = -1; a <2; a++)
{
for (b = -1; b <2; b++)
if (((rows +a) == rows) && ((cols +b) == cols))
neighbors = neighbors;
else if ((board[rows +a][cols +b] == 'O') ||(board[rows +a][cols +b] == 1) || (board[rows +a][cols +b] == 0))
neighbors++;
}
if ((neighbors == 2) || (neighbors == 3))
board[rows][cols] = 1; /*live*/
else if ((neighbors < 2) || (neighbors >= 4))
board[rows][cols] = 0; /*die*/
}
}
}
}
void checknewborns (int board[HEIGHT][WIDTH])
{
int neighbors;
int rows;
int cols;
int a, b;
for (rows =1; rows <HEIGHT -1; rows++)
{
for (cols = 1; cols <WIDTH -1; cols ++)
{
neighbors = 0;
if (board[rows][cols] == ' ')
{
for (a = -1; a <2; a++)
{
for (b = -1; b <2; b++)
if (((rows +a) == rows) && ((cols +b) == cols))
neighbors = neighbors;
else if ((board[rows +a][cols +b] == 'O') || (board[rows +a][cols +b] == 1) || (board[rows +a][cols +b] == 0))
neighbors++;
}
if ((neighbors == 3))
board[rows][cols] = 2; /*newborn*/
}
}
}
}
void anewgeneration (int board[HEIGHT][WIDTH])
{
int rows;
int cols;
for (rows =1; rows <HEIGHT -1; rows++)
{
for (cols = 1; cols <WIDTH -1; cols ++)
{
if (board[rows][cols] == 1)
board[rows][cols] = 'O';
else if (board[rows][cols] == 2)
board[rows][cols] = 'O';
else if (board[rows][cols] == 0)
board[rows][cols] = ' ';
}
}
}
int checkforexistence (int board[HEIGHT][WIDTH])
{
int rows;
int cols;
int creatures =0;
for (rows =1; rows <HEIGHT -1; rows++)
{
for (cols = 1; cols <WIDTH -1; cols ++)
{
if (board[rows][cols] == 'O')
creatures++;
}
}
if (creatures == 0)
return TRUE; /*all creatures died*/
else return FALSE; /*there are still living creatures*/
}
void playgame (int board[HEIGHT][WIDTH], int numgeneration)
{
int i, c, check;
for (i = 1; (i <= numgeneration) && (c != 32); i++)
{
system("cls");
countneighbors(board);
checknewborns(board);
anewgeneration(board);
printf ("Generation: %in", i);
printf ("Hit enter to move to the next generationn");
display2Darray(board);
if(kbhit())
{
c = getch();
if(c == 32)
break;
}
check = checkforexistence(board);
if ((check= checkforexistence(board)) ==TRUE)
{
printf ("nALL CREATURES HAVE DIED: GAME OVER");
c = 32;
}
}
}
int returnnumber(int anumber)
{
if ((anumber >50) || (anumber ==0))
{
printf ("ERROR! The number must be between 1 and 50n");
printf ("Please enter a valid number!: ");
scanf ("%i", &anumber);
returnnumber(anumber);
}
else
return anumber;
}
void entercoordinates (int board[HEIGHT][WIDTH])
{
int rows = 1;
int cols =1;
while ((rows >0) && (cols >0))
{
printf ("nPlease enter x coordinate(a number from 1 to 30): ");
scanf("%i", &cols);
cols = returnnumber(cols);
if (cols >0)
{
printf ("Please enter y coordinate(a number from 1 to 50): ");
scanf("%i", &rows);
rows = returnnumber(rows);
if ((rows >0) && (cols >0))
board[rows][cols] = 'O';
}
}
}
void creatingpatterntypes(int board[HEIGHT][WIDTH])
{
int type;
printf ("nEnter <1> for creating a BOX");
printf ("nEnter <2> for creating a BEEHIVE");
printf ("nEnter <3> for creating a TOAD");
printf ("nEnter <4> for creating a SHIP");
printf ("nEnter <5> for creating a GLIDER");
printf ("nEnter <6> for creating a QUEEN BEE SHUTTLE");
printf ("nEnter <7> for creating a PULSAR");
printf ("nEnter <8> for creating a BLINKER");
printf ("nEnter <9> for creating a PENTADECATHLONn");
scanf ("%i", &type);

if (type == 1)
{
board[10][10] = 'O';
board[10][11] = 'O';
board[11][10] = 'O';
board[11][11] = 'O';
}
else if (type == 9)
{
board[15][10] = 'O';
board[15][11] = 'O';
board[15][12] = 'O';
board[15][13] = 'O';
board[15][14] = 'O';
board[15][15] = 'O';
board[15][16] = 'O';
board[15][17] = 'O';
board[15][18] = 'O';
board[15][19] = 'O';
}
else if (type == 5)
{
board[28][3] = 'O';
board[27][4] = 'O';
board[26][4] = 'O';
board[27][5] = 'O';
board[28][5] = 'O';
}
else if (type == 3)
{
board[18][12] = 'O';
board[18][13] = 'O';
board[18][14] = 'O';
board[19][11] = 'O';
board[19][12] = 'O';
board[19][13] = 'O';
}
else if (type == 6)
{
board[20][28] = 'O';
board[20][29] = 'O';
board[21][30] = 'O';
board[22][31] = 'O';
board[23][31] = 'O';
board[24][31] = 'O';
board[25][30] = 'O';
board[26][29] = 'O';
board[26][28] = 'O';
}
else if (type == 7)
{
board[12][14] = 'O';
board[13][13] = 'O';
board[13][14] = 'O';
board[13][15] = 'O';
board[14][13] = 'O';
board[14][15] = 'O';
board[15][13] = 'O';
board[15][14] = 'O';
board[15][15] = 'O';
board[16][14] = 'O';
}
else if (type == 8)
{
board[12][12] = 'O';
board[12][13] = 'O';
board[12][14] = 'O';
}
else if (type == 4)
{
board[12][12] = 'O';
board[12][13] = 'O';
board[13][12] = 'O';
board[14][13] = 'O';
board[14][14] = 'O';
board[13][14] = 'O';
}
else if (type ==2)
{
board[12][14] = 'O';
board[13][13] = 'O';
board[13][15] = 'O';
board[14][13] = 'O';
board[15][14] = 'O';
board[14][15] = 'O';
}
}
void usermode(int board[HEIGHT][WIDTH])
{
int i, generation, c, choice;
printf ("nDo you want to insert a particular pattern type? <1> for yes and <0> for no: ");
scanf ("%i", &choice);
if (choice == 1)
{
creatingpatterntypes(board);
display2Darray(board);
}
else
{
entercoordinates(board);
display2Darray(board);
}

printf ("nPlease select a number of generation: ");
scanf ("%i", &generation);

playgame(board, generation);
}
void automaticmode(int board[HEIGHT][WIDTH])
{
int i, generation, c;
fillarrayrandomly(board);
display2Darray(board);
printf ("nPlease select a number of generation: ");
scanf ("%i", &generation);

playgame(board, generation);
}
void hybridmode (int board[HEIGHT][WIDTH])
{
int i, generation, c;
fillarrayrandomly(board);
display2Darray(board);
entercoordinates(board);
system("cls");
display2Darray(board);

printf ("nPlease select a number of generation: ");
scanf ("%i", &generation);

playgame(board, generation);
}

int main (void)
{
//printf ("hello. worldn");
int board[HEIGHT][WIDTH], mode;
makingboundarylines(board);
fillarray(board);

printf ("CONWAY'S GAME OF LIFEnn");
printf ("Please hit space to terminate the program, hit enter to move to the next generationn");
printf ("Please enter <1> for User Mode, <2> for Automatic Mode and <3> for Hybrid Mode: ");
scanf ("%i", &mode);

if (mode == 1)
usermode(board);
else if (mode == 2)
automaticmode(board);
else if (mode ==3)
hybridmode(board);

return 0;
}









share|improve this question









New contributor




Huỳnh Quang Huy is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
























    up vote
    1
    down vote

    favorite












    This is my program for the Game of life, I created it by myself with no reference or peers review so i need some comments and reviews on it.
    I created 3 mode:



    A. User Mode:
    The program asks the user to enter the coordinates (x,y) where live creatures are to be
    placed on the board, until the user enters a negative coordinate.



    B. Automatic Mode:
    The program randomly populates the board with creatures, each cell having a 1 in 10
    chance of containing a creature.



    C. Hybrid Mode:
    After having automatically populated the board, allow the user to modify it.



    How can I improve this? And I'm also working on a function to detect "steady" state. If anyone have any idea please suggest. Thank you very much.



    /**Conway's Game of Life**/
    #include <stdio.h>
    #include <stdlib.h>
    #include <time.h>
    #include <conio.h>

    const int WIDTH = 67;
    const int HEIGHT = 47;
    const int TRUE = 1;
    const int FALSE = 0;

    void makingboundarylines (int board[HEIGHT][WIDTH])
    {
    int cols, rows;
    for (cols =0; cols <WIDTH; cols++)
    {
    board[0][cols] = '_';
    board[HEIGHT -1][cols]= '_';
    }
    for (rows =1; rows <HEIGHT; rows++)
    {
    board[rows][0] = '|';
    board[rows][WIDTH -1] = '|';
    }
    }
    void fillarray(int board[HEIGHT][WIDTH])
    {
    int i,j;
    for(i =1; i <HEIGHT-1; i++)
    for(j=1; j <WIDTH-1; j++)
    board[i][j] = ' ';
    }
    void fillarrayrandomly(int board[HEIGHT][WIDTH])
    {
    int i, j, num;
    srand((unsigned)time(NULL));
    for(i =1; i <HEIGHT -1; i++)
    for(j=1; j <WIDTH -1;j++)
    {
    num = rand()%11;
    if (num == 1)
    board[i][j] = 'O';
    else board[i][j] = ' ';
    }
    }
    void display2Darray(int board[HEIGHT][WIDTH])
    {
    int rows;
    int cols;
    for (rows = 0; rows <HEIGHT; rows++)
    {
    for(cols =0; cols <WIDTH; cols++)
    printf ("%3c", board[rows][cols]);
    printf ("n");
    }
    }
    void countneighbors (int board[HEIGHT][WIDTH])
    {
    int neighbors;
    int rows;
    int cols;
    int a, b;
    for (rows =1; rows <HEIGHT; rows++)
    {
    for (cols = 1; cols <WIDTH; cols ++)
    {
    neighbors = 0;
    if (board[rows][cols] == 'O')
    {
    for (a = -1; a <2; a++)
    {
    for (b = -1; b <2; b++)
    if (((rows +a) == rows) && ((cols +b) == cols))
    neighbors = neighbors;
    else if ((board[rows +a][cols +b] == 'O') ||(board[rows +a][cols +b] == 1) || (board[rows +a][cols +b] == 0))
    neighbors++;
    }
    if ((neighbors == 2) || (neighbors == 3))
    board[rows][cols] = 1; /*live*/
    else if ((neighbors < 2) || (neighbors >= 4))
    board[rows][cols] = 0; /*die*/
    }
    }
    }
    }
    void checknewborns (int board[HEIGHT][WIDTH])
    {
    int neighbors;
    int rows;
    int cols;
    int a, b;
    for (rows =1; rows <HEIGHT -1; rows++)
    {
    for (cols = 1; cols <WIDTH -1; cols ++)
    {
    neighbors = 0;
    if (board[rows][cols] == ' ')
    {
    for (a = -1; a <2; a++)
    {
    for (b = -1; b <2; b++)
    if (((rows +a) == rows) && ((cols +b) == cols))
    neighbors = neighbors;
    else if ((board[rows +a][cols +b] == 'O') || (board[rows +a][cols +b] == 1) || (board[rows +a][cols +b] == 0))
    neighbors++;
    }
    if ((neighbors == 3))
    board[rows][cols] = 2; /*newborn*/
    }
    }
    }
    }
    void anewgeneration (int board[HEIGHT][WIDTH])
    {
    int rows;
    int cols;
    for (rows =1; rows <HEIGHT -1; rows++)
    {
    for (cols = 1; cols <WIDTH -1; cols ++)
    {
    if (board[rows][cols] == 1)
    board[rows][cols] = 'O';
    else if (board[rows][cols] == 2)
    board[rows][cols] = 'O';
    else if (board[rows][cols] == 0)
    board[rows][cols] = ' ';
    }
    }
    }
    int checkforexistence (int board[HEIGHT][WIDTH])
    {
    int rows;
    int cols;
    int creatures =0;
    for (rows =1; rows <HEIGHT -1; rows++)
    {
    for (cols = 1; cols <WIDTH -1; cols ++)
    {
    if (board[rows][cols] == 'O')
    creatures++;
    }
    }
    if (creatures == 0)
    return TRUE; /*all creatures died*/
    else return FALSE; /*there are still living creatures*/
    }
    void playgame (int board[HEIGHT][WIDTH], int numgeneration)
    {
    int i, c, check;
    for (i = 1; (i <= numgeneration) && (c != 32); i++)
    {
    system("cls");
    countneighbors(board);
    checknewborns(board);
    anewgeneration(board);
    printf ("Generation: %in", i);
    printf ("Hit enter to move to the next generationn");
    display2Darray(board);
    if(kbhit())
    {
    c = getch();
    if(c == 32)
    break;
    }
    check = checkforexistence(board);
    if ((check= checkforexistence(board)) ==TRUE)
    {
    printf ("nALL CREATURES HAVE DIED: GAME OVER");
    c = 32;
    }
    }
    }
    int returnnumber(int anumber)
    {
    if ((anumber >50) || (anumber ==0))
    {
    printf ("ERROR! The number must be between 1 and 50n");
    printf ("Please enter a valid number!: ");
    scanf ("%i", &anumber);
    returnnumber(anumber);
    }
    else
    return anumber;
    }
    void entercoordinates (int board[HEIGHT][WIDTH])
    {
    int rows = 1;
    int cols =1;
    while ((rows >0) && (cols >0))
    {
    printf ("nPlease enter x coordinate(a number from 1 to 30): ");
    scanf("%i", &cols);
    cols = returnnumber(cols);
    if (cols >0)
    {
    printf ("Please enter y coordinate(a number from 1 to 50): ");
    scanf("%i", &rows);
    rows = returnnumber(rows);
    if ((rows >0) && (cols >0))
    board[rows][cols] = 'O';
    }
    }
    }
    void creatingpatterntypes(int board[HEIGHT][WIDTH])
    {
    int type;
    printf ("nEnter <1> for creating a BOX");
    printf ("nEnter <2> for creating a BEEHIVE");
    printf ("nEnter <3> for creating a TOAD");
    printf ("nEnter <4> for creating a SHIP");
    printf ("nEnter <5> for creating a GLIDER");
    printf ("nEnter <6> for creating a QUEEN BEE SHUTTLE");
    printf ("nEnter <7> for creating a PULSAR");
    printf ("nEnter <8> for creating a BLINKER");
    printf ("nEnter <9> for creating a PENTADECATHLONn");
    scanf ("%i", &type);

    if (type == 1)
    {
    board[10][10] = 'O';
    board[10][11] = 'O';
    board[11][10] = 'O';
    board[11][11] = 'O';
    }
    else if (type == 9)
    {
    board[15][10] = 'O';
    board[15][11] = 'O';
    board[15][12] = 'O';
    board[15][13] = 'O';
    board[15][14] = 'O';
    board[15][15] = 'O';
    board[15][16] = 'O';
    board[15][17] = 'O';
    board[15][18] = 'O';
    board[15][19] = 'O';
    }
    else if (type == 5)
    {
    board[28][3] = 'O';
    board[27][4] = 'O';
    board[26][4] = 'O';
    board[27][5] = 'O';
    board[28][5] = 'O';
    }
    else if (type == 3)
    {
    board[18][12] = 'O';
    board[18][13] = 'O';
    board[18][14] = 'O';
    board[19][11] = 'O';
    board[19][12] = 'O';
    board[19][13] = 'O';
    }
    else if (type == 6)
    {
    board[20][28] = 'O';
    board[20][29] = 'O';
    board[21][30] = 'O';
    board[22][31] = 'O';
    board[23][31] = 'O';
    board[24][31] = 'O';
    board[25][30] = 'O';
    board[26][29] = 'O';
    board[26][28] = 'O';
    }
    else if (type == 7)
    {
    board[12][14] = 'O';
    board[13][13] = 'O';
    board[13][14] = 'O';
    board[13][15] = 'O';
    board[14][13] = 'O';
    board[14][15] = 'O';
    board[15][13] = 'O';
    board[15][14] = 'O';
    board[15][15] = 'O';
    board[16][14] = 'O';
    }
    else if (type == 8)
    {
    board[12][12] = 'O';
    board[12][13] = 'O';
    board[12][14] = 'O';
    }
    else if (type == 4)
    {
    board[12][12] = 'O';
    board[12][13] = 'O';
    board[13][12] = 'O';
    board[14][13] = 'O';
    board[14][14] = 'O';
    board[13][14] = 'O';
    }
    else if (type ==2)
    {
    board[12][14] = 'O';
    board[13][13] = 'O';
    board[13][15] = 'O';
    board[14][13] = 'O';
    board[15][14] = 'O';
    board[14][15] = 'O';
    }
    }
    void usermode(int board[HEIGHT][WIDTH])
    {
    int i, generation, c, choice;
    printf ("nDo you want to insert a particular pattern type? <1> for yes and <0> for no: ");
    scanf ("%i", &choice);
    if (choice == 1)
    {
    creatingpatterntypes(board);
    display2Darray(board);
    }
    else
    {
    entercoordinates(board);
    display2Darray(board);
    }

    printf ("nPlease select a number of generation: ");
    scanf ("%i", &generation);

    playgame(board, generation);
    }
    void automaticmode(int board[HEIGHT][WIDTH])
    {
    int i, generation, c;
    fillarrayrandomly(board);
    display2Darray(board);
    printf ("nPlease select a number of generation: ");
    scanf ("%i", &generation);

    playgame(board, generation);
    }
    void hybridmode (int board[HEIGHT][WIDTH])
    {
    int i, generation, c;
    fillarrayrandomly(board);
    display2Darray(board);
    entercoordinates(board);
    system("cls");
    display2Darray(board);

    printf ("nPlease select a number of generation: ");
    scanf ("%i", &generation);

    playgame(board, generation);
    }

    int main (void)
    {
    //printf ("hello. worldn");
    int board[HEIGHT][WIDTH], mode;
    makingboundarylines(board);
    fillarray(board);

    printf ("CONWAY'S GAME OF LIFEnn");
    printf ("Please hit space to terminate the program, hit enter to move to the next generationn");
    printf ("Please enter <1> for User Mode, <2> for Automatic Mode and <3> for Hybrid Mode: ");
    scanf ("%i", &mode);

    if (mode == 1)
    usermode(board);
    else if (mode == 2)
    automaticmode(board);
    else if (mode ==3)
    hybridmode(board);

    return 0;
    }









    share|improve this question









    New contributor




    Huỳnh Quang Huy is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.






















      up vote
      1
      down vote

      favorite









      up vote
      1
      down vote

      favorite











      This is my program for the Game of life, I created it by myself with no reference or peers review so i need some comments and reviews on it.
      I created 3 mode:



      A. User Mode:
      The program asks the user to enter the coordinates (x,y) where live creatures are to be
      placed on the board, until the user enters a negative coordinate.



      B. Automatic Mode:
      The program randomly populates the board with creatures, each cell having a 1 in 10
      chance of containing a creature.



      C. Hybrid Mode:
      After having automatically populated the board, allow the user to modify it.



      How can I improve this? And I'm also working on a function to detect "steady" state. If anyone have any idea please suggest. Thank you very much.



      /**Conway's Game of Life**/
      #include <stdio.h>
      #include <stdlib.h>
      #include <time.h>
      #include <conio.h>

      const int WIDTH = 67;
      const int HEIGHT = 47;
      const int TRUE = 1;
      const int FALSE = 0;

      void makingboundarylines (int board[HEIGHT][WIDTH])
      {
      int cols, rows;
      for (cols =0; cols <WIDTH; cols++)
      {
      board[0][cols] = '_';
      board[HEIGHT -1][cols]= '_';
      }
      for (rows =1; rows <HEIGHT; rows++)
      {
      board[rows][0] = '|';
      board[rows][WIDTH -1] = '|';
      }
      }
      void fillarray(int board[HEIGHT][WIDTH])
      {
      int i,j;
      for(i =1; i <HEIGHT-1; i++)
      for(j=1; j <WIDTH-1; j++)
      board[i][j] = ' ';
      }
      void fillarrayrandomly(int board[HEIGHT][WIDTH])
      {
      int i, j, num;
      srand((unsigned)time(NULL));
      for(i =1; i <HEIGHT -1; i++)
      for(j=1; j <WIDTH -1;j++)
      {
      num = rand()%11;
      if (num == 1)
      board[i][j] = 'O';
      else board[i][j] = ' ';
      }
      }
      void display2Darray(int board[HEIGHT][WIDTH])
      {
      int rows;
      int cols;
      for (rows = 0; rows <HEIGHT; rows++)
      {
      for(cols =0; cols <WIDTH; cols++)
      printf ("%3c", board[rows][cols]);
      printf ("n");
      }
      }
      void countneighbors (int board[HEIGHT][WIDTH])
      {
      int neighbors;
      int rows;
      int cols;
      int a, b;
      for (rows =1; rows <HEIGHT; rows++)
      {
      for (cols = 1; cols <WIDTH; cols ++)
      {
      neighbors = 0;
      if (board[rows][cols] == 'O')
      {
      for (a = -1; a <2; a++)
      {
      for (b = -1; b <2; b++)
      if (((rows +a) == rows) && ((cols +b) == cols))
      neighbors = neighbors;
      else if ((board[rows +a][cols +b] == 'O') ||(board[rows +a][cols +b] == 1) || (board[rows +a][cols +b] == 0))
      neighbors++;
      }
      if ((neighbors == 2) || (neighbors == 3))
      board[rows][cols] = 1; /*live*/
      else if ((neighbors < 2) || (neighbors >= 4))
      board[rows][cols] = 0; /*die*/
      }
      }
      }
      }
      void checknewborns (int board[HEIGHT][WIDTH])
      {
      int neighbors;
      int rows;
      int cols;
      int a, b;
      for (rows =1; rows <HEIGHT -1; rows++)
      {
      for (cols = 1; cols <WIDTH -1; cols ++)
      {
      neighbors = 0;
      if (board[rows][cols] == ' ')
      {
      for (a = -1; a <2; a++)
      {
      for (b = -1; b <2; b++)
      if (((rows +a) == rows) && ((cols +b) == cols))
      neighbors = neighbors;
      else if ((board[rows +a][cols +b] == 'O') || (board[rows +a][cols +b] == 1) || (board[rows +a][cols +b] == 0))
      neighbors++;
      }
      if ((neighbors == 3))
      board[rows][cols] = 2; /*newborn*/
      }
      }
      }
      }
      void anewgeneration (int board[HEIGHT][WIDTH])
      {
      int rows;
      int cols;
      for (rows =1; rows <HEIGHT -1; rows++)
      {
      for (cols = 1; cols <WIDTH -1; cols ++)
      {
      if (board[rows][cols] == 1)
      board[rows][cols] = 'O';
      else if (board[rows][cols] == 2)
      board[rows][cols] = 'O';
      else if (board[rows][cols] == 0)
      board[rows][cols] = ' ';
      }
      }
      }
      int checkforexistence (int board[HEIGHT][WIDTH])
      {
      int rows;
      int cols;
      int creatures =0;
      for (rows =1; rows <HEIGHT -1; rows++)
      {
      for (cols = 1; cols <WIDTH -1; cols ++)
      {
      if (board[rows][cols] == 'O')
      creatures++;
      }
      }
      if (creatures == 0)
      return TRUE; /*all creatures died*/
      else return FALSE; /*there are still living creatures*/
      }
      void playgame (int board[HEIGHT][WIDTH], int numgeneration)
      {
      int i, c, check;
      for (i = 1; (i <= numgeneration) && (c != 32); i++)
      {
      system("cls");
      countneighbors(board);
      checknewborns(board);
      anewgeneration(board);
      printf ("Generation: %in", i);
      printf ("Hit enter to move to the next generationn");
      display2Darray(board);
      if(kbhit())
      {
      c = getch();
      if(c == 32)
      break;
      }
      check = checkforexistence(board);
      if ((check= checkforexistence(board)) ==TRUE)
      {
      printf ("nALL CREATURES HAVE DIED: GAME OVER");
      c = 32;
      }
      }
      }
      int returnnumber(int anumber)
      {
      if ((anumber >50) || (anumber ==0))
      {
      printf ("ERROR! The number must be between 1 and 50n");
      printf ("Please enter a valid number!: ");
      scanf ("%i", &anumber);
      returnnumber(anumber);
      }
      else
      return anumber;
      }
      void entercoordinates (int board[HEIGHT][WIDTH])
      {
      int rows = 1;
      int cols =1;
      while ((rows >0) && (cols >0))
      {
      printf ("nPlease enter x coordinate(a number from 1 to 30): ");
      scanf("%i", &cols);
      cols = returnnumber(cols);
      if (cols >0)
      {
      printf ("Please enter y coordinate(a number from 1 to 50): ");
      scanf("%i", &rows);
      rows = returnnumber(rows);
      if ((rows >0) && (cols >0))
      board[rows][cols] = 'O';
      }
      }
      }
      void creatingpatterntypes(int board[HEIGHT][WIDTH])
      {
      int type;
      printf ("nEnter <1> for creating a BOX");
      printf ("nEnter <2> for creating a BEEHIVE");
      printf ("nEnter <3> for creating a TOAD");
      printf ("nEnter <4> for creating a SHIP");
      printf ("nEnter <5> for creating a GLIDER");
      printf ("nEnter <6> for creating a QUEEN BEE SHUTTLE");
      printf ("nEnter <7> for creating a PULSAR");
      printf ("nEnter <8> for creating a BLINKER");
      printf ("nEnter <9> for creating a PENTADECATHLONn");
      scanf ("%i", &type);

      if (type == 1)
      {
      board[10][10] = 'O';
      board[10][11] = 'O';
      board[11][10] = 'O';
      board[11][11] = 'O';
      }
      else if (type == 9)
      {
      board[15][10] = 'O';
      board[15][11] = 'O';
      board[15][12] = 'O';
      board[15][13] = 'O';
      board[15][14] = 'O';
      board[15][15] = 'O';
      board[15][16] = 'O';
      board[15][17] = 'O';
      board[15][18] = 'O';
      board[15][19] = 'O';
      }
      else if (type == 5)
      {
      board[28][3] = 'O';
      board[27][4] = 'O';
      board[26][4] = 'O';
      board[27][5] = 'O';
      board[28][5] = 'O';
      }
      else if (type == 3)
      {
      board[18][12] = 'O';
      board[18][13] = 'O';
      board[18][14] = 'O';
      board[19][11] = 'O';
      board[19][12] = 'O';
      board[19][13] = 'O';
      }
      else if (type == 6)
      {
      board[20][28] = 'O';
      board[20][29] = 'O';
      board[21][30] = 'O';
      board[22][31] = 'O';
      board[23][31] = 'O';
      board[24][31] = 'O';
      board[25][30] = 'O';
      board[26][29] = 'O';
      board[26][28] = 'O';
      }
      else if (type == 7)
      {
      board[12][14] = 'O';
      board[13][13] = 'O';
      board[13][14] = 'O';
      board[13][15] = 'O';
      board[14][13] = 'O';
      board[14][15] = 'O';
      board[15][13] = 'O';
      board[15][14] = 'O';
      board[15][15] = 'O';
      board[16][14] = 'O';
      }
      else if (type == 8)
      {
      board[12][12] = 'O';
      board[12][13] = 'O';
      board[12][14] = 'O';
      }
      else if (type == 4)
      {
      board[12][12] = 'O';
      board[12][13] = 'O';
      board[13][12] = 'O';
      board[14][13] = 'O';
      board[14][14] = 'O';
      board[13][14] = 'O';
      }
      else if (type ==2)
      {
      board[12][14] = 'O';
      board[13][13] = 'O';
      board[13][15] = 'O';
      board[14][13] = 'O';
      board[15][14] = 'O';
      board[14][15] = 'O';
      }
      }
      void usermode(int board[HEIGHT][WIDTH])
      {
      int i, generation, c, choice;
      printf ("nDo you want to insert a particular pattern type? <1> for yes and <0> for no: ");
      scanf ("%i", &choice);
      if (choice == 1)
      {
      creatingpatterntypes(board);
      display2Darray(board);
      }
      else
      {
      entercoordinates(board);
      display2Darray(board);
      }

      printf ("nPlease select a number of generation: ");
      scanf ("%i", &generation);

      playgame(board, generation);
      }
      void automaticmode(int board[HEIGHT][WIDTH])
      {
      int i, generation, c;
      fillarrayrandomly(board);
      display2Darray(board);
      printf ("nPlease select a number of generation: ");
      scanf ("%i", &generation);

      playgame(board, generation);
      }
      void hybridmode (int board[HEIGHT][WIDTH])
      {
      int i, generation, c;
      fillarrayrandomly(board);
      display2Darray(board);
      entercoordinates(board);
      system("cls");
      display2Darray(board);

      printf ("nPlease select a number of generation: ");
      scanf ("%i", &generation);

      playgame(board, generation);
      }

      int main (void)
      {
      //printf ("hello. worldn");
      int board[HEIGHT][WIDTH], mode;
      makingboundarylines(board);
      fillarray(board);

      printf ("CONWAY'S GAME OF LIFEnn");
      printf ("Please hit space to terminate the program, hit enter to move to the next generationn");
      printf ("Please enter <1> for User Mode, <2> for Automatic Mode and <3> for Hybrid Mode: ");
      scanf ("%i", &mode);

      if (mode == 1)
      usermode(board);
      else if (mode == 2)
      automaticmode(board);
      else if (mode ==3)
      hybridmode(board);

      return 0;
      }









      share|improve this question









      New contributor




      Huỳnh Quang Huy is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      This is my program for the Game of life, I created it by myself with no reference or peers review so i need some comments and reviews on it.
      I created 3 mode:



      A. User Mode:
      The program asks the user to enter the coordinates (x,y) where live creatures are to be
      placed on the board, until the user enters a negative coordinate.



      B. Automatic Mode:
      The program randomly populates the board with creatures, each cell having a 1 in 10
      chance of containing a creature.



      C. Hybrid Mode:
      After having automatically populated the board, allow the user to modify it.



      How can I improve this? And I'm also working on a function to detect "steady" state. If anyone have any idea please suggest. Thank you very much.



      /**Conway's Game of Life**/
      #include <stdio.h>
      #include <stdlib.h>
      #include <time.h>
      #include <conio.h>

      const int WIDTH = 67;
      const int HEIGHT = 47;
      const int TRUE = 1;
      const int FALSE = 0;

      void makingboundarylines (int board[HEIGHT][WIDTH])
      {
      int cols, rows;
      for (cols =0; cols <WIDTH; cols++)
      {
      board[0][cols] = '_';
      board[HEIGHT -1][cols]= '_';
      }
      for (rows =1; rows <HEIGHT; rows++)
      {
      board[rows][0] = '|';
      board[rows][WIDTH -1] = '|';
      }
      }
      void fillarray(int board[HEIGHT][WIDTH])
      {
      int i,j;
      for(i =1; i <HEIGHT-1; i++)
      for(j=1; j <WIDTH-1; j++)
      board[i][j] = ' ';
      }
      void fillarrayrandomly(int board[HEIGHT][WIDTH])
      {
      int i, j, num;
      srand((unsigned)time(NULL));
      for(i =1; i <HEIGHT -1; i++)
      for(j=1; j <WIDTH -1;j++)
      {
      num = rand()%11;
      if (num == 1)
      board[i][j] = 'O';
      else board[i][j] = ' ';
      }
      }
      void display2Darray(int board[HEIGHT][WIDTH])
      {
      int rows;
      int cols;
      for (rows = 0; rows <HEIGHT; rows++)
      {
      for(cols =0; cols <WIDTH; cols++)
      printf ("%3c", board[rows][cols]);
      printf ("n");
      }
      }
      void countneighbors (int board[HEIGHT][WIDTH])
      {
      int neighbors;
      int rows;
      int cols;
      int a, b;
      for (rows =1; rows <HEIGHT; rows++)
      {
      for (cols = 1; cols <WIDTH; cols ++)
      {
      neighbors = 0;
      if (board[rows][cols] == 'O')
      {
      for (a = -1; a <2; a++)
      {
      for (b = -1; b <2; b++)
      if (((rows +a) == rows) && ((cols +b) == cols))
      neighbors = neighbors;
      else if ((board[rows +a][cols +b] == 'O') ||(board[rows +a][cols +b] == 1) || (board[rows +a][cols +b] == 0))
      neighbors++;
      }
      if ((neighbors == 2) || (neighbors == 3))
      board[rows][cols] = 1; /*live*/
      else if ((neighbors < 2) || (neighbors >= 4))
      board[rows][cols] = 0; /*die*/
      }
      }
      }
      }
      void checknewborns (int board[HEIGHT][WIDTH])
      {
      int neighbors;
      int rows;
      int cols;
      int a, b;
      for (rows =1; rows <HEIGHT -1; rows++)
      {
      for (cols = 1; cols <WIDTH -1; cols ++)
      {
      neighbors = 0;
      if (board[rows][cols] == ' ')
      {
      for (a = -1; a <2; a++)
      {
      for (b = -1; b <2; b++)
      if (((rows +a) == rows) && ((cols +b) == cols))
      neighbors = neighbors;
      else if ((board[rows +a][cols +b] == 'O') || (board[rows +a][cols +b] == 1) || (board[rows +a][cols +b] == 0))
      neighbors++;
      }
      if ((neighbors == 3))
      board[rows][cols] = 2; /*newborn*/
      }
      }
      }
      }
      void anewgeneration (int board[HEIGHT][WIDTH])
      {
      int rows;
      int cols;
      for (rows =1; rows <HEIGHT -1; rows++)
      {
      for (cols = 1; cols <WIDTH -1; cols ++)
      {
      if (board[rows][cols] == 1)
      board[rows][cols] = 'O';
      else if (board[rows][cols] == 2)
      board[rows][cols] = 'O';
      else if (board[rows][cols] == 0)
      board[rows][cols] = ' ';
      }
      }
      }
      int checkforexistence (int board[HEIGHT][WIDTH])
      {
      int rows;
      int cols;
      int creatures =0;
      for (rows =1; rows <HEIGHT -1; rows++)
      {
      for (cols = 1; cols <WIDTH -1; cols ++)
      {
      if (board[rows][cols] == 'O')
      creatures++;
      }
      }
      if (creatures == 0)
      return TRUE; /*all creatures died*/
      else return FALSE; /*there are still living creatures*/
      }
      void playgame (int board[HEIGHT][WIDTH], int numgeneration)
      {
      int i, c, check;
      for (i = 1; (i <= numgeneration) && (c != 32); i++)
      {
      system("cls");
      countneighbors(board);
      checknewborns(board);
      anewgeneration(board);
      printf ("Generation: %in", i);
      printf ("Hit enter to move to the next generationn");
      display2Darray(board);
      if(kbhit())
      {
      c = getch();
      if(c == 32)
      break;
      }
      check = checkforexistence(board);
      if ((check= checkforexistence(board)) ==TRUE)
      {
      printf ("nALL CREATURES HAVE DIED: GAME OVER");
      c = 32;
      }
      }
      }
      int returnnumber(int anumber)
      {
      if ((anumber >50) || (anumber ==0))
      {
      printf ("ERROR! The number must be between 1 and 50n");
      printf ("Please enter a valid number!: ");
      scanf ("%i", &anumber);
      returnnumber(anumber);
      }
      else
      return anumber;
      }
      void entercoordinates (int board[HEIGHT][WIDTH])
      {
      int rows = 1;
      int cols =1;
      while ((rows >0) && (cols >0))
      {
      printf ("nPlease enter x coordinate(a number from 1 to 30): ");
      scanf("%i", &cols);
      cols = returnnumber(cols);
      if (cols >0)
      {
      printf ("Please enter y coordinate(a number from 1 to 50): ");
      scanf("%i", &rows);
      rows = returnnumber(rows);
      if ((rows >0) && (cols >0))
      board[rows][cols] = 'O';
      }
      }
      }
      void creatingpatterntypes(int board[HEIGHT][WIDTH])
      {
      int type;
      printf ("nEnter <1> for creating a BOX");
      printf ("nEnter <2> for creating a BEEHIVE");
      printf ("nEnter <3> for creating a TOAD");
      printf ("nEnter <4> for creating a SHIP");
      printf ("nEnter <5> for creating a GLIDER");
      printf ("nEnter <6> for creating a QUEEN BEE SHUTTLE");
      printf ("nEnter <7> for creating a PULSAR");
      printf ("nEnter <8> for creating a BLINKER");
      printf ("nEnter <9> for creating a PENTADECATHLONn");
      scanf ("%i", &type);

      if (type == 1)
      {
      board[10][10] = 'O';
      board[10][11] = 'O';
      board[11][10] = 'O';
      board[11][11] = 'O';
      }
      else if (type == 9)
      {
      board[15][10] = 'O';
      board[15][11] = 'O';
      board[15][12] = 'O';
      board[15][13] = 'O';
      board[15][14] = 'O';
      board[15][15] = 'O';
      board[15][16] = 'O';
      board[15][17] = 'O';
      board[15][18] = 'O';
      board[15][19] = 'O';
      }
      else if (type == 5)
      {
      board[28][3] = 'O';
      board[27][4] = 'O';
      board[26][4] = 'O';
      board[27][5] = 'O';
      board[28][5] = 'O';
      }
      else if (type == 3)
      {
      board[18][12] = 'O';
      board[18][13] = 'O';
      board[18][14] = 'O';
      board[19][11] = 'O';
      board[19][12] = 'O';
      board[19][13] = 'O';
      }
      else if (type == 6)
      {
      board[20][28] = 'O';
      board[20][29] = 'O';
      board[21][30] = 'O';
      board[22][31] = 'O';
      board[23][31] = 'O';
      board[24][31] = 'O';
      board[25][30] = 'O';
      board[26][29] = 'O';
      board[26][28] = 'O';
      }
      else if (type == 7)
      {
      board[12][14] = 'O';
      board[13][13] = 'O';
      board[13][14] = 'O';
      board[13][15] = 'O';
      board[14][13] = 'O';
      board[14][15] = 'O';
      board[15][13] = 'O';
      board[15][14] = 'O';
      board[15][15] = 'O';
      board[16][14] = 'O';
      }
      else if (type == 8)
      {
      board[12][12] = 'O';
      board[12][13] = 'O';
      board[12][14] = 'O';
      }
      else if (type == 4)
      {
      board[12][12] = 'O';
      board[12][13] = 'O';
      board[13][12] = 'O';
      board[14][13] = 'O';
      board[14][14] = 'O';
      board[13][14] = 'O';
      }
      else if (type ==2)
      {
      board[12][14] = 'O';
      board[13][13] = 'O';
      board[13][15] = 'O';
      board[14][13] = 'O';
      board[15][14] = 'O';
      board[14][15] = 'O';
      }
      }
      void usermode(int board[HEIGHT][WIDTH])
      {
      int i, generation, c, choice;
      printf ("nDo you want to insert a particular pattern type? <1> for yes and <0> for no: ");
      scanf ("%i", &choice);
      if (choice == 1)
      {
      creatingpatterntypes(board);
      display2Darray(board);
      }
      else
      {
      entercoordinates(board);
      display2Darray(board);
      }

      printf ("nPlease select a number of generation: ");
      scanf ("%i", &generation);

      playgame(board, generation);
      }
      void automaticmode(int board[HEIGHT][WIDTH])
      {
      int i, generation, c;
      fillarrayrandomly(board);
      display2Darray(board);
      printf ("nPlease select a number of generation: ");
      scanf ("%i", &generation);

      playgame(board, generation);
      }
      void hybridmode (int board[HEIGHT][WIDTH])
      {
      int i, generation, c;
      fillarrayrandomly(board);
      display2Darray(board);
      entercoordinates(board);
      system("cls");
      display2Darray(board);

      printf ("nPlease select a number of generation: ");
      scanf ("%i", &generation);

      playgame(board, generation);
      }

      int main (void)
      {
      //printf ("hello. worldn");
      int board[HEIGHT][WIDTH], mode;
      makingboundarylines(board);
      fillarray(board);

      printf ("CONWAY'S GAME OF LIFEnn");
      printf ("Please hit space to terminate the program, hit enter to move to the next generationn");
      printf ("Please enter <1> for User Mode, <2> for Automatic Mode and <3> for Hybrid Mode: ");
      scanf ("%i", &mode);

      if (mode == 1)
      usermode(board);
      else if (mode == 2)
      automaticmode(board);
      else if (mode ==3)
      hybridmode(board);

      return 0;
      }






      c






      share|improve this question









      New contributor




      Huỳnh Quang Huy is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Huỳnh Quang Huy is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 36 mins ago





















      New contributor




      Huỳnh Quang Huy is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 43 mins ago









      Huỳnh Quang Huy

      62




      62




      New contributor




      Huỳnh Quang Huy is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Huỳnh Quang Huy is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Huỳnh Quang Huy is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Huỳnh Quang Huy is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208973%2fconways-game-of-life-in-c-3-mode%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Huỳnh Quang Huy is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Huỳnh Quang Huy is a new contributor. Be nice, and check out our Code of Conduct.













          Huỳnh Quang Huy is a new contributor. Be nice, and check out our Code of Conduct.












          Huỳnh Quang Huy is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208973%2fconways-game-of-life-in-c-3-mode%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'