Code uses Deck Methods, but not sure if It should use Stack methods
Not sure how to word the title that well, but I really just have design questions. I know both ways will work, I just don't know what is best and why. I need some experienced insight on potential pitfalls, strengths and such.
I have a Stack Data Structure that adds and removes Nodes from a Stack. I found this helpful as the basis of a Deck of Cards.
When I build a Deck class, I create a new Stack, and fill it with Card objects. I do this by saying in it's constructor:
this.deck = new Stack();
Then I just loop and add in new cards as such:
this.deck.add(new Card(...))
So, my deck itself has a prebuilt in add method so to speak, which comes from the Stack class, and adds a new Card in as data of a Node on the Stack.
But I also have an addToDeck method on the Deck class which just does the same thing under the hood.
let deck = new Deck();
deck.addToDeck(new Card()); // which just calls this.deck.add(card)
I then have a Player class. The player holds their own Decks as such:
this.deck = new Deck();
And the player has their own addToDeck method:
let playerOne = new Player('mike');
playerOne.addToDeck(new Card());
Which under the hood could do two things:
1:
this.deck.addToDeck(card) // Use the Deck addToDeck method.
2:
this.deck.deck.add(card) // Use the Stack add method.
And that's where my questions lay. Am I being redundant by adding an addToDeck method to both my Deck class and my Player class? I feel that this is much more in line with functional programming paradigm. I feel I should work through my objects and what they expose rather than reach into their inner workings. I also feel this allows me to add a Card to either the player, or their decks if I were to need to in the future, and they are both conventionally consistent.
Also, Should I have subclassed my Deck class as an extended Stack?
Thanks. Any thoughts would be great!
javascript object-oriented functional-programming
asked 2 mins ago
Michael Treat
11
New contributor
Michael Treat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
Not sure how to word the title that well, but I really just have design questions. I know both ways will work, I just don't know what is best and why. I need some experienced insight on potential pitfalls, strengths and such.
I have a Stack Data Structure that adds and removes Nodes from a Stack. I found this helpful as the basis of a Deck of Cards.
When I build a Deck class, I create a new Stack, and fill it with Card objects. I do this by saying in it's constructor:
this.deck = new Stack();
Then I just loop and add in new cards as such:
this.deck.add(new Card(...))
So, my deck itself has a prebuilt in add method so to speak, which comes from the Stack class, and adds a new Card in as data of a Node on the Stack.
But I also have an addToDeck method on the Deck class which just does the same thing under the hood.
let deck = new Deck();
deck.addToDeck(new Card()); // which just calls this.deck.add(card)
I then have a Player class. The player holds their own Decks as such:
this.deck = new Deck();
And the player has their own addToDeck method:
let playerOne = new Player('mike');
playerOne.addToDeck(new Card());
Which under the hood could do two things:
1:
this.deck.addToDeck(card) // Use the Deck addToDeck method.
2:
this.deck.deck.add(card) // Use the Stack add method.
And that's where my questions lay. Am I being redundant by adding an addToDeck method to both my Deck class and my Player class? I feel that this is much more in line with functional programming paradigm. I feel I should work through my objects and what they expose rather than reach into their inner workings. I also feel this allows me to add a Card to either the player, or their decks if I were to need to in the future, and they are both conventionally consistent.
Also, Should I have subclassed my Deck class as an extended Stack?
Thanks. Any thoughts would be great!
javascript object-oriented functional-programming
asked 2 mins ago
Michael Treat
11
New contributor
Michael Treat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
Not sure how to word the title that well, but I really just have design questions. I know both ways will work, I just don't know what is best and why. I need some experienced insight on potential pitfalls, strengths and such.
I have a Stack Data Structure that adds and removes Nodes from a Stack. I found this helpful as the basis of a Deck of Cards.
When I build a Deck class, I create a new Stack, and fill it with Card objects. I do this by saying in it's constructor:
this.deck = new Stack();
Then I just loop and add in new cards as such:
this.deck.add(new Card(...))
So, my deck itself has a prebuilt in add method so to speak, which comes from the Stack class, and adds a new Card in as data of a Node on the Stack.
But I also have an addToDeck method on the Deck class which just does the same thing under the hood.
let deck = new Deck();
deck.addToDeck(new Card()); // which just calls this.deck.add(card)
I then have a Player class. The player holds their own Decks as such:
this.deck = new Deck();
And the player has their own addToDeck method:
let playerOne = new Player('mike');
playerOne.addToDeck(new Card());
Which under the hood could do two things:
1:
this.deck.addToDeck(card) // Use the Deck addToDeck method.
2:
this.deck.deck.add(card) // Use the Stack add method.
And that's where my questions lay. Am I being redundant by adding an addToDeck method to both my Deck class and my Player class? I feel that this is much more in line with functional programming paradigm. I feel I should work through my objects and what they expose rather than reach into their inner workings. I also feel this allows me to add a Card to either the player, or their decks if I were to need to in the future, and they are both conventionally consistent.
Also, Should I have subclassed my Deck class as an extended Stack?
Thanks. Any thoughts would be great!
javascript object-oriented functional-programming
asked 2 mins ago
Michael Treat
11
New contributor
Michael Treat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Not sure how to word the title that well, but I really just have design questions. I know both ways will work, I just don't know what is best and why. I need some experienced insight on potential pitfalls, strengths and such.
I have a Stack Data Structure that adds and removes Nodes from a Stack. I found this helpful as the basis of a Deck of Cards.
When I build a Deck class, I create a new Stack, and fill it with Card objects. I do this by saying in it's constructor:
this.deck = new Stack();
Then I just loop and add in new cards as such:
this.deck.add(new Card(...))
So, my deck itself has a prebuilt in add method so to speak, which comes from the Stack class, and adds a new Card in as data of a Node on the Stack.
But I also have an addToDeck method on the Deck class which just does the same thing under the hood.
let deck = new Deck();
deck.addToDeck(new Card()); // which just calls this.deck.add(card)
I then have a Player class. The player holds their own Decks as such:
this.deck = new Deck();
And the player has their own addToDeck method:
let playerOne = new Player('mike');
playerOne.addToDeck(new Card());
Which under the hood could do two things:
1:
this.deck.addToDeck(card) // Use the Deck addToDeck method.
2:
this.deck.deck.add(card) // Use the Stack add method.
And that's where my questions lay. Am I being redundant by adding an addToDeck method to both my Deck class and my Player class? I feel that this is much more in line with functional programming paradigm. I feel I should work through my objects and what they expose rather than reach into their inner workings. I also feel this allows me to add a Card to either the player, or their decks if I were to need to in the future, and they are both conventionally consistent.
Also, Should I have subclassed my Deck class as an extended Stack?
Thanks. Any thoughts would be great!
javascript object-oriented functional-programming
javascript object-oriented functional-programming
asked 2 mins ago
Michael Treat
11
New contributor
Michael Treat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 2 mins ago
Michael Treat
11
New contributor
Michael Treat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 2 mins ago
Michael Treat
11
New contributor
Michael Treat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 2 mins ago
Michael Treat
11
asked 2 mins ago
Michael Treat
11
11
New contributor
Michael Treat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Michael Treat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Michael Treat is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Michael Treat is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210206%2fcode-uses-deck-methods-but-not-sure-if-it-should-use-stack-methods%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Michael Treat is a new contributor. Be nice, and check out our Code of Conduct.
Michael Treat is a new contributor. Be nice, and check out our Code of Conduct.
Michael Treat is a new contributor. Be nice, and check out our Code of Conduct.
Michael Treat is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210206%2fcode-uses-deck-methods-but-not-sure-if-it-should-use-stack-methods%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
