Prevent quote expansion in user-made function












1














I think the following bash code is self-explanatory (even if incorrect) :



tg() {

  git add -A && git commit -m $1 && git push

}


But it seems not to work :



$ tg "create index for users"

error: pathspec 'index' did not match any file(s) known to git.

error: pathspec 'for' did not match any file(s) known to git.

error: pathspec 'users' did not match any file(s) known to git.


Obviously, the problem is that the quote was expanded and my middle command was read as git commit -m create index for users rather than git commit -m "create index for users"



What did I do wrong ? How can I fix this ?






bash quoting







share|improve this question



























    1














    I think the following bash code is self-explanatory (even if incorrect) :



    tg() {
    
  git add -A && git commit -m $1 && git push
    
}


    But it seems not to work :



    $ tg "create index for users"
    
error: pathspec 'index' did not match any file(s) known to git.
    
error: pathspec 'for' did not match any file(s) known to git.
    
error: pathspec 'users' did not match any file(s) known to git.


    Obviously, the problem is that the quote was expanded and my middle command was read as git commit -m create index for users rather than git commit -m "create index for users"



    What did I do wrong ? How can I fix this ?






    bash quoting







    share|improve this question

























      1












      1








      1







      I think the following bash code is self-explanatory (even if incorrect) :



      tg() {
      
  git add -A && git commit -m $1 && git push
      
}


      But it seems not to work :



      $ tg "create index for users"
      
error: pathspec 'index' did not match any file(s) known to git.
      
error: pathspec 'for' did not match any file(s) known to git.
      
error: pathspec 'users' did not match any file(s) known to git.


      Obviously, the problem is that the quote was expanded and my middle command was read as git commit -m create index for users rather than git commit -m "create index for users"



      What did I do wrong ? How can I fix this ?






      bash quoting







      share|improve this question













      I think the following bash code is self-explanatory (even if incorrect) :



      tg() {
      
  git add -A && git commit -m $1 && git push
      
}


      But it seems not to work :



      $ tg "create index for users"
      
error: pathspec 'index' did not match any file(s) known to git.
      
error: pathspec 'for' did not match any file(s) known to git.
      
error: pathspec 'users' did not match any file(s) known to git.


      Obviously, the problem is that the quote was expanded and my middle command was read as git commit -m create index for users rather than git commit -m "create index for users"



      What did I do wrong ? How can I fix this ?






      bash quoting




      bash quoting






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 32 mins ago









      Ewan Delanoy

      1577




      1577






















          1 Answer
          1






          active

          oldest

          votes


















          3














          Double quote the expansion $1:



          tg() {
          
  git add -A &&
          
  git commit -m "$1" &&
          
  git push
          
}


          By not quoting $1, the shell will split its value on whitespaces (the contents of $IFS) and the resulting words will additionally undergo filename globbing.



          Related:




          • Why does my shell script choke on whitespace or other special characters?

          • When is double-quoting necessary?

          • Security implications of forgetting to quote a variable in bash/POSIX shells






          share|improve this answer























          • Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?
            – Ewan Delanoy
            23 mins ago






          • 2




            @EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.
            – Kusalananda
            19 mins ago












          • Got it, thx. I'll try your solution a few times and accept it if it works.
            – Ewan Delanoy
            17 mins ago








          • 1




            @EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.
            – Sergiy Kolodyazhnyy
            17 mins ago








          • 1




            @SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.
            – Kusalananda
            13 mins ago













          Your Answer








          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "106"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2funix.stackexchange.com%2fquestions%2f491999%2fprevent-quote-expansion-in-user-made-function%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          1 Answer
          1






          active

          oldest

          votes








          1 Answer
          1






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes









          3














          Double quote the expansion $1:



          tg() {
          
  git add -A &&
          
  git commit -m "$1" &&
          
  git push
          
}


          By not quoting $1, the shell will split its value on whitespaces (the contents of $IFS) and the resulting words will additionally undergo filename globbing.



          Related:




          • Why does my shell script choke on whitespace or other special characters?

          • When is double-quoting necessary?

          • Security implications of forgetting to quote a variable in bash/POSIX shells






          share|improve this answer























          • Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?
            – Ewan Delanoy
            23 mins ago






          • 2




            @EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.
            – Kusalananda
            19 mins ago












          • Got it, thx. I'll try your solution a few times and accept it if it works.
            – Ewan Delanoy
            17 mins ago








          • 1




            @EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.
            – Sergiy Kolodyazhnyy
            17 mins ago








          • 1




            @SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.
            – Kusalananda
            13 mins ago


















          3














          Double quote the expansion $1:



          tg() {
          
  git add -A &&
          
  git commit -m "$1" &&
          
  git push
          
}


          By not quoting $1, the shell will split its value on whitespaces (the contents of $IFS) and the resulting words will additionally undergo filename globbing.



          Related:




          • Why does my shell script choke on whitespace or other special characters?

          • When is double-quoting necessary?

          • Security implications of forgetting to quote a variable in bash/POSIX shells






          share|improve this answer























          • Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?
            – Ewan Delanoy
            23 mins ago






          • 2




            @EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.
            – Kusalananda
            19 mins ago












          • Got it, thx. I'll try your solution a few times and accept it if it works.
            – Ewan Delanoy
            17 mins ago








          • 1




            @EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.
            – Sergiy Kolodyazhnyy
            17 mins ago








          • 1




            @SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.
            – Kusalananda
            13 mins ago
















          3












          3








          3






          Double quote the expansion $1:



          tg() {
          
  git add -A &&
          
  git commit -m "$1" &&
          
  git push
          
}


          By not quoting $1, the shell will split its value on whitespaces (the contents of $IFS) and the resulting words will additionally undergo filename globbing.



          Related:




          • Why does my shell script choke on whitespace or other special characters?

          • When is double-quoting necessary?

          • Security implications of forgetting to quote a variable in bash/POSIX shells






          share|improve this answer














          Double quote the expansion $1:



          tg() {
          
  git add -A &&
          
  git commit -m "$1" &&
          
  git push
          
}


          By not quoting $1, the shell will split its value on whitespaces (the contents of $IFS) and the resulting words will additionally undergo filename globbing.



          Related:




          • Why does my shell script choke on whitespace or other special characters?

          • When is double-quoting necessary?

          • Security implications of forgetting to quote a variable in bash/POSIX shells







          share|improve this answer














          share|improve this answer



          share|improve this answer








          edited 14 mins ago

























          answered 27 mins ago









          Kusalananda

          121k16229372




          121k16229372












          • Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?
            – Ewan Delanoy
            23 mins ago






          • 2




            @EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.
            – Kusalananda
            19 mins ago












          • Got it, thx. I'll try your solution a few times and accept it if it works.
            – Ewan Delanoy
            17 mins ago








          • 1




            @EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.
            – Sergiy Kolodyazhnyy
            17 mins ago








          • 1




            @SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.
            – Kusalananda
            13 mins ago




















          • Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?
            – Ewan Delanoy
            23 mins ago






          • 2




            @EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.
            – Kusalananda
            19 mins ago












          • Got it, thx. I'll try your solution a few times and accept it if it works.
            – Ewan Delanoy
            17 mins ago








          • 1




            @EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.
            – Sergiy Kolodyazhnyy
            17 mins ago








          • 1




            @SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.
            – Kusalananda
            13 mins ago


















          Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?
          – Ewan Delanoy
          23 mins ago




          Thx for your help. I'm confused here : isn't "$1" supposed to be a "heredoc" string and variables inside it are supposed to be expanded ? For example, in the shell echo "$MYVAR" is equivalent to echo $MYVAR ?
          – Ewan Delanoy
          23 mins ago




          2




          2




          @EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.
          – Kusalananda
          19 mins ago






          @EwanDelanoy You are not using any here-document in your code. A here-document is written utility <<TAG and terminated by TAG (TAG can be any string). It's a form of redirection. echo $var and echo "$var" are not equivalent for the same reasons as I mentioned in my answer. Test with var=*. When it comes to variable expansions and quoting, $var and $1 behaves the same.
          – Kusalananda
          19 mins ago














          Got it, thx. I'll try your solution a few times and accept it if it works.
          – Ewan Delanoy
          17 mins ago






          Got it, thx. I'll try your solution a few times and accept it if it works.
          – Ewan Delanoy
          17 mins ago






          1




          1




          @EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.
          – Sergiy Kolodyazhnyy
          17 mins ago






          @EwanDelanoy If there's only one "word" and no whitespaces, then echo "$MYVAR" and echo $MYVAR will have same output. But if you have hello world then "$MYVAR" is treated as single word, $MYVAR is split into two words. In this case, this is trivial. If you do ls $MYVAR it can give you file not found if you're looking for hello world file, because ls will look for two files, hello and world, but ls "$MYVAR" will show you the file hello world.
          – Sergiy Kolodyazhnyy
          17 mins ago






          1




          1




          @SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.
          – Kusalananda
          13 mins ago






          @SergiyKolodyazhnyy That first sentence is true only given that the word contains no filename globbing characters, and that IFS has the default value.
          – Kusalananda
          13 mins ago




















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Unix & Linux Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid …



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid …



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2funix.stackexchange.com%2fquestions%2f491999%2fprevent-quote-expansion-in-user-made-function%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          -

          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          Image
          0 The contact form does not work, and affects loading after one try. The chrome console shows the error message: POST http://example.com/wp-json/contact-form-7/v1/contact-forms/50/feedback 404 (Not Found) send @ jquery.js?ver=1.12.4:4 ajax @ jquery.js?ver=1.12.4:4 wpcf7.submit @ scripts.js?ver=5.0.3:346 (anonymous) @ scripts.js?ver=5.0.3:53 dispatch @ jquery.js?ver=1.12.4:3 r.handle @ jquery.js?ver=1.12.4:3 How to solve this issue? thanks in advance javascript wordpress contact-form-7 share | improve this question edited Jul 17 '18 at 5:39 Kiran Shahi 4,745 3 16 43 ...
          Read more

          How to know if a Active Directory user can login interactively

          Image
          1 I would like to know if and how is it possible to know if a AD user can login interactively (on a server) in a domain. I need to know if I can find it out using a LDAP search. Thanks. windows active-directory login user-permissions user-profile share | improve this question edited 1 hour ago yagmoth555 ♦ 11.6k 3 17 42 asked 1 hour ago Luigi Luigi 6 1 New contributor ...
          Read more

          Refactoring coordinates for Minecraft Pi buildings written in Python

          Image
          0 $begingroup$ I'm fairly new to coding and I wrote this script in Python for a house with a roof in Minecraft Pi. I've found different ways to write the coordinates to make the code base shorter, but I'm wondering if it is possible for me to refactor it any further so I don't have to list each coordinate line by line. import mcpi.minecraft as minecraft import mcpi.block as block mc = minecraft.Minecraft.create() p = mc.player.getTilePos() mc.setBlocks(p.x+1, p.y, p.z+1, #Main structure starting coordinates (DO NOT ALTER) p.x+19, p.y+4, p.z+6, #Structure size/coordinates (Alters cube size) block.STONE_BRICK) mc.setBlocks(p.x+2, p.y+1, p.z+2, #Hollowing out main structure interior p.x+18, p.y+3, p.z+5, block.AIR) mc.setBlocks(p.x, p.y...
          Read more