Keypress and regex validation
I've recently come across the following code which tests an input value against a regex.
It's written with jQuery and listens for 'keypress' changes.
$('form').each(function (i, elem) {
$(elem).on('keypress', '.my-input-field', function (event) {
var theEvent = event || window.event;
var key = theEvent.keyCode || theEvent.which;
key = String.fromCharCode(key);
var regex = /[0-9]|.|t/;
if (!regex.test(key) && !theEvent.shiftKey) {
return false;
}
});
}
I'm interested to know why you might want to listen for a 'keypress' (rather than say 'input' or 'change') and i'm also a bit confused about the code that checks for 'window.event' and 'theEvent.which' and why they are needed rather that only the 'event' object.
I feel that the code could be simplified (with JS) as follows -
document.addEventListener('change', function(e) {
var regex = /[0-9]|.|t/;
if(e.target.classList.contains('my-input-field') {
if (!regex.test(e.target.value)) {
return false;
}
})
});
Alternatively, and possibly even more straightforward, since no validation error is actually displayed why not just use a number field to prevent anything non numeric characters from being entered.
<input type="number" class="my-input-field">
Just curious to see if I've missed something fundamental in my understanding of what the original code is doing. Any help much appreciated.
Thanks,
J.
javascript javascript-events keypress
asked Nov 22 '18 at 17:59
Jon KJon K
556
add a comment |
I've recently come across the following code which tests an input value against a regex.
It's written with jQuery and listens for 'keypress' changes.
$('form').each(function (i, elem) {
$(elem).on('keypress', '.my-input-field', function (event) {
var theEvent = event || window.event;
var key = theEvent.keyCode || theEvent.which;
key = String.fromCharCode(key);
var regex = /[0-9]|.|t/;
if (!regex.test(key) && !theEvent.shiftKey) {
return false;
}
});
}
I'm interested to know why you might want to listen for a 'keypress' (rather than say 'input' or 'change') and i'm also a bit confused about the code that checks for 'window.event' and 'theEvent.which' and why they are needed rather that only the 'event' object.
I feel that the code could be simplified (with JS) as follows -
document.addEventListener('change', function(e) {
var regex = /[0-9]|.|t/;
if(e.target.classList.contains('my-input-field') {
if (!regex.test(e.target.value)) {
return false;
}
})
});
Alternatively, and possibly even more straightforward, since no validation error is actually displayed why not just use a number field to prevent anything non numeric characters from being entered.
<input type="number" class="my-input-field">
Just curious to see if I've missed something fundamental in my understanding of what the original code is doing. Any help much appreciated.
Thanks,
J.
javascript javascript-events keypress
asked Nov 22 '18 at 17:59
Jon KJon K
556
"I feel that the code could be simplified (with JS) as follows" - Don't feel it but test it. Do the scripts really react the same way? "why not just use a number field" - That would now be the way to go, but thenumbertype is only available since HTML 5.1 and only works in IE since v10.
– Andreas
Nov 22 '18 at 18:17
add a comment |
I've recently come across the following code which tests an input value against a regex.
It's written with jQuery and listens for 'keypress' changes.
$('form').each(function (i, elem) {
$(elem).on('keypress', '.my-input-field', function (event) {
var theEvent = event || window.event;
var key = theEvent.keyCode || theEvent.which;
key = String.fromCharCode(key);
var regex = /[0-9]|.|t/;
if (!regex.test(key) && !theEvent.shiftKey) {
return false;
}
});
}
I'm interested to know why you might want to listen for a 'keypress' (rather than say 'input' or 'change') and i'm also a bit confused about the code that checks for 'window.event' and 'theEvent.which' and why they are needed rather that only the 'event' object.
I feel that the code could be simplified (with JS) as follows -
document.addEventListener('change', function(e) {
var regex = /[0-9]|.|t/;
if(e.target.classList.contains('my-input-field') {
if (!regex.test(e.target.value)) {
return false;
}
})
});
Alternatively, and possibly even more straightforward, since no validation error is actually displayed why not just use a number field to prevent anything non numeric characters from being entered.
<input type="number" class="my-input-field">
Just curious to see if I've missed something fundamental in my understanding of what the original code is doing. Any help much appreciated.
Thanks,
J.
javascript javascript-events keypress
asked Nov 22 '18 at 17:59
Jon KJon K
556
I've recently come across the following code which tests an input value against a regex.
It's written with jQuery and listens for 'keypress' changes.
$('form').each(function (i, elem) {
$(elem).on('keypress', '.my-input-field', function (event) {
var theEvent = event || window.event;
var key = theEvent.keyCode || theEvent.which;
key = String.fromCharCode(key);
var regex = /[0-9]|.|t/;
if (!regex.test(key) && !theEvent.shiftKey) {
return false;
}
});
}
I'm interested to know why you might want to listen for a 'keypress' (rather than say 'input' or 'change') and i'm also a bit confused about the code that checks for 'window.event' and 'theEvent.which' and why they are needed rather that only the 'event' object.
I feel that the code could be simplified (with JS) as follows -
document.addEventListener('change', function(e) {
var regex = /[0-9]|.|t/;
if(e.target.classList.contains('my-input-field') {
if (!regex.test(e.target.value)) {
return false;
}
})
});
Alternatively, and possibly even more straightforward, since no validation error is actually displayed why not just use a number field to prevent anything non numeric characters from being entered.
<input type="number" class="my-input-field">
Just curious to see if I've missed something fundamental in my understanding of what the original code is doing. Any help much appreciated.
Thanks,
J.
javascript javascript-events keypress
javascript javascript-events keypress
asked Nov 22 '18 at 17:59
Jon KJon K
556
asked Nov 22 '18 at 17:59
Jon KJon K
556
asked Nov 22 '18 at 17:59
Jon KJon K
556
asked Nov 22 '18 at 17:59
Jon KJon K
556
asked Nov 22 '18 at 17:59
Jon KJon K
556
556
"I feel that the code could be simplified (with JS) as follows" - Don't feel it but test it. Do the scripts really react the same way? "why not just use a number field" - That would now be the way to go, but thenumbertype is only available since HTML 5.1 and only works in IE since v10.
– Andreas
Nov 22 '18 at 18:17
add a comment |
"I feel that the code could be simplified (with JS) as follows" - Don't feel it but test it. Do the scripts really react the same way? "why not just use a number field" - That would now be the way to go, but thenumbertype is only available since HTML 5.1 and only works in IE since v10.
– Andreas
Nov 22 '18 at 18:17
"I feel that the code could be simplified (with JS) as follows" - Don't feel it but test it. Do the scripts really react the same way? "why not just use a number field" - That would now be the way to go, but the
number type is only available since HTML 5.1 and only works in IE since v10.– Andreas
Nov 22 '18 at 18:17
"I feel that the code could be simplified (with JS) as follows" - Don't feel it but test it. Do the scripts really react the same way? "why not just use a number field" - That would now be the way to go, but the
number type is only available since HTML 5.1 and only works in IE since v10.– Andreas
Nov 22 '18 at 18:17
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53436192%2fkeypress-and-regex-validation%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53436192%2fkeypress-and-regex-validation%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
"I feel that the code could be simplified (with JS) as follows" - Don't feel it but test it. Do the scripts really react the same way? "why not just use a number field" - That would now be the way to go, but the
numbertype is only available since HTML 5.1 and only works in IE since v10.– Andreas
Nov 22 '18 at 18:17