Test for an array being subset of another master array












1














I was trying to build a small utility function to check if an array is part of other array. It's testing if an array is a subset of another master array.



const masterArray = [1,2,3,4,5,6];
const candidateArray = [2,5,6];

//Test for subset.

//create a set from the two.
const s1 = new Set(masterArray.concat(candidateArray));

//Compare the sizes of the master array and the created set
//If the sizes are same, no new elements are added that means
//the candidate is complete subset.
s1.size === masterArray.length;


Can this be handled in a better way?










share|improve this question




















  • 2




    Wouldn't that fail if masterArray has duplicate elements?
    – Martin R
    Jul 16 at 7:15










  • Good point. In my case the master array is always unique.
    – Harshal
    Jul 16 at 7:22










  • I can enhance it by comparing with a new set created from master array (new Set(masterArray)).size
    – Harshal
    Jul 16 at 8:46
















1














I was trying to build a small utility function to check if an array is part of other array. It's testing if an array is a subset of another master array.



const masterArray = [1,2,3,4,5,6];
const candidateArray = [2,5,6];

//Test for subset.

//create a set from the two.
const s1 = new Set(masterArray.concat(candidateArray));

//Compare the sizes of the master array and the created set
//If the sizes are same, no new elements are added that means
//the candidate is complete subset.
s1.size === masterArray.length;


Can this be handled in a better way?










share|improve this question




















  • 2




    Wouldn't that fail if masterArray has duplicate elements?
    – Martin R
    Jul 16 at 7:15










  • Good point. In my case the master array is always unique.
    – Harshal
    Jul 16 at 7:22










  • I can enhance it by comparing with a new set created from master array (new Set(masterArray)).size
    – Harshal
    Jul 16 at 8:46














1












1








1







I was trying to build a small utility function to check if an array is part of other array. It's testing if an array is a subset of another master array.



const masterArray = [1,2,3,4,5,6];
const candidateArray = [2,5,6];

//Test for subset.

//create a set from the two.
const s1 = new Set(masterArray.concat(candidateArray));

//Compare the sizes of the master array and the created set
//If the sizes are same, no new elements are added that means
//the candidate is complete subset.
s1.size === masterArray.length;


Can this be handled in a better way?










share|improve this question















I was trying to build a small utility function to check if an array is part of other array. It's testing if an array is a subset of another master array.



const masterArray = [1,2,3,4,5,6];
const candidateArray = [2,5,6];

//Test for subset.

//create a set from the two.
const s1 = new Set(masterArray.concat(candidateArray));

//Compare the sizes of the master array and the created set
//If the sizes are same, no new elements are added that means
//the candidate is complete subset.
s1.size === masterArray.length;


Can this be handled in a better way?







typescript






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited 9 mins ago









Jamal

30.2k11116226




30.2k11116226










asked Jul 16 at 6:50









Harshal

1064




1064








  • 2




    Wouldn't that fail if masterArray has duplicate elements?
    – Martin R
    Jul 16 at 7:15










  • Good point. In my case the master array is always unique.
    – Harshal
    Jul 16 at 7:22










  • I can enhance it by comparing with a new set created from master array (new Set(masterArray)).size
    – Harshal
    Jul 16 at 8:46














  • 2




    Wouldn't that fail if masterArray has duplicate elements?
    – Martin R
    Jul 16 at 7:15










  • Good point. In my case the master array is always unique.
    – Harshal
    Jul 16 at 7:22










  • I can enhance it by comparing with a new set created from master array (new Set(masterArray)).size
    – Harshal
    Jul 16 at 8:46








2




2




Wouldn't that fail if masterArray has duplicate elements?
– Martin R
Jul 16 at 7:15




Wouldn't that fail if masterArray has duplicate elements?
– Martin R
Jul 16 at 7:15












Good point. In my case the master array is always unique.
– Harshal
Jul 16 at 7:22




Good point. In my case the master array is always unique.
– Harshal
Jul 16 at 7:22












I can enhance it by comparing with a new set created from master array (new Set(masterArray)).size
– Harshal
Jul 16 at 8:46




I can enhance it by comparing with a new set created from master array (new Set(masterArray)).size
– Harshal
Jul 16 at 8:46















active

oldest

votes











Your Answer





StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f199570%2ftest-for-an-array-being-subset-of-another-master-array%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown






























active

oldest

votes













active

oldest

votes









active

oldest

votes






active

oldest

votes
















draft saved

draft discarded




















































Thanks for contributing an answer to Code Review Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


Use MathJax to format equations. MathJax reference.


To learn more, see our tips on writing great answers.





Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


Please pay close attention to the following guidance:


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f199570%2ftest-for-an-array-being-subset-of-another-master-array%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

404 Error Contact Form 7 ajax form submitting

How to know if a Active Directory user can login interactively

TypeError: fit_transform() missing 1 required positional argument: 'X'