Forum system implementation












2












$begingroup$


I have a function which does the following:




  1. When new Post Entity is added some fields in Category table are updated.

  2. When new Thread Entity is added the same fields in Category table are updated.


Because of this, some lines are completely the same.



public function postPersist(LifecycleEventArgs $args)

{

    $entity = $args->getObject();

    $entityManager = $args->getObjectManager();



    if ($entity instanceof Post) {

        $post = $entity;



        $thread = $post->getThread();



        $category = $thread->getCategory(); 

        $category->setLastPostThreadTitle($thread->getTitle()); 

        $category->setLastPostThreadSlug($thread->getSlug()); 

        $category->setLastPostBody($post->getBody());

        $category->setLastPosterUsername($post->getUser()->getUsername());

        $category->setLastPostCreatedAt($post->getCreatedAt());

        $category->setIsLastPostOp(false);

        $category->setPosts($category->getPosts() + 1);



        $entityManager->merge($category);           

        $entityManager->flush();

    }



    if ($entity instanceof Thread) {

        $thread = $entity;



        $category = $thread->getCategory(); 

        $category->setLastPostThreadTitle($thread->getTitle()); 

        $category->setLastPostThreadSlug($thread->getSlug()); 

        $category->setLastPostBody($thread->getBody());

        $category->setLastPosterUsername($thread->getUser()->getUsername());

        $category->setLastPostCreatedAt($thread->getCreatedAt());

        $category->setIsLastPostOp(true);



        $entityManager->merge($category);           

        $entityManager->flush();

    }

}


How would be possible to refactor this code to avoid WET?






php doctrine







share|improve this question









New contributor




user10322178 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$












  • $begingroup$
    Errr.... Move the common code above if?
    $endgroup$
    – Your Common Sense
    14 hours ago
















2












$begingroup$


I have a function which does the following:




  1. When new Post Entity is added some fields in Category table are updated.

  2. When new Thread Entity is added the same fields in Category table are updated.


Because of this, some lines are completely the same.



public function postPersist(LifecycleEventArgs $args)

{

    $entity = $args->getObject();

    $entityManager = $args->getObjectManager();



    if ($entity instanceof Post) {

        $post = $entity;



        $thread = $post->getThread();



        $category = $thread->getCategory(); 

        $category->setLastPostThreadTitle($thread->getTitle()); 

        $category->setLastPostThreadSlug($thread->getSlug()); 

        $category->setLastPostBody($post->getBody());

        $category->setLastPosterUsername($post->getUser()->getUsername());

        $category->setLastPostCreatedAt($post->getCreatedAt());

        $category->setIsLastPostOp(false);

        $category->setPosts($category->getPosts() + 1);



        $entityManager->merge($category);           

        $entityManager->flush();

    }



    if ($entity instanceof Thread) {

        $thread = $entity;



        $category = $thread->getCategory(); 

        $category->setLastPostThreadTitle($thread->getTitle()); 

        $category->setLastPostThreadSlug($thread->getSlug()); 

        $category->setLastPostBody($thread->getBody());

        $category->setLastPosterUsername($thread->getUser()->getUsername());

        $category->setLastPostCreatedAt($thread->getCreatedAt());

        $category->setIsLastPostOp(true);



        $entityManager->merge($category);           

        $entityManager->flush();

    }

}


How would be possible to refactor this code to avoid WET?






php doctrine







share|improve this question









New contributor




user10322178 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$












  • $begingroup$
    Errr.... Move the common code above if?
    $endgroup$
    – Your Common Sense
    14 hours ago














2












2








2





$begingroup$


I have a function which does the following:




  1. When new Post Entity is added some fields in Category table are updated.

  2. When new Thread Entity is added the same fields in Category table are updated.


Because of this, some lines are completely the same.



public function postPersist(LifecycleEventArgs $args)

{

    $entity = $args->getObject();

    $entityManager = $args->getObjectManager();



    if ($entity instanceof Post) {

        $post = $entity;



        $thread = $post->getThread();



        $category = $thread->getCategory(); 

        $category->setLastPostThreadTitle($thread->getTitle()); 

        $category->setLastPostThreadSlug($thread->getSlug()); 

        $category->setLastPostBody($post->getBody());

        $category->setLastPosterUsername($post->getUser()->getUsername());

        $category->setLastPostCreatedAt($post->getCreatedAt());

        $category->setIsLastPostOp(false);

        $category->setPosts($category->getPosts() + 1);



        $entityManager->merge($category);           

        $entityManager->flush();

    }



    if ($entity instanceof Thread) {

        $thread = $entity;



        $category = $thread->getCategory(); 

        $category->setLastPostThreadTitle($thread->getTitle()); 

        $category->setLastPostThreadSlug($thread->getSlug()); 

        $category->setLastPostBody($thread->getBody());

        $category->setLastPosterUsername($thread->getUser()->getUsername());

        $category->setLastPostCreatedAt($thread->getCreatedAt());

        $category->setIsLastPostOp(true);



        $entityManager->merge($category);           

        $entityManager->flush();

    }

}


How would be possible to refactor this code to avoid WET?






php doctrine







share|improve this question









New contributor




user10322178 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$




I have a function which does the following:




  1. When new Post Entity is added some fields in Category table are updated.

  2. When new Thread Entity is added the same fields in Category table are updated.


Because of this, some lines are completely the same.



public function postPersist(LifecycleEventArgs $args)

{

    $entity = $args->getObject();

    $entityManager = $args->getObjectManager();



    if ($entity instanceof Post) {

        $post = $entity;



        $thread = $post->getThread();



        $category = $thread->getCategory(); 

        $category->setLastPostThreadTitle($thread->getTitle()); 

        $category->setLastPostThreadSlug($thread->getSlug()); 

        $category->setLastPostBody($post->getBody());

        $category->setLastPosterUsername($post->getUser()->getUsername());

        $category->setLastPostCreatedAt($post->getCreatedAt());

        $category->setIsLastPostOp(false);

        $category->setPosts($category->getPosts() + 1);



        $entityManager->merge($category);           

        $entityManager->flush();

    }



    if ($entity instanceof Thread) {

        $thread = $entity;



        $category = $thread->getCategory(); 

        $category->setLastPostThreadTitle($thread->getTitle()); 

        $category->setLastPostThreadSlug($thread->getSlug()); 

        $category->setLastPostBody($thread->getBody());

        $category->setLastPosterUsername($thread->getUser()->getUsername());

        $category->setLastPostCreatedAt($thread->getCreatedAt());

        $category->setIsLastPostOp(true);



        $entityManager->merge($category);           

        $entityManager->flush();

    }

}


How would be possible to refactor this code to avoid WET?






php doctrine




php doctrine






share|improve this question









New contributor




user10322178 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.











share|improve this question









New contributor




user10322178 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









share|improve this question




share|improve this question








edited 24 mins ago









Jamal♦

30.3k11116226




30.3k11116226






New contributor




user10322178 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









asked 15 hours ago









user10322178user10322178

132




132




New contributor




user10322178 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.





New contributor





user10322178 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.






user10322178 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.












  • $begingroup$
    Errr.... Move the common code above if?
    $endgroup$
    – Your Common Sense
    14 hours ago


















  • $begingroup$
    Errr.... Move the common code above if?
    $endgroup$
    – Your Common Sense
    14 hours ago
















$begingroup$
Errr.... Move the common code above if?
$endgroup$
– Your Common Sense
14 hours ago




$begingroup$
Errr.... Move the common code above if?
$endgroup$
– Your Common Sense
14 hours ago










1 Answer
1






active

oldest

votes


















0












$begingroup$

How about something like this there is some checking that needs to be done because I inverse the $isPost bool and that could be buggy



public function postPersist(LifecycleEventArgs $args)

{

    $entity = $args->getObject();

    $entityManager = $args->getObjectManager();



    $isPost = $entity instanceof Post;



    $thread = $isPost ? $post->getThread() : $entity;



    $details = $isPost ? $entity : $thread;



    $category = $thread->getCategory(); 

    $category->setLastPostThreadTitle($thread->getTitle()); 

    $category->setLastPostThreadSlug($thread->getSlug()); 

    $category->setLastPostBody($details->getBody());

    $category->setLastPosterUsername($details->getUser()->getUsername());

    $category->setLastPostCreatedAt($details->getCreatedAt());



    //NOTE the inversion of the isPost bool

    //TODO Test this

    $category->setIsLastPostOp(!$isPost);



    if($isPost){         

        $category->setPosts($category->getPosts() + 1);

    }



    $entityManager->merge($category);           

    $entityManager->flush();

}





share|improve this answer









$endgroup$













  • $begingroup$
    It works:). Just had to change $post->getThread() to $entity->getThread(), because $post is undefined on line 8
    $endgroup$
    – user10322178
    14 hours ago











Your Answer





StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});






user10322178 is a new contributor. Be nice, and check out our Code of Conduct.










draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212210%2fforum-system-implementation%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes









0












$begingroup$

How about something like this there is some checking that needs to be done because I inverse the $isPost bool and that could be buggy



public function postPersist(LifecycleEventArgs $args)

{

    $entity = $args->getObject();

    $entityManager = $args->getObjectManager();



    $isPost = $entity instanceof Post;



    $thread = $isPost ? $post->getThread() : $entity;



    $details = $isPost ? $entity : $thread;



    $category = $thread->getCategory(); 

    $category->setLastPostThreadTitle($thread->getTitle()); 

    $category->setLastPostThreadSlug($thread->getSlug()); 

    $category->setLastPostBody($details->getBody());

    $category->setLastPosterUsername($details->getUser()->getUsername());

    $category->setLastPostCreatedAt($details->getCreatedAt());



    //NOTE the inversion of the isPost bool

    //TODO Test this

    $category->setIsLastPostOp(!$isPost);



    if($isPost){         

        $category->setPosts($category->getPosts() + 1);

    }



    $entityManager->merge($category);           

    $entityManager->flush();

}





share|improve this answer









$endgroup$













  • $begingroup$
    It works:). Just had to change $post->getThread() to $entity->getThread(), because $post is undefined on line 8
    $endgroup$
    – user10322178
    14 hours ago
















0












$begingroup$

How about something like this there is some checking that needs to be done because I inverse the $isPost bool and that could be buggy



public function postPersist(LifecycleEventArgs $args)

{

    $entity = $args->getObject();

    $entityManager = $args->getObjectManager();



    $isPost = $entity instanceof Post;



    $thread = $isPost ? $post->getThread() : $entity;



    $details = $isPost ? $entity : $thread;



    $category = $thread->getCategory(); 

    $category->setLastPostThreadTitle($thread->getTitle()); 

    $category->setLastPostThreadSlug($thread->getSlug()); 

    $category->setLastPostBody($details->getBody());

    $category->setLastPosterUsername($details->getUser()->getUsername());

    $category->setLastPostCreatedAt($details->getCreatedAt());



    //NOTE the inversion of the isPost bool

    //TODO Test this

    $category->setIsLastPostOp(!$isPost);



    if($isPost){         

        $category->setPosts($category->getPosts() + 1);

    }



    $entityManager->merge($category);           

    $entityManager->flush();

}





share|improve this answer









$endgroup$













  • $begingroup$
    It works:). Just had to change $post->getThread() to $entity->getThread(), because $post is undefined on line 8
    $endgroup$
    – user10322178
    14 hours ago














0












0








0





$begingroup$

How about something like this there is some checking that needs to be done because I inverse the $isPost bool and that could be buggy



public function postPersist(LifecycleEventArgs $args)

{

    $entity = $args->getObject();

    $entityManager = $args->getObjectManager();



    $isPost = $entity instanceof Post;



    $thread = $isPost ? $post->getThread() : $entity;



    $details = $isPost ? $entity : $thread;



    $category = $thread->getCategory(); 

    $category->setLastPostThreadTitle($thread->getTitle()); 

    $category->setLastPostThreadSlug($thread->getSlug()); 

    $category->setLastPostBody($details->getBody());

    $category->setLastPosterUsername($details->getUser()->getUsername());

    $category->setLastPostCreatedAt($details->getCreatedAt());



    //NOTE the inversion of the isPost bool

    //TODO Test this

    $category->setIsLastPostOp(!$isPost);



    if($isPost){         

        $category->setPosts($category->getPosts() + 1);

    }



    $entityManager->merge($category);           

    $entityManager->flush();

}





share|improve this answer









$endgroup$



How about something like this there is some checking that needs to be done because I inverse the $isPost bool and that could be buggy



public function postPersist(LifecycleEventArgs $args)

{

    $entity = $args->getObject();

    $entityManager = $args->getObjectManager();



    $isPost = $entity instanceof Post;



    $thread = $isPost ? $post->getThread() : $entity;



    $details = $isPost ? $entity : $thread;



    $category = $thread->getCategory(); 

    $category->setLastPostThreadTitle($thread->getTitle()); 

    $category->setLastPostThreadSlug($thread->getSlug()); 

    $category->setLastPostBody($details->getBody());

    $category->setLastPosterUsername($details->getUser()->getUsername());

    $category->setLastPostCreatedAt($details->getCreatedAt());



    //NOTE the inversion of the isPost bool

    //TODO Test this

    $category->setIsLastPostOp(!$isPost);



    if($isPost){         

        $category->setPosts($category->getPosts() + 1);

    }



    $entityManager->merge($category);           

    $entityManager->flush();

}






share|improve this answer












share|improve this answer



share|improve this answer










answered 14 hours ago









DanDan

468311




468311












  • $begingroup$
    It works:). Just had to change $post->getThread() to $entity->getThread(), because $post is undefined on line 8
    $endgroup$
    – user10322178
    14 hours ago


















  • $begingroup$
    It works:). Just had to change $post->getThread() to $entity->getThread(), because $post is undefined on line 8
    $endgroup$
    – user10322178
    14 hours ago
















$begingroup$
It works:). Just had to change $post->getThread() to $entity->getThread(), because $post is undefined on line 8
$endgroup$
– user10322178
14 hours ago




$begingroup$
It works:). Just had to change $post->getThread() to $entity->getThread(), because $post is undefined on line 8
$endgroup$
– user10322178
14 hours ago










user10322178 is a new contributor. Be nice, and check out our Code of Conduct.










draft saved

draft discarded


















user10322178 is a new contributor. Be nice, and check out our Code of Conduct.













user10322178 is a new contributor. Be nice, and check out our Code of Conduct.












user10322178 is a new contributor. Be nice, and check out our Code of Conduct.
















Thanks for contributing an answer to Code Review Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid …



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


Use MathJax to format equations. MathJax reference.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212210%2fforum-system-implementation%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







-

Popular posts from this blog

404 Error Contact Form 7 ajax form submitting

Image
0 The contact form does not work, and affects loading after one try. The chrome console shows the error message: POST http://example.com/wp-json/contact-form-7/v1/contact-forms/50/feedback 404 (Not Found) send @ jquery.js?ver=1.12.4:4 ajax @ jquery.js?ver=1.12.4:4 wpcf7.submit @ scripts.js?ver=5.0.3:346 (anonymous) @ scripts.js?ver=5.0.3:53 dispatch @ jquery.js?ver=1.12.4:3 r.handle @ jquery.js?ver=1.12.4:3 How to solve this issue? thanks in advance javascript wordpress contact-form-7 share | improve this question edited Jul 17 '18 at 5:39 Kiran Shahi 4,745 3 16 43 ...
Read more

How to know if a Active Directory user can login interactively

Image
1 I would like to know if and how is it possible to know if a AD user can login interactively (on a server) in a domain. I need to know if I can find it out using a LDAP search. Thanks. windows active-directory login user-permissions user-profile share | improve this question edited 1 hour ago yagmoth555 ♦ 11.6k 3 17 42 asked 1 hour ago Luigi Luigi 6 1 New contributor ...
Read more

Refactoring coordinates for Minecraft Pi buildings written in Python

Image
0 $begingroup$ I'm fairly new to coding and I wrote this script in Python for a house with a roof in Minecraft Pi. I've found different ways to write the coordinates to make the code base shorter, but I'm wondering if it is possible for me to refactor it any further so I don't have to list each coordinate line by line. import mcpi.minecraft as minecraft import mcpi.block as block mc = minecraft.Minecraft.create() p = mc.player.getTilePos() mc.setBlocks(p.x+1, p.y, p.z+1, #Main structure starting coordinates (DO NOT ALTER) p.x+19, p.y+4, p.z+6, #Structure size/coordinates (Alters cube size) block.STONE_BRICK) mc.setBlocks(p.x+2, p.y+1, p.z+2, #Hollowing out main structure interior p.x+18, p.y+3, p.z+5, block.AIR) mc.setBlocks(p.x, p.y...
Read more