Using mobx for a trivial singleton











up vote
0
down vote

favorite












I'm very new to mobx and unsure, how to use it properly. I'm used to OO, so I prefer using the class keyword and I found myself writing the following singleton class:



// @flow
import {decorate, observable, action} from "mobx"

class Auth {
email: string = ""
authorization: string = ""

setEmail(email: string) { // P1
this.email = email
}
}

const auth = new Auth()

decorate({dummy: auth}, { // P2
auth: observable,
})

decorate(Auth, {
setEmail: action,
})

export {auth}


I myself find it pretty strange, nonetheless it seems to work.




  • P1: This is actually wrong as I wanted to use an arrow function, so that this is bound to the current instance. I'm about to change it, but I'm leaving it here hoping for an explanation why it works.

  • P2: This is a hack used to decorate all members of auth as observable. AFAIK the decoration marks all members recursively, which is about what I wanted (marking setEmail is superfluous, but AFAIK harmless).


I'm perfectly sure that this isn't the best piece of code and I'll gladly improve it. I'd prefer to preserve the class-syntax, if it makes any sense, but I'm open to all kinds of changes.









share


























    up vote
    0
    down vote

    favorite












    I'm very new to mobx and unsure, how to use it properly. I'm used to OO, so I prefer using the class keyword and I found myself writing the following singleton class:



    // @flow
    import {decorate, observable, action} from "mobx"

    class Auth {
    email: string = ""
    authorization: string = ""

    setEmail(email: string) { // P1
    this.email = email
    }
    }

    const auth = new Auth()

    decorate({dummy: auth}, { // P2
    auth: observable,
    })

    decorate(Auth, {
    setEmail: action,
    })

    export {auth}


    I myself find it pretty strange, nonetheless it seems to work.




    • P1: This is actually wrong as I wanted to use an arrow function, so that this is bound to the current instance. I'm about to change it, but I'm leaving it here hoping for an explanation why it works.

    • P2: This is a hack used to decorate all members of auth as observable. AFAIK the decoration marks all members recursively, which is about what I wanted (marking setEmail is superfluous, but AFAIK harmless).


    I'm perfectly sure that this isn't the best piece of code and I'll gladly improve it. I'd prefer to preserve the class-syntax, if it makes any sense, but I'm open to all kinds of changes.









    share
























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I'm very new to mobx and unsure, how to use it properly. I'm used to OO, so I prefer using the class keyword and I found myself writing the following singleton class:



      // @flow
      import {decorate, observable, action} from "mobx"

      class Auth {
      email: string = ""
      authorization: string = ""

      setEmail(email: string) { // P1
      this.email = email
      }
      }

      const auth = new Auth()

      decorate({dummy: auth}, { // P2
      auth: observable,
      })

      decorate(Auth, {
      setEmail: action,
      })

      export {auth}


      I myself find it pretty strange, nonetheless it seems to work.




      • P1: This is actually wrong as I wanted to use an arrow function, so that this is bound to the current instance. I'm about to change it, but I'm leaving it here hoping for an explanation why it works.

      • P2: This is a hack used to decorate all members of auth as observable. AFAIK the decoration marks all members recursively, which is about what I wanted (marking setEmail is superfluous, but AFAIK harmless).


      I'm perfectly sure that this isn't the best piece of code and I'll gladly improve it. I'd prefer to preserve the class-syntax, if it makes any sense, but I'm open to all kinds of changes.









      share













      I'm very new to mobx and unsure, how to use it properly. I'm used to OO, so I prefer using the class keyword and I found myself writing the following singleton class:



      // @flow
      import {decorate, observable, action} from "mobx"

      class Auth {
      email: string = ""
      authorization: string = ""

      setEmail(email: string) { // P1
      this.email = email
      }
      }

      const auth = new Auth()

      decorate({dummy: auth}, { // P2
      auth: observable,
      })

      decorate(Auth, {
      setEmail: action,
      })

      export {auth}


      I myself find it pretty strange, nonetheless it seems to work.




      • P1: This is actually wrong as I wanted to use an arrow function, so that this is bound to the current instance. I'm about to change it, but I'm leaving it here hoping for an explanation why it works.

      • P2: This is a hack used to decorate all members of auth as observable. AFAIK the decoration marks all members recursively, which is about what I wanted (marking setEmail is superfluous, but AFAIK harmless).


      I'm perfectly sure that this isn't the best piece of code and I'll gladly improve it. I'd prefer to preserve the class-syntax, if it makes any sense, but I'm open to all kinds of changes.







      javascript react.js mobx





      share












      share










      share



      share










      asked 2 mins ago









      maaartinus

      12.3k12668




      12.3k12668



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209195%2fusing-mobx-for-a-trivial-singleton%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209195%2fusing-mobx-for-a-trivial-singleton%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'