Is this code better written using ternary conditional or switch or if-else?












0












$begingroup$


When I'm checking some conditions to return one of a small handful of values, I often end up nesting several ternary conditional operators (?:) rather than using a series of if..elseif statements.



As a simple example of this, presume I have:



    public enum StringValueType 
{
Null,
Empty,
Short,
Long
}

public string Value { get; set; }


I'm trying to return the appropriate StringValueType value in a property:



    public StringValueType ValueType => 
Value == null ? StringValueType.Null
: Value == string.Empty ? StringValueType.Empty
: Value.Length < 8 ? StringValueType.Short
: StringValueType.Long;


Is this readable? Are there downsides? I'm not sure I've ever come across this in other people's code before.



For comparison, some alternate ways this might be written:



If-else



    public StringValueType ValueType
{
get
{
if (Value == null)
return StringValueType.Null;
else if (Value == string.Empty)
return StringValueType.Empty;
else if (Value.Length < 8)
return StringValueType.Short;
else
return StringValueType.Long;
}
}


Switch+Conditional



    public StringValueType ValueType
{
get
{
switch (MatchedDefinitionName)
{
case null:
return StringValueType.Null;
case "":
return StringValueType.Empty;
default:
return Value.Length < 8 ? StringValueType.Short : StringValueType.Long;
}
}
}








share







New contributor




gregmac is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    When I'm checking some conditions to return one of a small handful of values, I often end up nesting several ternary conditional operators (?:) rather than using a series of if..elseif statements.



    As a simple example of this, presume I have:



        public enum StringValueType 
    {
    Null,
    Empty,
    Short,
    Long
    }

    public string Value { get; set; }


    I'm trying to return the appropriate StringValueType value in a property:



        public StringValueType ValueType => 
    Value == null ? StringValueType.Null
    : Value == string.Empty ? StringValueType.Empty
    : Value.Length < 8 ? StringValueType.Short
    : StringValueType.Long;


    Is this readable? Are there downsides? I'm not sure I've ever come across this in other people's code before.



    For comparison, some alternate ways this might be written:



    If-else



        public StringValueType ValueType
    {
    get
    {
    if (Value == null)
    return StringValueType.Null;
    else if (Value == string.Empty)
    return StringValueType.Empty;
    else if (Value.Length < 8)
    return StringValueType.Short;
    else
    return StringValueType.Long;
    }
    }


    Switch+Conditional



        public StringValueType ValueType
    {
    get
    {
    switch (MatchedDefinitionName)
    {
    case null:
    return StringValueType.Null;
    case "":
    return StringValueType.Empty;
    default:
    return Value.Length < 8 ? StringValueType.Short : StringValueType.Long;
    }
    }
    }








    share







    New contributor




    gregmac is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      When I'm checking some conditions to return one of a small handful of values, I often end up nesting several ternary conditional operators (?:) rather than using a series of if..elseif statements.



      As a simple example of this, presume I have:



          public enum StringValueType 
      {
      Null,
      Empty,
      Short,
      Long
      }

      public string Value { get; set; }


      I'm trying to return the appropriate StringValueType value in a property:



          public StringValueType ValueType => 
      Value == null ? StringValueType.Null
      : Value == string.Empty ? StringValueType.Empty
      : Value.Length < 8 ? StringValueType.Short
      : StringValueType.Long;


      Is this readable? Are there downsides? I'm not sure I've ever come across this in other people's code before.



      For comparison, some alternate ways this might be written:



      If-else



          public StringValueType ValueType
      {
      get
      {
      if (Value == null)
      return StringValueType.Null;
      else if (Value == string.Empty)
      return StringValueType.Empty;
      else if (Value.Length < 8)
      return StringValueType.Short;
      else
      return StringValueType.Long;
      }
      }


      Switch+Conditional



          public StringValueType ValueType
      {
      get
      {
      switch (MatchedDefinitionName)
      {
      case null:
      return StringValueType.Null;
      case "":
      return StringValueType.Empty;
      default:
      return Value.Length < 8 ? StringValueType.Short : StringValueType.Long;
      }
      }
      }








      share







      New contributor




      gregmac is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      When I'm checking some conditions to return one of a small handful of values, I often end up nesting several ternary conditional operators (?:) rather than using a series of if..elseif statements.



      As a simple example of this, presume I have:



          public enum StringValueType 
      {
      Null,
      Empty,
      Short,
      Long
      }

      public string Value { get; set; }


      I'm trying to return the appropriate StringValueType value in a property:



          public StringValueType ValueType => 
      Value == null ? StringValueType.Null
      : Value == string.Empty ? StringValueType.Empty
      : Value.Length < 8 ? StringValueType.Short
      : StringValueType.Long;


      Is this readable? Are there downsides? I'm not sure I've ever come across this in other people's code before.



      For comparison, some alternate ways this might be written:



      If-else



          public StringValueType ValueType
      {
      get
      {
      if (Value == null)
      return StringValueType.Null;
      else if (Value == string.Empty)
      return StringValueType.Empty;
      else if (Value.Length < 8)
      return StringValueType.Short;
      else
      return StringValueType.Long;
      }
      }


      Switch+Conditional



          public StringValueType ValueType
      {
      get
      {
      switch (MatchedDefinitionName)
      {
      case null:
      return StringValueType.Null;
      case "":
      return StringValueType.Empty;
      default:
      return Value.Length < 8 ? StringValueType.Short : StringValueType.Long;
      }
      }
      }






      c#





      share







      New contributor




      gregmac is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      gregmac is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      gregmac is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 7 mins ago









      gregmacgregmac

      1011




      1011




      New contributor




      gregmac is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      gregmac is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      gregmac is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          gregmac is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212116%2fis-this-code-better-written-using-ternary-conditional-or-switch-or-if-else%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          gregmac is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          gregmac is a new contributor. Be nice, and check out our Code of Conduct.













          gregmac is a new contributor. Be nice, and check out our Code of Conduct.












          gregmac is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212116%2fis-this-code-better-written-using-ternary-conditional-or-switch-or-if-else%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'