Using solid principles php7
0
I'm using this code below, but I have to implement SOLID principles,
<?php
abstract class HouseDetail {
private $isBroken;
public function __construct(bool $isBroken)
{
$this->isBroken = $isBroken;
}
public function isBroken(): bool
{
return $this->isBroken;
}
}
class Door extends HouseDetail
{
}
class window extends HouseDetail
{
}
class House
{
/**
* @var HouseDetail
*/
private $details;
/**
* @param HouseDetail $details
*/
public function __construct(array $details)
{
$this->details = $details;
}
public function isBroken(): bool
{
foreach ($this->details as $detail) {
if ($detail->isBroken()) {
return true;
}
}
return false;
}
public function isPaintingDamaged(): bool
{
// MAKE AN IMPLEMENTATION
}
}
How can I improve the quality of this code and change anything to change anything in the existing code in order to make an implementation SOLID compliant, Principle of Dependency Inversion ?
And then I should $House = new House([new Door(true), new window(false)]); // we pass a list of all details
php
edited 16 mins ago
John Conde
22017
asked 3 hours ago
samir deuxsamir deux
11
New contributor
samir deux is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
0
I'm using this code below, but I have to implement SOLID principles,
<?php
abstract class HouseDetail {
private $isBroken;
public function __construct(bool $isBroken)
{
$this->isBroken = $isBroken;
}
public function isBroken(): bool
{
return $this->isBroken;
}
}
class Door extends HouseDetail
{
}
class window extends HouseDetail
{
}
class House
{
/**
* @var HouseDetail
*/
private $details;
/**
* @param HouseDetail $details
*/
public function __construct(array $details)
{
$this->details = $details;
}
public function isBroken(): bool
{
foreach ($this->details as $detail) {
if ($detail->isBroken()) {
return true;
}
}
return false;
}
public function isPaintingDamaged(): bool
{
// MAKE AN IMPLEMENTATION
}
}
How can I improve the quality of this code and change anything to change anything in the existing code in order to make an implementation SOLID compliant, Principle of Dependency Inversion ?
And then I should $House = new House([new Door(true), new window(false)]); // we pass a list of all details
php
edited 16 mins ago
John Conde
22017
asked 3 hours ago
samir deuxsamir deux
11
New contributor
samir deux is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
0
0
0
I'm using this code below, but I have to implement SOLID principles,
<?php
abstract class HouseDetail {
private $isBroken;
public function __construct(bool $isBroken)
{
$this->isBroken = $isBroken;
}
public function isBroken(): bool
{
return $this->isBroken;
}
}
class Door extends HouseDetail
{
}
class window extends HouseDetail
{
}
class House
{
/**
* @var HouseDetail
*/
private $details;
/**
* @param HouseDetail $details
*/
public function __construct(array $details)
{
$this->details = $details;
}
public function isBroken(): bool
{
foreach ($this->details as $detail) {
if ($detail->isBroken()) {
return true;
}
}
return false;
}
public function isPaintingDamaged(): bool
{
// MAKE AN IMPLEMENTATION
}
}
How can I improve the quality of this code and change anything to change anything in the existing code in order to make an implementation SOLID compliant, Principle of Dependency Inversion ?
And then I should $House = new House([new Door(true), new window(false)]); // we pass a list of all details
php
edited 16 mins ago
John Conde
22017
asked 3 hours ago
samir deuxsamir deux
11
New contributor
samir deux is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
I'm using this code below, but I have to implement SOLID principles,
<?php
abstract class HouseDetail {
private $isBroken;
public function __construct(bool $isBroken)
{
$this->isBroken = $isBroken;
}
public function isBroken(): bool
{
return $this->isBroken;
}
}
class Door extends HouseDetail
{
}
class window extends HouseDetail
{
}
class House
{
/**
* @var HouseDetail
*/
private $details;
/**
* @param HouseDetail $details
*/
public function __construct(array $details)
{
$this->details = $details;
}
public function isBroken(): bool
{
foreach ($this->details as $detail) {
if ($detail->isBroken()) {
return true;
}
}
return false;
}
public function isPaintingDamaged(): bool
{
// MAKE AN IMPLEMENTATION
}
}
How can I improve the quality of this code and change anything to change anything in the existing code in order to make an implementation SOLID compliant, Principle of Dependency Inversion ?
And then I should $House = new House([new Door(true), new window(false)]); // we pass a list of all details
php
php
edited 16 mins ago
John Conde
22017
asked 3 hours ago
samir deuxsamir deux
11
New contributor
samir deux is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 16 mins ago
John Conde
22017
asked 3 hours ago
samir deuxsamir deux
11
New contributor
samir deux is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 16 mins ago
John Conde
22017
edited 16 mins ago
John Conde
22017
edited 16 mins ago
John Conde
22017
22017
asked 3 hours ago
samir deuxsamir deux
11
New contributor
samir deux is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 3 hours ago
samir deuxsamir deux
11
asked 3 hours ago
samir deuxsamir deux
11
11
New contributor
samir deux is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
samir deux is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
samir deux is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
samir deux is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211139%2fusing-solid-principles-php7%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
samir deux is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
samir deux is a new contributor. Be nice, and check out our Code of Conduct.
samir deux is a new contributor. Be nice, and check out our Code of Conduct.
samir deux is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211139%2fusing-solid-principles-php7%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
