Using long if else conditionals within nested loops in Ruby
I'm currently working on parsing a users application into a pdf form. FormStack is the form service i'm currently for this project. I have the following code:
def fill_out
form_fields.each do |field|
@user_submission_data.each do |field_data|
if field_data["field"] == field
fill_form_with_data(field, field_data)
elsif phone_sections(field) && field.include?(field_data["field"])
fill_phone(field, field_data["value"])
end
end
end
end
This method works. It iterates over the fields of a PDF form which look something like this:
[2] pry(#<PdfScrie>)> form_fields
=> ["ENTER DATE",
"71177829",
"71177830",
"71177831",
"71940201",
"71940206",
"71940216",
"71940224",
"71177834",
"71177836",
"71183377",
This fields in form_fields are then use to match with the submission of the user's application to fill the right field in the pdf form with the user's data. The user's submission data looks something like this on the back end.
[1] pry(#<PdfScrie>)> @user_submission_data
=> [{"field"=>"72142647", "value"=>"SCRIE"},
{"field"=>"72142648", "value"=>"INITIAL"},
{"field"=>"71177825", "value"=>"SCRIE"},
{"field"=>"71180594", "value"=>"INITIAL"},
{"field"=>"71177829", "value"=>"Mar 03, 1995"},
{"field"=>"71344296", "value"=>"23"},
{"field"=>"71940956", "value"=>"Yes"},
{"field"=>"71177828", "value"=>"first = Michael B.nlast = Jordan"},
{"field"=>"71177830", "value"=>"123-45-6789"},
{"field"=>"71177831", "value"=>"16 Fisher Drive"},
{"field"=>"71940206", "value"=>"Staten Island"},
{"field"=>"71940216", "value"=>"NY"},
{"field"=>"71940224", "value"=>"11245"}
However the tricky part comes when parsing a phone number into the PDF form. The phone number received from FormStack is a string that looks as follows:
{"field"=>"71177832", "value"=>"(646) 896-5410"} However in the pdf form I have to break it into (000)-000-0000 3 sections area code, first three digits and last four digits.
I have a method phone_sections(field) that checks if the field has a phone subsection.
PHONE_NUMBER_SECTIONS = ['-a','-b','-c']
def phone_sections(phone_field)
PHONE_NUMBER_SECTIONS.any? { |section| phone_field.include?(section) }
end
## Example of fields with subsections in form_fields
"71177832-a",
"71177832-b",
"71177832-c",
Asking the community, should I encapsulate elsif phone_sections(field) && field.include?(field_data["field"]) into it'own method? something like elsif method_for_phone_number(arg1, arg2) or is this fine?
Is there a better way to deal with this iteration? I'm I meeting SOLID principles? My point is that is doing one thing. Filling out the form field. What style violations am I committing? Any feedback highly appreciated.
algorithm ruby array
asked 1 min ago
Steven AguilarSteven Aguilar
1063
add a comment |
I'm currently working on parsing a users application into a pdf form. FormStack is the form service i'm currently for this project. I have the following code:
def fill_out
form_fields.each do |field|
@user_submission_data.each do |field_data|
if field_data["field"] == field
fill_form_with_data(field, field_data)
elsif phone_sections(field) && field.include?(field_data["field"])
fill_phone(field, field_data["value"])
end
end
end
end
This method works. It iterates over the fields of a PDF form which look something like this:
[2] pry(#<PdfScrie>)> form_fields
=> ["ENTER DATE",
"71177829",
"71177830",
"71177831",
"71940201",
"71940206",
"71940216",
"71940224",
"71177834",
"71177836",
"71183377",
This fields in form_fields are then use to match with the submission of the user's application to fill the right field in the pdf form with the user's data. The user's submission data looks something like this on the back end.
[1] pry(#<PdfScrie>)> @user_submission_data
=> [{"field"=>"72142647", "value"=>"SCRIE"},
{"field"=>"72142648", "value"=>"INITIAL"},
{"field"=>"71177825", "value"=>"SCRIE"},
{"field"=>"71180594", "value"=>"INITIAL"},
{"field"=>"71177829", "value"=>"Mar 03, 1995"},
{"field"=>"71344296", "value"=>"23"},
{"field"=>"71940956", "value"=>"Yes"},
{"field"=>"71177828", "value"=>"first = Michael B.nlast = Jordan"},
{"field"=>"71177830", "value"=>"123-45-6789"},
{"field"=>"71177831", "value"=>"16 Fisher Drive"},
{"field"=>"71940206", "value"=>"Staten Island"},
{"field"=>"71940216", "value"=>"NY"},
{"field"=>"71940224", "value"=>"11245"}
However the tricky part comes when parsing a phone number into the PDF form. The phone number received from FormStack is a string that looks as follows:
{"field"=>"71177832", "value"=>"(646) 896-5410"} However in the pdf form I have to break it into (000)-000-0000 3 sections area code, first three digits and last four digits.
I have a method phone_sections(field) that checks if the field has a phone subsection.
PHONE_NUMBER_SECTIONS = ['-a','-b','-c']
def phone_sections(phone_field)
PHONE_NUMBER_SECTIONS.any? { |section| phone_field.include?(section) }
end
## Example of fields with subsections in form_fields
"71177832-a",
"71177832-b",
"71177832-c",
Asking the community, should I encapsulate elsif phone_sections(field) && field.include?(field_data["field"]) into it'own method? something like elsif method_for_phone_number(arg1, arg2) or is this fine?
Is there a better way to deal with this iteration? I'm I meeting SOLID principles? My point is that is doing one thing. Filling out the form field. What style violations am I committing? Any feedback highly appreciated.
algorithm ruby array
asked 1 min ago
Steven AguilarSteven Aguilar
1063
add a comment |
I'm currently working on parsing a users application into a pdf form. FormStack is the form service i'm currently for this project. I have the following code:
def fill_out
form_fields.each do |field|
@user_submission_data.each do |field_data|
if field_data["field"] == field
fill_form_with_data(field, field_data)
elsif phone_sections(field) && field.include?(field_data["field"])
fill_phone(field, field_data["value"])
end
end
end
end
This method works. It iterates over the fields of a PDF form which look something like this:
[2] pry(#<PdfScrie>)> form_fields
=> ["ENTER DATE",
"71177829",
"71177830",
"71177831",
"71940201",
"71940206",
"71940216",
"71940224",
"71177834",
"71177836",
"71183377",
This fields in form_fields are then use to match with the submission of the user's application to fill the right field in the pdf form with the user's data. The user's submission data looks something like this on the back end.
[1] pry(#<PdfScrie>)> @user_submission_data
=> [{"field"=>"72142647", "value"=>"SCRIE"},
{"field"=>"72142648", "value"=>"INITIAL"},
{"field"=>"71177825", "value"=>"SCRIE"},
{"field"=>"71180594", "value"=>"INITIAL"},
{"field"=>"71177829", "value"=>"Mar 03, 1995"},
{"field"=>"71344296", "value"=>"23"},
{"field"=>"71940956", "value"=>"Yes"},
{"field"=>"71177828", "value"=>"first = Michael B.nlast = Jordan"},
{"field"=>"71177830", "value"=>"123-45-6789"},
{"field"=>"71177831", "value"=>"16 Fisher Drive"},
{"field"=>"71940206", "value"=>"Staten Island"},
{"field"=>"71940216", "value"=>"NY"},
{"field"=>"71940224", "value"=>"11245"}
However the tricky part comes when parsing a phone number into the PDF form. The phone number received from FormStack is a string that looks as follows:
{"field"=>"71177832", "value"=>"(646) 896-5410"} However in the pdf form I have to break it into (000)-000-0000 3 sections area code, first three digits and last four digits.
I have a method phone_sections(field) that checks if the field has a phone subsection.
PHONE_NUMBER_SECTIONS = ['-a','-b','-c']
def phone_sections(phone_field)
PHONE_NUMBER_SECTIONS.any? { |section| phone_field.include?(section) }
end
## Example of fields with subsections in form_fields
"71177832-a",
"71177832-b",
"71177832-c",
Asking the community, should I encapsulate elsif phone_sections(field) && field.include?(field_data["field"]) into it'own method? something like elsif method_for_phone_number(arg1, arg2) or is this fine?
Is there a better way to deal with this iteration? I'm I meeting SOLID principles? My point is that is doing one thing. Filling out the form field. What style violations am I committing? Any feedback highly appreciated.
algorithm ruby array
asked 1 min ago
Steven AguilarSteven Aguilar
1063
I'm currently working on parsing a users application into a pdf form. FormStack is the form service i'm currently for this project. I have the following code:
def fill_out
form_fields.each do |field|
@user_submission_data.each do |field_data|
if field_data["field"] == field
fill_form_with_data(field, field_data)
elsif phone_sections(field) && field.include?(field_data["field"])
fill_phone(field, field_data["value"])
end
end
end
end
This method works. It iterates over the fields of a PDF form which look something like this:
[2] pry(#<PdfScrie>)> form_fields
=> ["ENTER DATE",
"71177829",
"71177830",
"71177831",
"71940201",
"71940206",
"71940216",
"71940224",
"71177834",
"71177836",
"71183377",
This fields in form_fields are then use to match with the submission of the user's application to fill the right field in the pdf form with the user's data. The user's submission data looks something like this on the back end.
[1] pry(#<PdfScrie>)> @user_submission_data
=> [{"field"=>"72142647", "value"=>"SCRIE"},
{"field"=>"72142648", "value"=>"INITIAL"},
{"field"=>"71177825", "value"=>"SCRIE"},
{"field"=>"71180594", "value"=>"INITIAL"},
{"field"=>"71177829", "value"=>"Mar 03, 1995"},
{"field"=>"71344296", "value"=>"23"},
{"field"=>"71940956", "value"=>"Yes"},
{"field"=>"71177828", "value"=>"first = Michael B.nlast = Jordan"},
{"field"=>"71177830", "value"=>"123-45-6789"},
{"field"=>"71177831", "value"=>"16 Fisher Drive"},
{"field"=>"71940206", "value"=>"Staten Island"},
{"field"=>"71940216", "value"=>"NY"},
{"field"=>"71940224", "value"=>"11245"}
However the tricky part comes when parsing a phone number into the PDF form. The phone number received from FormStack is a string that looks as follows:
{"field"=>"71177832", "value"=>"(646) 896-5410"} However in the pdf form I have to break it into (000)-000-0000 3 sections area code, first three digits and last four digits.
I have a method phone_sections(field) that checks if the field has a phone subsection.
PHONE_NUMBER_SECTIONS = ['-a','-b','-c']
def phone_sections(phone_field)
PHONE_NUMBER_SECTIONS.any? { |section| phone_field.include?(section) }
end
## Example of fields with subsections in form_fields
"71177832-a",
"71177832-b",
"71177832-c",
Asking the community, should I encapsulate elsif phone_sections(field) && field.include?(field_data["field"]) into it'own method? something like elsif method_for_phone_number(arg1, arg2) or is this fine?
Is there a better way to deal with this iteration? I'm I meeting SOLID principles? My point is that is doing one thing. Filling out the form field. What style violations am I committing? Any feedback highly appreciated.
algorithm ruby array
algorithm ruby array
asked 1 min ago
Steven AguilarSteven Aguilar
1063
asked 1 min ago
Steven AguilarSteven Aguilar
1063
asked 1 min ago
Steven AguilarSteven Aguilar
1063
asked 1 min ago
Steven AguilarSteven Aguilar
1063
asked 1 min ago
Steven AguilarSteven Aguilar
1063
1063
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211352%2fusing-long-if-else-conditionals-within-nested-loops-in-ruby%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211352%2fusing-long-if-else-conditionals-within-nested-loops-in-ruby%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
