Manipulating/Displaying Data based on boolean value in Javascript












0














I have this function (used on a timeout due to my page loading time) to display information on my site. It is very clunky. As you can see in the code, certain values (current year, costume_exists boolean value) change the output of data being displayed. I grab this data from my table view that I load into the page. Is there an easier way of doing this?



setTimeout(function() {
var table = document.getElementById("bands");
var icon = "</i>";
if (table != null) {
for (var i = 0; i < table.rows.length; i++) {
for (var j = 0; j < table.rows[i].cells.length; j++)
table.rows[i].cells[j].onclick = function() {
if (this.cellIndex == 7) {
if (!this.innerHTML.includes(icon)) {
var $row = $(this).closest("tr");
var $year = $row.find(".year").text();
var $prize = $row.find(".prize").text();
var $band = $row.find(".band").text();
var $mp = $row.find(".mp").text();
var $ge_music = $row.find(".ge_music").text();
var $vp = $row.find(".vp").text();
var $ge_visual = $row.find(".ge_visual").text();
var $costume = $row.find(".costume").text();
var $total = $row.find(".total").text();
var $costumer = $row.find(".costumer").text();
var $designer = $row.find(".designer").text();
var $arranger = $row.find(".arranger").text();
var $choreographer = $row.find(".choreographer").text();

if ($costume.length > 1) {
costume_exists = true;
} else {
costume_exists = false;
}

if ($mp.length > 0) {
playing_exists = true;
} else {
playing_exists = false;
}

breakdown = "breakdown"
if ($year < 1991 && costume_exists) {
breakdown = ('<h3>' + $band + " " + $year + '</h3>' +
'<i>' + getOrdinal($prize) + ' Prize' + '</i><br><br>' +
'<b>Music:</b> ' + $ge_music + '<br>' +
'<b>Presentation:</b> ' + $ge_visual + '<br>' +
'<b>Costume:</b> ' + $costume + '<br><br>' +
'<b>Total Points:</b> ' + $total + '<br><br>' +
'<b>Costumer:</b> ' + $costumer + '<br>' +
'<b>Costume/Set Designer:</b> ' + $designer + '<br>' +
'<b>Music Arranger:</b> ' + $arranger + '<br>' +
'<b>Choreographer:</b> ' + $choreographer + '<br>')
swal({
title: 'Point Breakdown',
html: breakdown
})
} else if (costume_exists) {
breakdown = ('<h3>' + $band + " " + $year + '</h3>' +
'<i>' + getOrdinal($prize) + ' Prize' + '</i><br><br>' +
'<b>Music Playing:</b> ' + $mp + '<br>' +
'<b>General Effect Music:</b> ' + $ge_music + '<br>' +
'<b>Visual Performance:</b> ' + $vp + '<br>' +
'<b>General Effect - Visual:</b> ' + $ge_visual + '<br>' +
'<b>Costume:</b> ' + $costume + '<br><br>' +
'<b>Total Points:</b> ' + $total + '<br><br>' +
'<b>Costumer:</b> ' + $costumer + '<br>' +
'<b>Costume/Set Designer:</b> ' + $designer + '<br>' +
'<b>Music Arranger:</b> ' + $arranger + '<br>' +
'<b>Choreographer:</b> ' + $choreographer + '<br>')
swal({
title: 'Point Breakdown',
html: breakdown
})
} else if (playing_exists) {
breakdown = ('<h3>' + $band + " " + $year + '</h3>' +
'<i>' + getOrdinal($prize) + ' Prize' + '</i><br><br>' +
'<b>Music Playing:</b> ' + $mp + '<br>' +
'<b>General Effect Music:</b> ' + $ge_music + '<br>' +
'<b>Visual Performance:</b> ' + $vp + '<br>' +
'<b>General Effect - Visual:</b> ' + $ge_visual + '<br><br>' +
'<b>Total Points:</b> ' + $total + '<br><br>' +
'<b>Costumer:</b> ' + $costumer + '<br>' +
'<b>Costume/Set Designer:</b> ' + $designer + '<br>' +
'<b>Music Arranger:</b> ' + $arranger + '<br>' +
'<b>Choreographer:</b> ' + $choreographer + '<br>')
swal({
title: 'Point Breakdown',
html: breakdown
})
} else {
alert("No point breakdowns for " + $year + " are available.");
}
}
}
}
}
};
}, 700);









share|improve this question





























    0














    I have this function (used on a timeout due to my page loading time) to display information on my site. It is very clunky. As you can see in the code, certain values (current year, costume_exists boolean value) change the output of data being displayed. I grab this data from my table view that I load into the page. Is there an easier way of doing this?



    setTimeout(function() {
    var table = document.getElementById("bands");
    var icon = "</i>";
    if (table != null) {
    for (var i = 0; i < table.rows.length; i++) {
    for (var j = 0; j < table.rows[i].cells.length; j++)
    table.rows[i].cells[j].onclick = function() {
    if (this.cellIndex == 7) {
    if (!this.innerHTML.includes(icon)) {
    var $row = $(this).closest("tr");
    var $year = $row.find(".year").text();
    var $prize = $row.find(".prize").text();
    var $band = $row.find(".band").text();
    var $mp = $row.find(".mp").text();
    var $ge_music = $row.find(".ge_music").text();
    var $vp = $row.find(".vp").text();
    var $ge_visual = $row.find(".ge_visual").text();
    var $costume = $row.find(".costume").text();
    var $total = $row.find(".total").text();
    var $costumer = $row.find(".costumer").text();
    var $designer = $row.find(".designer").text();
    var $arranger = $row.find(".arranger").text();
    var $choreographer = $row.find(".choreographer").text();

    if ($costume.length > 1) {
    costume_exists = true;
    } else {
    costume_exists = false;
    }

    if ($mp.length > 0) {
    playing_exists = true;
    } else {
    playing_exists = false;
    }

    breakdown = "breakdown"
    if ($year < 1991 && costume_exists) {
    breakdown = ('<h3>' + $band + " " + $year + '</h3>' +
    '<i>' + getOrdinal($prize) + ' Prize' + '</i><br><br>' +
    '<b>Music:</b> ' + $ge_music + '<br>' +
    '<b>Presentation:</b> ' + $ge_visual + '<br>' +
    '<b>Costume:</b> ' + $costume + '<br><br>' +
    '<b>Total Points:</b> ' + $total + '<br><br>' +
    '<b>Costumer:</b> ' + $costumer + '<br>' +
    '<b>Costume/Set Designer:</b> ' + $designer + '<br>' +
    '<b>Music Arranger:</b> ' + $arranger + '<br>' +
    '<b>Choreographer:</b> ' + $choreographer + '<br>')
    swal({
    title: 'Point Breakdown',
    html: breakdown
    })
    } else if (costume_exists) {
    breakdown = ('<h3>' + $band + " " + $year + '</h3>' +
    '<i>' + getOrdinal($prize) + ' Prize' + '</i><br><br>' +
    '<b>Music Playing:</b> ' + $mp + '<br>' +
    '<b>General Effect Music:</b> ' + $ge_music + '<br>' +
    '<b>Visual Performance:</b> ' + $vp + '<br>' +
    '<b>General Effect - Visual:</b> ' + $ge_visual + '<br>' +
    '<b>Costume:</b> ' + $costume + '<br><br>' +
    '<b>Total Points:</b> ' + $total + '<br><br>' +
    '<b>Costumer:</b> ' + $costumer + '<br>' +
    '<b>Costume/Set Designer:</b> ' + $designer + '<br>' +
    '<b>Music Arranger:</b> ' + $arranger + '<br>' +
    '<b>Choreographer:</b> ' + $choreographer + '<br>')
    swal({
    title: 'Point Breakdown',
    html: breakdown
    })
    } else if (playing_exists) {
    breakdown = ('<h3>' + $band + " " + $year + '</h3>' +
    '<i>' + getOrdinal($prize) + ' Prize' + '</i><br><br>' +
    '<b>Music Playing:</b> ' + $mp + '<br>' +
    '<b>General Effect Music:</b> ' + $ge_music + '<br>' +
    '<b>Visual Performance:</b> ' + $vp + '<br>' +
    '<b>General Effect - Visual:</b> ' + $ge_visual + '<br><br>' +
    '<b>Total Points:</b> ' + $total + '<br><br>' +
    '<b>Costumer:</b> ' + $costumer + '<br>' +
    '<b>Costume/Set Designer:</b> ' + $designer + '<br>' +
    '<b>Music Arranger:</b> ' + $arranger + '<br>' +
    '<b>Choreographer:</b> ' + $choreographer + '<br>')
    swal({
    title: 'Point Breakdown',
    html: breakdown
    })
    } else {
    alert("No point breakdowns for " + $year + " are available.");
    }
    }
    }
    }
    }
    };
    }, 700);









    share|improve this question



























      0












      0








      0







      I have this function (used on a timeout due to my page loading time) to display information on my site. It is very clunky. As you can see in the code, certain values (current year, costume_exists boolean value) change the output of data being displayed. I grab this data from my table view that I load into the page. Is there an easier way of doing this?



      setTimeout(function() {
      var table = document.getElementById("bands");
      var icon = "</i>";
      if (table != null) {
      for (var i = 0; i < table.rows.length; i++) {
      for (var j = 0; j < table.rows[i].cells.length; j++)
      table.rows[i].cells[j].onclick = function() {
      if (this.cellIndex == 7) {
      if (!this.innerHTML.includes(icon)) {
      var $row = $(this).closest("tr");
      var $year = $row.find(".year").text();
      var $prize = $row.find(".prize").text();
      var $band = $row.find(".band").text();
      var $mp = $row.find(".mp").text();
      var $ge_music = $row.find(".ge_music").text();
      var $vp = $row.find(".vp").text();
      var $ge_visual = $row.find(".ge_visual").text();
      var $costume = $row.find(".costume").text();
      var $total = $row.find(".total").text();
      var $costumer = $row.find(".costumer").text();
      var $designer = $row.find(".designer").text();
      var $arranger = $row.find(".arranger").text();
      var $choreographer = $row.find(".choreographer").text();

      if ($costume.length > 1) {
      costume_exists = true;
      } else {
      costume_exists = false;
      }

      if ($mp.length > 0) {
      playing_exists = true;
      } else {
      playing_exists = false;
      }

      breakdown = "breakdown"
      if ($year < 1991 && costume_exists) {
      breakdown = ('<h3>' + $band + " " + $year + '</h3>' +
      '<i>' + getOrdinal($prize) + ' Prize' + '</i><br><br>' +
      '<b>Music:</b> ' + $ge_music + '<br>' +
      '<b>Presentation:</b> ' + $ge_visual + '<br>' +
      '<b>Costume:</b> ' + $costume + '<br><br>' +
      '<b>Total Points:</b> ' + $total + '<br><br>' +
      '<b>Costumer:</b> ' + $costumer + '<br>' +
      '<b>Costume/Set Designer:</b> ' + $designer + '<br>' +
      '<b>Music Arranger:</b> ' + $arranger + '<br>' +
      '<b>Choreographer:</b> ' + $choreographer + '<br>')
      swal({
      title: 'Point Breakdown',
      html: breakdown
      })
      } else if (costume_exists) {
      breakdown = ('<h3>' + $band + " " + $year + '</h3>' +
      '<i>' + getOrdinal($prize) + ' Prize' + '</i><br><br>' +
      '<b>Music Playing:</b> ' + $mp + '<br>' +
      '<b>General Effect Music:</b> ' + $ge_music + '<br>' +
      '<b>Visual Performance:</b> ' + $vp + '<br>' +
      '<b>General Effect - Visual:</b> ' + $ge_visual + '<br>' +
      '<b>Costume:</b> ' + $costume + '<br><br>' +
      '<b>Total Points:</b> ' + $total + '<br><br>' +
      '<b>Costumer:</b> ' + $costumer + '<br>' +
      '<b>Costume/Set Designer:</b> ' + $designer + '<br>' +
      '<b>Music Arranger:</b> ' + $arranger + '<br>' +
      '<b>Choreographer:</b> ' + $choreographer + '<br>')
      swal({
      title: 'Point Breakdown',
      html: breakdown
      })
      } else if (playing_exists) {
      breakdown = ('<h3>' + $band + " " + $year + '</h3>' +
      '<i>' + getOrdinal($prize) + ' Prize' + '</i><br><br>' +
      '<b>Music Playing:</b> ' + $mp + '<br>' +
      '<b>General Effect Music:</b> ' + $ge_music + '<br>' +
      '<b>Visual Performance:</b> ' + $vp + '<br>' +
      '<b>General Effect - Visual:</b> ' + $ge_visual + '<br><br>' +
      '<b>Total Points:</b> ' + $total + '<br><br>' +
      '<b>Costumer:</b> ' + $costumer + '<br>' +
      '<b>Costume/Set Designer:</b> ' + $designer + '<br>' +
      '<b>Music Arranger:</b> ' + $arranger + '<br>' +
      '<b>Choreographer:</b> ' + $choreographer + '<br>')
      swal({
      title: 'Point Breakdown',
      html: breakdown
      })
      } else {
      alert("No point breakdowns for " + $year + " are available.");
      }
      }
      }
      }
      }
      };
      }, 700);









      share|improve this question















      I have this function (used on a timeout due to my page loading time) to display information on my site. It is very clunky. As you can see in the code, certain values (current year, costume_exists boolean value) change the output of data being displayed. I grab this data from my table view that I load into the page. Is there an easier way of doing this?



      setTimeout(function() {
      var table = document.getElementById("bands");
      var icon = "</i>";
      if (table != null) {
      for (var i = 0; i < table.rows.length; i++) {
      for (var j = 0; j < table.rows[i].cells.length; j++)
      table.rows[i].cells[j].onclick = function() {
      if (this.cellIndex == 7) {
      if (!this.innerHTML.includes(icon)) {
      var $row = $(this).closest("tr");
      var $year = $row.find(".year").text();
      var $prize = $row.find(".prize").text();
      var $band = $row.find(".band").text();
      var $mp = $row.find(".mp").text();
      var $ge_music = $row.find(".ge_music").text();
      var $vp = $row.find(".vp").text();
      var $ge_visual = $row.find(".ge_visual").text();
      var $costume = $row.find(".costume").text();
      var $total = $row.find(".total").text();
      var $costumer = $row.find(".costumer").text();
      var $designer = $row.find(".designer").text();
      var $arranger = $row.find(".arranger").text();
      var $choreographer = $row.find(".choreographer").text();

      if ($costume.length > 1) {
      costume_exists = true;
      } else {
      costume_exists = false;
      }

      if ($mp.length > 0) {
      playing_exists = true;
      } else {
      playing_exists = false;
      }

      breakdown = "breakdown"
      if ($year < 1991 && costume_exists) {
      breakdown = ('<h3>' + $band + " " + $year + '</h3>' +
      '<i>' + getOrdinal($prize) + ' Prize' + '</i><br><br>' +
      '<b>Music:</b> ' + $ge_music + '<br>' +
      '<b>Presentation:</b> ' + $ge_visual + '<br>' +
      '<b>Costume:</b> ' + $costume + '<br><br>' +
      '<b>Total Points:</b> ' + $total + '<br><br>' +
      '<b>Costumer:</b> ' + $costumer + '<br>' +
      '<b>Costume/Set Designer:</b> ' + $designer + '<br>' +
      '<b>Music Arranger:</b> ' + $arranger + '<br>' +
      '<b>Choreographer:</b> ' + $choreographer + '<br>')
      swal({
      title: 'Point Breakdown',
      html: breakdown
      })
      } else if (costume_exists) {
      breakdown = ('<h3>' + $band + " " + $year + '</h3>' +
      '<i>' + getOrdinal($prize) + ' Prize' + '</i><br><br>' +
      '<b>Music Playing:</b> ' + $mp + '<br>' +
      '<b>General Effect Music:</b> ' + $ge_music + '<br>' +
      '<b>Visual Performance:</b> ' + $vp + '<br>' +
      '<b>General Effect - Visual:</b> ' + $ge_visual + '<br>' +
      '<b>Costume:</b> ' + $costume + '<br><br>' +
      '<b>Total Points:</b> ' + $total + '<br><br>' +
      '<b>Costumer:</b> ' + $costumer + '<br>' +
      '<b>Costume/Set Designer:</b> ' + $designer + '<br>' +
      '<b>Music Arranger:</b> ' + $arranger + '<br>' +
      '<b>Choreographer:</b> ' + $choreographer + '<br>')
      swal({
      title: 'Point Breakdown',
      html: breakdown
      })
      } else if (playing_exists) {
      breakdown = ('<h3>' + $band + " " + $year + '</h3>' +
      '<i>' + getOrdinal($prize) + ' Prize' + '</i><br><br>' +
      '<b>Music Playing:</b> ' + $mp + '<br>' +
      '<b>General Effect Music:</b> ' + $ge_music + '<br>' +
      '<b>Visual Performance:</b> ' + $vp + '<br>' +
      '<b>General Effect - Visual:</b> ' + $ge_visual + '<br><br>' +
      '<b>Total Points:</b> ' + $total + '<br><br>' +
      '<b>Costumer:</b> ' + $costumer + '<br>' +
      '<b>Costume/Set Designer:</b> ' + $designer + '<br>' +
      '<b>Music Arranger:</b> ' + $arranger + '<br>' +
      '<b>Choreographer:</b> ' + $choreographer + '<br>')
      swal({
      title: 'Point Breakdown',
      html: breakdown
      })
      } else {
      alert("No point breakdowns for " + $year + " are available.");
      }
      }
      }
      }
      }
      };
      }, 700);






      javascript






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 20 mins ago

























      asked 25 mins ago









      Frank Doe

      6214




      6214



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210322%2fmanipulating-displaying-data-based-on-boolean-value-in-javascript%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210322%2fmanipulating-displaying-data-based-on-boolean-value-in-javascript%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'