Addition Program using wpf through MVVM












0














I'm new to MVVM and WPF. Please suggest whether this is okay or I need to correct my understanding of MVVM which I confess is very limited as at the moment.



I have created a simple addition application which gets two number as input and provide the added number after clicking the Button.



Please give me your honest (and brutal) opinion, since that will help me improve the most.



Model.cs:



using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.ComponentModel;

namespace addition.Model
{
class Number
{
public int number1

{ get; set; }


public int number2
{ get; set; }

public int number3
{ get; set; }


}
}


ViewModel.cs



using addition.Model;

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.ComponentModel;
using System.Collections.ObjectModel;
using System.Windows;
using System.Windows.Controls;
using System.Windows.Input;


namespace addition.ViewModel
{
class ViewModel : INotifyPropertyChanged
{
private Number n1 = new Number();
int num, num1;


public RelayCommand AddNew { get; set; }

private string _number1;

public string FirstArgument
{

get { return this._number1; }
set
{
this._number1 = value;
if (int.TryParse(_number1.ToString(), out num))
{
this.n1.number1 = num;
this.OnPropertyChanged("FirstArgument");

}
else { MessageBox.Show("The given Value is not a Number "); }

}
}
private string _number2;

public string secondargument
{
get { return this._number2; }

set
{
this._number2 = value;
if (int.TryParse(_number2.ToString(), out num1))
{
this.n1.number2 = num1;
this.OnPropertyChanged("secondargument");
}
else { MessageBox.Show("The given Value is not a Number "); }

}
}

private string _number3;

public string Addedargument
{
get { return this._number3; }
set
{
this._number3 = value;
this.OnPropertyChanged("Addedargument");
}
}

public ViewModel()
{

AddNew = new RelayCommand(o => AddNumbers());

}


private void AddNumbers()
{
var a = this.FirstArgument;
var b = this.secondargument ;
var c = (Convert.ToInt32(a) + Convert.ToInt32(b)).ToString();
MessageBox.Show(c);
Addedargument = c;


}

#region INotifyPropertyChanged Members

public event PropertyChangedEventHandler PropertyChanged;
private void OnPropertyChanged(string propertyName)
{
if (PropertyChanged != null)
{
PropertyChanged(this, new PropertyChangedEventArgs(propertyName));
}
}
#endregion

}
}


View.xaml



<Window x:Class="addition.Window1"
xmlns:vm="clr-namespace:addition.ViewModel"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
Title="Window1" Height="300" Width="300">
<Window.DataContext>
<vm:ViewModel />
</Window.DataContext>
<Grid>

<Label Height="28" Margin="28,54,0,0" Name="Number1" VerticalAlignment="Top" HorizontalAlignment="Left" Width="48">Number</Label>
<TextBox Height="28" Margin="112,56,46,0" Text ="{Binding Path = FirstArgument}" Name="textBox1" VerticalAlignment="Top" />
<Label Margin="28,106,0,128" Name="Number2" Width="58" HorizontalAlignment="Left">Number1</Label>
<TextBox Height="28" Margin="112,120,46,120" Text ="{Binding Path = secondargument}" Name="textBox2" />
<Label Height="28" Margin="28,0,0,75" Name="label1" VerticalAlignment="Bottom" HorizontalAlignment="Left" Width="58">Number2</Label>
<TextBox Height="23" Margin="112,0,46,68" Name="textBox3" Text="{Binding Path = Addedargument}" VerticalAlignment="Bottom" />
<Button Height="23" HorizontalAlignment="Left" Margin="39,0,0,16" Name="button1" VerticalAlignment="Bottom" Width="75" Command="{Binding AddNew}">Button</Button>
</Grid>
</Window>









share|improve this question



























    0














    I'm new to MVVM and WPF. Please suggest whether this is okay or I need to correct my understanding of MVVM which I confess is very limited as at the moment.



    I have created a simple addition application which gets two number as input and provide the added number after clicking the Button.



    Please give me your honest (and brutal) opinion, since that will help me improve the most.



    Model.cs:



    using System;
    using System.Collections.Generic;
    using System.Linq;
    using System.Text;
    using System.ComponentModel;

    namespace addition.Model
    {
    class Number
    {
    public int number1

    { get; set; }


    public int number2
    { get; set; }

    public int number3
    { get; set; }


    }
    }


    ViewModel.cs



    using addition.Model;

    using System;
    using System.Collections.Generic;
    using System.Linq;
    using System.Text;
    using System.ComponentModel;
    using System.Collections.ObjectModel;
    using System.Windows;
    using System.Windows.Controls;
    using System.Windows.Input;


    namespace addition.ViewModel
    {
    class ViewModel : INotifyPropertyChanged
    {
    private Number n1 = new Number();
    int num, num1;


    public RelayCommand AddNew { get; set; }

    private string _number1;

    public string FirstArgument
    {

    get { return this._number1; }
    set
    {
    this._number1 = value;
    if (int.TryParse(_number1.ToString(), out num))
    {
    this.n1.number1 = num;
    this.OnPropertyChanged("FirstArgument");

    }
    else { MessageBox.Show("The given Value is not a Number "); }

    }
    }
    private string _number2;

    public string secondargument
    {
    get { return this._number2; }

    set
    {
    this._number2 = value;
    if (int.TryParse(_number2.ToString(), out num1))
    {
    this.n1.number2 = num1;
    this.OnPropertyChanged("secondargument");
    }
    else { MessageBox.Show("The given Value is not a Number "); }

    }
    }

    private string _number3;

    public string Addedargument
    {
    get { return this._number3; }
    set
    {
    this._number3 = value;
    this.OnPropertyChanged("Addedargument");
    }
    }

    public ViewModel()
    {

    AddNew = new RelayCommand(o => AddNumbers());

    }


    private void AddNumbers()
    {
    var a = this.FirstArgument;
    var b = this.secondargument ;
    var c = (Convert.ToInt32(a) + Convert.ToInt32(b)).ToString();
    MessageBox.Show(c);
    Addedargument = c;


    }

    #region INotifyPropertyChanged Members

    public event PropertyChangedEventHandler PropertyChanged;
    private void OnPropertyChanged(string propertyName)
    {
    if (PropertyChanged != null)
    {
    PropertyChanged(this, new PropertyChangedEventArgs(propertyName));
    }
    }
    #endregion

    }
    }


    View.xaml



    <Window x:Class="addition.Window1"
    xmlns:vm="clr-namespace:addition.ViewModel"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    Title="Window1" Height="300" Width="300">
    <Window.DataContext>
    <vm:ViewModel />
    </Window.DataContext>
    <Grid>

    <Label Height="28" Margin="28,54,0,0" Name="Number1" VerticalAlignment="Top" HorizontalAlignment="Left" Width="48">Number</Label>
    <TextBox Height="28" Margin="112,56,46,0" Text ="{Binding Path = FirstArgument}" Name="textBox1" VerticalAlignment="Top" />
    <Label Margin="28,106,0,128" Name="Number2" Width="58" HorizontalAlignment="Left">Number1</Label>
    <TextBox Height="28" Margin="112,120,46,120" Text ="{Binding Path = secondargument}" Name="textBox2" />
    <Label Height="28" Margin="28,0,0,75" Name="label1" VerticalAlignment="Bottom" HorizontalAlignment="Left" Width="58">Number2</Label>
    <TextBox Height="23" Margin="112,0,46,68" Name="textBox3" Text="{Binding Path = Addedargument}" VerticalAlignment="Bottom" />
    <Button Height="23" HorizontalAlignment="Left" Margin="39,0,0,16" Name="button1" VerticalAlignment="Bottom" Width="75" Command="{Binding AddNew}">Button</Button>
    </Grid>
    </Window>









    share|improve this question

























      0












      0








      0







      I'm new to MVVM and WPF. Please suggest whether this is okay or I need to correct my understanding of MVVM which I confess is very limited as at the moment.



      I have created a simple addition application which gets two number as input and provide the added number after clicking the Button.



      Please give me your honest (and brutal) opinion, since that will help me improve the most.



      Model.cs:



      using System;
      using System.Collections.Generic;
      using System.Linq;
      using System.Text;
      using System.ComponentModel;

      namespace addition.Model
      {
      class Number
      {
      public int number1

      { get; set; }


      public int number2
      { get; set; }

      public int number3
      { get; set; }


      }
      }


      ViewModel.cs



      using addition.Model;

      using System;
      using System.Collections.Generic;
      using System.Linq;
      using System.Text;
      using System.ComponentModel;
      using System.Collections.ObjectModel;
      using System.Windows;
      using System.Windows.Controls;
      using System.Windows.Input;


      namespace addition.ViewModel
      {
      class ViewModel : INotifyPropertyChanged
      {
      private Number n1 = new Number();
      int num, num1;


      public RelayCommand AddNew { get; set; }

      private string _number1;

      public string FirstArgument
      {

      get { return this._number1; }
      set
      {
      this._number1 = value;
      if (int.TryParse(_number1.ToString(), out num))
      {
      this.n1.number1 = num;
      this.OnPropertyChanged("FirstArgument");

      }
      else { MessageBox.Show("The given Value is not a Number "); }

      }
      }
      private string _number2;

      public string secondargument
      {
      get { return this._number2; }

      set
      {
      this._number2 = value;
      if (int.TryParse(_number2.ToString(), out num1))
      {
      this.n1.number2 = num1;
      this.OnPropertyChanged("secondargument");
      }
      else { MessageBox.Show("The given Value is not a Number "); }

      }
      }

      private string _number3;

      public string Addedargument
      {
      get { return this._number3; }
      set
      {
      this._number3 = value;
      this.OnPropertyChanged("Addedargument");
      }
      }

      public ViewModel()
      {

      AddNew = new RelayCommand(o => AddNumbers());

      }


      private void AddNumbers()
      {
      var a = this.FirstArgument;
      var b = this.secondargument ;
      var c = (Convert.ToInt32(a) + Convert.ToInt32(b)).ToString();
      MessageBox.Show(c);
      Addedargument = c;


      }

      #region INotifyPropertyChanged Members

      public event PropertyChangedEventHandler PropertyChanged;
      private void OnPropertyChanged(string propertyName)
      {
      if (PropertyChanged != null)
      {
      PropertyChanged(this, new PropertyChangedEventArgs(propertyName));
      }
      }
      #endregion

      }
      }


      View.xaml



      <Window x:Class="addition.Window1"
      xmlns:vm="clr-namespace:addition.ViewModel"
      xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
      xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
      Title="Window1" Height="300" Width="300">
      <Window.DataContext>
      <vm:ViewModel />
      </Window.DataContext>
      <Grid>

      <Label Height="28" Margin="28,54,0,0" Name="Number1" VerticalAlignment="Top" HorizontalAlignment="Left" Width="48">Number</Label>
      <TextBox Height="28" Margin="112,56,46,0" Text ="{Binding Path = FirstArgument}" Name="textBox1" VerticalAlignment="Top" />
      <Label Margin="28,106,0,128" Name="Number2" Width="58" HorizontalAlignment="Left">Number1</Label>
      <TextBox Height="28" Margin="112,120,46,120" Text ="{Binding Path = secondargument}" Name="textBox2" />
      <Label Height="28" Margin="28,0,0,75" Name="label1" VerticalAlignment="Bottom" HorizontalAlignment="Left" Width="58">Number2</Label>
      <TextBox Height="23" Margin="112,0,46,68" Name="textBox3" Text="{Binding Path = Addedargument}" VerticalAlignment="Bottom" />
      <Button Height="23" HorizontalAlignment="Left" Margin="39,0,0,16" Name="button1" VerticalAlignment="Bottom" Width="75" Command="{Binding AddNew}">Button</Button>
      </Grid>
      </Window>









      share|improve this question













      I'm new to MVVM and WPF. Please suggest whether this is okay or I need to correct my understanding of MVVM which I confess is very limited as at the moment.



      I have created a simple addition application which gets two number as input and provide the added number after clicking the Button.



      Please give me your honest (and brutal) opinion, since that will help me improve the most.



      Model.cs:



      using System;
      using System.Collections.Generic;
      using System.Linq;
      using System.Text;
      using System.ComponentModel;

      namespace addition.Model
      {
      class Number
      {
      public int number1

      { get; set; }


      public int number2
      { get; set; }

      public int number3
      { get; set; }


      }
      }


      ViewModel.cs



      using addition.Model;

      using System;
      using System.Collections.Generic;
      using System.Linq;
      using System.Text;
      using System.ComponentModel;
      using System.Collections.ObjectModel;
      using System.Windows;
      using System.Windows.Controls;
      using System.Windows.Input;


      namespace addition.ViewModel
      {
      class ViewModel : INotifyPropertyChanged
      {
      private Number n1 = new Number();
      int num, num1;


      public RelayCommand AddNew { get; set; }

      private string _number1;

      public string FirstArgument
      {

      get { return this._number1; }
      set
      {
      this._number1 = value;
      if (int.TryParse(_number1.ToString(), out num))
      {
      this.n1.number1 = num;
      this.OnPropertyChanged("FirstArgument");

      }
      else { MessageBox.Show("The given Value is not a Number "); }

      }
      }
      private string _number2;

      public string secondargument
      {
      get { return this._number2; }

      set
      {
      this._number2 = value;
      if (int.TryParse(_number2.ToString(), out num1))
      {
      this.n1.number2 = num1;
      this.OnPropertyChanged("secondargument");
      }
      else { MessageBox.Show("The given Value is not a Number "); }

      }
      }

      private string _number3;

      public string Addedargument
      {
      get { return this._number3; }
      set
      {
      this._number3 = value;
      this.OnPropertyChanged("Addedargument");
      }
      }

      public ViewModel()
      {

      AddNew = new RelayCommand(o => AddNumbers());

      }


      private void AddNumbers()
      {
      var a = this.FirstArgument;
      var b = this.secondargument ;
      var c = (Convert.ToInt32(a) + Convert.ToInt32(b)).ToString();
      MessageBox.Show(c);
      Addedargument = c;


      }

      #region INotifyPropertyChanged Members

      public event PropertyChangedEventHandler PropertyChanged;
      private void OnPropertyChanged(string propertyName)
      {
      if (PropertyChanged != null)
      {
      PropertyChanged(this, new PropertyChangedEventArgs(propertyName));
      }
      }
      #endregion

      }
      }


      View.xaml



      <Window x:Class="addition.Window1"
      xmlns:vm="clr-namespace:addition.ViewModel"
      xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
      xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
      Title="Window1" Height="300" Width="300">
      <Window.DataContext>
      <vm:ViewModel />
      </Window.DataContext>
      <Grid>

      <Label Height="28" Margin="28,54,0,0" Name="Number1" VerticalAlignment="Top" HorizontalAlignment="Left" Width="48">Number</Label>
      <TextBox Height="28" Margin="112,56,46,0" Text ="{Binding Path = FirstArgument}" Name="textBox1" VerticalAlignment="Top" />
      <Label Margin="28,106,0,128" Name="Number2" Width="58" HorizontalAlignment="Left">Number1</Label>
      <TextBox Height="28" Margin="112,120,46,120" Text ="{Binding Path = secondargument}" Name="textBox2" />
      <Label Height="28" Margin="28,0,0,75" Name="label1" VerticalAlignment="Bottom" HorizontalAlignment="Left" Width="58">Number2</Label>
      <TextBox Height="23" Margin="112,0,46,68" Name="textBox3" Text="{Binding Path = Addedargument}" VerticalAlignment="Bottom" />
      <Button Height="23" HorizontalAlignment="Left" Margin="39,0,0,16" Name="button1" VerticalAlignment="Bottom" Width="75" Command="{Binding AddNew}">Button</Button>
      </Grid>
      </Window>






      c# wpf mvvm






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 13 mins ago









      Ramji R

      286




      286



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210344%2faddition-program-using-wpf-through-mvvm%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210344%2faddition-program-using-wpf-through-mvvm%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'