combobox with c# code (the correct way )












0












$begingroup$


i us this code and it work good with me bout what im asking for is this the good way to code it ( I use it to get data from table to link it with another combobox to make them work together).



the first combobox



public Needform()
{
string mainconn = ConfigurationManager.ConnectionStrings["MY"].ConnectionString;
SqlConnection sqlconn = new SqlConnection(mainconn);
string sqlquery = "select * from [dbo].[Governorate]";
SqlCommand sqlcomm = new SqlCommand(sqlquery, sqlconn);
sqlconn.Open();
SqlDataAdapter sda = new SqlDataAdapter(sqlcomm);
DataTable dt = new DataTable();
sda.Fill(dt);
comboBoxGovernorate.ValueMember = "id_Governorate";
comboBoxGovernorate.DisplayMember = "name";
comboBoxGovernorate.DataSource = dt;
comboBoxCity.Enabled = false;
}


the another one



private void ComboBoxGovernorate_SelectedIndexChanged(object sender, EventArgs e)
{
if (comboBoxGovernorate.SelectedValue.ToString() != null)
{
string mainconn = ConfigurationManager.ConnectionStrings["MY"].ConnectionString;
SqlConnection sqlconn = new SqlConnection(mainconn);
string sqlquery = "select * from [dbo].[City]where id_Governorate=@id_Governorate";
SqlCommand sqlcomm = new SqlCommand(sqlquery, sqlconn);
sqlconn.Open();
sqlcomm.Parameters.AddWithValue("@id_Governorate", comboBoxGovernorate.SelectedValue.ToString());
SqlDataAdapter sda = new SqlDataAdapter(sqlcomm);
DataTable dt = new DataTable();
sda.Fill(dt);
comboBoxCity.ValueMember = "id";
comboBoxCity.DisplayMember = "city";
comboBoxCity.DataSource = dt;
comboBoxCity.Enabled = true;
}
}


thx and i hope all learn from that









share







New contributor




Ahmed Al Khteeb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    i us this code and it work good with me bout what im asking for is this the good way to code it ( I use it to get data from table to link it with another combobox to make them work together).



    the first combobox



    public Needform()
    {
    string mainconn = ConfigurationManager.ConnectionStrings["MY"].ConnectionString;
    SqlConnection sqlconn = new SqlConnection(mainconn);
    string sqlquery = "select * from [dbo].[Governorate]";
    SqlCommand sqlcomm = new SqlCommand(sqlquery, sqlconn);
    sqlconn.Open();
    SqlDataAdapter sda = new SqlDataAdapter(sqlcomm);
    DataTable dt = new DataTable();
    sda.Fill(dt);
    comboBoxGovernorate.ValueMember = "id_Governorate";
    comboBoxGovernorate.DisplayMember = "name";
    comboBoxGovernorate.DataSource = dt;
    comboBoxCity.Enabled = false;
    }


    the another one



    private void ComboBoxGovernorate_SelectedIndexChanged(object sender, EventArgs e)
    {
    if (comboBoxGovernorate.SelectedValue.ToString() != null)
    {
    string mainconn = ConfigurationManager.ConnectionStrings["MY"].ConnectionString;
    SqlConnection sqlconn = new SqlConnection(mainconn);
    string sqlquery = "select * from [dbo].[City]where id_Governorate=@id_Governorate";
    SqlCommand sqlcomm = new SqlCommand(sqlquery, sqlconn);
    sqlconn.Open();
    sqlcomm.Parameters.AddWithValue("@id_Governorate", comboBoxGovernorate.SelectedValue.ToString());
    SqlDataAdapter sda = new SqlDataAdapter(sqlcomm);
    DataTable dt = new DataTable();
    sda.Fill(dt);
    comboBoxCity.ValueMember = "id";
    comboBoxCity.DisplayMember = "city";
    comboBoxCity.DataSource = dt;
    comboBoxCity.Enabled = true;
    }
    }


    thx and i hope all learn from that









    share







    New contributor




    Ahmed Al Khteeb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      i us this code and it work good with me bout what im asking for is this the good way to code it ( I use it to get data from table to link it with another combobox to make them work together).



      the first combobox



      public Needform()
      {
      string mainconn = ConfigurationManager.ConnectionStrings["MY"].ConnectionString;
      SqlConnection sqlconn = new SqlConnection(mainconn);
      string sqlquery = "select * from [dbo].[Governorate]";
      SqlCommand sqlcomm = new SqlCommand(sqlquery, sqlconn);
      sqlconn.Open();
      SqlDataAdapter sda = new SqlDataAdapter(sqlcomm);
      DataTable dt = new DataTable();
      sda.Fill(dt);
      comboBoxGovernorate.ValueMember = "id_Governorate";
      comboBoxGovernorate.DisplayMember = "name";
      comboBoxGovernorate.DataSource = dt;
      comboBoxCity.Enabled = false;
      }


      the another one



      private void ComboBoxGovernorate_SelectedIndexChanged(object sender, EventArgs e)
      {
      if (comboBoxGovernorate.SelectedValue.ToString() != null)
      {
      string mainconn = ConfigurationManager.ConnectionStrings["MY"].ConnectionString;
      SqlConnection sqlconn = new SqlConnection(mainconn);
      string sqlquery = "select * from [dbo].[City]where id_Governorate=@id_Governorate";
      SqlCommand sqlcomm = new SqlCommand(sqlquery, sqlconn);
      sqlconn.Open();
      sqlcomm.Parameters.AddWithValue("@id_Governorate", comboBoxGovernorate.SelectedValue.ToString());
      SqlDataAdapter sda = new SqlDataAdapter(sqlcomm);
      DataTable dt = new DataTable();
      sda.Fill(dt);
      comboBoxCity.ValueMember = "id";
      comboBoxCity.DisplayMember = "city";
      comboBoxCity.DataSource = dt;
      comboBoxCity.Enabled = true;
      }
      }


      thx and i hope all learn from that









      share







      New contributor




      Ahmed Al Khteeb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      i us this code and it work good with me bout what im asking for is this the good way to code it ( I use it to get data from table to link it with another combobox to make them work together).



      the first combobox



      public Needform()
      {
      string mainconn = ConfigurationManager.ConnectionStrings["MY"].ConnectionString;
      SqlConnection sqlconn = new SqlConnection(mainconn);
      string sqlquery = "select * from [dbo].[Governorate]";
      SqlCommand sqlcomm = new SqlCommand(sqlquery, sqlconn);
      sqlconn.Open();
      SqlDataAdapter sda = new SqlDataAdapter(sqlcomm);
      DataTable dt = new DataTable();
      sda.Fill(dt);
      comboBoxGovernorate.ValueMember = "id_Governorate";
      comboBoxGovernorate.DisplayMember = "name";
      comboBoxGovernorate.DataSource = dt;
      comboBoxCity.Enabled = false;
      }


      the another one



      private void ComboBoxGovernorate_SelectedIndexChanged(object sender, EventArgs e)
      {
      if (comboBoxGovernorate.SelectedValue.ToString() != null)
      {
      string mainconn = ConfigurationManager.ConnectionStrings["MY"].ConnectionString;
      SqlConnection sqlconn = new SqlConnection(mainconn);
      string sqlquery = "select * from [dbo].[City]where id_Governorate=@id_Governorate";
      SqlCommand sqlcomm = new SqlCommand(sqlquery, sqlconn);
      sqlconn.Open();
      sqlcomm.Parameters.AddWithValue("@id_Governorate", comboBoxGovernorate.SelectedValue.ToString());
      SqlDataAdapter sda = new SqlDataAdapter(sqlcomm);
      DataTable dt = new DataTable();
      sda.Fill(dt);
      comboBoxCity.ValueMember = "id";
      comboBoxCity.DisplayMember = "city";
      comboBoxCity.DataSource = dt;
      comboBoxCity.Enabled = true;
      }
      }


      thx and i hope all learn from that







      c#





      share







      New contributor




      Ahmed Al Khteeb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Ahmed Al Khteeb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Ahmed Al Khteeb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 7 mins ago









      Ahmed Al KhteebAhmed Al Khteeb

      1




      1




      New contributor




      Ahmed Al Khteeb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Ahmed Al Khteeb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Ahmed Al Khteeb is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Ahmed Al Khteeb is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213170%2fcombobox-with-c-code-the-correct-way%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Ahmed Al Khteeb is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Ahmed Al Khteeb is a new contributor. Be nice, and check out our Code of Conduct.













          Ahmed Al Khteeb is a new contributor. Be nice, and check out our Code of Conduct.












          Ahmed Al Khteeb is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213170%2fcombobox-with-c-code-the-correct-way%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'