HANGMANNNNN program
What improvements can I make? Should I organize my functions based on A-Z? For example, find_letter function comes before guessing function.
import json
import random
import re
def find_letter(user_input, vocab, i=None):
return [i.start() for i in re.finditer(user_input, vocab)]
def guessing(tries,vocab,blank_line):
while tries > 0:
user_input = input("Guess:")
if user_input in vocab:
if not(user_input in blank_line):
index = find_letter(user_input=user_input,vocab=vocab)
i = 0
while i < len(index):
blank_line[index[i]] = user_input
i += 1
if not('_' in blank_line):
return "you won!!!"
else:
print("YOU ALREADY TRIED THAT LETTER!")
else:
tries -= 1
print(str(blank_line) + " Number of Tries : " + str(tries))
return "you lost"
def hangman_game(vocab):
'Preliminary Conditions'
print(introductory(vocab=vocab))
tries = num_of_tries(vocab=vocab)
blank_line = produce_blank_lines(vocab=vocab)
print(blank_line)
print(guessing(tries=tries,vocab=vocab,blank_line=blank_line))
def introductory(vocab):
return "HANGMAN GAME. So...what you gotta do is guess and infer what the word might be. "
"WORD COUNT : " + str(len(vocab))
def num_of_tries(vocab):
if len(vocab) < 7:
return 8
elif 7 <= len(vocab) < 10:
return 10
else:
return 14
def produce_blank_lines(vocab):
blank_line =
for i in vocab:
if i.isalpha():
blank_line += "_"
elif i == " ":
blank_line += " "
else:
blank_line += i + " "
return blank_line
if __name__ == '__main__':
data = json.load(open("vocabulary.json"))
vocab = random.choice(list(data.keys())).lower()
print(vocab)
print(hangman_game(vocab=vocab))
python json
add a comment |
What improvements can I make? Should I organize my functions based on A-Z? For example, find_letter function comes before guessing function.
import json
import random
import re
def find_letter(user_input, vocab, i=None):
return [i.start() for i in re.finditer(user_input, vocab)]
def guessing(tries,vocab,blank_line):
while tries > 0:
user_input = input("Guess:")
if user_input in vocab:
if not(user_input in blank_line):
index = find_letter(user_input=user_input,vocab=vocab)
i = 0
while i < len(index):
blank_line[index[i]] = user_input
i += 1
if not('_' in blank_line):
return "you won!!!"
else:
print("YOU ALREADY TRIED THAT LETTER!")
else:
tries -= 1
print(str(blank_line) + " Number of Tries : " + str(tries))
return "you lost"
def hangman_game(vocab):
'Preliminary Conditions'
print(introductory(vocab=vocab))
tries = num_of_tries(vocab=vocab)
blank_line = produce_blank_lines(vocab=vocab)
print(blank_line)
print(guessing(tries=tries,vocab=vocab,blank_line=blank_line))
def introductory(vocab):
return "HANGMAN GAME. So...what you gotta do is guess and infer what the word might be. "
"WORD COUNT : " + str(len(vocab))
def num_of_tries(vocab):
if len(vocab) < 7:
return 8
elif 7 <= len(vocab) < 10:
return 10
else:
return 14
def produce_blank_lines(vocab):
blank_line =
for i in vocab:
if i.isalpha():
blank_line += "_"
elif i == " ":
blank_line += " "
else:
blank_line += i + " "
return blank_line
if __name__ == '__main__':
data = json.load(open("vocabulary.json"))
vocab = random.choice(list(data.keys())).lower()
print(vocab)
print(hangman_game(vocab=vocab))
python json
add a comment |
What improvements can I make? Should I organize my functions based on A-Z? For example, find_letter function comes before guessing function.
import json
import random
import re
def find_letter(user_input, vocab, i=None):
return [i.start() for i in re.finditer(user_input, vocab)]
def guessing(tries,vocab,blank_line):
while tries > 0:
user_input = input("Guess:")
if user_input in vocab:
if not(user_input in blank_line):
index = find_letter(user_input=user_input,vocab=vocab)
i = 0
while i < len(index):
blank_line[index[i]] = user_input
i += 1
if not('_' in blank_line):
return "you won!!!"
else:
print("YOU ALREADY TRIED THAT LETTER!")
else:
tries -= 1
print(str(blank_line) + " Number of Tries : " + str(tries))
return "you lost"
def hangman_game(vocab):
'Preliminary Conditions'
print(introductory(vocab=vocab))
tries = num_of_tries(vocab=vocab)
blank_line = produce_blank_lines(vocab=vocab)
print(blank_line)
print(guessing(tries=tries,vocab=vocab,blank_line=blank_line))
def introductory(vocab):
return "HANGMAN GAME. So...what you gotta do is guess and infer what the word might be. "
"WORD COUNT : " + str(len(vocab))
def num_of_tries(vocab):
if len(vocab) < 7:
return 8
elif 7 <= len(vocab) < 10:
return 10
else:
return 14
def produce_blank_lines(vocab):
blank_line =
for i in vocab:
if i.isalpha():
blank_line += "_"
elif i == " ":
blank_line += " "
else:
blank_line += i + " "
return blank_line
if __name__ == '__main__':
data = json.load(open("vocabulary.json"))
vocab = random.choice(list(data.keys())).lower()
print(vocab)
print(hangman_game(vocab=vocab))
python json
What improvements can I make? Should I organize my functions based on A-Z? For example, find_letter function comes before guessing function.
import json
import random
import re
def find_letter(user_input, vocab, i=None):
return [i.start() for i in re.finditer(user_input, vocab)]
def guessing(tries,vocab,blank_line):
while tries > 0:
user_input = input("Guess:")
if user_input in vocab:
if not(user_input in blank_line):
index = find_letter(user_input=user_input,vocab=vocab)
i = 0
while i < len(index):
blank_line[index[i]] = user_input
i += 1
if not('_' in blank_line):
return "you won!!!"
else:
print("YOU ALREADY TRIED THAT LETTER!")
else:
tries -= 1
print(str(blank_line) + " Number of Tries : " + str(tries))
return "you lost"
def hangman_game(vocab):
'Preliminary Conditions'
print(introductory(vocab=vocab))
tries = num_of_tries(vocab=vocab)
blank_line = produce_blank_lines(vocab=vocab)
print(blank_line)
print(guessing(tries=tries,vocab=vocab,blank_line=blank_line))
def introductory(vocab):
return "HANGMAN GAME. So...what you gotta do is guess and infer what the word might be. "
"WORD COUNT : " + str(len(vocab))
def num_of_tries(vocab):
if len(vocab) < 7:
return 8
elif 7 <= len(vocab) < 10:
return 10
else:
return 14
def produce_blank_lines(vocab):
blank_line =
for i in vocab:
if i.isalpha():
blank_line += "_"
elif i == " ":
blank_line += " "
else:
blank_line += i + " "
return blank_line
if __name__ == '__main__':
data = json.load(open("vocabulary.json"))
vocab = random.choice(list(data.keys())).lower()
print(vocab)
print(hangman_game(vocab=vocab))
python json
python json
asked 8 mins ago
austingae
44213
44213
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210386%2fhangmannnnn-program%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210386%2fhangmannnnn-program%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown