Tukukkk

I have tried all the different examples and methods I could find on Stack Overflow for this, and for whatever reason, can't get this to work properly.

So in my admin.py I have a UserForm and and UserAdmin. Based on the condition where a boolean is checked within the form, I want to change the 'required' attribute on a few different form fields to 'false' so I can effectively save. I've used a few different print statements to ascertain that the 'required' is in fact getting changed to false when the condition is met, however, when I try and save, it won't let me as the fields highlight and say they're still required.

It is almost like the save_model doesn't care how I edit the form, that the old form and its 'required' attributes are overriding my changes. Thanks for any help!

admin.py

class UserForm(forms.ModelForm):

    state = forms.CharField(min_length=2, widget=forms.TextInput(attrs={'placeholder':'CA'}))

    zipcode = forms.CharField(max_length=5, min_length=5,)



    class Meta:

        model = User

        fields = '__all__'





class UserAdmin(admin.ModelAdmin):

    model = Order

    form = UserForm



    def save_model(self, request, obj, form, change):

        if obj.pickup_only == 1:

            form.fields['address'].required = False

            form.fields['city'].required = False

            form.fields['state'].required = False

            form.fields['zipcode'].required = False

        return super(UserAdmin, self).save_model(request, obj, form, change)

revised code for UserForm:

def clean(self):

    cleaned_data = super(UserForm, self).clean()

    address = cleaned_data.get('address')

    state = cleaned_data.get('state')

    city = cleaned_data.get('city')

    zipcode = cleaned_data.get('zipcode')

    pickup_only = cleaned_data.get('pickup_only')



    if pickup_only == True:

        # I STUCK IN ADDRESS TO EMPHASIZE THE ERROR IN SCREENSHOT

        self.fields_required(['first_name', 'last_name', 'dob', 'phone', 'email', 'address'])

    else:

        self.cleaned_data['address', 'city', 'state', 'zip code'] = ''

    return self.cleaned_data



def fields_required(self, fields):

    for field in fields:

        print(field)

        # RETURNS: first_name, last_name, dob, phone, email, address

        if not self.cleaned_data.get(field, ''):

            msg = forms.ValidationError("This field is required. Custom.")

            self.add_error(field, msg)

When I save I get this:

You might have to tweak it a little bit to fit your needs, but you could try something like this in your clean method:

def clean(self):

    cleaned_data = super(UserForm, self).clean()

    state = cleaned_data.get('state')

    zipcode = cleaned_data.get('zipcode')

    pickup_only = cleaned_data.get('pickup_only')



    if pickup_only == True:

        self.fields_required(['any_fields_required',])

    else:

        self.cleaned_data['state', 'zip code'] = ''

    return self.cleaned_data



def fields_required(self, fields):

    for field in fields:

        if not self.cleaned_data.get(field, ''):

            msg = forms.ValidationError("This field is required.")

            self.add_error(field, msg)

Also, as one of the commenters mentioned, you should not specify your model=Order in the UserAdmin. Your UserAdmin is for the User model. That isn't the proper way to add inlines. See below:

# You can also use (admin.TabularInline) depending on your needs.

class OrderInline(admin.StackedInline):

    model = Order

    list_display = ('order_fields',)

    fieldsets = (

        ((''), {'fields': ('order_fields',)}),

    )



class UserAdmin(admin.ModelAdmin):

    model = User

    inlines = [OrderInline,]

Add an init method to your form:

class UserForm(forms.ModelForm):

    state = forms.CharField(min_length=2, widget=forms.TextInput(attrs={'placeholder':'CA'}))

    zipcode = forms.CharField(max_length=5, min_length=5,)



    class Meta:

        model = User

        fields = '__all__'



    def __init__(self, *args, **kwargs):

        super(UserForm, self).__init__(*args, **kwargs)

        self.fields['address'].required = False

        self.fields['city'].required = False

        self.fields['state'].required = False

        self.fields['zipcode'].required = False



    def clean(self):

        cleaned_data = super(UserForm, self).clean()

        address = cleaned_data.get('address')

        state = cleaned_data.get('state')

        city = cleaned_data.get('city')

        zipcode = cleaned_data.get('zipcode')

        pickup_only = cleaned_data.get('pickup_only')



        if pickup_only == True:

            self.fields_required(['first_name', 'last_name', 'dob', 'phone', 'email', 'address'])

        else:

            self.cleaned_data['address', 'city', 'state', 'zip code'] = ''

        return self.cleaned_data



    def fields_required(self, fields):

        for field in fields:

            if not self.cleaned_data.get(field, ''):

                msg = forms.ValidationError("This field is required. Custom.")

                self.add_error(field, msg)

Try this. If it works then I don't think you have to override the save method in your UserAdmin. I would avoid that anyway unless absolutely necessary.