Simple Android Volley login request












0












$begingroup$


I've made a simple login API request which gets a token as a response. I had to use Toast a few times. Is is possible to make it with only two Toasts Successful/Failed?



public void login(View view){
RequestQueue queue = Volley.newRequestQueue(this);
String URL = "http://10.0.2.2:8000/api/login";
StringRequest request = new StringRequest(Request.Method.POST, URL,
new Response.Listener<String>()
{
@Override
public void onResponse(String response) {
try {
JSONObject jsonObj = new JSONObject(response);
myToken =jsonObj.getString("token");
if (myToken != ""){
Toast.makeText(getApplicationContext(), "Login successfull !", Toast.LENGTH_LONG).show();
} else {
Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
}
} catch (JSONException e) {
myToken = "";
Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
e.printStackTrace();
}
}
},
new Response.ErrorListener()
{
@Override
public void onErrorResponse(VolleyError error) {
myToken = "";
Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
NetworkResponse response = error.networkResponse;
String errorMsg = "";
if(response != null && response.data != null){
String errorString = new String(response.data);
}
}
}
) {
@Override
protected Map<String, String> getParams()
{
Map<String, String> params = new HashMap<String, String>();
TextInputEditText mail = findViewById(R.id.textInputEditTextEmail);
TextInputEditText pw = findViewById(R.id.textInputEditTextPassword);
params.put("email", mail.getText().toString());
params.put("password", pw.getText().toString());
return params;
}
};
queue.add(request);
}









share|improve this question









New contributor




Programer Anel is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    I've made a simple login API request which gets a token as a response. I had to use Toast a few times. Is is possible to make it with only two Toasts Successful/Failed?



    public void login(View view){
    RequestQueue queue = Volley.newRequestQueue(this);
    String URL = "http://10.0.2.2:8000/api/login";
    StringRequest request = new StringRequest(Request.Method.POST, URL,
    new Response.Listener<String>()
    {
    @Override
    public void onResponse(String response) {
    try {
    JSONObject jsonObj = new JSONObject(response);
    myToken =jsonObj.getString("token");
    if (myToken != ""){
    Toast.makeText(getApplicationContext(), "Login successfull !", Toast.LENGTH_LONG).show();
    } else {
    Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
    }
    } catch (JSONException e) {
    myToken = "";
    Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
    e.printStackTrace();
    }
    }
    },
    new Response.ErrorListener()
    {
    @Override
    public void onErrorResponse(VolleyError error) {
    myToken = "";
    Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
    NetworkResponse response = error.networkResponse;
    String errorMsg = "";
    if(response != null && response.data != null){
    String errorString = new String(response.data);
    }
    }
    }
    ) {
    @Override
    protected Map<String, String> getParams()
    {
    Map<String, String> params = new HashMap<String, String>();
    TextInputEditText mail = findViewById(R.id.textInputEditTextEmail);
    TextInputEditText pw = findViewById(R.id.textInputEditTextPassword);
    params.put("email", mail.getText().toString());
    params.put("password", pw.getText().toString());
    return params;
    }
    };
    queue.add(request);
    }









    share|improve this question









    New contributor




    Programer Anel is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      I've made a simple login API request which gets a token as a response. I had to use Toast a few times. Is is possible to make it with only two Toasts Successful/Failed?



      public void login(View view){
      RequestQueue queue = Volley.newRequestQueue(this);
      String URL = "http://10.0.2.2:8000/api/login";
      StringRequest request = new StringRequest(Request.Method.POST, URL,
      new Response.Listener<String>()
      {
      @Override
      public void onResponse(String response) {
      try {
      JSONObject jsonObj = new JSONObject(response);
      myToken =jsonObj.getString("token");
      if (myToken != ""){
      Toast.makeText(getApplicationContext(), "Login successfull !", Toast.LENGTH_LONG).show();
      } else {
      Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
      }
      } catch (JSONException e) {
      myToken = "";
      Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
      e.printStackTrace();
      }
      }
      },
      new Response.ErrorListener()
      {
      @Override
      public void onErrorResponse(VolleyError error) {
      myToken = "";
      Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
      NetworkResponse response = error.networkResponse;
      String errorMsg = "";
      if(response != null && response.data != null){
      String errorString = new String(response.data);
      }
      }
      }
      ) {
      @Override
      protected Map<String, String> getParams()
      {
      Map<String, String> params = new HashMap<String, String>();
      TextInputEditText mail = findViewById(R.id.textInputEditTextEmail);
      TextInputEditText pw = findViewById(R.id.textInputEditTextPassword);
      params.put("email", mail.getText().toString());
      params.put("password", pw.getText().toString());
      return params;
      }
      };
      queue.add(request);
      }









      share|improve this question









      New contributor




      Programer Anel is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I've made a simple login API request which gets a token as a response. I had to use Toast a few times. Is is possible to make it with only two Toasts Successful/Failed?



      public void login(View view){
      RequestQueue queue = Volley.newRequestQueue(this);
      String URL = "http://10.0.2.2:8000/api/login";
      StringRequest request = new StringRequest(Request.Method.POST, URL,
      new Response.Listener<String>()
      {
      @Override
      public void onResponse(String response) {
      try {
      JSONObject jsonObj = new JSONObject(response);
      myToken =jsonObj.getString("token");
      if (myToken != ""){
      Toast.makeText(getApplicationContext(), "Login successfull !", Toast.LENGTH_LONG).show();
      } else {
      Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
      }
      } catch (JSONException e) {
      myToken = "";
      Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
      e.printStackTrace();
      }
      }
      },
      new Response.ErrorListener()
      {
      @Override
      public void onErrorResponse(VolleyError error) {
      myToken = "";
      Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
      NetworkResponse response = error.networkResponse;
      String errorMsg = "";
      if(response != null && response.data != null){
      String errorString = new String(response.data);
      }
      }
      }
      ) {
      @Override
      protected Map<String, String> getParams()
      {
      Map<String, String> params = new HashMap<String, String>();
      TextInputEditText mail = findViewById(R.id.textInputEditTextEmail);
      TextInputEditText pw = findViewById(R.id.textInputEditTextPassword);
      params.put("email", mail.getText().toString());
      params.put("password", pw.getText().toString());
      return params;
      }
      };
      queue.add(request);
      }






      java android authentication






      share|improve this question









      New contributor




      Programer Anel is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Programer Anel is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 19 mins ago









      Jamal

      30.3k11117227




      30.3k11117227






      New contributor




      Programer Anel is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 9 hours ago









      Programer AnelProgramer Anel

      1




      1




      New contributor




      Programer Anel is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Programer Anel is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Programer Anel is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          1 Answer
          1






          active

          oldest

          votes


















          1












          $begingroup$

          You can use a variable and assume that it will fail, if you do not print the new message



             public void login(View view){
          RequestQueue queue = Volley.newRequestQueue(this);
          String URL = "http://10.0.2.2:8000/api/login";
          StringRequest request = new StringRequest(Request.Method.POST, URL,
          new Response.Listener<String>()
          {
          @Override
          public void onResponse(String response) {
          String loginMsg = "Ooops something is not correct !";

          try {
          JSONObject jsonObj = new JSONObject(response);
          myToken =jsonObj.getString("token");
          if (myToken != ""){
          loginMsg = "Login successfull !"
          }
          } catch (JSONException e) {
          myToken = "";
          e.printStackTrace();
          }

          Toast.makeText(getApplicationContext(), loginMsg, Toast.LENGTH_LONG).show();

          }
          },
          new Response.ErrorListener()
          {
          @Override
          public void onErrorResponse(VolleyError error) {
          myToken = "";
          Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
          NetworkResponse response = error.networkResponse;
          String errorMsg = "";
          if(response != null && response.data != null){
          String errorString = new String(response.data);
          }
          }
          }
          ) {
          @Override
          protected Map<String, String> getParams()
          {
          Map<String, String> params = new HashMap<String, String>();
          TextInputEditText mail = findViewById(R.id.textInputEditTextEmail);
          TextInputEditText pw = findViewById(R.id.textInputEditTextPassword);
          params.put("email", mail.getText().toString());
          params.put("password", pw.getText().toString());
          return params;
          }
          };
          queue.add(request);
          }





          share|improve this answer








          New contributor




          Tlaloc-ES is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
          Check out our Code of Conduct.






          $endgroup$













            Your Answer





            StackExchange.ifUsing("editor", function () {
            return StackExchange.using("mathjaxEditing", function () {
            StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
            StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
            });
            });
            }, "mathjax-editing");

            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "196"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });






            Programer Anel is a new contributor. Be nice, and check out our Code of Conduct.










            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212771%2fsimple-android-volley-login-request%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            1












            $begingroup$

            You can use a variable and assume that it will fail, if you do not print the new message



               public void login(View view){
            RequestQueue queue = Volley.newRequestQueue(this);
            String URL = "http://10.0.2.2:8000/api/login";
            StringRequest request = new StringRequest(Request.Method.POST, URL,
            new Response.Listener<String>()
            {
            @Override
            public void onResponse(String response) {
            String loginMsg = "Ooops something is not correct !";

            try {
            JSONObject jsonObj = new JSONObject(response);
            myToken =jsonObj.getString("token");
            if (myToken != ""){
            loginMsg = "Login successfull !"
            }
            } catch (JSONException e) {
            myToken = "";
            e.printStackTrace();
            }

            Toast.makeText(getApplicationContext(), loginMsg, Toast.LENGTH_LONG).show();

            }
            },
            new Response.ErrorListener()
            {
            @Override
            public void onErrorResponse(VolleyError error) {
            myToken = "";
            Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
            NetworkResponse response = error.networkResponse;
            String errorMsg = "";
            if(response != null && response.data != null){
            String errorString = new String(response.data);
            }
            }
            }
            ) {
            @Override
            protected Map<String, String> getParams()
            {
            Map<String, String> params = new HashMap<String, String>();
            TextInputEditText mail = findViewById(R.id.textInputEditTextEmail);
            TextInputEditText pw = findViewById(R.id.textInputEditTextPassword);
            params.put("email", mail.getText().toString());
            params.put("password", pw.getText().toString());
            return params;
            }
            };
            queue.add(request);
            }





            share|improve this answer








            New contributor




            Tlaloc-ES is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
            Check out our Code of Conduct.






            $endgroup$


















              1












              $begingroup$

              You can use a variable and assume that it will fail, if you do not print the new message



                 public void login(View view){
              RequestQueue queue = Volley.newRequestQueue(this);
              String URL = "http://10.0.2.2:8000/api/login";
              StringRequest request = new StringRequest(Request.Method.POST, URL,
              new Response.Listener<String>()
              {
              @Override
              public void onResponse(String response) {
              String loginMsg = "Ooops something is not correct !";

              try {
              JSONObject jsonObj = new JSONObject(response);
              myToken =jsonObj.getString("token");
              if (myToken != ""){
              loginMsg = "Login successfull !"
              }
              } catch (JSONException e) {
              myToken = "";
              e.printStackTrace();
              }

              Toast.makeText(getApplicationContext(), loginMsg, Toast.LENGTH_LONG).show();

              }
              },
              new Response.ErrorListener()
              {
              @Override
              public void onErrorResponse(VolleyError error) {
              myToken = "";
              Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
              NetworkResponse response = error.networkResponse;
              String errorMsg = "";
              if(response != null && response.data != null){
              String errorString = new String(response.data);
              }
              }
              }
              ) {
              @Override
              protected Map<String, String> getParams()
              {
              Map<String, String> params = new HashMap<String, String>();
              TextInputEditText mail = findViewById(R.id.textInputEditTextEmail);
              TextInputEditText pw = findViewById(R.id.textInputEditTextPassword);
              params.put("email", mail.getText().toString());
              params.put("password", pw.getText().toString());
              return params;
              }
              };
              queue.add(request);
              }





              share|improve this answer








              New contributor




              Tlaloc-ES is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
              Check out our Code of Conduct.






              $endgroup$
















                1












                1








                1





                $begingroup$

                You can use a variable and assume that it will fail, if you do not print the new message



                   public void login(View view){
                RequestQueue queue = Volley.newRequestQueue(this);
                String URL = "http://10.0.2.2:8000/api/login";
                StringRequest request = new StringRequest(Request.Method.POST, URL,
                new Response.Listener<String>()
                {
                @Override
                public void onResponse(String response) {
                String loginMsg = "Ooops something is not correct !";

                try {
                JSONObject jsonObj = new JSONObject(response);
                myToken =jsonObj.getString("token");
                if (myToken != ""){
                loginMsg = "Login successfull !"
                }
                } catch (JSONException e) {
                myToken = "";
                e.printStackTrace();
                }

                Toast.makeText(getApplicationContext(), loginMsg, Toast.LENGTH_LONG).show();

                }
                },
                new Response.ErrorListener()
                {
                @Override
                public void onErrorResponse(VolleyError error) {
                myToken = "";
                Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
                NetworkResponse response = error.networkResponse;
                String errorMsg = "";
                if(response != null && response.data != null){
                String errorString = new String(response.data);
                }
                }
                }
                ) {
                @Override
                protected Map<String, String> getParams()
                {
                Map<String, String> params = new HashMap<String, String>();
                TextInputEditText mail = findViewById(R.id.textInputEditTextEmail);
                TextInputEditText pw = findViewById(R.id.textInputEditTextPassword);
                params.put("email", mail.getText().toString());
                params.put("password", pw.getText().toString());
                return params;
                }
                };
                queue.add(request);
                }





                share|improve this answer








                New contributor




                Tlaloc-ES is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                Check out our Code of Conduct.






                $endgroup$



                You can use a variable and assume that it will fail, if you do not print the new message



                   public void login(View view){
                RequestQueue queue = Volley.newRequestQueue(this);
                String URL = "http://10.0.2.2:8000/api/login";
                StringRequest request = new StringRequest(Request.Method.POST, URL,
                new Response.Listener<String>()
                {
                @Override
                public void onResponse(String response) {
                String loginMsg = "Ooops something is not correct !";

                try {
                JSONObject jsonObj = new JSONObject(response);
                myToken =jsonObj.getString("token");
                if (myToken != ""){
                loginMsg = "Login successfull !"
                }
                } catch (JSONException e) {
                myToken = "";
                e.printStackTrace();
                }

                Toast.makeText(getApplicationContext(), loginMsg, Toast.LENGTH_LONG).show();

                }
                },
                new Response.ErrorListener()
                {
                @Override
                public void onErrorResponse(VolleyError error) {
                myToken = "";
                Toast.makeText(getApplicationContext(), "Ooops something is not correct !", Toast.LENGTH_LONG).show();
                NetworkResponse response = error.networkResponse;
                String errorMsg = "";
                if(response != null && response.data != null){
                String errorString = new String(response.data);
                }
                }
                }
                ) {
                @Override
                protected Map<String, String> getParams()
                {
                Map<String, String> params = new HashMap<String, String>();
                TextInputEditText mail = findViewById(R.id.textInputEditTextEmail);
                TextInputEditText pw = findViewById(R.id.textInputEditTextPassword);
                params.put("email", mail.getText().toString());
                params.put("password", pw.getText().toString());
                return params;
                }
                };
                queue.add(request);
                }






                share|improve this answer








                New contributor




                Tlaloc-ES is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                Check out our Code of Conduct.









                share|improve this answer



                share|improve this answer






                New contributor




                Tlaloc-ES is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                Check out our Code of Conduct.









                answered 6 hours ago









                Tlaloc-ESTlaloc-ES

                111




                111




                New contributor




                Tlaloc-ES is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                Check out our Code of Conduct.





                New contributor





                Tlaloc-ES is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                Check out our Code of Conduct.






                Tlaloc-ES is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                Check out our Code of Conduct.






















                    Programer Anel is a new contributor. Be nice, and check out our Code of Conduct.










                    draft saved

                    draft discarded


















                    Programer Anel is a new contributor. Be nice, and check out our Code of Conduct.













                    Programer Anel is a new contributor. Be nice, and check out our Code of Conduct.












                    Programer Anel is a new contributor. Be nice, and check out our Code of Conduct.
















                    Thanks for contributing an answer to Code Review Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    Use MathJax to format equations. MathJax reference.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212771%2fsimple-android-volley-login-request%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    404 Error Contact Form 7 ajax form submitting

                    How to know if a Active Directory user can login interactively

                    TypeError: fit_transform() missing 1 required positional argument: 'X'