Tic-Tac-Toe with React Hooks












0












$begingroup$


I have found similar posts which has some optimizations on Winning-checking logic: React Tic Tac Toe



My primary focus for this post is about hook setters being asynchronous. So to check if anyone wins, I used useEffect to listen to the board.



  useEffect(
() => {
if (winning()) {
setMessage(`Player ${turn % 2 ? 1 : 2} wins!`);
setGameState("stopped");
} else {
setTurn(turn + 1);
}
},
[board]
);


When the move is made, the turn number won't increase when the game is finished.



However this makes the initial "turn number" 0 (so the effect adds to it to get 1).



Should I make the board update synchronous before calling the setters? (like using a tempBoard = {...board, (new move)} and check there instead?



Full code (Click handler is step)



import React, { useState, useEffect } from "react";
import ReactDOM from "react-dom";

import "./styles.css";

function App() {
const [turn, setTurn] = useState(0);
const [message, setMessage] = useState("");
const [gameState, setGameState] = useState("playing");
const [board, setBoard] = useState({});

const winning = _ => {
return (
(board[0] &&
board[1] &&
board[2] &&
board[0] === board[1] &&
board[1] === board[2]) ||
(board[3] &&
board[4] &&
board[5] &&
board[3] === board[4] &&
board[4] === board[5]) ||
(board[6] &&
board[7] &&
board[8] &&
board[6] === board[7] &&
board[7] === board[8]) ||
(board[0] &&
board[3] &&
board[6] &&
board[0] === board[3] &&
board[3] === board[6]) ||
(board[1] &&
board[4] &&
board[7] &&
board[1] === board[4] &&
board[4] === board[7]) ||
(board[2] &&
board[5] &&
board[8] &&
board[2] === board[5] &&
board[5] === board[8]) ||
(board[0] &&
board[4] &&
board[8] &&
board[0] === board[4] &&
board[4] === board[8]) ||
(board[2] &&
board[4] &&
board[6] &&
board[2] === board[4] &&
board[4] === board[6])
);
};

useEffect(
() => {
if (winning()) {
setMessage(`Player ${turn % 2 ? 1 : 2} wins!`);
setGameState("stopped");
} else {
setTurn(turn + 1);
}
},
[board]
);

const step = (n, turn) => {
if (gameState === "playing" && !board[n]) {
setBoard({ ...board, [n]: turn % 2 ? "x" : "o" });
}
};

return (
<div className="App">
Turn {turn}
<div className="container">
{[0, 1, 2, 3, 4, 5, 6, 7, 8].map(n => (
<div key={"b" + n} className={"b" + n}>
<button onClick={_ => step(n, turn)}>{board[n] || " "}</button>
</div>
))}
</div>
{message}
</div>
);
}

const rootElement = document.getElementById("root");
ReactDOM.render(<App />, rootElement);



CodeSandbox










share|improve this question







New contributor




Sunny Pun is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    I have found similar posts which has some optimizations on Winning-checking logic: React Tic Tac Toe



    My primary focus for this post is about hook setters being asynchronous. So to check if anyone wins, I used useEffect to listen to the board.



      useEffect(
    () => {
    if (winning()) {
    setMessage(`Player ${turn % 2 ? 1 : 2} wins!`);
    setGameState("stopped");
    } else {
    setTurn(turn + 1);
    }
    },
    [board]
    );


    When the move is made, the turn number won't increase when the game is finished.



    However this makes the initial "turn number" 0 (so the effect adds to it to get 1).



    Should I make the board update synchronous before calling the setters? (like using a tempBoard = {...board, (new move)} and check there instead?



    Full code (Click handler is step)



    import React, { useState, useEffect } from "react";
    import ReactDOM from "react-dom";

    import "./styles.css";

    function App() {
    const [turn, setTurn] = useState(0);
    const [message, setMessage] = useState("");
    const [gameState, setGameState] = useState("playing");
    const [board, setBoard] = useState({});

    const winning = _ => {
    return (
    (board[0] &&
    board[1] &&
    board[2] &&
    board[0] === board[1] &&
    board[1] === board[2]) ||
    (board[3] &&
    board[4] &&
    board[5] &&
    board[3] === board[4] &&
    board[4] === board[5]) ||
    (board[6] &&
    board[7] &&
    board[8] &&
    board[6] === board[7] &&
    board[7] === board[8]) ||
    (board[0] &&
    board[3] &&
    board[6] &&
    board[0] === board[3] &&
    board[3] === board[6]) ||
    (board[1] &&
    board[4] &&
    board[7] &&
    board[1] === board[4] &&
    board[4] === board[7]) ||
    (board[2] &&
    board[5] &&
    board[8] &&
    board[2] === board[5] &&
    board[5] === board[8]) ||
    (board[0] &&
    board[4] &&
    board[8] &&
    board[0] === board[4] &&
    board[4] === board[8]) ||
    (board[2] &&
    board[4] &&
    board[6] &&
    board[2] === board[4] &&
    board[4] === board[6])
    );
    };

    useEffect(
    () => {
    if (winning()) {
    setMessage(`Player ${turn % 2 ? 1 : 2} wins!`);
    setGameState("stopped");
    } else {
    setTurn(turn + 1);
    }
    },
    [board]
    );

    const step = (n, turn) => {
    if (gameState === "playing" && !board[n]) {
    setBoard({ ...board, [n]: turn % 2 ? "x" : "o" });
    }
    };

    return (
    <div className="App">
    Turn {turn}
    <div className="container">
    {[0, 1, 2, 3, 4, 5, 6, 7, 8].map(n => (
    <div key={"b" + n} className={"b" + n}>
    <button onClick={_ => step(n, turn)}>{board[n] || " "}</button>
    </div>
    ))}
    </div>
    {message}
    </div>
    );
    }

    const rootElement = document.getElementById("root");
    ReactDOM.render(<App />, rootElement);



    CodeSandbox










    share|improve this question







    New contributor




    Sunny Pun is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      I have found similar posts which has some optimizations on Winning-checking logic: React Tic Tac Toe



      My primary focus for this post is about hook setters being asynchronous. So to check if anyone wins, I used useEffect to listen to the board.



        useEffect(
      () => {
      if (winning()) {
      setMessage(`Player ${turn % 2 ? 1 : 2} wins!`);
      setGameState("stopped");
      } else {
      setTurn(turn + 1);
      }
      },
      [board]
      );


      When the move is made, the turn number won't increase when the game is finished.



      However this makes the initial "turn number" 0 (so the effect adds to it to get 1).



      Should I make the board update synchronous before calling the setters? (like using a tempBoard = {...board, (new move)} and check there instead?



      Full code (Click handler is step)



      import React, { useState, useEffect } from "react";
      import ReactDOM from "react-dom";

      import "./styles.css";

      function App() {
      const [turn, setTurn] = useState(0);
      const [message, setMessage] = useState("");
      const [gameState, setGameState] = useState("playing");
      const [board, setBoard] = useState({});

      const winning = _ => {
      return (
      (board[0] &&
      board[1] &&
      board[2] &&
      board[0] === board[1] &&
      board[1] === board[2]) ||
      (board[3] &&
      board[4] &&
      board[5] &&
      board[3] === board[4] &&
      board[4] === board[5]) ||
      (board[6] &&
      board[7] &&
      board[8] &&
      board[6] === board[7] &&
      board[7] === board[8]) ||
      (board[0] &&
      board[3] &&
      board[6] &&
      board[0] === board[3] &&
      board[3] === board[6]) ||
      (board[1] &&
      board[4] &&
      board[7] &&
      board[1] === board[4] &&
      board[4] === board[7]) ||
      (board[2] &&
      board[5] &&
      board[8] &&
      board[2] === board[5] &&
      board[5] === board[8]) ||
      (board[0] &&
      board[4] &&
      board[8] &&
      board[0] === board[4] &&
      board[4] === board[8]) ||
      (board[2] &&
      board[4] &&
      board[6] &&
      board[2] === board[4] &&
      board[4] === board[6])
      );
      };

      useEffect(
      () => {
      if (winning()) {
      setMessage(`Player ${turn % 2 ? 1 : 2} wins!`);
      setGameState("stopped");
      } else {
      setTurn(turn + 1);
      }
      },
      [board]
      );

      const step = (n, turn) => {
      if (gameState === "playing" && !board[n]) {
      setBoard({ ...board, [n]: turn % 2 ? "x" : "o" });
      }
      };

      return (
      <div className="App">
      Turn {turn}
      <div className="container">
      {[0, 1, 2, 3, 4, 5, 6, 7, 8].map(n => (
      <div key={"b" + n} className={"b" + n}>
      <button onClick={_ => step(n, turn)}>{board[n] || " "}</button>
      </div>
      ))}
      </div>
      {message}
      </div>
      );
      }

      const rootElement = document.getElementById("root");
      ReactDOM.render(<App />, rootElement);



      CodeSandbox










      share|improve this question







      New contributor




      Sunny Pun is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I have found similar posts which has some optimizations on Winning-checking logic: React Tic Tac Toe



      My primary focus for this post is about hook setters being asynchronous. So to check if anyone wins, I used useEffect to listen to the board.



        useEffect(
      () => {
      if (winning()) {
      setMessage(`Player ${turn % 2 ? 1 : 2} wins!`);
      setGameState("stopped");
      } else {
      setTurn(turn + 1);
      }
      },
      [board]
      );


      When the move is made, the turn number won't increase when the game is finished.



      However this makes the initial "turn number" 0 (so the effect adds to it to get 1).



      Should I make the board update synchronous before calling the setters? (like using a tempBoard = {...board, (new move)} and check there instead?



      Full code (Click handler is step)



      import React, { useState, useEffect } from "react";
      import ReactDOM from "react-dom";

      import "./styles.css";

      function App() {
      const [turn, setTurn] = useState(0);
      const [message, setMessage] = useState("");
      const [gameState, setGameState] = useState("playing");
      const [board, setBoard] = useState({});

      const winning = _ => {
      return (
      (board[0] &&
      board[1] &&
      board[2] &&
      board[0] === board[1] &&
      board[1] === board[2]) ||
      (board[3] &&
      board[4] &&
      board[5] &&
      board[3] === board[4] &&
      board[4] === board[5]) ||
      (board[6] &&
      board[7] &&
      board[8] &&
      board[6] === board[7] &&
      board[7] === board[8]) ||
      (board[0] &&
      board[3] &&
      board[6] &&
      board[0] === board[3] &&
      board[3] === board[6]) ||
      (board[1] &&
      board[4] &&
      board[7] &&
      board[1] === board[4] &&
      board[4] === board[7]) ||
      (board[2] &&
      board[5] &&
      board[8] &&
      board[2] === board[5] &&
      board[5] === board[8]) ||
      (board[0] &&
      board[4] &&
      board[8] &&
      board[0] === board[4] &&
      board[4] === board[8]) ||
      (board[2] &&
      board[4] &&
      board[6] &&
      board[2] === board[4] &&
      board[4] === board[6])
      );
      };

      useEffect(
      () => {
      if (winning()) {
      setMessage(`Player ${turn % 2 ? 1 : 2} wins!`);
      setGameState("stopped");
      } else {
      setTurn(turn + 1);
      }
      },
      [board]
      );

      const step = (n, turn) => {
      if (gameState === "playing" && !board[n]) {
      setBoard({ ...board, [n]: turn % 2 ? "x" : "o" });
      }
      };

      return (
      <div className="App">
      Turn {turn}
      <div className="container">
      {[0, 1, 2, 3, 4, 5, 6, 7, 8].map(n => (
      <div key={"b" + n} className={"b" + n}>
      <button onClick={_ => step(n, turn)}>{board[n] || " "}</button>
      </div>
      ))}
      </div>
      {message}
      </div>
      );
      }

      const rootElement = document.getElementById("root");
      ReactDOM.render(<App />, rootElement);



      CodeSandbox







      tic-tac-toe react.js






      share|improve this question







      New contributor




      Sunny Pun is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      Sunny Pun is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      Sunny Pun is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 10 mins ago









      Sunny PunSunny Pun

      1012




      1012




      New contributor




      Sunny Pun is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Sunny Pun is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Sunny Pun is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Sunny Pun is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213781%2ftic-tac-toe-with-react-hooks%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Sunny Pun is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Sunny Pun is a new contributor. Be nice, and check out our Code of Conduct.













          Sunny Pun is a new contributor. Be nice, and check out our Code of Conduct.












          Sunny Pun is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213781%2ftic-tac-toe-with-react-hooks%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          404 Error Contact Form 7 ajax form submitting

          How to know if a Active Directory user can login interactively

          TypeError: fit_transform() missing 1 required positional argument: 'X'